From: Simon Jeons <simon.jeons@gmail.com> To: Joonsoo Kim <iamjoonsoo.kim@lge.com> Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Mel Gorman <mgorman@suse.de>, Hugh Dickins <hughd@google.com>, Rik van Riel <riel@redhat.com>, Minchan Kim <minchan@kernel.org>, Christoph Lameter <cl@linux-foundation.org>, Pekka Enberg <penberg@kernel.org>, Matt Mackall <mpm@selenic.com> Subject: Re: [PATCH 2/3] mm, slub: count freed pages via rcu as this task's reclaimed_slab Date: Tue, 09 Apr 2013 17:38:28 +0800 [thread overview] Message-ID: <5163E194.3080600@gmail.com> (raw) In-Reply-To: <1365470478-645-2-git-send-email-iamjoonsoo.kim@lge.com> Hi Joonsoo, On 04/09/2013 09:21 AM, Joonsoo Kim wrote: > Currently, freed pages via rcu is not counted for reclaimed_slab, because > it is freed in rcu context, not current task context. But, this free is > initiated by this task, so counting this into this task's reclaimed_slab > is meaningful to decide whether we continue reclaim, or not. > So change code to count these pages for this task's reclaimed_slab. > > Cc: Christoph Lameter <cl@linux-foundation.org> > Cc: Pekka Enberg <penberg@kernel.org> > Cc: Matt Mackall <mpm@selenic.com> > Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com> > > diff --git a/mm/slub.c b/mm/slub.c > index 4aec537..16fd2d5 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -1409,8 +1409,6 @@ static void __free_slab(struct kmem_cache *s, struct page *page) > > memcg_release_pages(s, order); > page_mapcount_reset(page); > - if (current->reclaim_state) > - current->reclaim_state->reclaimed_slab += pages; > __free_memcg_kmem_pages(page, order); > } > > @@ -1431,6 +1429,8 @@ static void rcu_free_slab(struct rcu_head *h) > > static void free_slab(struct kmem_cache *s, struct page *page) > { > + int pages = 1 << compound_order(page); One question irrelevant this patch. Why slab cache can use compound page(hugetlbfs pages/thp pages)? They are just used by app to optimize tlb miss, is it? > + > if (unlikely(s->flags & SLAB_DESTROY_BY_RCU)) { > struct rcu_head *head; > > @@ -1450,6 +1450,9 @@ static void free_slab(struct kmem_cache *s, struct page *page) > call_rcu(head, rcu_free_slab); > } else > __free_slab(s, page); > + > + if (current->reclaim_state) > + current->reclaim_state->reclaimed_slab += pages; > } > > static void discard_slab(struct kmem_cache *s, struct page *page)
WARNING: multiple messages have this Message-ID (diff)
From: Simon Jeons <simon.jeons@gmail.com> To: Joonsoo Kim <iamjoonsoo.kim@lge.com> Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Mel Gorman <mgorman@suse.de>, Hugh Dickins <hughd@google.com>, Rik van Riel <riel@redhat.com>, Minchan Kim <minchan@kernel.org>, Christoph Lameter <cl@linux-foundation.org>, Pekka Enberg <penberg@kernel.org>, Matt Mackall <mpm@selenic.com> Subject: Re: [PATCH 2/3] mm, slub: count freed pages via rcu as this task's reclaimed_slab Date: Tue, 09 Apr 2013 17:38:28 +0800 [thread overview] Message-ID: <5163E194.3080600@gmail.com> (raw) In-Reply-To: <1365470478-645-2-git-send-email-iamjoonsoo.kim@lge.com> Hi Joonsoo, On 04/09/2013 09:21 AM, Joonsoo Kim wrote: > Currently, freed pages via rcu is not counted for reclaimed_slab, because > it is freed in rcu context, not current task context. But, this free is > initiated by this task, so counting this into this task's reclaimed_slab > is meaningful to decide whether we continue reclaim, or not. > So change code to count these pages for this task's reclaimed_slab. > > Cc: Christoph Lameter <cl@linux-foundation.org> > Cc: Pekka Enberg <penberg@kernel.org> > Cc: Matt Mackall <mpm@selenic.com> > Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com> > > diff --git a/mm/slub.c b/mm/slub.c > index 4aec537..16fd2d5 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -1409,8 +1409,6 @@ static void __free_slab(struct kmem_cache *s, struct page *page) > > memcg_release_pages(s, order); > page_mapcount_reset(page); > - if (current->reclaim_state) > - current->reclaim_state->reclaimed_slab += pages; > __free_memcg_kmem_pages(page, order); > } > > @@ -1431,6 +1429,8 @@ static void rcu_free_slab(struct rcu_head *h) > > static void free_slab(struct kmem_cache *s, struct page *page) > { > + int pages = 1 << compound_order(page); One question irrelevant this patch. Why slab cache can use compound page(hugetlbfs pages/thp pages)? They are just used by app to optimize tlb miss, is it? > + > if (unlikely(s->flags & SLAB_DESTROY_BY_RCU)) { > struct rcu_head *head; > > @@ -1450,6 +1450,9 @@ static void free_slab(struct kmem_cache *s, struct page *page) > call_rcu(head, rcu_free_slab); > } else > __free_slab(s, page); > + > + if (current->reclaim_state) > + current->reclaim_state->reclaimed_slab += pages; > } > > static void discard_slab(struct kmem_cache *s, struct page *page) -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-04-09 9:38 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-04-09 1:21 [PATCH 1/3] mm, vmscan: count accidental reclaimed pages failed to put into lru Joonsoo Kim 2013-04-09 1:21 ` Joonsoo Kim 2013-04-09 1:21 ` [PATCH 2/3] mm, slub: count freed pages via rcu as this task's reclaimed_slab Joonsoo Kim 2013-04-09 1:21 ` Joonsoo Kim 2013-04-09 9:38 ` Simon Jeons [this message] 2013-04-09 9:38 ` Simon Jeons 2013-04-09 14:32 ` Christoph Lameter 2013-04-09 14:32 ` Christoph Lameter 2013-04-10 3:20 ` Simon Jeons 2013-04-10 3:20 ` Simon Jeons 2013-04-10 13:54 ` Christoph Lameter 2013-04-10 13:54 ` Christoph Lameter 2013-04-11 3:46 ` Simon Jeons 2013-04-11 3:46 ` Simon Jeons 2013-04-11 15:03 ` Christoph Lameter 2013-04-11 15:03 ` Christoph Lameter 2013-04-09 14:28 ` Christoph Lameter 2013-04-09 14:28 ` Christoph Lameter 2013-04-10 5:26 ` Joonsoo Kim 2013-04-10 5:26 ` Joonsoo Kim 2013-04-10 13:57 ` Christoph Lameter 2013-04-10 13:57 ` Christoph Lameter 2013-04-10 14:24 ` JoonSoo Kim 2013-04-10 14:24 ` JoonSoo Kim 2013-04-09 1:21 ` [PATCH 3/3] mm, slab: " Joonsoo Kim 2013-04-09 1:21 ` Joonsoo Kim 2013-04-09 5:55 ` [PATCH 1/3] mm, vmscan: count accidental reclaimed pages failed to put into lru Minchan Kim 2013-04-09 5:55 ` Minchan Kim 2013-04-10 5:48 ` Joonsoo Kim 2013-04-10 5:48 ` Joonsoo Kim 2013-04-10 6:03 ` Minchan Kim 2013-04-10 6:03 ` Minchan Kim 2013-04-09 7:19 ` Wanpeng Li 2013-04-09 7:19 ` Wanpeng Li
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5163E194.3080600@gmail.com \ --to=simon.jeons@gmail.com \ --cc=akpm@linux-foundation.org \ --cc=cl@linux-foundation.org \ --cc=hughd@google.com \ --cc=iamjoonsoo.kim@lge.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mgorman@suse.de \ --cc=minchan@kernel.org \ --cc=mpm@selenic.com \ --cc=penberg@kernel.org \ --cc=riel@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.