All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christopher Covington <cov@codeaurora.org>
To: Will Deacon <will.deacon@arm.com>
Cc: Catalin Marinas <Catalin.Marinas@arm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH v2] arm64: Fix task tracing
Date: Wed, 10 Apr 2013 09:12:04 -0400	[thread overview]
Message-ID: <51656524.10708@codeaurora.org> (raw)
In-Reply-To: <20130410114126.GB26992@mudshark.cambridge.arm.com>

Hi Will,

On 04/10/2013 07:41 AM, Will Deacon wrote:
> On Tue, Apr 09, 2013 at 01:33:34PM +0100, Christopher Covington wrote:
>> For accurate accounting pass contextidr_thread_switch the prev
>> task pointer, since cpu_switch_to has at that point changed the
>> the stack pointer.
>>
>> Signed-off-by: Christopher Covington <cov@codeaurora.org>
> 
> Thanks Christopher -- I assume that using prev did resolve your issues?

Yes indeed. We're now able to see in simulation that if a userspace process
uses 100% CPU, its thread ID, rather than what was usually some random
kthread, gets written out most of the time. I donno if that meets your
criteria for a "real" use case, but I hope it's at least sufficient testing of
the code for now.

Thanks,
Christopher

-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by the Linux Foundation.

WARNING: multiple messages have this Message-ID (diff)
From: cov@codeaurora.org (Christopher Covington)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] arm64: Fix task tracing
Date: Wed, 10 Apr 2013 09:12:04 -0400	[thread overview]
Message-ID: <51656524.10708@codeaurora.org> (raw)
In-Reply-To: <20130410114126.GB26992@mudshark.cambridge.arm.com>

Hi Will,

On 04/10/2013 07:41 AM, Will Deacon wrote:
> On Tue, Apr 09, 2013 at 01:33:34PM +0100, Christopher Covington wrote:
>> For accurate accounting pass contextidr_thread_switch the prev
>> task pointer, since cpu_switch_to has at that point changed the
>> the stack pointer.
>>
>> Signed-off-by: Christopher Covington <cov@codeaurora.org>
> 
> Thanks Christopher -- I assume that using prev did resolve your issues?

Yes indeed. We're now able to see in simulation that if a userspace process
uses 100% CPU, its thread ID, rather than what was usually some random
kthread, gets written out most of the time. I donno if that meets your
criteria for a "real" use case, but I hope it's at least sufficient testing of
the code for now.

Thanks,
Christopher

-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by the Linux Foundation.

  reply	other threads:[~2013-04-10 13:12 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-03 18:01 [PATCH] arm64: Fix task tracing Christopher Covington
2013-04-03 18:01 ` Christopher Covington
2013-04-03 18:04 ` Will Deacon
2013-04-03 18:04   ` Will Deacon
2013-04-03 18:04   ` Will Deacon
2013-04-08 14:42   ` Christopher Covington
2013-04-08 14:42     ` Christopher Covington
2013-04-08 14:42     ` Christopher Covington
2013-04-08 15:31     ` Will Deacon
2013-04-08 15:31       ` Will Deacon
2013-04-08 15:31       ` Will Deacon
2013-04-09 12:33       ` [PATCH v2] " Christopher Covington
2013-04-09 12:33         ` Christopher Covington
2013-04-10 11:41         ` Will Deacon
2013-04-10 11:41           ` Will Deacon
2013-04-10 11:41           ` Will Deacon
2013-04-10 13:12           ` Christopher Covington [this message]
2013-04-10 13:12             ` Christopher Covington
2013-04-10 13:12             ` Christopher Covington
2013-04-15 10:11         ` Catalin Marinas
2013-04-15 10:11           ` Catalin Marinas
2013-04-15 10:11           ` Catalin Marinas
2013-04-15 10:45           ` Will Deacon
2013-04-15 10:45             ` Will Deacon
2013-04-15 10:45             ` Will Deacon
2013-04-15 10:58             ` Catalin Marinas
2013-04-15 10:58               ` Catalin Marinas
2013-04-15 10:58               ` Catalin Marinas
2013-04-15 11:43               ` Catalin Marinas
2013-04-15 11:43                 ` Catalin Marinas
2013-04-15 11:43                 ` Catalin Marinas
2013-04-15 13:09                 ` Christopher Covington
2013-04-15 13:09                   ` Christopher Covington
2013-04-15 13:09                   ` Christopher Covington
2013-04-15 15:23                   ` Catalin Marinas
2013-04-15 15:23                     ` Catalin Marinas
2013-04-15 15:23                     ` Catalin Marinas
2013-04-15 13:19                 ` Will Deacon
2013-04-15 13:19                   ` Will Deacon
2013-04-15 13:19                   ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51656524.10708@codeaurora.org \
    --to=cov@codeaurora.org \
    --cc=Catalin.Marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.