[PATCH] Net-next: ipv4: type issue, remove erroneous semicolon

[PATCH] Net-next: ipv4: type issue, remove erroneous semicolon

[Chen Gang]

  need remove erroneous semicolon.

  the related commit number: c54419321455631079c7d6e60bc732dd0c5914c5

  Find it by EXTRA_CFLAGS=-W


Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
 net/ipv4/ip_gre.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/ipv4/ip_gre.c b/net/ipv4/ip_gre.c
index 987a4e5..c625e4d 100644
--- a/net/ipv4/ip_gre.c
+++ b/net/ipv4/ip_gre.c
@@ -444,7 +444,7 @@ static netdev_tx_t ipgre_xmit(struct sk_buff *skb,
 	if (dev->header_ops) {
 		/* Need space for new headers */
 		if (skb_cow_head(skb, dev->needed_headroom -
-				      (tunnel->hlen + sizeof(struct iphdr))));
+				      (tunnel->hlen + sizeof(struct iphdr))))
 			goto free_skb;
 
 		tnl_params = (const struct iphdr *)skb->data;
-- 
1.7.7.6

Re: [PATCH] Net-next: ipv4: type issue, remove erroneous semicolon

[Sergei Shtylyov]

Hello.

On 22-04-2013 14:17, Chen Gang wrote:

>    need remove erroneous semicolon.

>    the related commit number: c54419321455631079c7d6e60bc732dd0c5914c5

    You also need to specify that commit's summary line in parens.

>    Find it by EXTRA_CFLAGS=-W


> Signed-off-by: Chen Gang <gang.chen@asianux.com>

WBR, Sergei

Re: [PATCH] Net-next: ipv4: type issue, remove erroneous semicolon

[David Miller]

From: Chen Gang <gang.chen@asianux.com>
Date: Mon, 22 Apr 2013 18:17:21 +0800

>   need remove erroneous semicolon.
> 
>   the related commit number: c54419321455631079c7d6e60bc732dd0c5914c5
> 
>   Find it by EXTRA_CFLAGS=-W
> 
> 
> Signed-off-by: Chen Gang <gang.chen@asianux.com>

First, what is a "type issue", you aren't changing any variable
or declaration types in this change.

Second, your formatting of your commit messages is terrible.

Do not indent the description with two spaces, just keep them at the
leftmost column.  Where did you learn to indent things like that, who
else does that?  If you've never seen it before, don't invent things.

It is very irritating when we see people write commit messages with
their own style rather than mimicking what other successful
contributors are doing.

Thanks.

Re: [PATCH] Net-next: ipv4: type issue, remove erroneous semicolon

[Chen Gang]

On 2013年04月22日 22:32, Sergei Shtylyov wrote:
> Hello.
> 
> On 22-04-2013 14:17, Chen Gang wrote:
> 
>>    need remove erroneous semicolon.
> 
>>    the related commit number: c54419321455631079c7d6e60bc732dd0c5914c5
> 
>    You also need to specify that commit's summary line in parens.
> 

  ok, thanks, I will send patch v2.


>>    Find it by EXTRA_CFLAGS=-W
> 
> 
>> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> 
> WBR, Sergei
> 
> 
> 
> 


-- 
Chen Gang

Asianux Corporation

Re: [PATCH] Net-next: ipv4: type issue, remove erroneous semicolon

[Chen Gang]

On 2013年04月23日 03:44, David Miller wrote:
> From: Chen Gang <gang.chen@asianux.com>
> Date: Mon, 22 Apr 2013 18:17:21 +0800
> 
>>   need remove erroneous semicolon.
>>
>>   the related commit number: c54419321455631079c7d6e60bc732dd0c5914c5
>>
>>   Find it by EXTRA_CFLAGS=-W
>>
>>
>> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> 
> First, what is a "type issue", you aren't changing any variable
> or declaration types in this change.
> 

  sorry for my poor English, maybe 'type issue' need change to 'typo
issue' ?


> Second, your formatting of your commit messages is terrible.
> 
> Do not indent the description with two spaces, just keep them at the
> leftmost column.  Where did you learn to indent things like that, who
> else does that?  If you've never seen it before, don't invent things.
> 

  ok, excuse me, what I have done is only to try to make my expression
is as clearer as I can. my English is not quite well, I am afraid to let
other members can not understand or misunderstand what I write.

  but since you dislike it, I will not send messages like that to you.

> It is very irritating when we see people write commit messages with
> their own style rather than mimicking what other successful
> contributors are doing.
> 

  sorry, I am not quite understand what your meaning. I guess your
meaning is: "you are very angry to see a member write message with his
own style. if a member is a successful contributor, he never writes
message with his own style, he only follow the public standard style".

  is what I guess correct ?

  thanks.

> Thanks.
> 
> 


-- 
Chen Gang

Asianux Corporation

[PATCH v2] Net-next: ipv4: typo issue, remove erroneous semicolon

[Chen Gang]

need remove erroneous semicolon, which is found by EXTRA_CFLAGS=-W.
the related commit number: c54419321455631079c7d6e60bc732dd0c5914c5
(by Pravin B Shelar <pshelar@nicira.com>  Mon Mar 25 14:49:35 2013)

Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
 net/ipv4/ip_gre.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/ipv4/ip_gre.c b/net/ipv4/ip_gre.c
index 987a4e5..c625e4d 100644
--- a/net/ipv4/ip_gre.c
+++ b/net/ipv4/ip_gre.c
@@ -444,7 +444,7 @@ static netdev_tx_t ipgre_xmit(struct sk_buff *skb,
 	if (dev->header_ops) {
 		/* Need space for new headers */
 		if (skb_cow_head(skb, dev->needed_headroom -
-				      (tunnel->hlen + sizeof(struct iphdr))));
+				      (tunnel->hlen + sizeof(struct iphdr))))
 			goto free_skb;
 
 		tnl_params = (const struct iphdr *)skb->data;
-- 
1.7.7.6

Re: [PATCH v2] Net-next: ipv4: typo issue, remove erroneous semicolon

[David Miller]

From: Chen Gang <gang.chen@asianux.com>
Date: Tue, 23 Apr 2013 10:45:23 +0800

> need remove erroneous semicolon, which is found by EXTRA_CFLAGS=-W.
> the related commit number: c54419321455631079c7d6e60bc732dd0c5914c5
> (by Pravin B Shelar <pshelar@nicira.com>  Mon Mar 25 14:49:35 2013)
> 
> Signed-off-by: Chen Gang <gang.chen@asianux.com>

Do not put the destination GIT tree outside of the "[]" brackets.  Put
it inside the "[]" brackets, so it doesn't show up in the final commit
message.

Also, do not capitalize it, just "net-next" is fine.

Putting "(by Pravin B Shelar <pshelar@nicira.com>  Mon Mar 25 14:49:35 2013)"
is not what we asked for, we asked for the commit message header line
which for this commit would be ("GRE: Refactor GRE tunneling code.")

I want to know by what example you are doing these things?  Follow
the model of other successful patch submitters, such as Eric Dumazet,
Ben Hutchings, Thomas Graf, Simon Horman, etc. just to name a few.

Do exactly what they do, because I never have to tell those people how
to properly format their commit messages, header lines, and the patch
itself.

In your commit message body, properly capitalize your sentences.

This feedback applies to all of the patches you have submitted.  I'm
sorry I have to pick you apart so much, but if you're going to
contribute regularly you have to get this right, I can't be constantly
fixing up by hand every patch you submit.

Re: [PATCH v2] Net-next: ipv4: typo issue, remove erroneous semicolon

[Chen Gang]

On 2013年04月23日 13:16, David Miller wrote:
> From: Chen Gang <gang.chen@asianux.com>
> Date: Tue, 23 Apr 2013 10:45:23 +0800
> 
>> > need remove erroneous semicolon, which is found by EXTRA_CFLAGS=-W.
>> > the related commit number: c54419321455631079c7d6e60bc732dd0c5914c5
>> > (by Pravin B Shelar <pshelar@nicira.com>  Mon Mar 25 14:49:35 2013)
>> > 
>> > Signed-off-by: Chen Gang <gang.chen@asianux.com>
> Do not put the destination GIT tree outside of the "[]" brackets.  Put
> it inside the "[]" brackets, so it doesn't show up in the final commit
> message.
> 
  ok, thanks.

> Also, do not capitalize it, just "net-next" is fine.
> 
  ok, thanks.

> Putting "(by Pravin B Shelar <pshelar@nicira.com>  Mon Mar 25 14:49:35 2013)"
> is not what we asked for, we asked for the commit message header line
> which for this commit would be ("GRE: Refactor GRE tunneling code.")
> 
  ok, thanks.

> I want to know by what example you are doing these things?  Follow
> the model of other successful patch submitters, such as Eric Dumazet,
> Ben Hutchings, Thomas Graf, Simon Horman, etc. just to name a few.
> 
> Do exactly what they do, because I never have to tell those people how
> to properly format their commit messages, header lines, and the patch
> itself.
> 
  ok, thanks.

> In your commit message body, properly capitalize your sentences.
> 
  ok, thanks.

> This feedback applies to all of the patches you have submitted.  I'm
> sorry I have to pick you apart so much, but if you're going to
> contribute regularly you have to get this right, I can't be constantly
> fixing up by hand every patch you submit.
> 
> 
  ok, thanks.

  need I send patch v3 ?


-- 
Chen Gang

Asianux Corporation

[PATCH net-next v3] net: ipv4: typo issue, remove erroneous semicolon

[Chen Gang]

Need remove erroneous semicolon, which is found by EXTRA_CFLAGS=-W,
the related commit number: c54419321455631079c7d6e60bc732dd0c5914c5
("GRE: Refactor GRE tunneling code")


Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
 net/ipv4/ip_gre.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/ipv4/ip_gre.c b/net/ipv4/ip_gre.c
index 987a4e5..c625e4d 100644
--- a/net/ipv4/ip_gre.c
+++ b/net/ipv4/ip_gre.c
@@ -444,7 +444,7 @@ static netdev_tx_t ipgre_xmit(struct sk_buff *skb,
 	if (dev->header_ops) {
 		/* Need space for new headers */
 		if (skb_cow_head(skb, dev->needed_headroom -
-				      (tunnel->hlen + sizeof(struct iphdr))));
+				      (tunnel->hlen + sizeof(struct iphdr))))
 			goto free_skb;
 
 		tnl_params = (const struct iphdr *)skb->data;
-- 
1.7.7.6

Re: [PATCH net-next v3] net: ipv4: typo issue, remove erroneous semicolon

[Pravin Shelar]

On Mon, Apr 22, 2013 at 11:45 PM, Chen Gang <gang.chen@asianux.com> wrote:
>
> Need remove erroneous semicolon, which is found by EXTRA_CFLAGS=-W,
> the related commit number: c54419321455631079c7d6e60bc732dd0c5914c5
> ("GRE: Refactor GRE tunneling code")
>
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
Thanks for fixing it.

Acked-by: Pravin B Shelar <pshelar@nicira.com>

> ---
>  net/ipv4/ip_gre.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/ipv4/ip_gre.c b/net/ipv4/ip_gre.c
> index 987a4e5..c625e4d 100644
> --- a/net/ipv4/ip_gre.c
> +++ b/net/ipv4/ip_gre.c
> @@ -444,7 +444,7 @@ static netdev_tx_t ipgre_xmit(struct sk_buff *skb,
>         if (dev->header_ops) {
>                 /* Need space for new headers */
>                 if (skb_cow_head(skb, dev->needed_headroom -
> -                                     (tunnel->hlen + sizeof(struct iphdr))));
> +                                     (tunnel->hlen + sizeof(struct iphdr))))
>                         goto free_skb;
>
>                 tnl_params = (const struct iphdr *)skb->data;
> --
> 1.7.7.6

Re: [PATCH net-next v3] net: ipv4: typo issue, remove erroneous semicolon

[Chen Gang]

On 2013年04月25日 02:09, Pravin Shelar wrote:
> On Mon, Apr 22, 2013 at 11:45 PM, Chen Gang <gang.chen@asianux.com> wrote:
>> >
>> > Need remove erroneous semicolon, which is found by EXTRA_CFLAGS=-W,
>> > the related commit number: c54419321455631079c7d6e60bc732dd0c5914c5
>> > ("GRE: Refactor GRE tunneling code")
>> >
>> >
>> > Signed-off-by: Chen Gang <gang.chen@asianux.com>
> Thanks for fixing it.
> 
> Acked-by: Pravin B Shelar <pshelar@nicira.com>
> 

Thanks, too.

-- 
Chen Gang

Asianux Corporation

Re: [PATCH net-next v3] net: ipv4: typo issue, remove erroneous semicolon

[David Miller]

From: Chen Gang <gang.chen@asianux.com>
Date: Tue, 23 Apr 2013 14:45:42 +0800

> Need remove erroneous semicolon, which is found by EXTRA_CFLAGS=-W,
> the related commit number: c54419321455631079c7d6e60bc732dd0c5914c5
> ("GRE: Refactor GRE tunneling code")
> 
> Signed-off-by: Chen Gang <gang.chen@asianux.com>

Applied.

Re: [PATCH net-next v3] net: ipv4: typo issue, remove erroneous semicolon

[Chen Gang]

On 2013年04月25日 16:08, David Miller wrote:
> From: Chen Gang <gang.chen@asianux.com>
> Date: Tue, 23 Apr 2013 14:45:42 +0800
> 
>> > Need remove erroneous semicolon, which is found by EXTRA_CFLAGS=-W,
>> > the related commit number: c54419321455631079c7d6e60bc732dd0c5914c5
>> > ("GRE: Refactor GRE tunneling code")
>> > 
>> > Signed-off-by: Chen Gang <gang.chen@asianux.com>
> Applied.
> 
> 

Thanks.

-- 
Chen Gang

Asianux Corporation