[PATCH] drm/amdgpu: Add error message for DAC setup failure

[PATCH] drm/amdgpu: Add error message for DAC setup failure

[Shashank Sharma]

This patch adds a return value check and an error message to
highlight the DAC setup failure case during encoder DPMS
operation.

Cc: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Shashank Sharma <shashank.sharma@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/atombios_encoders.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/atombios_encoders.c b/drivers/gpu/drm/amd/amdgpu/atombios_encoders.c
index 1e94a9b652f7..3779f933564b 100644
--- a/drivers/gpu/drm/amd/amdgpu/atombios_encoders.c
+++ b/drivers/gpu/drm/amd/amdgpu/atombios_encoders.c
@@ -341,8 +341,8 @@ amdgpu_atombios_encoder_setup_dac(struct drm_encoder *encoder, int action)
 	args.ucDacStandard = ATOM_DAC1_PS2;
 	args.usPixelClock = cpu_to_le16(amdgpu_encoder->pixel_clock / 10);
 
-	amdgpu_atom_execute_table(adev->mode_info.atom_context, index, (uint32_t *)&args);
-
+	if (amdgpu_atom_execute_table(adev->mode_info.atom_context, index, (uint32_t *)&args))
+		DRM_ERROR("AMDGPU: dac setup failed\n");
 }
 
 static u8 amdgpu_atombios_encoder_get_bpc(struct drm_encoder *encoder)
-- 
2.25.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/amdgpu: Add error message for DAC setup failure

[Nirmoy]

Acked-by: Nirmoy Das <nirmoy.das@amd.com>

On 10/6/20 8:05 AM, Shashank Sharma wrote:
> This patch adds a return value check and an error message to
> highlight the DAC setup failure case during encoder DPMS
> operation.
>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Signed-off-by: Shashank Sharma <shashank.sharma@amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/atombios_encoders.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/atombios_encoders.c b/drivers/gpu/drm/amd/amdgpu/atombios_encoders.c
> index 1e94a9b652f7..3779f933564b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/atombios_encoders.c
> +++ b/drivers/gpu/drm/amd/amdgpu/atombios_encoders.c
> @@ -341,8 +341,8 @@ amdgpu_atombios_encoder_setup_dac(struct drm_encoder *encoder, int action)
>   	args.ucDacStandard = ATOM_DAC1_PS2;
>   	args.usPixelClock = cpu_to_le16(amdgpu_encoder->pixel_clock / 10);
>   
> -	amdgpu_atom_execute_table(adev->mode_info.atom_context, index, (uint32_t *)&args);
> -
> +	if (amdgpu_atom_execute_table(adev->mode_info.atom_context, index, (uint32_t *)&args))
> +		DRM_ERROR("AMDGPU: dac setup failed\n");
>   }
>   
>   static u8 amdgpu_atombios_encoder_get_bpc(struct drm_encoder *encoder)
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx