From: Alex Shi <alex.shi@intel.com>
To: Paul Turner <pjt@google.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
Borislav Petkov <bp@alien8.de>,
Namhyung Kim <namhyung@kernel.org>,
Mike Galbraith <efault@gmx.de>,
Morten Rasmussen <morten.rasmussen@arm.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Preeti U Murthy <preeti@linux.vnet.ibm.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
LKML <linux-kernel@vger.kernel.org>, Mel Gorman <mgorman@suse.de>,
Rik van Riel <riel@redhat.com>,
Michael Wang <wangyun@linux.vnet.ibm.com>
Subject: Re: [PATCH v5 1/7] Revert "sched: Introduce temporary FAIR_GROUP_SCHED dependency for load-tracking"
Date: Mon, 06 May 2013 16:58:56 +0800 [thread overview]
Message-ID: <518770D0.50508@intel.com> (raw)
In-Reply-To: <CAPM31RLOHcDGJy6bpXeMN90+NpGNkKS=32Wyq5r0LkdGb=SKkQ@mail.gmail.com>
On 05/06/2013 04:55 PM, Paul Turner wrote:
>> > Is the comments ok? :)
>> >
>> > /* runnable related variables only used in FAIR_GROUP_SCHED */
> Perhaps:
>
> -/* These always depend on CONFIG_FAIR_GROUP_SCHED */
> #ifdef ...
> +/* Required to track per-cpu representation of a task_group */
>
>
looks fine. thanks a lot!
--
Thanks
Alex
next prev parent reply other threads:[~2013-05-06 8:59 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-06 1:45 [PATCH v5 0/7] use runnable load avg in load balance Alex Shi
2013-05-06 1:45 ` [PATCH v5 1/7] Revert "sched: Introduce temporary FAIR_GROUP_SCHED dependency for load-tracking" Alex Shi
2013-05-06 8:24 ` Paul Turner
2013-05-06 8:49 ` Alex Shi
2013-05-06 8:55 ` Paul Turner
2013-05-06 8:58 ` Alex Shi [this message]
2013-05-07 5:05 ` Alex Shi
2013-05-06 1:45 ` [PATCH v5 2/7] sched: remove SMP cover for runnable variables in cfs_rq Alex Shi
2013-05-06 4:11 ` Preeti U Murthy
2013-05-06 7:18 ` Alex Shi
2013-05-06 8:01 ` Paul Turner
2013-05-06 8:57 ` Alex Shi
2013-05-06 9:08 ` Paul Turner
2013-05-06 10:47 ` Preeti U Murthy
2013-05-06 15:02 ` Alex Shi
2013-05-07 5:07 ` Alex Shi
2013-05-06 1:45 ` [PATCH v5 3/7] sched: set initial value of runnable avg for new forked task Alex Shi
2013-05-06 8:19 ` Paul Turner
2013-05-06 9:21 ` Alex Shi
2013-05-06 10:17 ` Paul Turner
2013-05-07 2:18 ` Alex Shi
2013-05-07 3:06 ` Paul Turner
2013-05-07 3:24 ` Alex Shi
2013-05-07 5:03 ` Alex Shi
2013-05-09 8:31 ` Alex Shi
2013-05-09 9:30 ` Paul Turner
2013-05-09 14:23 ` Alex Shi
2013-05-08 11:15 ` Peter Zijlstra
2013-05-09 9:34 ` Paul Turner
2013-05-07 9:57 ` Morten Rasmussen
2013-05-07 11:05 ` Alex Shi
2013-05-07 11:20 ` Paul Turner
2013-05-08 11:34 ` Peter Zijlstra
2013-05-08 12:00 ` Paul Turner
2013-05-09 10:55 ` Morten Rasmussen
2013-05-09 8:22 ` Alex Shi
2013-05-09 9:24 ` Paul Turner
2013-05-09 13:13 ` Alex Shi
2013-05-06 10:22 ` Paul Turner
2013-05-06 15:26 ` Alex Shi
2013-05-06 15:28 ` Peter Zijlstra
2013-05-07 2:19 ` Alex Shi
2013-05-06 1:45 ` [PATCH v5 4/7] sched: update cpu load after task_tick Alex Shi
2013-05-06 1:45 ` [PATCH v5 5/7] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task Alex Shi
2013-05-06 8:46 ` Paul Turner
2013-05-06 10:19 ` Peter Zijlstra
2013-05-06 10:33 ` Paul Turner
2013-05-06 11:10 ` Peter Zijlstra
2013-05-07 6:17 ` Alex Shi
2013-06-04 1:45 ` Alex Shi
2013-06-04 1:51 ` [DISCUSSION] removing variety rq->cpu_load ? Alex Shi
2013-06-04 2:33 ` Michael Wang
2013-06-04 2:44 ` Alex Shi
2013-06-04 3:09 ` Michael Wang
2013-06-04 4:55 ` Alex Shi
2013-05-06 15:00 ` [PATCH v5 5/7] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task Alex Shi
2013-05-06 18:34 ` Paul Turner
2013-05-07 0:24 ` Alex Shi
2013-05-07 5:12 ` Alex Shi
2013-05-06 1:45 ` [PATCH v5 6/7] sched: consider runnable load average in move_tasks Alex Shi
2013-05-06 8:53 ` Paul Turner
2013-05-06 15:04 ` Peter Zijlstra
2013-05-06 20:59 ` Paul Turner
2013-05-07 5:17 ` Alex Shi
2013-05-08 1:39 ` Alex Shi
2013-05-09 1:24 ` Alex Shi
2013-05-10 13:58 ` Alex Shi
2013-05-09 5:29 ` Alex Shi
2013-05-10 14:03 ` Alex Shi
2013-05-06 15:07 ` Alex Shi
2013-05-06 1:45 ` [PATCH v5 7/7] sched: consider runnable load average in effective_load Alex Shi
2013-05-06 3:34 ` Michael Wang
2013-05-06 5:39 ` Alex Shi
2013-05-06 6:11 ` Michael Wang
2013-05-06 9:39 ` Alex Shi
2013-05-06 7:49 ` Michael Wang
2013-05-06 8:02 ` Alex Shi
2013-05-06 8:34 ` Michael Wang
2013-05-06 9:06 ` Paul Turner
2013-05-06 9:35 ` Alex Shi
2013-05-06 9:59 ` Preeti U Murthy
2013-05-07 2:43 ` Michael Wang
2013-05-07 5:43 ` Alex Shi
2013-05-08 1:33 ` Alex Shi
2013-05-06 10:00 ` Paul Turner
2013-05-06 7:10 ` Preeti U Murthy
2013-05-06 7:20 ` Michael Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518770D0.50508@intel.com \
--to=alex.shi@intel.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=preeti@linux.vnet.ibm.com \
--cc=riel@redhat.com \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=wangyun@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.