* [PATCH 08/26] mtd: maps: ixp4xx: remove unnecessary platform_set_drvdata()
@ 2013-05-07 6:31 Jingoo Han
2013-05-07 6:49 ` Marc Kleine-Budde
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-05-07 6:31 UTC (permalink / raw)
To: 'Artem Bityutskiy'
Cc: linux-mtd, Jingoo Han, 'David Woodhouse',
'Marc Kleine-Budde'
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/mtd/maps/ixp4xx.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/maps/ixp4xx.c b/drivers/mtd/maps/ixp4xx.c
index 52b3410..09c542b 100644
--- a/drivers/mtd/maps/ixp4xx.c
+++ b/drivers/mtd/maps/ixp4xx.c
@@ -155,8 +155,6 @@ static int ixp4xx_flash_remove(struct platform_device *dev)
struct flash_platform_data *plat = dev->dev.platform_data;
struct ixp4xx_flash_info *info = platform_get_drvdata(dev);
- platform_set_drvdata(dev, NULL);
-
if(!info)
return 0;
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 08/26] mtd: maps: ixp4xx: remove unnecessary platform_set_drvdata()
2013-05-07 6:31 [PATCH 08/26] mtd: maps: ixp4xx: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-05-07 6:49 ` Marc Kleine-Budde
0 siblings, 0 replies; 2+ messages in thread
From: Marc Kleine-Budde @ 2013-05-07 6:49 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Artem Bityutskiy', 'David Woodhouse', linux-mtd
[-- Attachment #1: Type: text/plain, Size: 440 bytes --]
On 05/07/2013 08:31 AM, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Marc Kleine-Budde <mkl@blackshift.org>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-07 6:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-07 6:31 [PATCH 08/26] mtd: maps: ixp4xx: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-07 6:49 ` Marc Kleine-Budde
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.