* [PATCH 04/36] net: can: ti_hecc: remove unnecessary platform_set_drvdata()
@ 2013-05-07 4:17 Jingoo Han
2013-05-07 7:08 ` Marc Kleine-Budde
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-05-07 4:17 UTC (permalink / raw)
To: 'David S. Miller'; +Cc: netdev, Jingoo Han, Marc Kleine-Budde
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/can/ti_hecc.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/can/ti_hecc.c b/drivers/net/can/ti_hecc.c
index f21fc37..3a349a2 100644
--- a/drivers/net/can/ti_hecc.c
+++ b/drivers/net/can/ti_hecc.c
@@ -1001,7 +1001,6 @@ static int ti_hecc_remove(struct platform_device *pdev)
iounmap(priv->base);
release_mem_region(res->start, resource_size(res));
free_candev(ndev);
- platform_set_drvdata(pdev, NULL);
return 0;
}
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 04/36] net: can: ti_hecc: remove unnecessary platform_set_drvdata()
2013-05-07 4:17 [PATCH 04/36] net: can: ti_hecc: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-05-07 7:08 ` Marc Kleine-Budde
0 siblings, 0 replies; 2+ messages in thread
From: Marc Kleine-Budde @ 2013-05-07 7:08 UTC (permalink / raw)
To: Jingoo Han; +Cc: 'David S. Miller', netdev
[-- Attachment #1: Type: text/plain, Size: 725 bytes --]
On 05/07/2013 06:17 AM, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-07 7:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-07 4:17 [PATCH 04/36] net: can: ti_hecc: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-07 7:08 ` Marc Kleine-Budde
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.