All of lore.kernel.org
 help / color / mirror / Atom feed
* What's cooking in git.git (May 2013, #01; Fri, 3)
@ 2013-05-03 23:14 Junio C Hamano
  2013-05-07 14:27 ` Problems with Windows, Was: " Torsten Bögershausen
  0 siblings, 1 reply; 8+ messages in thread
From: Junio C Hamano @ 2013-05-03 23:14 UTC (permalink / raw)
  To: git

Here are the topics that have been cooking.  Commits prefixed with
'-' are only in 'pu' (proposed updates) while commits prefixed with
'+' are in 'next'.

The tip of the 'master' branch is tagged as v1.8.3-rc1.  We seem to
have a few interesting topics that are being discussed but it is
unlikely I'll be picking them up in 'pu'.  As we already have merged
enough changes to 'master' during this cycle that can potentially
cause unforseen regressions, let's not merge topics that are not
regression fixes from 'next' to 'master', either, until the final
release.

You can find the changes described here in the integration branches
of the repositories listed at

    http://git-blame.blogspot.com/p/git-public-repositories.html

--------------------------------------------------
[Graduated to "master"]

* hb/git-pm-tempfile (2013-04-29) 1 commit
  (merged to 'next' on 2013-04-29 at fecc6b0)
 + Git.pm: call tempfile from File::Temp as a regular function


* mb/relnotes-1.8.3-typofix (2013-04-30) 1 commit
 - Fix grammar in the 1.8.3 release notes.


* rs/pp-user-info-without-extra-allocation (2013-04-25) 3 commits
  (merged to 'next' on 2013-04-29 at 13eafc3)
 + pretty: remove intermediate strbufs from pp_user_info()
 + pretty: simplify output line length calculation in pp_user_info()
 + pretty: simplify input line length calculation in pp_user_info()


* tr/remote-tighten-commandline-parsing (2013-04-24) 3 commits
  (merged to 'next' on 2013-04-29 at 46a1043)
 + remote: 'show' and 'prune' can take more than one remote
 + remote: check for superfluous arguments in 'git remote add'
 + remote: add a test for extra arguments, according to docs


* tr/unpack-entry-use-after-free-fix (2013-04-30) 1 commit
 - unpack_entry: avoid freeing objects in base cache

 Fix for use-after-free regression in 1.8.3-rc0.


* zk/prompt-rebase-step (2013-04-25) 1 commit
  (merged to 'next' on 2013-04-25 at a8264bf)
 + bash-prompt.sh: show where rebase is at when stopped

--------------------------------------------------
[New Topics]

* fc/at-head (2013-05-02) 5 commits
 - Add new @ shortcut for HEAD
 - sha1_name: refactor reinterpret()
 - sha1_name: compare variable with constant, not constant with variable
 - sha1_name: remove unnecessary braces
 - sha1_name: remove no-op

 People are too lazy to type four capital letters "HEAD" and want to
 use a single line-noise "@" instead.


* fc/remote-bzr (2013-04-30) 18 commits
 - remote-bzr: access branches only when needed
 - remote-bzr: delay peer branch usage
 - remote-bzr: iterate revisions properly
 - remote-bzr: improve progress reporting
 - remote-bzr: add option to specify branches
 - remote-bzr: add custom method to find branches
 - remote-bzr: improve author sanitazion
 - remote-bzr: add support for shared repo
 - remote-bzr: fix branch names
 - remote-bzr: add support for bzr repos
 - remote-bzr: use branch variable when appropriate
 - remote-bzr: fix partially pushed merge
 - remote-bzr: fixes for branch diverge
 - remote-bzr: add support to push merges
 - remote-bzr: always try to update the worktree
 - remote-bzr: fix order of locking in CustomTree
 - remote-bzr: delay blob fetching until the very end
 - remote-bzr: cleanup CustomTree


* jk/lookup-object-prefer-latest (2013-05-02) 1 commit
 - lookup_object: prioritize recently found objects


* jk/subtree-do-not-push-if-split-fails (2013-05-01) 1 commit
 - contrib/subtree: don't delete remote branches if split fails

--------------------------------------------------
[Stalled]

* mg/more-textconv (2013-04-23) 7 commits
 - git grep: honor textconv by default
 - grep: honor --textconv for the case rev:path
 - grep: allow to use textconv filters
 - t7008: demonstrate behavior of grep with textconv
 - cat-file: do not die on --textconv without textconv filters
 - show: honor --textconv for blobs
 - t4030: demonstrate behavior of show with textconv

 Rerolled. I am not sure if I like "show <blob>" and "grep" that use
 textconv by default, though.


* mh/multimail (2013-04-21) 1 commit
 - git-multimail: a replacement for post-receive-email

 Waiting for comments.


* jc/format-patch (2013-04-22) 2 commits
 - format-patch: --inline-single
 - format-patch: rename "no_inline" field

 A new option to send a single patch to the standard output to be
 appended at the bottom of a message.  I personally have no need for
 this, but it was easy enough to cobble together.  Tests, docs and
 stripping out more MIMEy stuff are left as exercises to interested
 parties.

 Not ready for inclusion.


* jk/gitweb-utf8 (2013-04-08) 4 commits
 - gitweb: Fix broken blob action parameters on blob/commitdiff pages
 - gitweb: Don't append ';js=(0|1)' to external links
 - gitweb: Make feed title valid utf8
 - gitweb: Fix utf8 encoding for blob_plain, blobdiff_plain, commitdiff_plain, and patch

 Various fixes to gitweb.

 Waiting for a reroll after a review.


* jk/commit-info-slab (2013-04-19) 3 commits
 - commit-slab: introduce a macro to define a slab for new type
 - commit-slab: avoid large realloc
 - commit: allow associating auxiliary info on-demand
 (this branch is used by jc/show-branch.)

 Technology demonstration to show a way we could use unbound number
 of flag bits on commit objects.


* jn/config-ignore-inaccessible (2013-04-15) 1 commit
 - config: allow inaccessible configuration under $HOME

 When $HOME is misconfigured to point at an unreadable directory, we
 used to complain and die. This loosens the check.

 I do not think we agreed that this is a good idea, though.

--------------------------------------------------
[Cooking]

* fc/completion (2013-04-27) 9 commits
 - completion: remove __git_index_file_list_filter()
 - completion: add space after completed filename
 - completion: add hack to enable file mode in bash < 4
 - completion: refactor __git_complete_index_file()
 - completion: refactor diff_index wrappers
 - completion: use __gitcompadd for __gitcomp_file
 - completion; remove unuseful comments
 - completion: document tilde expansion failure in tests
 - completion: add file completion tests

 I saw this discussed somewhat. Is everybody happy with this
 version?  This is its v2, in the $gmane/222682 thread.


* jk/test-output (2013-04-29) 2 commits
  (merged to 'next' on 2013-05-01 at 63827c9)
 + test output: respect $TEST_OUTPUT_DIRECTORY
 + t/Makefile: fix result handling with TEST_OUTPUT_DIRECTORY

 When TEST_OUTPUT_DIRECTORY setting is used, it was handled somewhat
 inconsistently between the test framework and t/Makefile, and logic
 to summarize the results looked at a wrong place.

 Will cook in 'next'.


* rj/mingw-cygwin (2013-04-28) 2 commits
 - cygwin: Remove the CYGWIN_V15_WIN32API build variable
 - mingw: rename WIN32 cpp macro to GIT_WINDOWS_NATIVE

 Cygwin portability; both were reviewed by Jonathan, and the tip one
 seems to want a bit further explanation.  Needs positive report
 from Cygwin 1.7 users who have been on 1.7 to make sure it does not
 regress for them.


* rj/sparse (2013-04-28) 10 commits
  (merged to 'next' on 2013-05-01 at 649e16c)
 + sparse: Fix mingw_main() argument number/type errors
 + compat/mingw.c: Fix some sparse warnings
 + compat/win32mmap.c: Fix some sparse warnings
 + compat/poll/poll.c: Fix a sparse warning
 + compat/win32/pthread.c: Fix a sparse warning
 + compat/unsetenv.c: Fix a sparse warning
 + compat/nedmalloc: Fix compiler warnings on linux
 + compat/nedmalloc: Fix some sparse warnings
 + compat/fnmatch/fnmatch.c: Fix a sparse error
 + compat/regex/regexec.c: Fix some sparse warnings

 Will cook in 'next'.


* js/transport-helper-error-reporting-fix (2013-04-28) 3 commits
  (merged to 'next' on 2013-04-29 at 8cc4bb8)
 + git-remote-testgit: build it to run under $SHELL_PATH
 + git-remote-testgit: further remove some bashisms
 + git-remote-testgit: avoid process substitution
 (this branch uses fc/transport-helper-error-reporting.)

 Finishing touches to fc/transport-helper-error-reporting topic.
 Will cook in 'next'.


* mh/fetch-into-shallow (2013-05-02) 2 commits
  (merged to 'next' on 2013-05-03 at 3fadc61)
 + t5500: add test for fetching with an unknown 'shallow'
  (merged to 'next' on 2013-04-29 at a167d3e)
 + upload-pack: ignore 'shallow' lines with unknown obj-ids

 Will cook in 'next'.


* kb/full-history-compute-treesame-carefully (2013-04-30) 8 commits
 - revision.c: discount UNINTERESTING parents
 - simplify-merges: drop merge from irrelevant side branch
 - simplify-merges: never remove all TREESAME parents
 - t6012: update test for tweaked full-history traversal
 - revision.c: Make --full-history consider more merges
 - rev-list-options.txt: correct TREESAME for P
 - t6019: test file dropped in -s ours merge
 - decorate.c: compact table when growing

 Major update to a very core part of the system to improve culling
 of irrelevant parents while traversing a mergy history.

 Will not be a 1.8.3 material.


* jh/checkout-auto-tracking (2013-04-21) 8 commits
  (merged to 'next' on 2013-04-22 at 2356700)
 + glossary: Update and rephrase the definition of a remote-tracking branch
 + branch.c: Validate tracking branches with refspecs instead of refs/remotes/*
 + t9114.2: Don't use --track option against "svn-remote"-tracking branches
 + t7201.24: Add refspec to keep --track working
 + t3200.39: tracking setup should fail if there is no matching refspec.
 + checkout: Use remote refspecs when DWIMming tracking branches
 + t2024: Show failure to use refspec when DWIMming remote branch names
 + t2024: Add tests verifying current DWIM behavior of 'git checkout <branch>'

 Updates "git checkout foo" that DWIMs the intended "upstream" and
 turns it into "git checkout -t -b foo remotes/origin/foo" to
 correctly take existing remote definitions into account.  The
 remote "origin" may be what uniquely map its own branch to
 remotes/some/where/foo but that some/where may not be "origin".

 Will cook in 'next'.


* jc/prune-all (2013-04-25) 4 commits
  (merged to 'next' on 2013-04-26 at 97a7387)
 + prune: introduce OPT_EXPIRY_DATE() and use it
  (merged to 'next' on 2013-04-22 at b00ccf6)
 + api-parse-options.txt: document "no-" for non-boolean options
 + git-gc.txt, git-reflog.txt: document new expiry options
 + date.c: add parse_expiry_date()
 (this branch is used by mh/packed-refs-various.)

 We used the approxidate() parser for "--expire=<timestamp>" options
 of various commands, but it is better to treat --expire=all and
 --expire=now a bit more specially than using the current timestamp.
 Update "git gc" and "git reflog" with a new parsing function for
 expiry dates.

 Will cook in 'next'.


* as/check-ignore (2013-04-29) 6 commits
  (merged to 'next' on 2013-04-30 at 646931f)
 + t0008: use named pipe (FIFO) to test check-ignore streaming
  (merged to 'next' on 2013-04-21 at 7515aa8)
 + Documentation: add caveats about I/O buffering for check-{attr,ignore}
 + check-ignore: allow incremental streaming of queries via --stdin
 + check-ignore: move setup into cmd_check_ignore()
 + check-ignore: add -n / --non-matching option
 + t0008: remove duplicated test fixture data

 Enhance "check-ignore" (1.8.2 update) to work more like "check-attr"
 over bidi-pipes.

 Will cook in 'next'.


* mh/packed-refs-various (2013-05-01) 33 commits
  (merged to 'next' on 2013-05-01 at e527153)
 + refs: handle the main ref_cache specially
 + refs: change do_for_each_*() functions to take ref_cache arguments
 + pack_one_ref(): do some cheap tests before a more expensive one
 + pack_one_ref(): use write_packed_entry() to do the writing
 + pack_one_ref(): use function peel_entry()
 + refs: inline function do_not_prune()
 + pack_refs(): change to use do_for_each_entry()
 + refs: use same lock_file object for both ref-packing functions
 + pack_one_ref(): rename "path" parameter to "refname"
 + pack-refs: merge code from pack-refs.{c,h} into refs.{c,h}
 + pack-refs: rename handle_one_ref() to pack_one_ref()
 + refs: extract a function write_packed_entry()
 + repack_without_ref(): write peeled refs in the rewritten file
 + t3211: demonstrate loss of peeled refs if a packed ref is deleted
 + refs: change how packed refs are deleted
 + search_ref_dir(): return an index rather than a pointer
 + repack_without_ref(): silence errors for dangling packed refs
 + t3210: test for spurious error messages for dangling packed refs
 + refs: change the internal reference-iteration API
 + refs: extract a function peel_entry()
 + peel_ref(): fix return value for non-peelable, not-current reference
 + peel_object(): give more specific information in return value
 + refs: extract function peel_object()
 + refs: extract a function ref_resolves_to_object()
 + repack_without_ref(): use function get_packed_ref()
 + peel_ref(): use function get_packed_ref()
 + get_packed_ref(): return a ref_entry
 + do_for_each_ref_in_dirs(): remove dead code
 + refs: define constant PEELED_LINE_LENGTH
 + refs: document how current_ref is used
 + refs: document do_for_each_ref() and do_one_ref()
 + refs: document the fields of struct ref_value
 + refs: document flags constants REF_*
 (this branch uses jc/prune-all.)

 Updates reading and updating packed-refs file, correcting corner
 case bugs.

 Will cook in 'next'.


* fc/transport-helper-error-reporting (2013-04-25) 10 commits
  (merged to 'next' on 2013-04-25 at 3358f1a)
 + t5801: "VAR=VAL shell_func args" is forbidden
  (merged to 'next' on 2013-04-22 at 5ba6467)
 + transport-helper: update remote helper namespace
 + transport-helper: trivial code shuffle
 + transport-helper: warn when refspec is not used
 + transport-helper: clarify pushing without refspecs
 + transport-helper: update refspec documentation
 + transport-helper: clarify *:* refspec
 + transport-helper: improve push messages
 + transport-helper: mention helper name when it dies
 + transport-helper: report errors properly
 (this branch is used by js/transport-helper-error-reporting-fix.)

 Update transport helper to report errors and maintain ref hierarchy
 used to keep track of remote helper state better.

 Will cook in 'next', but may be 1.8.3 material depending on how things go.


* jk/submodule-subdirectory-ok (2013-04-24) 3 commits
  (merged to 'next' on 2013-04-24 at 6306b29)
 + submodule: fix quoting in relative_path()
  (merged to 'next' on 2013-04-22 at f211e25)
 + submodule: drop the top-level requirement
 + rev-parse: add --prefix option

 Allow various subcommands of "git submodule" to be run not from the
 top of the working tree of the superproject.

 Will cook in 'next'.


* jl/submodule-mv (2013-04-23) 5 commits
  (merged to 'next' on 2013-04-23 at c04f574)
 + submodule.c: duplicate real_path's return value
  (merged to 'next' on 2013-04-19 at 45ae3c9)
 + rm: delete .gitmodules entry of submodules removed from the work tree
 + Teach mv to update the path entry in .gitmodules for moved submodules
 + Teach mv to move submodules using a gitfile
 + Teach mv to move submodules together with their work trees

 "git mv A B" when moving a submodule A does "the right thing",
 inclusing relocating its working tree and adjusting the paths in
 the .gitmodules file.

 Will cook in 'next'.


* jn/add-2.0-u-A-sans-pathspec (2013-04-26) 1 commit
 - git add: -u/-A now affects the entire working tree

 Will cook in 'next' until Git 2.0.


* nd/magic-pathspecs (2013-03-31) 45 commits
 . Rename field "raw" to "_raw" in struct pathspec
 . pathspec: support :(glob) syntax
 . pathspec: make --literal-pathspecs disable pathspec magic
 . pathspec: support :(literal) syntax for noglob pathspec
 . Kill limit_pathspec_to_literal() as it's only used by parse_pathspec()
 . parse_pathspec: preserve prefix length via PATHSPEC_PREFIX_ORIGIN
 . parse_pathspec: make sure the prefix part is wildcard-free
 . tree-diff: remove the use of pathspec's raw[] in follow-rename codepath
 . Remove match_pathspec() in favor of match_pathspec_depth()
 . Remove init_pathspec() in favor of parse_pathspec()
 . Remove diff_tree_{setup,release}_paths
 . Convert common_prefix() to use struct pathspec
 . Convert add_files_to_cache to take struct pathspec
 . Convert {read,fill}_directory to take struct pathspec
 . Convert refresh_index to take struct pathspec
 . Convert report_path_error to take struct pathspec
 . checkout: convert read_tree_some to take struct pathspec
 . Convert unmerge_cache to take struct pathspec
 . Convert run_add_interactive to use struct pathspec
 . Convert read_cache_preload() to take struct pathspec
 . reset: convert to use parse_pathspec
 . add: convert to use parse_pathspec
 . check-ignore: convert to use parse_pathspec
 . archive: convert to use parse_pathspec
 . ls-files: convert to use parse_pathspec
 . rm: convert to use parse_pathspec
 . checkout: convert to use parse_pathspec
 . rerere: convert to use parse_pathspec
 . status: convert to use parse_pathspec
 . commit: convert to use parse_pathspec
 . clean: convert to use parse_pathspec
 . Guard against new pathspec magic in pathspec matching code
 . parse_pathspec: support prefixing original patterns
 . parse_pathspec: support stripping/checking submodule paths
 . parse_pathspec: support stripping submodule trailing slashes
 . parse_pathspec: a special flag for max_depth feature
 . Convert some get_pathspec() calls to parse_pathspec()
 . parse_pathspec: add PATHSPEC_PREFER_{CWD,FULL}
 . parse_pathspec: save original pathspec for reporting
 . Add parse_pathspec() that converts cmdline args to struct pathspec
 . pathspec: add copy_pathspec
 . pathspec: i18n-ize error strings in pathspec parsing code
 . Move struct pathspec and related functions to pathspec.[ch]
 . clean: remove unused variable "seen"
 . setup.c: check that the pathspec magic ends with ")"

 Migrate the rest of codebase to use "struct pathspec" more.

 This has nasty conflicts with kb/status-ignored-optim-2,
 as/check-ignore and tr/line-log; I've already asked Duy to hold
 this and later rebase on top of them.

 Will defer.


* tr/line-log (2013-04-22) 13 commits
  (merged to 'next' on 2013-04-22 at 8f2c1de)
 + git-log(1): remove --full-line-diff description
  (merged to 'next' on 2013-04-21 at cd92620)
 + line-log: fix documentation formatting
  (merged to 'next' on 2013-04-15 at 504559e)
 + log -L: improve comments in process_all_files()
 + log -L: store the path instead of a diff_filespec
 + log -L: test merge of parallel modify/rename
 + t4211: pass -M to 'git log -M -L...' test
  (merged to 'next' on 2013-04-05 at 5afb00c)
 + log -L: fix overlapping input ranges
 + log -L: check range set invariants when we look it up
  (merged to 'next' on 2013-04-01 at 5be920c)
 + Speed up log -L... -M
 + log -L: :pattern:file syntax to find by funcname
 + Implement line-history search (git log -L)
 + Export rewrite_parents() for 'log -L'
 + Refactor parse_loc

 Will cook in 'next'.


* jc/push-2.0-default-to-simple (2013-04-03) 1 commit
 - push: switch default from "matching" to "simple"

 The early bits to adjust the tests have been merged to 'master'.

 Will cook in 'next' until Git 2.0.


* jc/add-2.0-ignore-removal (2013-04-22) 1 commit
 - git add <pathspec>... defaults to "-A"

 Updated endgame for "git add <pathspec>" that defaults to "--all"
 aka "--no-ignore-removal".

 Will cook in 'next' until Git 2.0.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Problems with Windows, Was: What's cooking in git.git (May 2013, #01; Fri, 3)
  2013-05-03 23:14 What's cooking in git.git (May 2013, #01; Fri, 3) Junio C Hamano
@ 2013-05-07 14:27 ` Torsten Bögershausen
  2013-05-08  0:30   ` Mark Levedahl
  2013-05-09 17:18   ` Ramsay Jones
  0 siblings, 2 replies; 8+ messages in thread
From: Torsten Bögershausen @ 2013-05-07 14:27 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: git

On 2013-05-04 01.14, Junio C Hamano wrote:
> 
>  Cygwin portability; both were reviewed by Jonathan, and the tip one
>  seems to want a bit further explanation.  Needs positive report
>  from Cygwin 1.7 users who have been on 1.7 to make sure it does not
>  regress for them.

I was trying to verify that cygwin 1.7 is still Ok, but got puzzled.

Running the test suite under cygwin doesn't seem to work any more (?):

Scenario 1:
The PC is running alone, and goes into the screen saver.
Pressing CTRL-ALT-DEL didn't get any effect.

Scenario 2:
The PC didn't react any more, when the test suite was run in background.
In 3 or 4 cases the PC needed to be reboot hardly.

Using the commits before and after this change makes the test suite hang 
as well at some point, then it hangs somewhere at TC 3000--4000.

Scenario 4:
The I disabled the screensaver, upgdated cygwin,
 and went back to an older commit:
The latest run from commit 52d63e70, April 28,
hangs in TC 5500, ok 26 clone shallow object count.

I can see 2 times 
git.exe pull --depth 4 ..A 

Scenario 5:
The run of today 1.8.3-rc1, hangs in t5510,
some git.exe are running fetch. (or pull)


It seems as if some process/exes are not terminated
in the way it should be.

I will try on a different machine,
comments are wellcome
/Torsten

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Problems with Windows, Was: What's cooking in git.git (May 2013, #01; Fri, 3)
  2013-05-07 14:27 ` Problems with Windows, Was: " Torsten Bögershausen
@ 2013-05-08  0:30   ` Mark Levedahl
  2013-05-08 15:01     ` Torsten Bögershausen
  2013-05-09 17:18   ` Ramsay Jones
  1 sibling, 1 reply; 8+ messages in thread
From: Mark Levedahl @ 2013-05-08  0:30 UTC (permalink / raw)
  To: git; +Cc: Junio C Hamano, git

On 05/07/2013 10:27 AM, Torsten Bögershausen wrote:
> On 2013-05-04 01.14, Junio C Hamano wrote:
>>
>>   Cygwin portability; both were reviewed by Jonathan, and the tip one
>>   seems to want a bit further explanation.  Needs positive report
>>   from Cygwin 1.7 users who have been on 1.7 to make sure it does not
>>   regress for them.
>
> I was trying to verify that cygwin 1.7 is still Ok, but got puzzled.
>
> Running the test suite under cygwin doesn't seem to work any more (?):
>
> Scenario 1:
> The PC is running alone, and goes into the screen saver.
> Pressing CTRL-ALT-DEL didn't get any effect.
>
> Scenario 2:
> The PC didn't react any more, when the test suite was run in background.
> In 3 or 4 cases the PC needed to be reboot hardly.
>
> Using the commits before and after this change makes the test suite hang
> as well at some point, then it hangs somewhere at TC 3000--4000.
>
> Scenario 4:
> The I disabled the screensaver, upgdated cygwin,
>   and went back to an older commit:
> The latest run from commit 52d63e70, April 28,
> hangs in TC 5500, ok 26 clone shallow object count.
>
> I can see 2 times
> git.exe pull --depth 4 ..A
>
> Scenario 5:
> The run of today 1.8.3-rc1, hangs in t5510,
> some git.exe are running fetch. (or pull)
>
>
> It seems as if some process/exes are not terminated
> in the way it should be.
>
> I will try on a different machine,
> comments are wellcome
> /Torsten
>

I have run into very similar problems trying to test these patches, so I 
declined to reply thinking someone else might have better or at least 
explicable results. I am able to build git on cygwin 1.7 using the 
proposed patches, it seems to work, but I've run into strange problems 
such as the main git repo becoming corrupted, no idea how or why.

Mark

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Problems with Windows, Was: What's cooking in git.git (May 2013, #01; Fri, 3)
  2013-05-08  0:30   ` Mark Levedahl
@ 2013-05-08 15:01     ` Torsten Bögershausen
  0 siblings, 0 replies; 8+ messages in thread
From: Torsten Bögershausen @ 2013-05-08 15:01 UTC (permalink / raw)
  To: Mark Levedahl
  Cc: Torsten Bögershausen, Junio C Hamano, git, Ramsay Jones

On 2013-05-08 02.30, Mark Levedahl wrote:
> On 05/07/2013 10:27 AM, Torsten Bögershausen wrote:
>> On 2013-05-04 01.14, Junio C Hamano wrote:
>>>
>>>   Cygwin portability; both were reviewed by Jonathan, and the tip one
>>>   seems to want a bit further explanation.  Needs positive report
>>>   from Cygwin 1.7 users who have been on 1.7 to make sure it does not
>>>   regress for them.
>>
>> I was trying to verify that cygwin 1.7 is still Ok, but got puzzled.
>>
>> Running the test suite under cygwin doesn't seem to work any more (?):
>>
>> Scenario 1:
>> The PC is running alone, and goes into the screen saver.
>> Pressing CTRL-ALT-DEL didn't get any effect.
>>
>> Scenario 2:
>> The PC didn't react any more, when the test suite was run in background.
>> In 3 or 4 cases the PC needed to be reboot hardly.
>>
>> Using the commits before and after this change makes the test suite hang
>> as well at some point, then it hangs somewhere at TC 3000--4000.
>>
>> Scenario 4:
>> The I disabled the screensaver, upgdated cygwin,
>>   and went back to an older commit:
>> The latest run from commit 52d63e70, April 28,
>> hangs in TC 5500, ok 26 clone shallow object count.
>>
>> I can see 2 times
>> git.exe pull --depth 4 ..A
>>
>> Scenario 5:
>> The run of today 1.8.3-rc1, hangs in t5510,
>> some git.exe are running fetch. (or pull)
>>
>>
>> It seems as if some process/exes are not terminated
>> in the way it should be.
>>
>> I will try on a different machine,
>> comments are wellcome
>> /Torsten
>>
> 
> I have run into very similar problems trying to test these patches, so I declined to reply thinking someone else might have better or at least explicable results. I am able to build git on cygwin 1.7 using the proposed patches, it seems to work, but I've run into strange problems such as the main git repo becoming corrupted, no idea how or why.
> 
> Mark

I tried 1.8.3-rc1 on a different PC, and it seems to have the same hanging.
So I will do some bisecting on master, and try to find out more.


 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Problems with Windows, Was: What's cooking in git.git (May 2013, #01; Fri, 3)
  2013-05-07 14:27 ` Problems with Windows, Was: " Torsten Bögershausen
  2013-05-08  0:30   ` Mark Levedahl
@ 2013-05-09 17:18   ` Ramsay Jones
  2013-05-14 19:37     ` Torsten Bögershausen
  1 sibling, 1 reply; 8+ messages in thread
From: Ramsay Jones @ 2013-05-09 17:18 UTC (permalink / raw)
  To: Torsten Bögershausen; +Cc: Junio C Hamano, git, mlevedahl, Jonathan Nieder

Torsten Bögershausen wrote:
> On 2013-05-04 01.14, Junio C Hamano wrote:
>>
>>  Cygwin portability; both were reviewed by Jonathan, and the tip one
>>  seems to want a bit further explanation.  Needs positive report
>>  from Cygwin 1.7 users who have been on 1.7 to make sure it does not
>>  regress for them.
> 
> I was trying to verify that cygwin 1.7 is still Ok, but got puzzled.
> 
> Running the test suite under cygwin doesn't seem to work any more (?):
> 
> Scenario 1:
> The PC is running alone, and goes into the screen saver.
> Pressing CTRL-ALT-DEL didn't get any effect.
> 
> Scenario 2:
> The PC didn't react any more, when the test suite was run in background.
> In 3 or 4 cases the PC needed to be reboot hardly.
> 
> Using the commits before and after this change makes the test suite hang 
> as well at some point, then it hangs somewhere at TC 3000--4000.
> 
> Scenario 4:
> The I disabled the screensaver, upgdated cygwin,
>  and went back to an older commit:
> The latest run from commit 52d63e70, April 28,
> hangs in TC 5500, ok 26 clone shallow object count.
> 
> I can see 2 times 
> git.exe pull --depth 4 ..A 
> 
> Scenario 5:
> The run of today 1.8.3-rc1, hangs in t5510,
> some git.exe are running fetch. (or pull)
> 
> 
> It seems as if some process/exes are not terminated
> in the way it should be.
> 
> I will try on a different machine,
> comments are wellcome

Hmm, I'm a little puzzled, but not shocked. ;-)

Somebody, I forget who, had already tested Jonathan's patch
on cygwin 1.7 successfully and my follow up patch should be
a no-op on cygwin 1.7; so I'm puzzled! (The high risk should
have been on cygwin 1.5).

I'm not shocked because running the test-suite on cygwin has
been a bit of a magical mystery tour for quite some time.

In about 2007, I could not run the test-suite for about six
to nine months; it would randomly wedge my laptop solid - I had
to pull the power-cord out in order to re-boot. (I suspect that
commit 9cb18f56fde may have cured that particular problem, but
don't quote me on that - I didn't investigate at the time.)

I have noticed that running the tests with 'prove' is more likely
to prove successful, so my config.mak looks like:

    $ cat config.mak
    NO_SVN_TESTS=1
    GIT_TEST_OPTS=--no-color
    NO_GETTEXT=1
    DEFAULT_TEST_TARGET=prove
    GIT_PROVE_OPTS='--timer'
    $

I currently run the tests like so:

    $ time $(GIT_SKIP_TESTS='t0061.3 t0070.3 t4130 t9010 t9300' make test \
    >test-outp13 2>&1)

    real    172m25.311s
    user    132m15.133s
    sys     66m43.122s
    $

The t0061.3 and t0070.3 failures don't require much discussion. The t4130
failure is an intermittent "racy git" issue that has been on my TODO list
for several years. t9300 also fails intermittently. However, t9010 fails
every time for me, hanging the test suite (although ^C interrupts it just
fine).

I have a "fix" for t9010 that looks like:

    diff --git a/t/t9010-svn-fe.sh b/t/t9010-svn-fe.sh
    index b7eed24..4d01e3b 100755
    --- a/t/t9010-svn-fe.sh
    +++ b/t/t9010-svn-fe.sh
    @@ -22,10 +22,9 @@ try_dump () {
            maybe_fail_fi=${3:+test_$3} &&
    
            {
    -               $maybe_fail_svnfe test-svn-fe "$input" >stream 3<backflow &
    -       } &&
    -       $maybe_fail_fi git fast-import --cat-blob-fd=3 <stream 3>backflow &&
    -       wait $!
    +               $maybe_fail_svnfe test-svn-fe "$input" 3<backflow
    +       } |
    +       $maybe_fail_fi git fast-import --cat-blob-fd=3 3>backflow
     }
    
     properties () {

but I have not tested this patch enough to be happy to submit it (I have
some suspicions that it would still fail intermittently, just like t9300).

Also, commit 7bc0911d ("test-lib: Fix say_color () not to interpret \a\b\c
in the message", 11-10-2012) caused several random test failures. (don't ask
me why). So, before each test run, I have to apply the following:

    diff --git a/t/test-lib.sh b/t/test-lib.sh
    index f50f834..ed32b7f 100644
    --- a/t/test-lib.sh
    +++ b/t/test-lib.sh
    @@ -230,7 +230,7 @@ else
            say_color() {
                    test -z "$1" && test -n "$quiet" && return
                    shift
    -               printf "%s\n" "$*"
    +               echo -E "$*"
            }
     fi

which effectively reverts that commit.

So, as I said, a "magical mystery tour". :-D

ATB,
Ramsay Jones

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Problems with Windows, Was: What's cooking in git.git (May 2013, #01; Fri, 3)
  2013-05-09 17:18   ` Ramsay Jones
@ 2013-05-14 19:37     ` Torsten Bögershausen
  2013-05-14 22:41       ` Philip Oakley
  2013-05-15  6:19       ` Tay Ray Chuan
  0 siblings, 2 replies; 8+ messages in thread
From: Torsten Bögershausen @ 2013-05-14 19:37 UTC (permalink / raw)
  To: Ramsay Jones
  Cc: Torsten Bögershausen, Junio C Hamano, git, mlevedahl,
	Jonathan Nieder, j6t, msysGit

On 2013-05-09 19.18, Ramsay Jones wrote:
> Torsten Bögershausen wrote:
>> On 2013-05-04 01.14, Junio C Hamano wrote:
>>>
>>>  Cygwin portability; both were reviewed by Jonathan, and the tip one
>>>  seems to want a bit further explanation.  Needs positive report
>>>  from Cygwin 1.7 users who have been on 1.7 to make sure it does not
>>>  regress for them.
>>
>> I was trying to verify that cygwin 1.7 is still Ok, but got puzzled.
>>
>> Running the test suite under cygwin doesn't seem to work any more (?):
>>
>> Scenario 1:
>> The PC is running alone, and goes into the screen saver.
>> Pressing CTRL-ALT-DEL didn't get any effect.
>>
>> Scenario 2:
>> The PC didn't react any more, when the test suite was run in background.
>> In 3 or 4 cases the PC needed to be reboot hardly.
>>
>> Using the commits before and after this change makes the test suite hang 
>> as well at some point, then it hangs somewhere at TC 3000--4000.
>>
>> Scenario 4:
>> The I disabled the screensaver, upgdated cygwin,
>>  and went back to an older commit:
>> The latest run from commit 52d63e70, April 28,
>> hangs in TC 5500, ok 26 clone shallow object count.
>>
>> I can see 2 times 
>> git.exe pull --depth 4 ..A 
>>
>> Scenario 5:
>> The run of today 1.8.3-rc1, hangs in t5510,
>> some git.exe are running fetch. (or pull)
>>
>>
>> It seems as if some process/exes are not terminated
>> in the way it should be.
>>
>> I will try on a different machine,
>> comments are wellcome
> 
> Hmm, I'm a little puzzled, but not shocked. ;-)
> 
> Somebody, I forget who, had already tested Jonathan's patch
> on cygwin 1.7 successfully and my follow up patch should be
> a no-op on cygwin 1.7; so I'm puzzled! (The high risk should
> have been on cygwin 1.5).
> 
> I'm not shocked because running the test-suite on cygwin has
> been a bit of a magical mystery tour for quite some time.
> 
> In about 2007, I could not run the test-suite for about six
> to nine months; it would randomly wedge my laptop solid - I had
> to pull the power-cord out in order to re-boot. (I suspect that
> commit 9cb18f56fde may have cured that particular problem, but
> don't quote me on that - I didn't investigate at the time.)
> 
> I have noticed that running the tests with 'prove' is more likely
> to prove successful, so my config.mak looks like:
> 
>     $ cat config.mak
>     NO_SVN_TESTS=1
>     GIT_TEST_OPTS=--no-color
>     NO_GETTEXT=1
>     DEFAULT_TEST_TARGET=prove
>     GIT_PROVE_OPTS='--timer'
>     $
> 
> I currently run the tests like so:
> 
>     $ time $(GIT_SKIP_TESTS='t0061.3 t0070.3 t4130 t9010 t9300' make test \
>     >test-outp13 2>&1)
> 
>     real    172m25.311s
>     user    132m15.133s
>     sys     66m43.122s
>     $
> 
> The t0061.3 and t0070.3 failures don't require much discussion. The t4130
> failure is an intermittent "racy git" issue that has been on my TODO list
> for several years. t9300 also fails intermittently. However, t9010 fails
> every time for me, hanging the test suite (although ^C interrupts it just
> fine).
> 
> I have a "fix" for t9010 that looks like:
> 
>     diff --git a/t/t9010-svn-fe.sh b/t/t9010-svn-fe.sh
>     index b7eed24..4d01e3b 100755
>     --- a/t/t9010-svn-fe.sh
>     +++ b/t/t9010-svn-fe.sh
>     @@ -22,10 +22,9 @@ try_dump () {
>             maybe_fail_fi=${3:+test_$3} &&
>     
>             {
>     -               $maybe_fail_svnfe test-svn-fe "$input" >stream 3<backflow &
>     -       } &&
>     -       $maybe_fail_fi git fast-import --cat-blob-fd=3 <stream 3>backflow &&
>     -       wait $!
>     +               $maybe_fail_svnfe test-svn-fe "$input" 3<backflow
>     +       } |
>     +       $maybe_fail_fi git fast-import --cat-blob-fd=3 3>backflow
>      }
>     
>      properties () {
> 
> but I have not tested this patch enough to be happy to submit it (I have
> some suspicions that it would still fail intermittently, just like t9300).
> 
> Also, commit 7bc0911d ("test-lib: Fix say_color () not to interpret \a\b\c
> in the message", 11-10-2012) caused several random test failures. (don't ask
> me why). So, before each test run, I have to apply the following:
> 
>     diff --git a/t/test-lib.sh b/t/test-lib.sh
>     index f50f834..ed32b7f 100644
>     --- a/t/test-lib.sh
>     +++ b/t/test-lib.sh
>     @@ -230,7 +230,7 @@ else
>             say_color() {
>                     test -z "$1" && test -n "$quiet" && return
>                     shift
>     -               printf "%s\n" "$*"
>     +               echo -E "$*"
>             }
>      fi
> 
> which effectively reverts that commit.
> 
> So, as I said, a "magical mystery tour". :-D
> 
> ATB,
> Ramsay Jones
> 
> 
First of all,
the patch we are talking about does not any regrssions at my side.

Second,
I was able to do some testing.
The hanging is not 100% reproducable, and I had one hanging in Git 1.8.1

Turning the screen saver off in Win XP helps that the machine reacts,
and using process explorer showed that the hanging is happening
in test cases doing "git fetch" (or git pull) from a local repository.
What I can see is one git-fetch.exe together with git-upload-pack.exe

From my understanding is the upload-pack a "forked" exe from the main git,
and they should talk to each other.
One interesting part is in run-command.c, and there we have different code for MiNGW
and the "rest of the world", Linux/Unix/cygwin.

I tried to steal the code around mingw_spawnvpe(), but could not get that working (yet).

Another approach could be to steal the pipe() from mingw.

Does anybody know if we have a similar problem (hanging TC which test fetch/pull)
in MinGW/msysGit?

If no, why not ;-)

Thanks for reading
/Torsten

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Re: Problems with Windows, Was: What's cooking in git.git (May 2013, #01; Fri, 3)
  2013-05-14 19:37     ` Torsten Bögershausen
@ 2013-05-14 22:41       ` Philip Oakley
  2013-05-15  6:19       ` Tay Ray Chuan
  1 sibling, 0 replies; 8+ messages in thread
From: Philip Oakley @ 2013-05-14 22:41 UTC (permalink / raw)
  To: Torsten Bögershausen, Ramsay Jones
  Cc: Torsten Bögershausen, Junio C Hamano, Git List, mlevedahl,
	Jonathan Nieder, j6t, msysGit

sorry about the MUA mangling - reply at end.
----- Original Message ----- 
From: "Torsten Bögershausen" <tboegi@web.de>
To: "Ramsay Jones" <ramsay@ramsay1.demon.co.uk>
Cc: "Torsten Bögershausen" <tboegi@web.de>; "Junio C Hamano"
<gitster@pobox.com>; <git@vger.kernel.org>; <mlevedahl@gmail.com>;
"Jonathan Nieder" <jrnieder@gmail.com>; <j6t@kdbg.org>; "msysGit"
<msysgit@googlegroups.com>
Sent: Tuesday, May 14, 2013 8:37 PM
Subject: [msysGit] Re: Problems with Windows, Was: What's cooking in
git.git (May 2013, #01; Fri, 3)


On 2013-05-09 19.18, Ramsay Jones wrote:
> Torsten Bögershausen wrote:
>> On 2013-05-04 01.14, Junio C Hamano wrote:
>>>
>>>  Cygwin portability; both were reviewed by Jonathan, and the tip one
>>>  seems to want a bit further explanation.  Needs positive report
>>>  from Cygwin 1.7 users who have been on 1.7 to make sure it does not
>>>  regress for them.
>>
>> I was trying to verify that cygwin 1.7 is still Ok, but got puzzled.
>>
>> Running the test suite under cygwin doesn't seem to work any more
>> (?):
>>
>> Scenario 1:
>> The PC is running alone, and goes into the screen saver.
>> Pressing CTRL-ALT-DEL didn't get any effect.
>>
>> Scenario 2:
>> The PC didn't react any more, when the test suite was run in
>> background.
>> In 3 or 4 cases the PC needed to be reboot hardly.
>>
>> Using the commits before and after this change makes the test suite
>> hang
>> as well at some point, then it hangs somewhere at TC 3000--4000.
>>
>> Scenario 4:
>> The I disabled the screensaver, upgdated cygwin,
>>  and went back to an older commit:
>> The latest run from commit 52d63e70, April 28,
>> hangs in TC 5500, ok 26 clone shallow object count.
>>
>> I can see 2 times
>> git.exe pull --depth 4 ..A
>>
>> Scenario 5:
>> The run of today 1.8.3-rc1, hangs in t5510,
>> some git.exe are running fetch. (or pull)
>>
>>
>> It seems as if some process/exes are not terminated
>> in the way it should be.
>>
>> I will try on a different machine,
>> comments are wellcome
>
> Hmm, I'm a little puzzled, but not shocked. ;-)
>
> Somebody, I forget who, had already tested Jonathan's patch
> on cygwin 1.7 successfully and my follow up patch should be
> a no-op on cygwin 1.7; so I'm puzzled! (The high risk should
> have been on cygwin 1.5).
>
> I'm not shocked because running the test-suite on cygwin has
> been a bit of a magical mystery tour for quite some time.
>
> In about 2007, I could not run the test-suite for about six
> to nine months; it would randomly wedge my laptop solid - I had
> to pull the power-cord out in order to re-boot. (I suspect that
> commit 9cb18f56fde may have cured that particular problem, but
> don't quote me on that - I didn't investigate at the time.)
>
> I have noticed that running the tests with 'prove' is more likely
> to prove successful, so my config.mak looks like:
>
>     $ cat config.mak
>     NO_SVN_TESTS=1
>     GIT_TEST_OPTS=--no-color
>     NO_GETTEXT=1
>     DEFAULT_TEST_TARGET=prove
>     GIT_PROVE_OPTS='--timer'
>     $
>
> I currently run the tests like so:
>
>     $ time $(GIT_SKIP_TESTS='t0061.3 t0070.3 t4130 t9010 t9300' make
> test \
>     >test-outp13 2>&1)
>
>     real    172m25.311s
>     user    132m15.133s
>     sys     66m43.122s
>     $
>
> The t0061.3 and t0070.3 failures don't require much discussion. The
> t4130
> failure is an intermittent "racy git" issue that has been on my TODO
> list
> for several years. t9300 also fails intermittently. However, t9010
> fails
> every time for me, hanging the test suite (although ^C interrupts it
> just
> fine).
>
> I have a "fix" for t9010 that looks like:
>
>     diff --git a/t/t9010-svn-fe.sh b/t/t9010-svn-fe.sh
>     index b7eed24..4d01e3b 100755
>     --- a/t/t9010-svn-fe.sh
>     +++ b/t/t9010-svn-fe.sh
>     @@ -22,10 +22,9 @@ try_dump () {
>             maybe_fail_fi=${3:+test_$3} &&
>
>             {
>     -               $maybe_fail_svnfe test-svn-fe "$input" >stream
> 3<backflow &
>     -       } &&
>     -       $maybe_fail_fi git fast-import --cat-blob-fd=3 <stream
> 3>backflow &&
>     -       wait $!
>     +               $maybe_fail_svnfe test-svn-fe "$input" 3<backflow
>     +       } |
>     +       $maybe_fail_fi git fast-import --cat-blob-fd=3 3>backflow
>      }
>
>      properties () {
>
> but I have not tested this patch enough to be happy to submit it (I
> have
> some suspicions that it would still fail intermittently, just like
> t9300).
>
> Also, commit 7bc0911d ("test-lib: Fix say_color () not to interpret
> \a\b\c
> in the message", 11-10-2012) caused several random test failures.
> (don't ask
> me why). So, before each test run, I have to apply the following:
>
>     diff --git a/t/test-lib.sh b/t/test-lib.sh
>     index f50f834..ed32b7f 100644
>     --- a/t/test-lib.sh
>     +++ b/t/test-lib.sh
>     @@ -230,7 +230,7 @@ else
>             say_color() {
>                     test -z "$1" && test -n "$quiet" && return
>                     shift
>     -               printf "%s\n" "$*"
>     +               echo -E "$*"
>             }
>      fi
>
> which effectively reverts that commit.
>
> So, as I said, a "magical mystery tour". :-D
>
> ATB,
> Ramsay Jones
>
>
First of all,
the patch we are talking about does not any regrssions at my side.

Second,
I was able to do some testing.
The hanging is not 100% reproducable, and I had one hanging in Git 1.8.1

Turning the screen saver off in Win XP helps that the machine reacts,
and using process explorer showed that the hanging is happening
in test cases doing "git fetch" (or git pull) from a local repository.
What I can see is one git-fetch.exe together with git-upload-pack.exe

>From my understanding is the upload-pack a "forked" exe from the main
git,
and they should talk to each other.
One interesting part is in run-command.c, and there we have different
code for MiNGW
and the "rest of the world", Linux/Unix/cygwin.

I tried to steal the code around mingw_spawnvpe(), but could not get
that working (yet).

Another approach could be to steal the pipe() from mingw.

Does anybody know if we have a similar problem (hanging TC which test
fetch/pull)
in MinGW/msysGit?

If no, why not ;-)

Thanks for reading
/Torsten

---
Torsten,

There have been on-going sporadic problems with the push / fetch over
various protocols which haven't been tracked down to an exact point that
affords a proper fix. The reports appear to cover both ssh and git 
protocols. In some cases it could be the users ssh client.

The skill sets and developer approaches to problem resolution in
Windowsland and *nixland do appear to be somewhat different ;-)

I posted a reply to an earlier report on
https://groups.google.com/group/msysgit/msg/fdabaa0e4f8a55a7?hl=en
From: "Philip Oakley" <philipoak...@iee.org>
Date: Fri, 8 Feb 2013 19:31:33 -0000
Local: Fri, Feb 8 2013 8:31 pm
Subject: Re: [msysGit] Unable to clone/fetch

[...]

This is my list of web pages on the issue that may be of help. Issue 457
has a good discussion. It looks to me as if this is a case of 'premature
optimisation' in Linux land (or the the opposite by microsoft) in the
way that the side band channels are set-up and info is exchanged. But I
haven't go any further than reading through the various reports,
thinking, and surmising (no practical work ;-).


If you are able to find a method to unwind the situation that causes the
deadlock it would be great for every one.
regards
Philip


Google :: "msysgit hangs when ssh fetch"
========================================
http://billauer.co.il/blog/2012/10/git-pull-windows-freeze-receive-pack/
 Change "side-band-64k" to "side-bond-64k" so it never gets used.


http://devnet.jetbrains.net/message/5473415?tstart=0
 remnants of several previous installations of Git. Sort the path
entries..


http://code.google.com/p/msysgit/issues/detail?id=74
 Issue 74: git remote update/git fetch fails via ssh


http://code.google.com/p/msysgit/issues/detail?id=161
 Issue 161: git-gui hangs on ssh for users with home directory mapped to
server share


http://code.google.com/p/msysgit/issues/detail?id=243
https://groups.google.com/forum/?fromgroups=#!topic/msysgit/mFnzYM3IA_4
 Re: Issue 243 in msysgit: ssh hangs a minute than goes to next line
without performing action


http://code.google.com/p/msysgit/issues/detail?id=361
 Issue 361: Clone/fetch/pull from github using git protocol hangs, http
works


http://code.google.com/p/msysgit/issues/detail?id=457
*** a good discussion.
 Issue 457: Push over git protocol hangs in msysGit
 The problematic commit is 0c499ea60f, which introduced the sideband
support in send_pack.



-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Problems with Windows, Was: What's cooking in git.git (May 2013, #01; Fri, 3)
  2013-05-14 19:37     ` Torsten Bögershausen
  2013-05-14 22:41       ` Philip Oakley
@ 2013-05-15  6:19       ` Tay Ray Chuan
  1 sibling, 0 replies; 8+ messages in thread
From: Tay Ray Chuan @ 2013-05-15  6:19 UTC (permalink / raw)
  To: Torsten Bögershausen
  Cc: Ramsay Jones, Junio C Hamano, Git Mailing List, mlevedahl,
	Jonathan Nieder, Johannes Sixt, msysGit

On Wed, May 15, 2013 at 3:37 AM, Torsten Bögershausen <tboegi@web.de> wrote:
> Second,
> I was able to do some testing.
> The hanging is not 100% reproducable, and I had one hanging in Git 1.8.1
>
> Turning the screen saver off in Win XP helps that the machine reacts,
> and using process explorer showed that the hanging is happening
> in test cases doing "git fetch" (or git pull) from a local repository.
> What I can see is one git-fetch.exe together with git-upload-pack.exe

I also managed to run into the intermittent hanging of git-fetch when
running t5510. What I do is keep running the test till it stalls:

  while [ $? -eq 0 ]; do date; ./t5510-fetch.sh -i -v; done

Almost always the git-fetch output looks like this:

  remote: Counting objects: 7, done.
  remote: Compressing objects: 100% (5/5), done.
  remote: Total 6 (delta 1), reused 0 (delta 0)

However my task manager indicates that git-upload-pack or whatever
that runs on the remote side is absent, only git-fetch is waiting - 0
I/O, 0 cswitches, nilda. I tried getting a gdb backtrace but I get ???
nonsense, despite having compiled git with `-g -O0`. I also noticed
there were a couple of threads. This is my gdb session:

$ gdb --pid=7936
GNU gdb (GDB) 7.6.50.20130508-cvs (cygwin-special)
...
Attaching to process 7936
[New Thread 7936.0x1c7c]
[New Thread 7936.0x6b8]
[New Thread 7936.0xd20]
[New Thread 7936.0x1cf8]
[New Thread 7936.0x1b24]
Reading symbols from /cygdrive/f/files/coding/git/git.exe...done.
(gdb) info thread
  Id   Target Id         Frame
* 5    Thread 7936.0x1b24 0x77c5000d in ntdll!DbgBreakPoint ()
   from /cygdrive/c/Windows/SysWOW64/ntdll.dll
  4    Thread 7936.0x1cf8 0x77c5f8b1 in ntdll!ZwWaitForSingleObject ()
   from /cygdrive/c/Windows/SysWOW64/ntdll.dll
  3    Thread 7936.0xd20 0x77c5f91d in ntdll!ZwWriteFile ()
   from /cygdrive/c/Windows/SysWOW64/ntdll.dll
  2    Thread 7936.0x6b8 0x77c5f8b1 in ntdll!ZwWaitForSingleObject ()
   from /cygdrive/c/Windows/SysWOW64/ntdll.dll
  1    Thread 7936.0x1c7c 0x77c5f8b1 in ntdll!ZwWaitForSingleObject ()
   from /cygdrive/c/Windows/SysWOW64/ntdll.dll
(gdb) bt
#0  0x77c5000d in ntdll!DbgBreakPoint () from
/cygdrive/c/Windows/SysWOW64/ntdll.dll
#1  0x77cdf896 in ntdll!DbgUiRemoteBreakin () from
/cygdrive/c/Windows/SysWOW64/ntdll.dll
#2  0x775c5cca in ?? ()
#3  0x00000000 in ?? ()
(gdb) thread 4
[Switching to thread 4 (Thread 7936.0x1cf8)]
#0  0x77c5f8b1 in ntdll!ZwWaitForSingleObject () from
/cygdrive/c/Windows/SysWOW64/ntdll.dll
(gdb) bt
#0  0x77c5f8b1 in ntdll!ZwWaitForSingleObject () from
/cygdrive/c/Windows/SysWOW64/ntdll.dll
#1  0x77c5f8b1 in ntdll!ZwWaitForSingleObject () from
/cygdrive/c/Windows/SysWOW64/ntdll.dll
#2  0x7573149d in WaitForSingleObjectEx () from
/cygdrive/c/Windows/syswow64/KERNELBASE.dll
#3  0x00000148 in ?? ()
#4  0x00000000 in ?? ()
(gdb) thread 3
[Switching to thread 3 (Thread 7936.0xd20)]
#0  0x77c5f91d in ntdll!ZwWriteFile () from
/cygdrive/c/Windows/SysWOW64/ntdll.dll
(gdb) bt
#0  0x77c5f91d in ntdll!ZwWriteFile () from
/cygdrive/c/Windows/SysWOW64/ntdll.dll
#1  0x77c5f91d in ntdll!ZwWriteFile () from
/cygdrive/c/Windows/SysWOW64/ntdll.dll
#2  0x7572dec1 in WriteFile () from /cygdrive/c/Windows/syswow64/KERNELBASE.dll
#3  0x0000009c in ?? ()
#4  0x00000000 in ?? ()
(gdb) thread 2
[Switching to thread 2 (Thread 7936.0x6b8)]
#0  0x77c5f8b1 in ntdll!ZwWaitForSingleObject () from
/cygdrive/c/Windows/SysWOW64/ntdll.dll
(gdb) bt
#0  0x77c5f8b1 in ntdll!ZwWaitForSingleObject () from
/cygdrive/c/Windows/SysWOW64/ntdll.dll
#1  0x77c5f8b1 in ntdll!ZwWaitForSingleObject () from
/cygdrive/c/Windows/SysWOW64/ntdll.dll
#2  0x7573149d in WaitForSingleObjectEx () from
/cygdrive/c/Windows/syswow64/KERNELBASE.dll
#3  0x0000001c in ?? ()
#4  0x00000000 in ?? ()
(gdb) thread 1
[Switching to thread 1 (Thread 7936.0x1c7c)]
#0  0x77c5f8b1 in ntdll!ZwWaitForSingleObject () from
/cygdrive/c/Windows/SysWOW64/ntdll.dll
(gdb) bt
#0  0x77c5f8b1 in ntdll!ZwWaitForSingleObject () from
/cygdrive/c/Windows/SysWOW64/ntdll.dll
#1  0x77c5f8b1 in ntdll!ZwWaitForSingleObject () from
/cygdrive/c/Windows/SysWOW64/ntdll.dll
#2  0x7573149d in WaitForSingleObjectEx () from
/cygdrive/c/Windows/syswow64/KERNELBASE.dll
#3  0x00000034 in ?? ()
#4  0x00000000 in ?? ()

--
Cheers,
Ray Chuan

-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2013-05-15  6:19 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-03 23:14 What's cooking in git.git (May 2013, #01; Fri, 3) Junio C Hamano
2013-05-07 14:27 ` Problems with Windows, Was: " Torsten Bögershausen
2013-05-08  0:30   ` Mark Levedahl
2013-05-08 15:01     ` Torsten Bögershausen
2013-05-09 17:18   ` Ramsay Jones
2013-05-14 19:37     ` Torsten Bögershausen
2013-05-14 22:41       ` Philip Oakley
2013-05-15  6:19       ` Tay Ray Chuan

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.