All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH V2] osdep.h: include sys/types.h for ssize_t definition
@ 2013-05-10 19:58 Igor Mitsyanko
  2013-05-12  9:24 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
  2013-05-12  9:29 ` [Qemu-devel] [PATCH for-1.5 " Stefan Weil
  0 siblings, 2 replies; 3+ messages in thread
From: Igor Mitsyanko @ 2013-05-10 19:58 UTC (permalink / raw)
  To: qemu-devel
  Cc: qemu-trivial, pbonzini, aliguori, Igor Mitsyanko, peter.maydell

sys/types.h is taken out from "ifdef __OpenBSD__" guard. It should be
safe for other systems, according to following survey:
http://hacks.owlfolio.org/header-survey/

This fixes build for CONFIG_IOVEC-less systems (mingw).

Signed-off-by: Igor Mitsyanko <i.mitsyanko@gmail.com>
---
 include/qemu/osdep.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h
index 42545bc..3bcd4ab 100644
--- a/include/qemu/osdep.h
+++ b/include/qemu/osdep.h
@@ -5,8 +5,8 @@
 #include <stdarg.h>
 #include <stddef.h>
 #include <stdbool.h>
-#ifdef __OpenBSD__
 #include <sys/types.h>
+#ifdef __OpenBSD__
 #include <sys/signal.h>
 #endif
 
-- 
1.8.1.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Qemu-devel] [Qemu-trivial] [PATCH V2] osdep.h: include sys/types.h for ssize_t definition
  2013-05-10 19:58 [Qemu-devel] [PATCH V2] osdep.h: include sys/types.h for ssize_t definition Igor Mitsyanko
@ 2013-05-12  9:24 ` Michael Tokarev
  2013-05-12  9:29 ` [Qemu-devel] [PATCH for-1.5 " Stefan Weil
  1 sibling, 0 replies; 3+ messages in thread
From: Michael Tokarev @ 2013-05-12  9:24 UTC (permalink / raw)
  To: Igor Mitsyanko
  Cc: qemu-trivial, pbonzini, aliguori, qemu-devel, peter.maydell

10.05.2013 23:58, Igor Mitsyanko wrote:
> sys/types.h is taken out from "ifdef __OpenBSD__" guard. It should be
> safe for other systems, according to following survey:
> http://hacks.owlfolio.org/header-survey/
> 
> This fixes build for CONFIG_IOVEC-less systems (mingw).

Thanks, applied to the trivial patches queue.

/mjt

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Qemu-devel] [PATCH for-1.5 V2] osdep.h: include sys/types.h for ssize_t definition
  2013-05-10 19:58 [Qemu-devel] [PATCH V2] osdep.h: include sys/types.h for ssize_t definition Igor Mitsyanko
  2013-05-12  9:24 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
@ 2013-05-12  9:29 ` Stefan Weil
  1 sibling, 0 replies; 3+ messages in thread
From: Stefan Weil @ 2013-05-12  9:29 UTC (permalink / raw)
  To: aliguori
  Cc: Igor Mitsyanko, qemu-trivial, peter.maydell, qemu-devel, pbonzini

Am 10.05.2013 21:58, schrieb Igor Mitsyanko:
> sys/types.h is taken out from "ifdef __OpenBSD__" guard. It should be
> safe for other systems, according to following survey:
> http://hacks.owlfolio.org/header-survey/
>
> This fixes build for CONFIG_IOVEC-less systems (mingw).
>
> Signed-off-by: Igor Mitsyanko <i.mitsyanko@gmail.com>
> ---
>  include/qemu/osdep.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h
> index 42545bc..3bcd4ab 100644
> --- a/include/qemu/osdep.h
> +++ b/include/qemu/osdep.h
> @@ -5,8 +5,8 @@
>  #include <stdarg.h>
>  #include <stddef.h>
>  #include <stdbool.h>
> -#ifdef __OpenBSD__
>  #include <sys/types.h>
> +#ifdef __OpenBSD__
>  #include <sys/signal.h>
>  #endif

Either this patch or http://patchwork.ozlabs.org/patch/243151/
is needed for QEMU 1.5 to fix compilation with MinGW.

Regards,
Stefan Weil

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-05-12  9:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-10 19:58 [Qemu-devel] [PATCH V2] osdep.h: include sys/types.h for ssize_t definition Igor Mitsyanko
2013-05-12  9:24 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2013-05-12  9:29 ` [Qemu-devel] [PATCH for-1.5 " Stefan Weil

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.