* [meta-networking][PATCH v2] vpnc: Runtime dependency to perl was missing
@ 2013-05-14 7:57 Jukka Rissanen
2013-05-14 8:07 ` Koen Kooi
2013-05-14 12:25 ` Joe MacDonald
0 siblings, 2 replies; 4+ messages in thread
From: Jukka Rissanen @ 2013-05-14 7:57 UTC (permalink / raw)
To: openembedded-devel
Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
---
This version now properly rdepends on perl-module-io-file instead of
just the perl package.
Cheers,
Jukka
meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb b/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb
index 2ce9530..a73cd13 100644
--- a/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb
+++ b/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb
@@ -6,7 +6,7 @@ PRIORITY = "optional"
LICENSE = "GPL-2.0+"
LIC_FILES_CHKSUM = "file://COPYING;md5=173b74cb8ac640a9992c03f3bce22a33"
DEPENDS = "libgcrypt"
-RDEPENDS_${PN} = "kernel-module-tun"
+RDEPENDS_${PN} = "kernel-module-tun perl-module-io-file"
CFLAGS_append = ' -DVERSION=\\"${PV}\\"'
LDFLAGS_append = " -lgcrypt -lgpg-error"
--
1.7.11.7
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [meta-networking][PATCH v2] vpnc: Runtime dependency to perl was missing
2013-05-14 7:57 [meta-networking][PATCH v2] vpnc: Runtime dependency to perl was missing Jukka Rissanen
@ 2013-05-14 8:07 ` Koen Kooi
2013-05-14 12:25 ` Joe MacDonald
1 sibling, 0 replies; 4+ messages in thread
From: Koen Kooi @ 2013-05-14 8:07 UTC (permalink / raw)
To: openembedded-devel
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Op 14-05-13 09:57, Jukka Rissanen schreef:
>
> Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com> --- This
> version now properly rdepends on perl-module-io-file instead of just the
> perl package.
>
> Cheers, Jukka
>
> meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb | 2 +- 1 file
> changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb
> b/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb index
> 2ce9530..a73cd13 100644 ---
> a/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb +++
> b/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb @@ -6,7 +6,7 @@
> PRIORITY = "optional" LICENSE = "GPL-2.0+" LIC_FILES_CHKSUM =
> "file://COPYING;md5=173b74cb8ac640a9992c03f3bce22a33" DEPENDS =
> "libgcrypt" -RDEPENDS_${PN} = "kernel-module-tun" +RDEPENDS_${PN} =
> "kernel-module-tun perl-module-io-file"
R* variables go below do_install, they are ordered in next to the tasks they
get used in, which is do_package for R*
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: GPGTools - http://gpgtools.org
iD8DBQFRkfDHMkyGM64RGpERAjt0AJ9hsPHsYnaDCmM20ja/kcCuonJNygCfUPvz
Hp448ff5MXm9XIlMZfkG/w0=
=sFZm
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [meta-networking][PATCH v2] vpnc: Runtime dependency to perl was missing
2013-05-14 7:57 [meta-networking][PATCH v2] vpnc: Runtime dependency to perl was missing Jukka Rissanen
2013-05-14 8:07 ` Koen Kooi
@ 2013-05-14 12:25 ` Joe MacDonald
2013-05-14 12:46 ` Jukka Rissanen
1 sibling, 1 reply; 4+ messages in thread
From: Joe MacDonald @ 2013-05-14 12:25 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 1499 bytes --]
[[oe] [meta-networking][PATCH v2] vpnc: Runtime dependency to perl was missing] On 13.05.14 (Tue 10:57) Jukka Rissanen wrote:
>
> Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
> ---
> This version now properly rdepends on perl-module-io-file instead of
> just the perl package.
>
> Cheers,
> Jukka
>
> meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb b/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb
> index 2ce9530..a73cd13 100644
> --- a/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb
> +++ b/meta-networking/recipes-connectivity/vpnc/vpnc_0.5.3.bb
> @@ -6,7 +6,7 @@ PRIORITY = "optional"
> LICENSE = "GPL-2.0+"
> LIC_FILES_CHKSUM = "file://COPYING;md5=173b74cb8ac640a9992c03f3bce22a33"
> DEPENDS = "libgcrypt"
> -RDEPENDS_${PN} = "kernel-module-tun"
> +RDEPENDS_${PN} = "kernel-module-tun perl-module-io-file"
>
> CFLAGS_append = ' -DVERSION=\\"${PV}\\"'
> LDFLAGS_append = " -lgcrypt -lgpg-error"
Given that I'd already merged your previous change (and Koen is
absolutely right, I should've pushed back on it too since I completely
agree with him) can you send out another version of this patch that
addresses his suggestion about reordering the R* variables and is
against the latest tree? This one won't apply as the tree stands now.
Thanks.
--
-Joe MacDonald.
:wq
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [meta-networking][PATCH v2] vpnc: Runtime dependency to perl was missing
2013-05-14 12:25 ` Joe MacDonald
@ 2013-05-14 12:46 ` Jukka Rissanen
0 siblings, 0 replies; 4+ messages in thread
From: Jukka Rissanen @ 2013-05-14 12:46 UTC (permalink / raw)
To: openembedded-devel; +Cc: Joe MacDonald
Hi Joe,
On 14.05.2013 15:25, Joe MacDonald wrote:
> [[oe] [meta-networking][PATCH v2] vpnc: Runtime dependency to perl was missing] On 13.05.14 (Tue 10:57) Jukka Rissanen wrote:
>
>>
> Given that I'd already merged your previous change (and Koen is
> absolutely right, I should've pushed back on it too since I completely
> agree with him) can you send out another version of this patch that
> addresses his suggestion about reordering the R* variables and is
> against the latest tree? This one won't apply as the tree stands now.
>
> Thanks.
Sure, a new patch is in its way.
Cheers,
Jukka
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-05-14 13:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-14 7:57 [meta-networking][PATCH v2] vpnc: Runtime dependency to perl was missing Jukka Rissanen
2013-05-14 8:07 ` Koen Kooi
2013-05-14 12:25 ` Joe MacDonald
2013-05-14 12:46 ` Jukka Rissanen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.