* [PATCH] mmc: make <mmc.h> self-contained
@ 2020-02-24 17:25 ` Masahiro Yamada
2020-02-25 22:09 ` Jaehoon Chung
2020-03-17 15:28 ` Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Masahiro Yamada @ 2020-02-24 17:25 UTC (permalink / raw)
To: u-boot
This header uses bd_t without including its definition.
Change it to (struct bd_info), and add the forward declaration
to specify it as a structure.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
include/mmc.h | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/include/mmc.h b/include/mmc.h
index 71e2e1735a..4bdeb929d7 100644
--- a/include/mmc.h
+++ b/include/mmc.h
@@ -15,6 +15,8 @@
#include <linux/dma-direction.h>
#include <part.h>
+struct bd_info;
+
#if CONFIG_IS_ENABLED(MMC_HS200_SUPPORT)
#define MMC_SUPPORTS_TUNING
#endif
@@ -712,7 +714,7 @@ void mmc_destroy(struct mmc *mmc);
* @return 0 if OK, -ve on error
*/
int mmc_unbind(struct udevice *dev);
-int mmc_initialize(bd_t *bis);
+int mmc_initialize(struct bd_info *bis);
int mmc_init_device(int num);
int mmc_init(struct mmc *mmc);
int mmc_send_tuning(struct mmc *mmc, u32 opcode, int *cmd_error);
@@ -857,8 +859,8 @@ void mmc_set_preinit(struct mmc *mmc, int preinit);
#endif
void board_mmc_power_init(void);
-int board_mmc_init(bd_t *bis);
-int cpu_mmc_init(bd_t *bis);
+int board_mmc_init(struct bd_info *bis);
+int cpu_mmc_init(struct bd_info *bis);
int mmc_get_env_addr(struct mmc *mmc, int copy, u32 *env_addr);
# ifdef CONFIG_SYS_MMC_ENV_PART
extern uint mmc_get_env_part(struct mmc *mmc);
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] mmc: make <mmc.h> self-contained
2020-02-24 17:25 ` [PATCH] mmc: make <mmc.h> self-contained Masahiro Yamada
@ 2020-02-25 22:09 ` Jaehoon Chung
2020-03-17 15:28 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Jaehoon Chung @ 2020-02-25 22:09 UTC (permalink / raw)
To: u-boot
On 2/25/20 2:25 AM, Masahiro Yamada wrote:
> This header uses bd_t without including its definition.
>
> Change it to (struct bd_info), and add the forward declaration
> to specify it as a structure.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>
Best Regards,
Jaehoon Chung
> ---
>
> include/mmc.h | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/include/mmc.h b/include/mmc.h
> index 71e2e1735a..4bdeb929d7 100644
> --- a/include/mmc.h
> +++ b/include/mmc.h
> @@ -15,6 +15,8 @@
> #include <linux/dma-direction.h>
> #include <part.h>
>
> +struct bd_info;
> +
> #if CONFIG_IS_ENABLED(MMC_HS200_SUPPORT)
> #define MMC_SUPPORTS_TUNING
> #endif
> @@ -712,7 +714,7 @@ void mmc_destroy(struct mmc *mmc);
> * @return 0 if OK, -ve on error
> */
> int mmc_unbind(struct udevice *dev);
> -int mmc_initialize(bd_t *bis);
> +int mmc_initialize(struct bd_info *bis);
> int mmc_init_device(int num);
> int mmc_init(struct mmc *mmc);
> int mmc_send_tuning(struct mmc *mmc, u32 opcode, int *cmd_error);
> @@ -857,8 +859,8 @@ void mmc_set_preinit(struct mmc *mmc, int preinit);
> #endif
>
> void board_mmc_power_init(void);
> -int board_mmc_init(bd_t *bis);
> -int cpu_mmc_init(bd_t *bis);
> +int board_mmc_init(struct bd_info *bis);
> +int cpu_mmc_init(struct bd_info *bis);
> int mmc_get_env_addr(struct mmc *mmc, int copy, u32 *env_addr);
> # ifdef CONFIG_SYS_MMC_ENV_PART
> extern uint mmc_get_env_part(struct mmc *mmc);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] mmc: make <mmc.h> self-contained
2020-02-24 17:25 ` [PATCH] mmc: make <mmc.h> self-contained Masahiro Yamada
2020-02-25 22:09 ` Jaehoon Chung
@ 2020-03-17 15:28 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2020-03-17 15:28 UTC (permalink / raw)
To: u-boot
On Tue, Feb 25, 2020 at 02:25:30AM +0900, Masahiro Yamada wrote:
> This header uses bd_t without including its definition.
>
> Change it to (struct bd_info), and add the forward declaration
> to specify it as a structure.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>
Applied to u-boot/next, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200317/d8ed80ad/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-17 15:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20200224172644epcas1p129c1f0b31154bda8bfa5388b832d5904@epcas1p1.samsung.com>
2020-02-24 17:25 ` [PATCH] mmc: make <mmc.h> self-contained Masahiro Yamada
2020-02-25 22:09 ` Jaehoon Chung
2020-03-17 15:28 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.