All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@iki.fi>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: tony@atomide.com, linux@arm.linux.org.uk,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, balbi@ti.com
Subject: Re: [PATCH] ARM: OMAP4: change the device names in usb_bind_phy
Date: Wed, 15 May 2013 13:53:58 +0300	[thread overview]
Message-ID: <51936946.3030507@iki.fi> (raw)
In-Reply-To: <1366697656-14315-1-git-send-email-kishon@ti.com>

On 23/04/13 09:14, Kishon Vijay Abraham I wrote:
> After the device names are created using PLATFORM_DEVID_AUTO, the old
> device names given in usb_bind_phy are no longer valid causing the musb
> controller not to get the phy reference. Updated the usb_bind_phy with
> the new device names to get MUSB functional in omap4 panda.
> 
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
> Tested in OMAP4 PANDA.
>  arch/arm/mach-omap2/board-4430sdp.c    |    2 +-
>  arch/arm/mach-omap2/board-omap4panda.c |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/board-4430sdp.c b/arch/arm/mach-omap2/board-4430sdp.c
> index 00d7290..56a9a4f 100644
> --- a/arch/arm/mach-omap2/board-4430sdp.c
> +++ b/arch/arm/mach-omap2/board-4430sdp.c
> @@ -730,7 +730,7 @@ static void __init omap_4430sdp_init(void)
>  	omap4_sdp4430_wifi_init();
>  	omap4_twl6030_hsmmc_init(mmc);
>  
> -	usb_bind_phy("musb-hdrc.0.auto", 0, "omap-usb2.1.auto");
> +	usb_bind_phy("musb-hdrc.2.auto", 0, "omap-usb2.3.auto");
>  	usb_musb_init(&musb_board_data);
>  
>  	status = omap_ethernet_init();

I'm seeing

[    2.190155] unable to find transceiver
[    2.190155] HS USB OTG: no transceiver configured
[    2.190155] musb-hdrc musb-hdrc.0.auto: musb_init_controller failed
with status -517
[    2.207458] platform musb-hdrc.0.auto: Driver musb-hdrc requests
probe deferral

on 4430sdp with v3.10-rc1. Does that mean that the musb-hdrc.0.auto was
indeed correct, and the new value of musb-hdrc.2.auto is not?

The musb-hdrc id is wrong on overo also.

 Tomi


WARNING: multiple messages have this Message-ID (diff)
From: tomi.valkeinen@iki.fi (Tomi Valkeinen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP4: change the device names in usb_bind_phy
Date: Wed, 15 May 2013 13:53:58 +0300	[thread overview]
Message-ID: <51936946.3030507@iki.fi> (raw)
In-Reply-To: <1366697656-14315-1-git-send-email-kishon@ti.com>

On 23/04/13 09:14, Kishon Vijay Abraham I wrote:
> After the device names are created using PLATFORM_DEVID_AUTO, the old
> device names given in usb_bind_phy are no longer valid causing the musb
> controller not to get the phy reference. Updated the usb_bind_phy with
> the new device names to get MUSB functional in omap4 panda.
> 
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
> Tested in OMAP4 PANDA.
>  arch/arm/mach-omap2/board-4430sdp.c    |    2 +-
>  arch/arm/mach-omap2/board-omap4panda.c |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/board-4430sdp.c b/arch/arm/mach-omap2/board-4430sdp.c
> index 00d7290..56a9a4f 100644
> --- a/arch/arm/mach-omap2/board-4430sdp.c
> +++ b/arch/arm/mach-omap2/board-4430sdp.c
> @@ -730,7 +730,7 @@ static void __init omap_4430sdp_init(void)
>  	omap4_sdp4430_wifi_init();
>  	omap4_twl6030_hsmmc_init(mmc);
>  
> -	usb_bind_phy("musb-hdrc.0.auto", 0, "omap-usb2.1.auto");
> +	usb_bind_phy("musb-hdrc.2.auto", 0, "omap-usb2.3.auto");
>  	usb_musb_init(&musb_board_data);
>  
>  	status = omap_ethernet_init();

I'm seeing

[    2.190155] unable to find transceiver
[    2.190155] HS USB OTG: no transceiver configured
[    2.190155] musb-hdrc musb-hdrc.0.auto: musb_init_controller failed
with status -517
[    2.207458] platform musb-hdrc.0.auto: Driver musb-hdrc requests
probe deferral

on 4430sdp with v3.10-rc1. Does that mean that the musb-hdrc.0.auto was
indeed correct, and the new value of musb-hdrc.2.auto is not?

The musb-hdrc id is wrong on overo also.

 Tomi

  parent reply	other threads:[~2013-05-15 10:54 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-23  6:14 [PATCH] ARM: OMAP4: change the device names in usb_bind_phy Kishon Vijay Abraham I
2013-04-23  6:14 ` Kishon Vijay Abraham I
2013-04-23  6:14 ` Kishon Vijay Abraham I
2013-04-23 17:36 ` Tony Lindgren
2013-04-23 17:36   ` Tony Lindgren
2013-05-15 10:53 ` Tomi Valkeinen [this message]
2013-05-15 10:53   ` Tomi Valkeinen
2013-05-16 15:58   ` Tony Lindgren
2013-05-16 15:58     ` Tony Lindgren
2013-05-16 16:05     ` Tomi Valkeinen
2013-05-16 16:05       ` Tomi Valkeinen
2013-05-16 16:20       ` Tony Lindgren
2013-05-16 16:20         ` Tony Lindgren
2013-05-17  5:39         ` Kishon Vijay Abraham I
2013-05-17  5:39           ` Kishon Vijay Abraham I
2013-05-17  5:39           ` Kishon Vijay Abraham I
2013-05-17 17:23           ` Tony Lindgren
2013-05-17 17:23             ` Tony Lindgren
2013-05-21 12:08             ` Florian Vaussard
2013-05-21 12:08               ` Florian Vaussard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51936946.3030507@iki.fi \
    --to=tomi.valkeinen@iki.fi \
    --cc=balbi@ti.com \
    --cc=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.