All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Barry Song <Baohua.Song@csr.com>
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com,
	workgroup.linux@csr.com, Graeme Gregory <graeme@openmoko.org>,
	broonie@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ASoC: dfbmcs320: make the driver common for other BT modules
Date: Thu, 16 May 2013 11:51:56 +0200	[thread overview]
Message-ID: <5194AC3C.4080206@metafoo.de> (raw)
In-Reply-To: <1368687184-12169-1-git-send-email-Baohua.Song@csr.com>

On 05/16/2013 08:53 AM, Barry Song wrote:
> DFBM-CS320 is only one of bluetooth modules using CSR bluetooth chips,
> we don't want everyone to have a seperate codec driver. anyway, the
> feature of Bluetooth handsfree is same on all platforms, so this patch
> makes the DFBM-CS320 driver become a common BT handsfree driver.
[...]
> -static struct platform_driver dfmcs320_driver = {
> +static struct platform_driver bt_handsfree_driver = {
>  	.driver = {
> -		.name = "dfbmcs320",
> +		.name = "bt-handsfree",
>  		.owner = THIS_MODULE,

In my opinion it's a good idea to keep a platform_id list of all the
supported devices.

>  	},
> -	.probe = dfbmcs320_probe,
> -	.remove = dfbmcs320_remove,
> +	.probe = bt_handsfree_probe,
> +	.remove = bt_handsfree_remove,
>  };
>  
> -module_platform_driver(dfmcs320_driver);
> +module_platform_driver(bt_handsfree_driver);

WARNING: multiple messages have this Message-ID (diff)
From: lars@metafoo.de (Lars-Peter Clausen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ASoC: dfbmcs320: make the driver common for other BT modules
Date: Thu, 16 May 2013 11:51:56 +0200	[thread overview]
Message-ID: <5194AC3C.4080206@metafoo.de> (raw)
In-Reply-To: <1368687184-12169-1-git-send-email-Baohua.Song@csr.com>

On 05/16/2013 08:53 AM, Barry Song wrote:
> DFBM-CS320 is only one of bluetooth modules using CSR bluetooth chips,
> we don't want everyone to have a seperate codec driver. anyway, the
> feature of Bluetooth handsfree is same on all platforms, so this patch
> makes the DFBM-CS320 driver become a common BT handsfree driver.
[...]
> -static struct platform_driver dfmcs320_driver = {
> +static struct platform_driver bt_handsfree_driver = {
>  	.driver = {
> -		.name = "dfbmcs320",
> +		.name = "bt-handsfree",
>  		.owner = THIS_MODULE,

In my opinion it's a good idea to keep a platform_id list of all the
supported devices.

>  	},
> -	.probe = dfbmcs320_probe,
> -	.remove = dfbmcs320_remove,
> +	.probe = bt_handsfree_probe,
> +	.remove = bt_handsfree_remove,
>  };
>  
> -module_platform_driver(dfmcs320_driver);
> +module_platform_driver(bt_handsfree_driver);

  reply	other threads:[~2013-05-16  9:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-16  6:53 [PATCH] ASoC: dfbmcs320: make the driver common for other BT modules Barry Song
2013-05-16  6:53 ` Barry Song
2013-05-16  9:51 ` Lars-Peter Clausen [this message]
2013-05-16  9:51   ` Lars-Peter Clausen
2013-05-16 10:31   ` Barry Song
2013-05-16 10:31     ` [alsa-devel] " Barry Song
2013-05-16 11:29     ` Lars-Peter Clausen
2013-05-16 11:29       ` [alsa-devel] " Lars-Peter Clausen
2013-05-16 12:00       ` Barry Song
2013-05-16 12:00         ` [alsa-devel] " Barry Song
2013-05-16 17:35         ` Mark Brown
2013-05-16 17:35           ` [alsa-devel] " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5194AC3C.4080206@metafoo.de \
    --to=lars@metafoo.de \
    --cc=Baohua.Song@csr.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=graeme@openmoko.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=workgroup.linux@csr.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.