* [Qemu-devel] [PATCH] target-moxie: replace target_phys_addr_t with hwaddr
@ 2013-05-15 6:04 Hu Tao
2013-05-15 8:23 ` Peter Maydell
2013-05-18 11:28 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
0 siblings, 2 replies; 4+ messages in thread
From: Hu Tao @ 2013-05-15 6:04 UTC (permalink / raw)
To: qemu-devel, qemu-trivial; +Cc: Anthony Green
target_phys_addr_t has been already replaced by hwaddr, but this
one is introduced after.
Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
---
target-moxie/helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-moxie/helper.c b/target-moxie/helper.c
index 6e0ac2a..5cfe889 100644
--- a/target-moxie/helper.c
+++ b/target-moxie/helper.c
@@ -116,7 +116,7 @@ int cpu_moxie_handle_mmu_fault(CPUMoxieState *env, target_ulong address,
return 1;
}
-target_phys_addr_t cpu_get_phys_page_debug(CPUState *env, target_ulong addr)
+hwaddr cpu_get_phys_page_debug(CPUState *env, target_ulong addr)
{
return addr;
}
--
1.8.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] target-moxie: replace target_phys_addr_t with hwaddr
2013-05-15 6:04 [Qemu-devel] [PATCH] target-moxie: replace target_phys_addr_t with hwaddr Hu Tao
@ 2013-05-15 8:23 ` Peter Maydell
2013-05-17 8:26 ` Andreas Färber
2013-05-18 11:28 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
1 sibling, 1 reply; 4+ messages in thread
From: Peter Maydell @ 2013-05-15 8:23 UTC (permalink / raw)
To: Hu Tao; +Cc: qemu-trivial, Anthony Green, qemu-devel
On 15 May 2013 07:04, Hu Tao <hutao@cn.fujitsu.com> wrote:
> target_phys_addr_t has been already replaced by hwaddr, but this
> one is introduced after.
>
> Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
This doesn't cause compile errors because it's in a bit
of code that can never get compiled (it's inside a
CONFIG_USER_ONLY block but there is no moxie-linux-user
target in configure).
thanks
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] target-moxie: replace target_phys_addr_t with hwaddr
2013-05-15 8:23 ` Peter Maydell
@ 2013-05-17 8:26 ` Andreas Färber
0 siblings, 0 replies; 4+ messages in thread
From: Andreas Färber @ 2013-05-17 8:26 UTC (permalink / raw)
To: Anthony Green; +Cc: qemu-trivial, Peter Maydell, qemu-devel, Hu Tao
Anthony G.,
Am 15.05.2013 10:23, schrieb Peter Maydell:
> On 15 May 2013 07:04, Hu Tao <hutao@cn.fujitsu.com> wrote:
>> target_phys_addr_t has been already replaced by hwaddr, but this
>> one is introduced after.
>>
>> Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>
> This doesn't cause compile errors because it's in a bit
> of code that can never get compiled (it's inside a
> CONFIG_USER_ONLY block but there is no moxie-linux-user
> target in configure).
A similar issue had come up before and I don't remember seeing a clear
answer:
Are you planning to actually implement moxie-linux-user and enable it by
default, so that we can catch any errors? Or should we rather drop any
such unused CONFIG_USER_ONLY code from target-moxie?
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] target-moxie: replace target_phys_addr_t with hwaddr
2013-05-15 6:04 [Qemu-devel] [PATCH] target-moxie: replace target_phys_addr_t with hwaddr Hu Tao
2013-05-15 8:23 ` Peter Maydell
@ 2013-05-18 11:28 ` Michael Tokarev
1 sibling, 0 replies; 4+ messages in thread
From: Michael Tokarev @ 2013-05-18 11:28 UTC (permalink / raw)
To: Hu Tao; +Cc: qemu-trivial, Anthony Green, qemu-devel
15.05.2013 10:04, Hu Tao wrote:
> target_phys_addr_t has been already replaced by hwaddr, but this
> one is introduced after.
>
> Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
Thanks, added to the trivial patches queue.
/mjt
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-05-18 11:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-15 6:04 [Qemu-devel] [PATCH] target-moxie: replace target_phys_addr_t with hwaddr Hu Tao
2013-05-15 8:23 ` Peter Maydell
2013-05-17 8:26 ` Andreas Färber
2013-05-18 11:28 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.