All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drivers: dma: sh: sudmac: use devm_ioremap_resource()
@ 2013-05-14 11:35 Laurent Navet
  2013-05-17  8:29 ` Shimoda, Yoshihiro
  0 siblings, 1 reply; 2+ messages in thread
From: Laurent Navet @ 2013-05-14 11:35 UTC (permalink / raw)
  To: djbw
  Cc: vinod.koul, kuninori.morimoto.gx, g.liakhovetski,
	yoshihiro.shimoda.uh, linux-kernel, Laurent Navet

Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource.
Found with coccicheck and this semantic patch:
 scripts/coccinelle/api/devm_ioremap_resource.cocci

Signed-off-by: Laurent Navet <laurent.navet@gmail.com>
---
 drivers/dma/sh/sudmac.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/dma/sh/sudmac.c b/drivers/dma/sh/sudmac.c
index e7c94bb..0a81e30 100644
--- a/drivers/dma/sh/sudmac.c
+++ b/drivers/dma/sh/sudmac.c
@@ -360,9 +360,9 @@ static int sudmac_probe(struct platform_device *pdev)
 
 	dma_dev = &su_dev->shdma_dev.dma_dev;
 
-	su_dev->chan_reg = devm_request_and_ioremap(&pdev->dev, chan);
-	if (!su_dev->chan_reg)
-		return err;
+	su_dev->chan_reg = devm_ioremap_resource(&pdev->dev, chan);
+	if (IS_ERR(su_dev->chan_reg))
+		return PTR_ERR(su_dev->chan_reg);
 
 	dma_cap_set(DMA_SLAVE, dma_dev->cap_mask);
 
-- 
1.7.10.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drivers: dma: sh: sudmac: use devm_ioremap_resource()
  2013-05-14 11:35 [PATCH] drivers: dma: sh: sudmac: use devm_ioremap_resource() Laurent Navet
@ 2013-05-17  8:29 ` Shimoda, Yoshihiro
  0 siblings, 0 replies; 2+ messages in thread
From: Shimoda, Yoshihiro @ 2013-05-17  8:29 UTC (permalink / raw)
  To: Laurent Navet
  Cc: djbw, vinod.koul, kuninori.morimoto.gx, g.liakhovetski, linux-kernel

Hi,

(2013/05/14 20:35), Laurent Navet wrote:
> Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource.
> Found with coccicheck and this semantic patch:
>  scripts/coccinelle/api/devm_ioremap_resource.cocci
> 
> Signed-off-by: Laurent Navet <laurent.navet@gmail.com>
> ---
>  drivers/dma/sh/sudmac.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Thank you for the patch.

Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Best regards,
Yoshihiro Shimoda

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-05-17  8:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-14 11:35 [PATCH] drivers: dma: sh: sudmac: use devm_ioremap_resource() Laurent Navet
2013-05-17  8:29 ` Shimoda, Yoshihiro

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.