* [PATCH 1/2] fec: Let device core handle pinctrl
@ 2013-05-20 13:06 Fabio Estevam
2013-05-20 13:06 ` Fabio Estevam
2013-05-20 20:44 ` [PATCH 1/2] fec: " David Miller
0 siblings, 2 replies; 5+ messages in thread
From: Fabio Estevam @ 2013-05-20 13:06 UTC (permalink / raw)
To: davem; +Cc: shawn.guo, netdev, Fabio Estevam
Since commit ab78029 (drivers/pinctrl: grab default handles from device core)
we can rely on device core for handling pinctrl, so remove
devm_pinctrl_get_select_default() from the driver.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/net/ethernet/freescale/fec_main.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index 570dfad..e277860 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -53,7 +53,6 @@
#include <linux/of_device.h>
#include <linux/of_gpio.h>
#include <linux/of_net.h>
-#include <linux/pinctrl/consumer.h>
#include <linux/regulator/consumer.h>
#include <asm/cacheflush.h>
@@ -1841,7 +1840,6 @@ fec_probe(struct platform_device *pdev)
struct resource *r;
const struct of_device_id *of_id;
static int dev_id;
- struct pinctrl *pinctrl;
struct regulator *reg_phy;
of_id = of_match_device(fec_dt_ids, &pdev->dev);
@@ -1891,12 +1889,6 @@ fec_probe(struct platform_device *pdev)
fep->phy_interface = ret;
}
- pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
- if (IS_ERR(pinctrl)) {
- ret = PTR_ERR(pinctrl);
- goto failed_pin;
- }
-
fep->clk_ipg = devm_clk_get(&pdev->dev, "ipg");
if (IS_ERR(fep->clk_ipg)) {
ret = PTR_ERR(fep->clk_ipg);
@@ -1996,7 +1988,6 @@ failed_regulator:
clk_disable_unprepare(fep->clk_ipg);
clk_disable_unprepare(fep->clk_enet_out);
clk_disable_unprepare(fep->clk_ptp);
-failed_pin:
failed_clk:
failed_ioremap:
free_netdev(ndev);
--
1.8.1.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] can: flexcan: Let device core handle pinctrl
2013-05-20 13:06 [PATCH 1/2] fec: Let device core handle pinctrl Fabio Estevam
@ 2013-05-20 13:06 ` Fabio Estevam
2013-05-20 20:44 ` [PATCH 1/2] fec: " David Miller
1 sibling, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2013-05-20 13:06 UTC (permalink / raw)
To: davem; +Cc: shawn.guo, netdev, Fabio Estevam, Marc Kleine-Budde, linux-can
Since commit ab78029 (drivers/pinctrl: grab default handles from device core)
we can rely on device core for handling pinctrl, so remove
devm_pinctrl_get_select_default() from the driver.
Cc: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: <linux-can@vger.kernel.org>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/net/can/flexcan.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c
index 4a40a18..a93cdb2 100644
--- a/drivers/net/can/flexcan.c
+++ b/drivers/net/can/flexcan.c
@@ -37,7 +37,6 @@
#include <linux/of.h>
#include <linux/of_device.h>
#include <linux/platform_device.h>
-#include <linux/pinctrl/consumer.h>
#define DRV_NAME "flexcan"
@@ -1004,16 +1003,11 @@ static int flexcan_probe(struct platform_device *pdev)
struct flexcan_priv *priv;
struct resource *mem;
struct clk *clk_ipg = NULL, *clk_per = NULL;
- struct pinctrl *pinctrl;
void __iomem *base;
resource_size_t mem_size;
int err, irq;
u32 clock_freq = 0;
- pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
- if (IS_ERR(pinctrl))
- return PTR_ERR(pinctrl);
-
if (pdev->dev.of_node)
of_property_read_u32(pdev->dev.of_node,
"clock-frequency", &clock_freq);
--
1.8.1.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] can: flexcan: Let device core handle pinctrl
@ 2013-05-20 13:06 ` Fabio Estevam
0 siblings, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2013-05-20 13:06 UTC (permalink / raw)
To: davem; +Cc: shawn.guo, netdev, Fabio Estevam, Marc Kleine-Budde, linux-can
Since commit ab78029 (drivers/pinctrl: grab default handles from device core)
we can rely on device core for handling pinctrl, so remove
devm_pinctrl_get_select_default() from the driver.
Cc: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: <linux-can@vger.kernel.org>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/net/can/flexcan.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c
index 4a40a18..a93cdb2 100644
--- a/drivers/net/can/flexcan.c
+++ b/drivers/net/can/flexcan.c
@@ -37,7 +37,6 @@
#include <linux/of.h>
#include <linux/of_device.h>
#include <linux/platform_device.h>
-#include <linux/pinctrl/consumer.h>
#define DRV_NAME "flexcan"
@@ -1004,16 +1003,11 @@ static int flexcan_probe(struct platform_device *pdev)
struct flexcan_priv *priv;
struct resource *mem;
struct clk *clk_ipg = NULL, *clk_per = NULL;
- struct pinctrl *pinctrl;
void __iomem *base;
resource_size_t mem_size;
int err, irq;
u32 clock_freq = 0;
- pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
- if (IS_ERR(pinctrl))
- return PTR_ERR(pinctrl);
-
if (pdev->dev.of_node)
of_property_read_u32(pdev->dev.of_node,
"clock-frequency", &clock_freq);
--
1.8.1.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] can: flexcan: Let device core handle pinctrl
2013-05-20 13:06 ` Fabio Estevam
(?)
@ 2013-05-20 16:07 ` Marc Kleine-Budde
-1 siblings, 0 replies; 5+ messages in thread
From: Marc Kleine-Budde @ 2013-05-20 16:07 UTC (permalink / raw)
To: Fabio Estevam; +Cc: davem, shawn.guo, netdev, linux-can
[-- Attachment #1: Type: text/plain, Size: 712 bytes --]
On 05/20/2013 03:06 PM, Fabio Estevam wrote:
> Since commit ab78029 (drivers/pinctrl: grab default handles from device core)
> we can rely on device core for handling pinctrl, so remove
> devm_pinctrl_get_select_default() from the driver.
>
> Cc: Marc Kleine-Budde <mkl@pengutronix.de>
> Cc: <linux-can@vger.kernel.org>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
applied to linux-can-next.
Thx,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] fec: Let device core handle pinctrl
2013-05-20 13:06 [PATCH 1/2] fec: Let device core handle pinctrl Fabio Estevam
2013-05-20 13:06 ` Fabio Estevam
@ 2013-05-20 20:44 ` David Miller
1 sibling, 0 replies; 5+ messages in thread
From: David Miller @ 2013-05-20 20:44 UTC (permalink / raw)
To: fabio.estevam; +Cc: shawn.guo, netdev
From: Fabio Estevam <fabio.estevam@freescale.com>
Date: Mon, 20 May 2013 10:06:17 -0300
> Since commit ab78029 (drivers/pinctrl: grab default handles from device core)
> we can rely on device core for handling pinctrl, so remove
> devm_pinctrl_get_select_default() from the driver.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Applied.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-05-20 20:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-20 13:06 [PATCH 1/2] fec: Let device core handle pinctrl Fabio Estevam
2013-05-20 13:06 ` [PATCH 2/2] can: flexcan: " Fabio Estevam
2013-05-20 13:06 ` Fabio Estevam
2013-05-20 16:07 ` Marc Kleine-Budde
2013-05-20 20:44 ` [PATCH 1/2] fec: " David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.