From: Kukjin Kim <kgene.kim@samsung.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-kernel@vger.kernel.org, Kukjin Kim <kgene.kim@samsung.com>,
Stephen Warren <swarren@wwwdotorg.org>,
linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org,
Ben Dooks <ben-linux@fluff.org>, Barry Song <baohua.song@csr.com>,
linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 08/33] drivers/i2c/busses: don't check resource with devm_ioremap_resource
Date: Tue, 21 May 2013 01:40:46 +0900 [thread overview]
Message-ID: <519A520E.3060801@samsung.com> (raw)
In-Reply-To: <1368702961-4325-9-git-send-email-wsa@the-dreams.de>
On 05/16/13 20:15, Wolfram Sang wrote:
> devm_ioremap_resource does sanity checks on the given resource. No need to
> duplicate this in the driver.
>
> Signed-off-by: Wolfram Sang<wsa@the-dreams.de>
For i2c-s3c2410:
Acked-by: Kukjin Kim <kgene.kim@samsung.com>
Thanks.
- Kukjin
> ---
> drivers/i2c/busses/i2c-s3c2410.c | 5 -----
> drivers/i2c/busses/i2c-sirf.c | 6 ------
> drivers/i2c/busses/i2c-tegra.c | 5 -----
> 3 files changed, 16 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
> index 6e8ee92..cab1c91 100644
> --- a/drivers/i2c/busses/i2c-s3c2410.c
> +++ b/drivers/i2c/busses/i2c-s3c2410.c
> @@ -1082,11 +1082,6 @@ static int s3c24xx_i2c_probe(struct platform_device *pdev)
> /* map the registers */
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (res == NULL) {
> - dev_err(&pdev->dev, "cannot find IO resource\n");
> - return -ENOENT;
> - }
> -
> i2c->regs = devm_ioremap_resource(&pdev->dev, res);
>
> if (IS_ERR(i2c->regs))
> diff --git a/drivers/i2c/busses/i2c-sirf.c b/drivers/i2c/busses/i2c-sirf.c
> index 5a7ad24..a63c7d5 100644
> --- a/drivers/i2c/busses/i2c-sirf.c
> +++ b/drivers/i2c/busses/i2c-sirf.c
> @@ -303,12 +303,6 @@ static int i2c_sirfsoc_probe(struct platform_device *pdev)
> adap->class = I2C_CLASS_HWMON;
>
> mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (mem_res == NULL) {
> - dev_err(&pdev->dev, "Unable to get MEM resource\n");
> - err = -EINVAL;
> - goto out;
> - }
> -
> siic->base = devm_ioremap_resource(&pdev->dev, mem_res);
> if (IS_ERR(siic->base)) {
> err = PTR_ERR(siic->base);
> diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
> index b60ff90..9aa1b60 100644
> --- a/drivers/i2c/busses/i2c-tegra.c
> +++ b/drivers/i2c/busses/i2c-tegra.c
> @@ -714,11 +714,6 @@ static int tegra_i2c_probe(struct platform_device *pdev)
> int ret = 0;
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (!res) {
> - dev_err(&pdev->dev, "no mem resource\n");
> - return -EINVAL;
> - }
> -
> base = devm_ioremap_resource(&pdev->dev, res);
> if (IS_ERR(base))
> return PTR_ERR(base);
WARNING: multiple messages have this Message-ID (diff)
From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 08/33] drivers/i2c/busses: don't check resource with devm_ioremap_resource
Date: Tue, 21 May 2013 01:40:46 +0900 [thread overview]
Message-ID: <519A520E.3060801@samsung.com> (raw)
In-Reply-To: <1368702961-4325-9-git-send-email-wsa@the-dreams.de>
On 05/16/13 20:15, Wolfram Sang wrote:
> devm_ioremap_resource does sanity checks on the given resource. No need to
> duplicate this in the driver.
>
> Signed-off-by: Wolfram Sang<wsa@the-dreams.de>
For i2c-s3c2410:
Acked-by: Kukjin Kim <kgene.kim@samsung.com>
Thanks.
- Kukjin
> ---
> drivers/i2c/busses/i2c-s3c2410.c | 5 -----
> drivers/i2c/busses/i2c-sirf.c | 6 ------
> drivers/i2c/busses/i2c-tegra.c | 5 -----
> 3 files changed, 16 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
> index 6e8ee92..cab1c91 100644
> --- a/drivers/i2c/busses/i2c-s3c2410.c
> +++ b/drivers/i2c/busses/i2c-s3c2410.c
> @@ -1082,11 +1082,6 @@ static int s3c24xx_i2c_probe(struct platform_device *pdev)
> /* map the registers */
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (res == NULL) {
> - dev_err(&pdev->dev, "cannot find IO resource\n");
> - return -ENOENT;
> - }
> -
> i2c->regs = devm_ioremap_resource(&pdev->dev, res);
>
> if (IS_ERR(i2c->regs))
> diff --git a/drivers/i2c/busses/i2c-sirf.c b/drivers/i2c/busses/i2c-sirf.c
> index 5a7ad24..a63c7d5 100644
> --- a/drivers/i2c/busses/i2c-sirf.c
> +++ b/drivers/i2c/busses/i2c-sirf.c
> @@ -303,12 +303,6 @@ static int i2c_sirfsoc_probe(struct platform_device *pdev)
> adap->class = I2C_CLASS_HWMON;
>
> mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (mem_res == NULL) {
> - dev_err(&pdev->dev, "Unable to get MEM resource\n");
> - err = -EINVAL;
> - goto out;
> - }
> -
> siic->base = devm_ioremap_resource(&pdev->dev, mem_res);
> if (IS_ERR(siic->base)) {
> err = PTR_ERR(siic->base);
> diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
> index b60ff90..9aa1b60 100644
> --- a/drivers/i2c/busses/i2c-tegra.c
> +++ b/drivers/i2c/busses/i2c-tegra.c
> @@ -714,11 +714,6 @@ static int tegra_i2c_probe(struct platform_device *pdev)
> int ret = 0;
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (!res) {
> - dev_err(&pdev->dev, "no mem resource\n");
> - return -EINVAL;
> - }
> -
> base = devm_ioremap_resource(&pdev->dev, res);
> if (IS_ERR(base))
> return PTR_ERR(base);
next prev parent reply other threads:[~2013-05-20 16:40 UTC|newest]
Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-16 11:15 [PATCH 00/33] devm improvement series, part 1, take 2 Wolfram Sang
2013-05-16 11:15 ` Wolfram Sang
2013-05-16 11:15 ` Wolfram Sang
2013-05-16 11:15 ` [PATCH 01/33] drivers/ata: don't check resource with devm_ioremap_resource Wolfram Sang
2013-05-16 11:15 ` [PATCH 02/33] drivers/char/hw_random: " Wolfram Sang
2013-05-16 11:15 ` [PATCH 03/33] drivers/cpufreq: " Wolfram Sang
2013-05-16 11:15 ` Viresh Kumar
[not found] ` <1368702961-4325-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2013-05-16 11:15 ` [PATCH 04/33] drivers/dma: " Wolfram Sang
2013-05-16 11:15 ` Wolfram Sang
2013-05-16 11:15 ` [PATCH 17/33] drivers/spi: " Wolfram Sang
2013-05-16 11:15 ` Wolfram Sang
2013-05-16 11:15 ` [PATCH 05/33] drivers/gpio: " Wolfram Sang
2013-05-16 11:15 ` [PATCH 06/33] drivers/gpu/drm/exynos: " Wolfram Sang
2013-05-16 11:15 ` [PATCH 07/33] drivers/gpu/host1x/drm: " Wolfram Sang
2013-05-16 11:15 ` [PATCH 08/33] drivers/i2c/busses: " Wolfram Sang
2013-05-16 11:15 ` Wolfram Sang
[not found] ` <1368702961-4325-9-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2013-05-16 12:22 ` Barry Song
2013-05-16 12:22 ` Barry Song
2013-05-16 12:22 ` Barry Song
2013-05-20 16:40 ` Kukjin Kim [this message]
2013-05-20 16:40 ` Kukjin Kim
2013-05-16 11:15 ` [PATCH 09/33] drivers/memory: " Wolfram Sang
2013-05-16 11:15 ` [PATCH 10/33] drivers/mfd: " Wolfram Sang
2013-05-16 11:15 ` [PATCH 11/33] drivers/misc: " Wolfram Sang
2013-05-16 11:15 ` [PATCH 12/33] drivers/mtd/nand: " Wolfram Sang
2013-05-16 11:15 ` Wolfram Sang
2013-05-16 11:15 ` [PATCH 13/33] drivers/net/ethernet/renesas: " Wolfram Sang
2013-05-16 15:37 ` Joe Perches
2013-05-16 11:15 ` [PATCH 14/33] drivers/pinctrl: " Wolfram Sang
2013-05-20 11:39 ` Linus Walleij
2013-05-20 17:13 ` Wolfram Sang
2013-05-20 18:34 ` Linus Walleij
2013-05-16 11:15 ` [PATCH 15/33] drivers/pwm: " Wolfram Sang
2013-05-16 11:15 ` Wolfram Sang
2013-05-16 11:15 ` [PATCH 16/33] drivers/rtc: " Wolfram Sang
2013-05-16 11:15 ` Wolfram Sang
2013-05-16 11:15 ` Wolfram Sang
2013-05-16 11:15 ` [PATCH 18/33] drivers/staging/dwc2: " Wolfram Sang
2013-05-16 11:15 ` [PATCH 19/33] drivers/staging/nvec: " Wolfram Sang
2013-05-16 11:15 ` Wolfram Sang
2013-05-16 11:15 ` [PATCH 20/33] drivers/thermal: " Wolfram Sang
2013-05-20 15:38 ` Zhang, Rui
2013-05-16 11:15 ` [PATCH 21/33] drivers/usb/chipidea: " Wolfram Sang
2013-05-16 11:29 ` Alexander Shishkin
2013-05-16 11:15 ` [PATCH 22/33] drivers/usb/gadget: " Wolfram Sang
2013-05-16 11:15 ` [PATCH 23/33] drivers/usb/host: " Wolfram Sang
2013-05-16 14:27 ` Alan Stern
2013-05-16 11:15 ` [PATCH 24/33] drivers/usb/phy: " Wolfram Sang
2013-05-16 11:15 ` [PATCH 25/33] drivers/video/omap2: " Wolfram Sang
2013-05-16 11:15 ` Wolfram Sang
2013-05-16 11:15 ` [PATCH 26/33] drivers/video/omap2/dss: " Wolfram Sang
2013-05-16 11:15 ` Wolfram Sang
2013-05-16 11:15 ` [PATCH 27/33] drivers/w1/masters: " Wolfram Sang
2013-05-16 11:15 ` [PATCH 28/33] drivers/watchdog: " Wolfram Sang
2013-05-16 11:15 ` [PATCH 29/33] arch/arm/mach-tegra: " Wolfram Sang
2013-05-16 11:15 ` Wolfram Sang
2013-05-16 11:15 ` [PATCH 30/33] arch/arm/plat-samsung: " Wolfram Sang
2013-05-16 11:15 ` Wolfram Sang
2013-05-20 16:38 ` Kukjin Kim
2013-05-20 16:38 ` Kukjin Kim
2013-05-20 17:11 ` Wolfram Sang
2013-05-20 17:11 ` Wolfram Sang
2013-05-20 17:13 ` Kukjin Kim
2013-05-20 17:13 ` Kukjin Kim
2013-05-16 11:15 ` [PATCH 31/33] arch/mips/lantiq/xway: " Wolfram Sang
2013-05-16 14:42 ` John Crispin
2013-05-16 11:16 ` [PATCH 32/33] sound/soc/fsl: " Wolfram Sang
2013-05-16 11:16 ` [PATCH 33/33] sound/soc/kirkwood: " Wolfram Sang
2013-05-16 11:57 ` [PATCH 00/33] devm improvement series, part 1, take 2 Artem Bityutskiy
2013-05-16 11:57 ` Artem Bityutskiy
2013-05-16 11:57 ` Artem Bityutskiy
2013-05-16 12:55 ` Viresh Kumar
2013-05-16 12:55 ` Viresh Kumar
2013-05-16 12:55 ` Viresh Kumar
2013-05-16 12:55 ` Viresh Kumar
2013-05-16 13:11 ` Artem Bityutskiy
2013-05-16 13:11 ` Artem Bityutskiy
2013-05-16 13:11 ` Artem Bityutskiy
2013-05-16 13:11 ` Artem Bityutskiy
2013-05-16 13:11 ` Artem Bityutskiy
2013-05-16 13:17 ` Tomi Valkeinen
2013-05-16 13:17 ` Tomi Valkeinen
2013-05-16 13:17 ` Tomi Valkeinen
2013-05-16 13:17 ` Tomi Valkeinen
2013-05-16 13:17 ` Tomi Valkeinen
2013-05-16 16:13 ` Wolfram Sang
2013-05-16 16:13 ` Wolfram Sang
2013-05-16 16:13 ` Wolfram Sang
2013-05-16 16:13 ` Wolfram Sang
2013-05-16 18:29 ` Stephen Warren
2013-05-16 18:29 ` Stephen Warren
2013-05-16 18:29 ` Stephen Warren
2013-05-16 18:29 ` Stephen Warren
2013-05-23 20:32 ` Thierry Reding
2013-05-23 20:32 ` Thierry Reding
2013-05-23 20:32 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519A520E.3060801@samsung.com \
--to=kgene.kim@samsung.com \
--cc=baohua.song@csr.com \
--cc=ben-linux@fluff.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.