From: Chen Gang <gang.chen@asianux.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"kgene.kim@samsung.com" <kgene.kim@samsung.com>,
Ben Dooks <ben@fluff.org>
Subject: Re: [PATCH] include/linux/posix_acl.h: need 'return NULL' when BUG(), if neither CONFIG_BUG nor HAVE_ARCH_BUG is defined.
Date: Tue, 21 May 2013 19:16:11 +0800 [thread overview]
Message-ID: <519B577B.8080204@asianux.com> (raw)
In-Reply-To: <20130521105959.GZ18614@n2100.arm.linux.org.uk>
On 05/21/2013 06:59 PM, Russell King - ARM Linux wrote:
> On Tue, May 21, 2013 at 09:51:57AM +0800, Chen Gang wrote:
>> On 05/21/2013 12:31 AM, Russell King - ARM Linux wrote:
>>> On Mon, May 20, 2013 at 07:40:24AM -0700, Eric W. Biederman wrote:
>>>> Seriously? The correct fix it would seem is to give a useful default BUG
>>>> definition. Say *NULL.
>>>
>>> Absolutely.
>>>
>>> The real question is... how is this happening. I've seen it occasionally
>>> in the randconfig builds - though I don't have any logs to hand which
>>> show that in the build system at the moment. So, looking at the files:
>>>
>>
>> Maybe it is my fault for the incorrect configuration.
>>
>> My operation:
>> make EXTRA_CFLAGS=-W ARCH=arm randconfig
>> make EXTRA_CFLAGS=-W ARCH=arm menuconfig
>> set 'arm-linux-gnu-' as cross compiler prefix.
>> select "MMU-based Paged Memory" in "System Type".
>> select "Samsung S5PV210/S5PC110" in "ARM System type"
>> make EXTRA_CFLAGS=-W ARCH=arm
>> ...
>>
>> In menuconfig, I do not touch the "S5PV210 Machines" or "S5PC110
>> Machines" in "System Type", and no machines will be chosen as default.
>
> You know, telling us that you're using a random configuration to produce
> a problem and not providing the actual configuration file is utterly
> insane. How many iterations do you think it might take to generate a
> random configuration which shows the same problem you're seeing?
>
>
Oh, it is my fault for my original reply (it is another issue which
also need further discussed)
But for current issue, we can repeat it only in menuconfig, unset " >
General setup > Configure standard kernel features (expert users) >
BUG() Support ", it will report related warnings.
For arm architecture, allmodconfig
make ARCH=arm allmodconfig
make ARCH=arm menuconfig
set "arm-linux-gnu-" as cross compiler prefix.
unset " > General setup > Configure standard kernel features (expert users) > BUG() Support "
make ARCH=arm
...
kernel/sched/core.c:2353:1: warning: control reaches end of non-void function [-Wreturn-type]
mm/bootmem.c:386:1: warning: control reaches end of non-void function [-Wreturn-type]
include/linux/posix_acl.h:108:1: warning: control reaches end of non-void function [-Wreturn-type]
...
For x86 architecture, allmodconfig:
make allmodconfig
make menuconfig
unset " > General setup > Configure standard kernel features (expert users) > BUG() Support "
make ARCH=arm
...
arch/x86/kvm/x86.c:4298:5: warning: ‘exchanged’ may be used uninitialized in this function [-Wuninitialized]
kernel/sched/core.c:2353:1: warning: control reaches end of non-void function [-Wreturn-type]
mm/mempolicy.c:1755:1: warning: control reaches end of non-void function [-Wreturn-type]
include/linux/posix_acl.h:108:1: warning: control reaches end of non-void function [-Wreturn-type]
...
So, we need fix the generic bug.h code, it is not arm specific.
Thanks.--
Chen Gang
Asianux Corporation
WARNING: multiple messages have this Message-ID (diff)
From: gang.chen@asianux.com (Chen Gang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] include/linux/posix_acl.h: need 'return NULL' when BUG(), if neither CONFIG_BUG nor HAVE_ARCH_BUG is defined.
Date: Tue, 21 May 2013 19:16:11 +0800 [thread overview]
Message-ID: <519B577B.8080204@asianux.com> (raw)
In-Reply-To: <20130521105959.GZ18614@n2100.arm.linux.org.uk>
On 05/21/2013 06:59 PM, Russell King - ARM Linux wrote:
> On Tue, May 21, 2013 at 09:51:57AM +0800, Chen Gang wrote:
>> On 05/21/2013 12:31 AM, Russell King - ARM Linux wrote:
>>> On Mon, May 20, 2013 at 07:40:24AM -0700, Eric W. Biederman wrote:
>>>> Seriously? The correct fix it would seem is to give a useful default BUG
>>>> definition. Say *NULL.
>>>
>>> Absolutely.
>>>
>>> The real question is... how is this happening. I've seen it occasionally
>>> in the randconfig builds - though I don't have any logs to hand which
>>> show that in the build system at the moment. So, looking at the files:
>>>
>>
>> Maybe it is my fault for the incorrect configuration.
>>
>> My operation:
>> make EXTRA_CFLAGS=-W ARCH=arm randconfig
>> make EXTRA_CFLAGS=-W ARCH=arm menuconfig
>> set 'arm-linux-gnu-' as cross compiler prefix.
>> select "MMU-based Paged Memory" in "System Type".
>> select "Samsung S5PV210/S5PC110" in "ARM System type"
>> make EXTRA_CFLAGS=-W ARCH=arm
>> ...
>>
>> In menuconfig, I do not touch the "S5PV210 Machines" or "S5PC110
>> Machines" in "System Type", and no machines will be chosen as default.
>
> You know, telling us that you're using a random configuration to produce
> a problem and not providing the actual configuration file is utterly
> insane. How many iterations do you think it might take to generate a
> random configuration which shows the same problem you're seeing?
>
>
Oh, it is my fault for my original reply (it is another issue which
also need further discussed)
But for current issue, we can repeat it only in menuconfig, unset " >
General setup > Configure standard kernel features (expert users) >
BUG() Support ", it will report related warnings.
For arm architecture, allmodconfig
make ARCH=arm allmodconfig
make ARCH=arm menuconfig
set "arm-linux-gnu-" as cross compiler prefix.
unset " > General setup > Configure standard kernel features (expert users) > BUG() Support "
make ARCH=arm
...
kernel/sched/core.c:2353:1: warning: control reaches end of non-void function [-Wreturn-type]
mm/bootmem.c:386:1: warning: control reaches end of non-void function [-Wreturn-type]
include/linux/posix_acl.h:108:1: warning: control reaches end of non-void function [-Wreturn-type]
...
For x86 architecture, allmodconfig:
make allmodconfig
make menuconfig
unset " > General setup > Configure standard kernel features (expert users) > BUG() Support "
make ARCH=arm
...
arch/x86/kvm/x86.c:4298:5: warning: ?exchanged? may be used uninitialized in this function [-Wuninitialized]
kernel/sched/core.c:2353:1: warning: control reaches end of non-void function [-Wreturn-type]
mm/mempolicy.c:1755:1: warning: control reaches end of non-void function [-Wreturn-type]
include/linux/posix_acl.h:108:1: warning: control reaches end of non-void function [-Wreturn-type]
...
So, we need fix the generic bug.h code, it is not arm specific.
Thanks.--
Chen Gang
Asianux Corporation
next prev parent reply other threads:[~2013-05-21 11:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-20 8:16 [PATCH] include/linux/posix_acl.h: need 'return NULL' when BUG(), if neither CONFIG_BUG nor HAVE_ARCH_BUG is defined Chen Gang
2013-05-20 8:16 ` Chen Gang
2013-05-20 14:40 ` Eric W. Biederman
2013-05-20 14:40 ` Eric W. Biederman
2013-05-20 16:31 ` Russell King - ARM Linux
2013-05-20 16:31 ` Russell King - ARM Linux
2013-05-21 1:51 ` Chen Gang
2013-05-21 1:51 ` Chen Gang
2013-05-21 10:59 ` Russell King - ARM Linux
2013-05-21 10:59 ` Russell King - ARM Linux
2013-05-21 11:16 ` Chen Gang [this message]
2013-05-21 11:16 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519B577B.8080204@asianux.com \
--to=gang.chen@asianux.com \
--cc=ben@fluff.org \
--cc=ebiederm@xmission.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.