From: Roman Gushchin <klamm@yandex-team.ru>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: paulmck@linux.vnet.ibm.com, Dipankar Sarma <dipankar@in.ibm.com>,
zhmurov@yandex-team.ru, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
James Morris <jmorris@namei.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>
Subject: Re: [PATCH] rcu: fix a race in hlist_nulls_for_each_entry_rcu macro
Date: Tue, 21 May 2013 19:51:37 +0400 [thread overview]
Message-ID: <519B9809.1010408@yandex-team.ru> (raw)
In-Reply-To: <1369150693.3301.233.camel@edumazet-glaptop>
On 21.05.2013 19:38, Eric Dumazet wrote:
> On Tue, 2013-05-21 at 18:47 +0400, Roman Gushchin wrote:
>
>> This code has the same mistake: it is rcu_dereference_raw(head->first),
>> so there is nothing that prevents gcc to store the (head->first) value
>> in a register.
>
> If other rcu accessors have the same problem, a more complete patch is
> needed.
Ok, I'll try to provide a complete patch ASAP.
>
> Thanks
>
>
>
next prev parent reply other threads:[~2013-05-21 15:51 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-21 9:05 [PATCH] rcu: fix a race in hlist_nulls_for_each_entry_rcu macro Roman Gushchin
2013-05-21 10:40 ` David Laight
2013-05-21 11:55 ` Roman Gushchin
2013-05-21 13:42 ` David Laight
2013-05-21 12:09 ` Paul E. McKenney
2013-05-21 12:46 ` Roman Gushchin
2013-05-21 12:58 ` Paul E. McKenney
2013-05-21 13:37 ` Eric Dumazet
2013-05-21 13:44 ` Eric Dumazet
2013-05-21 14:47 ` Roman Gushchin
2013-05-21 15:16 ` Eric Dumazet
2013-05-21 15:51 ` Roman Gushchin
2013-05-21 15:38 ` Eric Dumazet
2013-05-21 15:51 ` Roman Gushchin [this message]
2013-05-21 18:12 ` [PATCH v2] " Roman Gushchin
2013-05-22 2:01 ` Eric Dumazet
2013-05-22 5:49 ` Eric Dumazet
2013-05-22 11:58 ` Roman Gushchin
2013-05-22 12:30 ` Eric Dumazet
2013-05-22 13:07 ` Roman Gushchin
2013-05-22 17:45 ` Paul E. McKenney
2013-05-22 19:17 ` Roman Gushchin
2013-05-25 11:37 ` Paul E. McKenney
2013-05-27 11:34 ` Roman Gushchin
2013-05-27 17:55 ` Roman Gushchin
2013-05-28 0:12 ` Eric Dumazet
2013-05-28 9:10 ` Roman Gushchin
2013-05-29 0:34 ` Eric Dumazet
2013-05-29 1:31 ` Paul E. McKenney
2013-05-29 5:08 ` Eric Dumazet
2013-05-29 10:09 ` Roman Gushchin
2013-05-29 19:06 ` Eric Dumazet
2013-05-30 8:25 ` Roman Gushchin
2013-06-02 23:31 ` Eric Dumazet
2013-06-03 2:58 ` David Miller
2013-06-03 3:12 ` Eric Dumazet
2013-06-03 3:27 ` David Miller
2013-06-03 3:42 ` Paul E. McKenney
2013-06-03 3:47 ` Eric Dumazet
2013-06-03 3:49 ` David Miller
2013-06-03 6:05 ` Paul E. McKenney
2013-06-10 18:29 ` Boris B. Zhmurov
2013-06-10 18:51 ` Eric Dumazet
2013-06-03 3:48 ` Paul E. McKenney
2013-06-03 3:42 ` Paul E. McKenney
2013-05-29 9:17 ` Roman Gushchin
2013-05-29 1:19 ` Paul E. McKenney
2013-05-22 13:27 ` David Laight
2013-05-22 13:27 ` David Laight
2013-05-22 13:36 ` Eric Dumazet
2013-05-22 14:23 ` David Laight
2013-05-22 14:23 ` David Laight
2013-05-22 13:55 ` Roman Gushchin
2013-05-22 9:58 ` Paul E. McKenney
2013-05-22 12:28 ` Eric Dumazet
2013-05-22 13:00 ` Paul E. McKenney
2013-05-22 14:16 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519B9809.1010408@yandex-team.ru \
--to=klamm@yandex-team.ru \
--cc=davem@davemloft.net \
--cc=dipankar@in.ibm.com \
--cc=eric.dumazet@gmail.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=yoshfuji@linux-ipv6.org \
--cc=zhmurov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.