* [Qemu-devel] [PATCH][v4 1/3] debugcon: fix always print "addr=0x0, val=0x0" bug when use DEBUG_DEBUGCON
@ 2013-05-23 6:58 liguang
2013-05-23 6:58 ` [Qemu-devel] [PATCH][v4 2/3] debugcon: make debug message more readable liguang
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: liguang @ 2013-05-23 6:58 UTC (permalink / raw)
To: qemu-trivial, qemu-devel; +Cc: liguang
when use DEBUG_DEBUGCON, screen spits:
debugcon: write addr=0x0000 val=0x00
Rdebugcon: write addr=0x0000 val=0x00
udebugcon: write addr=0x0000 val=0x00
ndebugcon: write addr=0x0000 val=0x00
ndebugcon: write addr=0x0000 val=0x00
idebugcon: write addr=0x0000 val=0x00
ndebugcon: write addr=0x0000 val=0x00
gdebugcon: write addr=0x0000 val=0x00
debugcon: write addr=0x0000 val=0x00
odebugcon: write addr=0x0000 val=0x00
pdebugcon: write addr=0x0000 val=0x00
tdebugcon: write addr=0x0000 val=0x00
idebugcon: write addr=0x0000 val=0x00
odebugcon: write addr=0x0000 val=0x00
ndebugcon: write addr=0x0000 val=0x00
debugcon: write addr=0x0000 val=0x00
rdebugcon: write addr=0x0000 val=0x00
odebugcon: write addr=0x0000 val=0x00
mdebugcon: write addr=0x0000 val=0x00
debugcon: write addr=0x0000 val=0x00
adebugcon: write addr=0x0000 val=0x00
tdebugcon: write addr=0x0000 val=0x00
debugcon: write addr=0x0000 val=0x00
Oh, that's wrong, val is not always be 0.
this bug caused by lack of length modifier
for specifier 'x'.
Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
---
v4: fix misleading subject
---
hw/char/debugcon.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/char/debugcon.c b/hw/char/debugcon.c
index 02c9577..7e41c90 100644
--- a/hw/char/debugcon.c
+++ b/hw/char/debugcon.c
@@ -55,7 +55,7 @@ static void debugcon_ioport_write(void *opaque, hwaddr addr, uint64_t val,
unsigned char ch = val;
#ifdef DEBUG_DEBUGCON
- printf("debugcon: write addr=0x%04x val=0x%02x\n", addr, val);
+ printf("debugcon: write addr=0x%04" HWADDR_PRIx " val=0x%02x\n", addr, val);
#endif
qemu_chr_fe_write(s->chr, &ch, 1);
--
1.7.2.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Qemu-devel] [PATCH][v4 2/3] debugcon: make debug message more readable
2013-05-23 6:58 [Qemu-devel] [PATCH][v4 1/3] debugcon: fix always print "addr=0x0, val=0x0" bug when use DEBUG_DEBUGCON liguang
@ 2013-05-23 6:58 ` liguang
2013-05-23 13:06 ` Andreas Färber
2013-05-23 6:58 ` [Qemu-devel] [PATCH][v4 3/3] debugcon: fix compiler warning when open DEBUG_DEBUGCON liguang
2013-05-23 13:05 ` [Qemu-devel] [PATCH][v4 1/3] debugcon: fix always print "addr=0x0, val=0x0" bug when use DEBUG_DEBUGCON Andreas Färber
2 siblings, 1 reply; 7+ messages in thread
From: liguang @ 2013-05-23 6:58 UTC (permalink / raw)
To: qemu-trivial, qemu-devel; +Cc: liguang
before change:
Bdebugcon: write addr=0x0000 val=0x6f
odebugcon: write addr=0x0000 val=0x6f
odebugcon: write addr=0x0000 val=0x74
tdebugcon: write addr=0x0000 val=0x69
idebugcon: write addr=0x0000 val=0x6e
ndebugcon: write addr=0x0000 val=0x67
gdebugcon: write addr=0x0000 val=0x20
debugcon: write addr=0x0000 val=0x66
after change:
B [debugcon: write addr=0x0000 val=0x6f]
o [debugcon: write addr=0x0000 val=0x6f]
o [debugcon: write addr=0x0000 val=0x74]
t [debugcon: write addr=0x0000 val=0x69]
i [debugcon: write addr=0x0000 val=0x6e]
n [debugcon: write addr=0x0000 val=0x67]
g [debugcon: write addr=0x0000 val=0x20]
[debugcon: write addr=0x0000 val=0x66]
Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
---
hw/char/debugcon.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/char/debugcon.c b/hw/char/debugcon.c
index 7e41c90..52fa0ab 100644
--- a/hw/char/debugcon.c
+++ b/hw/char/debugcon.c
@@ -55,7 +55,7 @@ static void debugcon_ioport_write(void *opaque, hwaddr addr, uint64_t val,
unsigned char ch = val;
#ifdef DEBUG_DEBUGCON
- printf("debugcon: write addr=0x%04" HWADDR_PRIx " val=0x%02x\n", addr, val);
+ printf(" [debugcon: write addr=0x%04" HWADDR_PRIx " val=0x%02x]\n", addr, val);
#endif
qemu_chr_fe_write(s->chr, &ch, 1);
--
1.7.2.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Qemu-devel] [PATCH][v4 3/3] debugcon: fix compiler warning when open DEBUG_DEBUGCON
2013-05-23 6:58 [Qemu-devel] [PATCH][v4 1/3] debugcon: fix always print "addr=0x0, val=0x0" bug when use DEBUG_DEBUGCON liguang
2013-05-23 6:58 ` [Qemu-devel] [PATCH][v4 2/3] debugcon: make debug message more readable liguang
@ 2013-05-23 6:58 ` liguang
2013-05-23 13:05 ` [Qemu-devel] [PATCH][v4 1/3] debugcon: fix always print "addr=0x0, val=0x0" bug when use DEBUG_DEBUGCON Andreas Färber
2 siblings, 0 replies; 7+ messages in thread
From: liguang @ 2013-05-23 6:58 UTC (permalink / raw)
To: qemu-trivial, qemu-devel; +Cc: liguang
compiler warnings:
CC hw/char/debugcon.o
hw/char/debugcon.c: In function ‘debugcon_ioport_write’:
hw/char/debugcon.c:58: warning: format ‘%02x’ expects type ‘unsigned int’, but argument 3 has type ‘uint64_t’
hw/char/debugcon.c: In function ‘debugcon_ioport_read’:
hw/char/debugcon.c:70: warning: format ‘%04x’ expects type ‘unsigned int’, but argument 2 has type ‘hwaddr’
Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
---
hw/char/debugcon.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/char/debugcon.c b/hw/char/debugcon.c
index 52fa0ab..3b0637d 100644
--- a/hw/char/debugcon.c
+++ b/hw/char/debugcon.c
@@ -55,7 +55,7 @@ static void debugcon_ioport_write(void *opaque, hwaddr addr, uint64_t val,
unsigned char ch = val;
#ifdef DEBUG_DEBUGCON
- printf(" [debugcon: write addr=0x%04" HWADDR_PRIx " val=0x%02x]\n", addr, val);
+ printf(" [debugcon: write addr=0x%04" HWADDR_PRIx " val=0x%02" PRIx64 "]\n", addr, val);
#endif
qemu_chr_fe_write(s->chr, &ch, 1);
@@ -67,7 +67,7 @@ static uint64_t debugcon_ioport_read(void *opaque, hwaddr addr, unsigned width)
DebugconState *s = opaque;
#ifdef DEBUG_DEBUGCON
- printf("debugcon: read addr=0x%04x\n", addr);
+ printf("debugcon: read addr=0x%04" HWADDR_PRIx "\n", addr);
#endif
return s->readback;
--
1.7.2.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH][v4 1/3] debugcon: fix always print "addr=0x0, val=0x0" bug when use DEBUG_DEBUGCON
2013-05-23 6:58 [Qemu-devel] [PATCH][v4 1/3] debugcon: fix always print "addr=0x0, val=0x0" bug when use DEBUG_DEBUGCON liguang
2013-05-23 6:58 ` [Qemu-devel] [PATCH][v4 2/3] debugcon: make debug message more readable liguang
2013-05-23 6:58 ` [Qemu-devel] [PATCH][v4 3/3] debugcon: fix compiler warning when open DEBUG_DEBUGCON liguang
@ 2013-05-23 13:05 ` Andreas Färber
2013-05-24 0:20 ` li guang
2 siblings, 1 reply; 7+ messages in thread
From: Andreas Färber @ 2013-05-23 13:05 UTC (permalink / raw)
To: liguang; +Cc: qemu-trivial, qemu-devel
Am 23.05.2013 08:58, schrieb liguang:
> when use DEBUG_DEBUGCON, screen spits:
> debugcon: write addr=0x0000 val=0x00
> Rdebugcon: write addr=0x0000 val=0x00
> udebugcon: write addr=0x0000 val=0x00
> ndebugcon: write addr=0x0000 val=0x00
> ndebugcon: write addr=0x0000 val=0x00
> idebugcon: write addr=0x0000 val=0x00
> ndebugcon: write addr=0x0000 val=0x00
> gdebugcon: write addr=0x0000 val=0x00
> debugcon: write addr=0x0000 val=0x00
> odebugcon: write addr=0x0000 val=0x00
> pdebugcon: write addr=0x0000 val=0x00
> tdebugcon: write addr=0x0000 val=0x00
> idebugcon: write addr=0x0000 val=0x00
> odebugcon: write addr=0x0000 val=0x00
> ndebugcon: write addr=0x0000 val=0x00
> debugcon: write addr=0x0000 val=0x00
> rdebugcon: write addr=0x0000 val=0x00
> odebugcon: write addr=0x0000 val=0x00
> mdebugcon: write addr=0x0000 val=0x00
> debugcon: write addr=0x0000 val=0x00
> adebugcon: write addr=0x0000 val=0x00
> tdebugcon: write addr=0x0000 val=0x00
> debugcon: write addr=0x0000 val=0x00
>
> Oh, that's wrong, val is not always be 0.
> this bug caused by lack of length modifier
> for specifier 'x'.
>
> Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
> ---
> v4: fix misleading subject
As I've reminded before, please prepend a cover letter (0/x) when
sending more than once patch!
> ---
> hw/char/debugcon.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/char/debugcon.c b/hw/char/debugcon.c
> index 02c9577..7e41c90 100644
> --- a/hw/char/debugcon.c
> +++ b/hw/char/debugcon.c
> @@ -55,7 +55,7 @@ static void debugcon_ioport_write(void *opaque, hwaddr addr, uint64_t val,
> unsigned char ch = val;
>
> #ifdef DEBUG_DEBUGCON
> - printf("debugcon: write addr=0x%04x val=0x%02x\n", addr, val);
> + printf("debugcon: write addr=0x%04" HWADDR_PRIx " val=0x%02x\n", addr, val);
Please merge 3/3 with this patch - the changes are pretty obviously
correct, so you can shorten the commit message by dropping the example
output.
Andreas
> #endif
>
> qemu_chr_fe_write(s->chr, &ch, 1);
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH][v4 2/3] debugcon: make debug message more readable
2013-05-23 6:58 ` [Qemu-devel] [PATCH][v4 2/3] debugcon: make debug message more readable liguang
@ 2013-05-23 13:06 ` Andreas Färber
2013-05-24 0:28 ` li guang
0 siblings, 1 reply; 7+ messages in thread
From: Andreas Färber @ 2013-05-23 13:06 UTC (permalink / raw)
To: liguang; +Cc: qemu-trivial, Stefan Hajnoczi, qemu-devel, Peter Maydell
Am 23.05.2013 08:58, schrieb liguang:
> before change:
> Bdebugcon: write addr=0x0000 val=0x6f
> odebugcon: write addr=0x0000 val=0x6f
> odebugcon: write addr=0x0000 val=0x74
> tdebugcon: write addr=0x0000 val=0x69
> idebugcon: write addr=0x0000 val=0x6e
> ndebugcon: write addr=0x0000 val=0x67
> gdebugcon: write addr=0x0000 val=0x20
> debugcon: write addr=0x0000 val=0x66
>
> after change:
> B [debugcon: write addr=0x0000 val=0x6f]
> o [debugcon: write addr=0x0000 val=0x6f]
> o [debugcon: write addr=0x0000 val=0x74]
> t [debugcon: write addr=0x0000 val=0x69]
> i [debugcon: write addr=0x0000 val=0x6e]
> n [debugcon: write addr=0x0000 val=0x67]
> g [debugcon: write addr=0x0000 val=0x20]
> [debugcon: write addr=0x0000 val=0x66]
>
> Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
> ---
> hw/char/debugcon.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/char/debugcon.c b/hw/char/debugcon.c
> index 7e41c90..52fa0ab 100644
> --- a/hw/char/debugcon.c
> +++ b/hw/char/debugcon.c
> @@ -55,7 +55,7 @@ static void debugcon_ioport_write(void *opaque, hwaddr addr, uint64_t val,
> unsigned char ch = val;
>
> #ifdef DEBUG_DEBUGCON
> - printf("debugcon: write addr=0x%04" HWADDR_PRIx " val=0x%02x\n", addr, val);
> + printf(" [debugcon: write addr=0x%04" HWADDR_PRIx " val=0x%02x]\n", addr, val);
While not wrong, this is rather exotic - wouldn't it be better to
fprintf() to stderr instead or to use qemu_log() or tracepoints?
Andreas
> #endif
>
> qemu_chr_fe_write(s->chr, &ch, 1);
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH][v4 1/3] debugcon: fix always print "addr=0x0, val=0x0" bug when use DEBUG_DEBUGCON
2013-05-23 13:05 ` [Qemu-devel] [PATCH][v4 1/3] debugcon: fix always print "addr=0x0, val=0x0" bug when use DEBUG_DEBUGCON Andreas Färber
@ 2013-05-24 0:20 ` li guang
0 siblings, 0 replies; 7+ messages in thread
From: li guang @ 2013-05-24 0:20 UTC (permalink / raw)
To: Andreas Färber; +Cc: qemu-trivial, qemu-devel
在 2013-05-23四的 15:05 +0200,Andreas Färber写道:
> Am 23.05.2013 08:58, schrieb liguang:
> > when use DEBUG_DEBUGCON, screen spits:
> > debugcon: write addr=0x0000 val=0x00
> > Rdebugcon: write addr=0x0000 val=0x00
> > udebugcon: write addr=0x0000 val=0x00
> > ndebugcon: write addr=0x0000 val=0x00
> > ndebugcon: write addr=0x0000 val=0x00
> > idebugcon: write addr=0x0000 val=0x00
> > ndebugcon: write addr=0x0000 val=0x00
> > gdebugcon: write addr=0x0000 val=0x00
> > debugcon: write addr=0x0000 val=0x00
> > odebugcon: write addr=0x0000 val=0x00
> > pdebugcon: write addr=0x0000 val=0x00
> > tdebugcon: write addr=0x0000 val=0x00
> > idebugcon: write addr=0x0000 val=0x00
> > odebugcon: write addr=0x0000 val=0x00
> > ndebugcon: write addr=0x0000 val=0x00
> > debugcon: write addr=0x0000 val=0x00
> > rdebugcon: write addr=0x0000 val=0x00
> > odebugcon: write addr=0x0000 val=0x00
> > mdebugcon: write addr=0x0000 val=0x00
> > debugcon: write addr=0x0000 val=0x00
> > adebugcon: write addr=0x0000 val=0x00
> > tdebugcon: write addr=0x0000 val=0x00
> > debugcon: write addr=0x0000 val=0x00
> >
> > Oh, that's wrong, val is not always be 0.
> > this bug caused by lack of length modifier
> > for specifier 'x'.
> >
> > Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
> > ---
> > v4: fix misleading subject
>
> As I've reminded before, please prepend a cover letter (0/x) when
> sending more than once patch!
OK, I'll write cover-letter.
I thought since they are trivial patch, you'll not mind
that I sent without cover-letter before.
Thanks!
>
> > ---
> > hw/char/debugcon.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/hw/char/debugcon.c b/hw/char/debugcon.c
> > index 02c9577..7e41c90 100644
> > --- a/hw/char/debugcon.c
> > +++ b/hw/char/debugcon.c
> > @@ -55,7 +55,7 @@ static void debugcon_ioport_write(void *opaque, hwaddr addr, uint64_t val,
> > unsigned char ch = val;
> >
> > #ifdef DEBUG_DEBUGCON
> > - printf("debugcon: write addr=0x%04x val=0x%02x\n", addr, val);
> > + printf("debugcon: write addr=0x%04" HWADDR_PRIx " val=0x%02x\n", addr, val);
>
> Please merge 3/3 with this patch - the changes are pretty obviously
> correct, so you can shorten the commit message by dropping the example
> output.
>
> Andreas
>
> > #endif
> >
> > qemu_chr_fe_write(s->chr, &ch, 1);
> >
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH][v4 2/3] debugcon: make debug message more readable
2013-05-23 13:06 ` Andreas Färber
@ 2013-05-24 0:28 ` li guang
0 siblings, 0 replies; 7+ messages in thread
From: li guang @ 2013-05-24 0:28 UTC (permalink / raw)
To: Andreas Färber
Cc: qemu-trivial, Stefan Hajnoczi, qemu-devel, Peter Maydell
在 2013-05-23四的 15:06 +0200,Andreas Färber写道:
> Am 23.05.2013 08:58, schrieb liguang:
> > before change:
> > Bdebugcon: write addr=0x0000 val=0x6f
> > odebugcon: write addr=0x0000 val=0x6f
> > odebugcon: write addr=0x0000 val=0x74
> > tdebugcon: write addr=0x0000 val=0x69
> > idebugcon: write addr=0x0000 val=0x6e
> > ndebugcon: write addr=0x0000 val=0x67
> > gdebugcon: write addr=0x0000 val=0x20
> > debugcon: write addr=0x0000 val=0x66
> >
> > after change:
> > B [debugcon: write addr=0x0000 val=0x6f]
> > o [debugcon: write addr=0x0000 val=0x6f]
> > o [debugcon: write addr=0x0000 val=0x74]
> > t [debugcon: write addr=0x0000 val=0x69]
> > i [debugcon: write addr=0x0000 val=0x6e]
> > n [debugcon: write addr=0x0000 val=0x67]
> > g [debugcon: write addr=0x0000 val=0x20]
> > [debugcon: write addr=0x0000 val=0x66]
> >
> > Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
> > ---
> > hw/char/debugcon.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/hw/char/debugcon.c b/hw/char/debugcon.c
> > index 7e41c90..52fa0ab 100644
> > --- a/hw/char/debugcon.c
> > +++ b/hw/char/debugcon.c
> > @@ -55,7 +55,7 @@ static void debugcon_ioport_write(void *opaque, hwaddr addr, uint64_t val,
> > unsigned char ch = val;
> >
> > #ifdef DEBUG_DEBUGCON
> > - printf("debugcon: write addr=0x%04" HWADDR_PRIx " val=0x%02x\n", addr, val);
> > + printf(" [debugcon: write addr=0x%04" HWADDR_PRIx " val=0x%02x]\n", addr, val);
>
> While not wrong, this is rather exotic - wouldn't it be better to
> fprintf() to stderr instead or to use qemu_log() or tracepoints?
>
Hmm... let me change.
>
> > #endif
> >
> > qemu_chr_fe_write(s->chr, &ch, 1);
> >
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-05-24 0:28 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-23 6:58 [Qemu-devel] [PATCH][v4 1/3] debugcon: fix always print "addr=0x0, val=0x0" bug when use DEBUG_DEBUGCON liguang
2013-05-23 6:58 ` [Qemu-devel] [PATCH][v4 2/3] debugcon: make debug message more readable liguang
2013-05-23 13:06 ` Andreas Färber
2013-05-24 0:28 ` li guang
2013-05-23 6:58 ` [Qemu-devel] [PATCH][v4 3/3] debugcon: fix compiler warning when open DEBUG_DEBUGCON liguang
2013-05-23 13:05 ` [Qemu-devel] [PATCH][v4 1/3] debugcon: fix always print "addr=0x0, val=0x0" bug when use DEBUG_DEBUGCON Andreas Färber
2013-05-24 0:20 ` li guang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.