* [PATCH] add generic/286 to the auto and quick groups
@ 2013-05-24 4:33 ` Theodore Ts'o
0 siblings, 0 replies; 5+ messages in thread
From: Theodore Ts'o @ 2013-05-24 4:33 UTC (permalink / raw)
To: xfs; +Cc: Ext4 Developers List, Theodore Ts'o
The generic/286 test tests SEEK_HOLE and SEEK_DATA, and is reasonably
fast. We should just run the test by default.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
---
tests/generic/group | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/generic/group b/tests/generic/group
index e2ef70e..bd443c1 100644
--- a/tests/generic/group
+++ b/tests/generic/group
@@ -103,7 +103,7 @@
277 auto ioctl quick metadata
280 auto quota freeze dangerous
285 auto rw
-286 other
+286 auto quick other
288 auto quick ioctl trim
294 auto quick
299 auto aio enospc rw stress
--
1.7.12.rc0.22.gcdd159b
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] add generic/286 to the auto and quick groups
@ 2013-05-24 4:33 ` Theodore Ts'o
0 siblings, 0 replies; 5+ messages in thread
From: Theodore Ts'o @ 2013-05-24 4:33 UTC (permalink / raw)
To: xfs; +Cc: Ext4 Developers List, Theodore Ts'o
The generic/286 test tests SEEK_HOLE and SEEK_DATA, and is reasonably
fast. We should just run the test by default.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
---
tests/generic/group | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/generic/group b/tests/generic/group
index e2ef70e..bd443c1 100644
--- a/tests/generic/group
+++ b/tests/generic/group
@@ -103,7 +103,7 @@
277 auto ioctl quick metadata
280 auto quota freeze dangerous
285 auto rw
-286 other
+286 auto quick other
288 auto quick ioctl trim
294 auto quick
299 auto aio enospc rw stress
--
1.7.12.rc0.22.gcdd159b
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] add generic/286 to the auto and quick groups
2013-05-24 4:33 ` Theodore Ts'o
@ 2013-05-24 4:54 ` Eric Sandeen
-1 siblings, 0 replies; 5+ messages in thread
From: Eric Sandeen @ 2013-05-24 4:54 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: xfs, Ext4 Developers List
On 5/23/13 11:33 PM, Theodore Ts'o wrote:
> The generic/286 test tests SEEK_HOLE and SEEK_DATA, and is reasonably
> fast. We should just run the test by default.
>
> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Seems fine to me
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
another patch to follow to fix it on kernels that don't support it.
> ---
> tests/generic/group | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/generic/group b/tests/generic/group
> index e2ef70e..bd443c1 100644
> --- a/tests/generic/group
> +++ b/tests/generic/group
> @@ -103,7 +103,7 @@
> 277 auto ioctl quick metadata
> 280 auto quota freeze dangerous
> 285 auto rw
> -286 other
> +286 auto quick other
> 288 auto quick ioctl trim
> 294 auto quick
> 299 auto aio enospc rw stress
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] add generic/286 to the auto and quick groups
@ 2013-05-24 4:54 ` Eric Sandeen
0 siblings, 0 replies; 5+ messages in thread
From: Eric Sandeen @ 2013-05-24 4:54 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: Ext4 Developers List, xfs
On 5/23/13 11:33 PM, Theodore Ts'o wrote:
> The generic/286 test tests SEEK_HOLE and SEEK_DATA, and is reasonably
> fast. We should just run the test by default.
>
> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Seems fine to me
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
another patch to follow to fix it on kernels that don't support it.
> ---
> tests/generic/group | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/generic/group b/tests/generic/group
> index e2ef70e..bd443c1 100644
> --- a/tests/generic/group
> +++ b/tests/generic/group
> @@ -103,7 +103,7 @@
> 277 auto ioctl quick metadata
> 280 auto quota freeze dangerous
> 285 auto rw
> -286 other
> +286 auto quick other
> 288 auto quick ioctl trim
> 294 auto quick
> 299 auto aio enospc rw stress
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] add generic/286 to the auto and quick groups
2013-05-24 4:33 ` Theodore Ts'o
(?)
(?)
@ 2013-05-28 16:05 ` Rich Johnston
-1 siblings, 0 replies; 5+ messages in thread
From: Rich Johnston @ 2013-05-28 16:05 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: Ext4 Developers List, xfs
On 05/23/2013 11:33 PM, Theodore Ts'o wrote:
> The generic/286 test tests SEEK_HOLE and SEEK_DATA, and is reasonably
> fast. We should just run the test by default.
>
> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
> ---
> tests/generic/group | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/generic/group b/tests/generic/group
> index e2ef70e..bd443c1 100644
> --- a/tests/generic/group
> +++ b/tests/generic/group
> @@ -103,7 +103,7 @@
> 277 auto ioctl quick metadata
> 280 auto quota freeze dangerous
> 285 auto rw
> -286 other
> +286 auto quick other
> 288 auto quick ioctl trim
> 294 auto quick
> 299 auto aio enospc rw stress
>
Thanks, this patch has been committed:
commit f45c6881577221e04f6cfe19d25e571bee088996
Author: Theodore Ts'o <tytso@mit.edu>
Date: Tue May 28 11:01:01 2013 -0500
xfstests: add generic/286 to the auto and quick groups
--Rich
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-05-28 16:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-24 4:33 [PATCH] add generic/286 to the auto and quick groups Theodore Ts'o
2013-05-24 4:33 ` Theodore Ts'o
2013-05-24 4:54 ` Eric Sandeen
2013-05-24 4:54 ` Eric Sandeen
2013-05-28 16:05 ` Rich Johnston
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.