* [Qemu-devel] [PATCH] qemu: fix out of tree cross compile
@ 2013-05-27 6:13 Alexey Kardashevskiy
2013-05-27 10:24 ` Peter Maydell
0 siblings, 1 reply; 13+ messages in thread
From: Alexey Kardashevskiy @ 2013-05-27 6:13 UTC (permalink / raw)
To: qemu-devel; +Cc: Alexey Kardashevskiy, qemu-trivial
QEMU uses headers from source directory, however the "asm" symlink was
created in the build directory what broke KVM stuff compilation.
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 5ae7e4a..9c3c5e5 100755
--- a/configure
+++ b/configure
@@ -4135,7 +4135,7 @@ if test "$linux" = "yes" ; then
esac
# For non-KVM architectures we will not have asm headers
if [ -e "$source_path/linux-headers/asm-$linux_arch" ]; then
- symlink "$source_path/linux-headers/asm-$linux_arch" linux-headers/asm
+ symlink "$source_path/linux-headers/asm-$linux_arch" $source_path/linux-headers/asm
fi
fi
--
1.7.10.4
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [Qemu-devel] [PATCH] qemu: fix out of tree cross compile
2013-05-27 6:13 [Qemu-devel] [PATCH] qemu: fix out of tree cross compile Alexey Kardashevskiy
@ 2013-05-27 10:24 ` Peter Maydell
2013-05-27 14:11 ` Alexey Kardashevskiy
0 siblings, 1 reply; 13+ messages in thread
From: Peter Maydell @ 2013-05-27 10:24 UTC (permalink / raw)
To: Alexey Kardashevskiy; +Cc: qemu-trivial, qemu-devel
On 27 May 2013 07:13, Alexey Kardashevskiy <aik@ozlabs.ru> wrote:
> QEMU uses headers from source directory, however the "asm" symlink was
> created in the build directory what broke KVM stuff compilation.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 5ae7e4a..9c3c5e5 100755
> --- a/configure
> +++ b/configure
> @@ -4135,7 +4135,7 @@ if test "$linux" = "yes" ; then
> esac
> # For non-KVM architectures we will not have asm headers
> if [ -e "$source_path/linux-headers/asm-$linux_arch" ]; then
> - symlink "$source_path/linux-headers/asm-$linux_arch" linux-headers/asm
> + symlink "$source_path/linux-headers/asm-$linux_arch" $source_path/linux-headers/asm
This is definitely wrong -- the asm symlink must be created
in the build tree, because you could have two build trees
which are building for different architectures and need
different symlink targets. (More generally, an out of tree
build should never create files in the source tree, because
the point of out of tree builds is to leave the source tree
in a pristine state.)
What is the actual bug here? QEMU builds fine for me, because
the build directory is also in the include path via "-I.".
thanks
-- PMM
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Qemu-devel] [PATCH] qemu: fix out of tree cross compile
2013-05-27 10:24 ` Peter Maydell
@ 2013-05-27 14:11 ` Alexey Kardashevskiy
2013-05-27 14:12 ` Alexey Kardashevskiy
0 siblings, 1 reply; 13+ messages in thread
From: Alexey Kardashevskiy @ 2013-05-27 14:11 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-trivial, qemu-devel
On 05/27/2013 08:24 PM, Peter Maydell wrote:
> On 27 May 2013 07:13, Alexey Kardashevskiy <aik@ozlabs.ru> wrote:
>> QEMU uses headers from source directory, however the "asm" symlink was
>> created in the build directory what broke KVM stuff compilation.
>>
>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>> ---
>> configure | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/configure b/configure
>> index 5ae7e4a..9c3c5e5 100755
>> --- a/configure
>> +++ b/configure
>> @@ -4135,7 +4135,7 @@ if test "$linux" = "yes" ; then
>> esac
>> # For non-KVM architectures we will not have asm headers
>> if [ -e "$source_path/linux-headers/asm-$linux_arch" ]; then
>> - symlink "$source_path/linux-headers/asm-$linux_arch" linux-headers/asm
>> + symlink "$source_path/linux-headers/asm-$linux_arch" $source_path/linux-headers/asm
>
> This is definitely wrong -- the asm symlink must be created
> in the build tree, because you could have two build trees
> which are building for different architectures and need
> different symlink targets. (More generally, an out of tree
> build should never create files in the source tree, because
> the point of out of tree builds is to leave the source tree
> in a pristine state.)
Ok, ok. Then I'll post another patch in a a response to this.
> What is the actual bug here? QEMU builds fine for me, because
> the build directory is also in the include path via "-I.".
Does you build directory beside inside the source tree directory? I cannot
see the other way for it to work. -I <blabla>/linux-headers must be added,
"-I." is not enough.
The actual bug is that it does not cross compile until I apply this or the
other patch.
This is how I run ./configure:
/home/alexey/pcipassthru/qemu-impreza/configure
--source-path=/home/alexey/pcipassthru/qemu-impreza
--target-list=ppc64-softmmu
--cpu=ppc64
--cross-prefix=powerpc64-linux-
--prefix=/home/alexey/pcipassthru/lib4qemu/install
--extra-ldflags=-L/home/alexey/pcipassthru/lib4qemu/usr/lib64
'--extra-cflags=--sysroot=/home/alexey/pcipassthru/lib4qemu/
-I/home/alexey/pcipassthru/lib4qemu/usr/include -D__EXCEPTIONS
-D__LONG_DOUBLE_128__ -D__NO_INLINE__ -Wno-redundant-decls
-Wno-missing-prototypes -Wmissing-include-dirs'
--disable-werror
--enable-fdt
--enable-attr
--enable-kvm
--enable-profiler
--disable-seccomp
--enable-trace-backend=stderr
--enable-debug
--disable-debug-tcg
--enable-debug-info
This is where the compilation fails on:
powerpc64-linux-gcc \
-I/home/alexey/pcipassthru/qemu-impreza/tcg
-I/home/alexey/pcipassthru/qemu-impreza/tcg/ppc64
-I/home/alexey/pcipassthru/qemu-impreza/linux-headers
-I.
-I/home/alexey/pcipassthru/qemu-impreza
-I/home/alexey/pcipassthru/qemu-impreza/include
-I/home/alexey/pcipassthru/qemu-impreza/target-ppc
-Itarget-ppc
-D_GNU_SOURCE
-D_FILE_OFFSET_BITS=64
-D_LARGEFILE_SOURCE
-Wstrict-prototypes
-Wredundant-decls -Wall
-Wundef
-Wwrite-strings
-Wmissing-prototypes
-fno-strict-aliasing
--sysroot=/home/alexey/pcipassthru/lib4qemu/
-I/home/alexey/pcipassthru/lib4qemu/usr/include
-D__EXCEPTIONS -D__LONG_DOUBLE_128__ -D__NO_INLINE__
-Wno-redundant-decls -Wno-missing-prototypes
-Wmissing-include-dirs -Wendif-labels
-Wmissing-include-dirs -Wempty-body
-Wnested-externs -Wformat-security
-Wformat-y2k -Winit-self -Wignored-qualifiers
-Wold-style-declaration -Wold-style-definition
-Wtype-limits
-I/home/alexey/pcipassthru/lib4qemu/usr/include
-I/home/alexey/pcipassthru/lib4qemu/usr/include/p11-kit-1
-I/home/alexey/pcipassthru/lib4qemu/usr/include
-I/home/alexey/pcipassthru/lib4qemu/usr/include/libusb-1.0
-I/home/alexey/pcipassthru/lib4qemu/usr/include
-I/home/alexey/pcipassthru/lib4qemu/usr/include/pixman-1
-I../linux-headers
-I..
-I/home/alexey/pcipassthru/qemu-impreza/target-ppc
-DNEED_CPU_H
-I/home/alexey/pcipassthru/qemu-impreza/include
-pthread
-I/home/alexey/pcipassthru/lib4qemu/usr/include/glib-2.0
-I/home/alexey/pcipassthru/lib4qemu/usr/lib64/glib-2.0/include
-MMD -MP -MT target-ppc/kvm.o -MF target-ppc/kvm.d -g
-I/home/alexey/pcipassthru/lib4qemu/usr/include -c
-o target-ppc/kvm.o
/home/alexey/pcipassthru/qemu-impreza/target-ppc/kvm.c
/home/alexey/pcipassthru/qemu-impreza/hw/ppc/xics.c: In function
'icp_get_kvm_state':
/home/alexey/pcipassthru/qemu-impreza/hw/ppc/xics.c:186:15: error:
'KVM_REG_PPC_ICP_STATE' undeclared (first use in this function)
.id = KVM_REG_PPC_ICP_STATE,
^
...
--
Alexey
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Qemu-devel] [PATCH] qemu: fix out of tree cross compile
2013-05-27 14:11 ` Alexey Kardashevskiy
@ 2013-05-27 14:12 ` Alexey Kardashevskiy
2013-05-27 15:02 ` Paolo Bonzini
0 siblings, 1 reply; 13+ messages in thread
From: Alexey Kardashevskiy @ 2013-05-27 14:12 UTC (permalink / raw)
To: Peter Maydell; +Cc: Alexey Kardashevskiy, qemu-trivial, qemu-ppc, qemu-devel
The symlink to platform linux headers is made in the build tree by
the configure script but gcc is not told to look for them there.
The patch fixes this.
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 5ae7e4a..5ba691a 100755
--- a/configure
+++ b/configure
@@ -547,7 +547,7 @@ Haiku)
if [ "$cpu" = "i386" -o "$cpu" = "x86_64" ] ; then
audio_possible_drivers="$audio_possible_drivers fmod"
fi
- QEMU_INCLUDES="-I\$(SRC_PATH)/linux-headers $QEMU_INCLUDES"
+ QEMU_INCLUDES="-I$(pwd)/linux-headers $QEMU_INCLUDES"
;;
esac
--
1.7.10.4
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [Qemu-devel] [PATCH] qemu: fix out of tree cross compile
2013-05-27 14:12 ` Alexey Kardashevskiy
@ 2013-05-27 15:02 ` Paolo Bonzini
2013-05-27 22:59 ` Alexey Kardashevskiy
0 siblings, 1 reply; 13+ messages in thread
From: Paolo Bonzini @ 2013-05-27 15:02 UTC (permalink / raw)
To: Alexey Kardashevskiy; +Cc: qemu-trivial, Peter Maydell, qemu-ppc, qemu-devel
Il 27/05/2013 16:12, Alexey Kardashevskiy ha scritto:
> The symlink to platform linux headers is made in the build tree by
> the configure script but gcc is not told to look for them there.
> The patch fixes this.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 5ae7e4a..5ba691a 100755
> --- a/configure
> +++ b/configure
> @@ -547,7 +547,7 @@ Haiku)
> if [ "$cpu" = "i386" -o "$cpu" = "x86_64" ] ; then
> audio_possible_drivers="$audio_possible_drivers fmod"
> fi
> - QEMU_INCLUDES="-I\$(SRC_PATH)/linux-headers $QEMU_INCLUDES"
> + QEMU_INCLUDES="-I$(pwd)/linux-headers $QEMU_INCLUDES"
You need to have both directories. Files other than asm/*.h will be
found in the source path.
Paolo
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Qemu-devel] [PATCH] qemu: fix out of tree cross compile
2013-05-27 15:02 ` Paolo Bonzini
@ 2013-05-27 22:59 ` Alexey Kardashevskiy
2013-05-27 23:44 ` [Qemu-devel] [PATCH v2] " Alexey Kardashevskiy
0 siblings, 1 reply; 13+ messages in thread
From: Alexey Kardashevskiy @ 2013-05-27 22:59 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-trivial, Peter Maydell, qemu-ppc, qemu-devel
On 05/28/2013 01:02 AM, Paolo Bonzini wrote:
> Il 27/05/2013 16:12, Alexey Kardashevskiy ha scritto:
>> The symlink to platform linux headers is made in the build tree by
>> the configure script but gcc is not told to look for them there.
>> The patch fixes this.
>>
>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>> ---
>> configure | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/configure b/configure
>> index 5ae7e4a..5ba691a 100755
>> --- a/configure
>> +++ b/configure
>> @@ -547,7 +547,7 @@ Haiku)
>> if [ "$cpu" = "i386" -o "$cpu" = "x86_64" ] ; then
>> audio_possible_drivers="$audio_possible_drivers fmod"
>> fi
>> - QEMU_INCLUDES="-I\$(SRC_PATH)/linux-headers $QEMU_INCLUDES"
>> + QEMU_INCLUDES="-I$(pwd)/linux-headers $QEMU_INCLUDES"
>
> You need to have both directories. Files other than asm/*.h will be
> found in the source path.
So do I need this?
+ QEMU_INCLUDES="-I$(pwd)/linux-headers -I\$(SRC_PATH)/linux-headers
$QEMU_INCLUDES"
--
Alexey
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Qemu-devel] [PATCH v2] qemu: fix out of tree cross compile
2013-05-27 22:59 ` Alexey Kardashevskiy
@ 2013-05-27 23:44 ` Alexey Kardashevskiy
2013-05-27 23:49 ` [Qemu-devel] [PATCH v3] " Alexey Kardashevskiy
0 siblings, 1 reply; 13+ messages in thread
From: Alexey Kardashevskiy @ 2013-05-27 23:44 UTC (permalink / raw)
To: Paolo Bonzini, Peter Maydell
Cc: Alexey Kardashevskiy, qemu-trivial, qemu-devel
The symlink to "asm" platform linux headers is made in the build tree by
the configure script but gcc is not told to look for them there.
The patch fixes this.
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
configure | 1 +
1 file changed, 1 insertion(+)
diff --git a/configure b/configure
index 5ae7e4a..20b42f0 100755
--- a/configure
+++ b/configure
@@ -548,6 +548,7 @@ Haiku)
audio_possible_drivers="$audio_possible_drivers fmod"
fi
QEMU_INCLUDES="-I\$(SRC_PATH)/linux-headers $QEMU_INCLUDES"
+ QEMU_INCLUDES="-I\$(SRC_PATH)/linux-headers -I$(pwd)/linux-headers $QEMU_INCLUDES"
;;
esac
--
1.7.10.4
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [Qemu-devel] [PATCH v3] qemu: fix out of tree cross compile
2013-05-27 23:44 ` [Qemu-devel] [PATCH v2] " Alexey Kardashevskiy
@ 2013-05-27 23:49 ` Alexey Kardashevskiy
2013-05-28 8:54 ` Paolo Bonzini
2013-05-29 13:17 ` Anthony Liguori
0 siblings, 2 replies; 13+ messages in thread
From: Alexey Kardashevskiy @ 2013-05-27 23:49 UTC (permalink / raw)
To: Paolo Bonzini, Peter Maydell
Cc: Alexey Kardashevskiy, qemu-trivial, qemu-devel
The symlink to "asm" platform linux headers is made in the build tree by
the configure script but gcc is not told to look for them there.
The patch fixes this.
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
The previous patch did not remove the old line adding includes. Early morning,
lack of focus :)
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 5ae7e4a..eca2a20 100755
--- a/configure
+++ b/configure
@@ -547,7 +547,7 @@ Haiku)
if [ "$cpu" = "i386" -o "$cpu" = "x86_64" ] ; then
audio_possible_drivers="$audio_possible_drivers fmod"
fi
- QEMU_INCLUDES="-I\$(SRC_PATH)/linux-headers $QEMU_INCLUDES"
+ QEMU_INCLUDES="-I\$(SRC_PATH)/linux-headers -I$(pwd)/linux-headers $QEMU_INCLUDES"
;;
esac
--
1.7.10.4
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [Qemu-devel] [PATCH v3] qemu: fix out of tree cross compile
2013-05-27 23:49 ` [Qemu-devel] [PATCH v3] " Alexey Kardashevskiy
@ 2013-05-28 8:54 ` Paolo Bonzini
2013-05-28 9:12 ` Andreas Färber
2013-05-29 13:17 ` Anthony Liguori
1 sibling, 1 reply; 13+ messages in thread
From: Paolo Bonzini @ 2013-05-28 8:54 UTC (permalink / raw)
To: Alexey Kardashevskiy; +Cc: qemu-trivial, Peter Maydell, qemu-devel
Il 28/05/2013 01:49, Alexey Kardashevskiy ha scritto:
> The symlink to "asm" platform linux headers is made in the build tree by
> the configure script but gcc is not told to look for them there.
>
> The patch fixes this.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
>
> The previous patch did not remove the old line adding includes. Early morning,
> lack of focus :)
>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 5ae7e4a..eca2a20 100755
> --- a/configure
> +++ b/configure
> @@ -547,7 +547,7 @@ Haiku)
> if [ "$cpu" = "i386" -o "$cpu" = "x86_64" ] ; then
> audio_possible_drivers="$audio_possible_drivers fmod"
> fi
> - QEMU_INCLUDES="-I\$(SRC_PATH)/linux-headers $QEMU_INCLUDES"
> + QEMU_INCLUDES="-I\$(SRC_PATH)/linux-headers -I$(pwd)/linux-headers $QEMU_INCLUDES"
> ;;
> esac
>
>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Paolo
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Qemu-devel] [PATCH v3] qemu: fix out of tree cross compile
2013-05-28 8:54 ` Paolo Bonzini
@ 2013-05-28 9:12 ` Andreas Färber
2013-05-28 9:21 ` Paolo Bonzini
0 siblings, 1 reply; 13+ messages in thread
From: Andreas Färber @ 2013-05-28 9:12 UTC (permalink / raw)
To: Paolo Bonzini, Alexey Kardashevskiy
Cc: qemu-trivial, Peter Maydell, qemu-devel
Am 28.05.2013 10:54, schrieb Paolo Bonzini:
> Il 28/05/2013 01:49, Alexey Kardashevskiy ha scritto:
>> The symlink to "asm" platform linux headers is made in the build tree by
>> the configure script but gcc is not told to look for them there.
>>
>> The patch fixes this.
>>
>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>> ---
>>
>> The previous patch did not remove the old line adding includes. Early morning,
>> lack of focus :)
>>
>> ---
>> configure | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/configure b/configure
>> index 5ae7e4a..eca2a20 100755
>> --- a/configure
>> +++ b/configure
>> @@ -547,7 +547,7 @@ Haiku)
>> if [ "$cpu" = "i386" -o "$cpu" = "x86_64" ] ; then
>> audio_possible_drivers="$audio_possible_drivers fmod"
>> fi
>> - QEMU_INCLUDES="-I\$(SRC_PATH)/linux-headers $QEMU_INCLUDES"
>> + QEMU_INCLUDES="-I\$(SRC_PATH)/linux-headers -I$(pwd)/linux-headers $QEMU_INCLUDES"
>> ;;
>> esac
>>
>>
>
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Hm, I see no other case of adding $(pwd) to QEMU_INCLUDES - shouldn't
this just be -Ilinux-headers?
And might it make sense to give the build directory precedence over the
source directory?
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Qemu-devel] [PATCH v3] qemu: fix out of tree cross compile
2013-05-28 9:12 ` Andreas Färber
@ 2013-05-28 9:21 ` Paolo Bonzini
0 siblings, 0 replies; 13+ messages in thread
From: Paolo Bonzini @ 2013-05-28 9:21 UTC (permalink / raw)
To: Andreas Färber
Cc: Alexey Kardashevskiy, qemu-trivial, qemu-devel, Peter Maydell
Il 28/05/2013 11:12, Andreas Färber ha scritto:
> Am 28.05.2013 10:54, schrieb Paolo Bonzini:
>> Il 28/05/2013 01:49, Alexey Kardashevskiy ha scritto:
>>> The symlink to "asm" platform linux headers is made in the build tree by
>>> the configure script but gcc is not told to look for them there.
>>>
>>> The patch fixes this.
>>>
>>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>>> ---
>>>
>>> The previous patch did not remove the old line adding includes. Early morning,
>>> lack of focus :)
>>>
>>> ---
>>> configure | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/configure b/configure
>>> index 5ae7e4a..eca2a20 100755
>>> --- a/configure
>>> +++ b/configure
>>> @@ -547,7 +547,7 @@ Haiku)
>>> if [ "$cpu" = "i386" -o "$cpu" = "x86_64" ] ; then
>>> audio_possible_drivers="$audio_possible_drivers fmod"
>>> fi
>>> - QEMU_INCLUDES="-I\$(SRC_PATH)/linux-headers $QEMU_INCLUDES"
>>> + QEMU_INCLUDES="-I\$(SRC_PATH)/linux-headers -I$(pwd)/linux-headers $QEMU_INCLUDES"
>>> ;;
>>> esac
>>>
>>>
>>
>> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
>
> Hm, I see no other case of adding $(pwd) to QEMU_INCLUDES - shouldn't
> this just be -Ilinux-headers?
I think -Ilinux-headers would add
<builddir>/x86_64-softmmu/linux-headers, which is wrong.
> And might it make sense to give the build directory precedence over the
> source directory?
It shouldn't matter.
Paolo
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Qemu-devel] [PATCH v3] qemu: fix out of tree cross compile
2013-05-27 23:49 ` [Qemu-devel] [PATCH v3] " Alexey Kardashevskiy
2013-05-28 8:54 ` Paolo Bonzini
@ 2013-05-29 13:17 ` Anthony Liguori
1 sibling, 0 replies; 13+ messages in thread
From: Anthony Liguori @ 2013-05-29 13:17 UTC (permalink / raw)
To: Alexey Kardashevskiy, Paolo Bonzini, Peter Maydell
Cc: qemu-trivial, qemu-devel
Alexey Kardashevskiy <aik@ozlabs.ru> writes:
> The symlink to "asm" platform linux headers is made in the build tree by
> the configure script but gcc is not told to look for them there.
>
> The patch fixes this.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
>
> The previous patch did not remove the old line adding includes. Early morning,
> lack of focus :)
Please repost as a top level patch.
Regards,
Anthony Liguori
>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 5ae7e4a..eca2a20 100755
> --- a/configure
> +++ b/configure
> @@ -547,7 +547,7 @@ Haiku)
> if [ "$cpu" = "i386" -o "$cpu" = "x86_64" ] ; then
> audio_possible_drivers="$audio_possible_drivers fmod"
> fi
> - QEMU_INCLUDES="-I\$(SRC_PATH)/linux-headers $QEMU_INCLUDES"
> + QEMU_INCLUDES="-I\$(SRC_PATH)/linux-headers -I$(pwd)/linux-headers $QEMU_INCLUDES"
> ;;
> esac
>
> --
> 1.7.10.4
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Qemu-devel] [PATCH v3] qemu: fix out of tree cross compile
@ 2013-05-29 13:30 Alexey Kardashevskiy
0 siblings, 0 replies; 13+ messages in thread
From: Alexey Kardashevskiy @ 2013-05-29 13:30 UTC (permalink / raw)
To: Paolo Bonzini, Peter Maydell
Cc: Alexey Kardashevskiy, qemu-trivial, qemu-devel
The symlink to "asm" platform linux headers is made in the build tree by
the configure script but gcc is not told to look for them there.
The patch fixes this.
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
Reposting it as a top level patch.
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 5ae7e4a..eca2a20 100755
--- a/configure
+++ b/configure
@@ -547,7 +547,7 @@ Haiku)
if [ "$cpu" = "i386" -o "$cpu" = "x86_64" ] ; then
audio_possible_drivers="$audio_possible_drivers fmod"
fi
- QEMU_INCLUDES="-I\$(SRC_PATH)/linux-headers $QEMU_INCLUDES"
+ QEMU_INCLUDES="-I\$(SRC_PATH)/linux-headers -I$(pwd)/linux-headers $QEMU_INCLUDES"
;;
esac
--
1.7.10.4
^ permalink raw reply related [flat|nested] 13+ messages in thread
end of thread, other threads:[~2013-05-29 13:31 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-27 6:13 [Qemu-devel] [PATCH] qemu: fix out of tree cross compile Alexey Kardashevskiy
2013-05-27 10:24 ` Peter Maydell
2013-05-27 14:11 ` Alexey Kardashevskiy
2013-05-27 14:12 ` Alexey Kardashevskiy
2013-05-27 15:02 ` Paolo Bonzini
2013-05-27 22:59 ` Alexey Kardashevskiy
2013-05-27 23:44 ` [Qemu-devel] [PATCH v2] " Alexey Kardashevskiy
2013-05-27 23:49 ` [Qemu-devel] [PATCH v3] " Alexey Kardashevskiy
2013-05-28 8:54 ` Paolo Bonzini
2013-05-28 9:12 ` Andreas Färber
2013-05-28 9:21 ` Paolo Bonzini
2013-05-29 13:17 ` Anthony Liguori
2013-05-29 13:30 Alexey Kardashevskiy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.