From: Liu Jiang <liuj97@gmail.com> To: Vineet Gupta <vineet.gupta1@synopsys.com> Cc: Andrew Morton <akpm@linux-foundation.org>, Jiang Liu <jiang.liu@huawei.com>, David Rientjes <rientjes@google.com>, Wen Congyang <wency@cn.fujitsu.com>, Mel Gorman <mgorman@suse.de>, Minchan Kim <minchan@kernel.org>, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>, Michal Hocko <mhocko@suse.cz>, James Bottomley <james.bottomley@hansenpartnership.com>, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>, David Howells <dhowells@redhat.com>, Mark Salter <msalter@redhat.com>, Jianguo Wu <wujianguo@huawei.com>, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, James Hogan <james.hogan@imgtec.com>, Rob Herring <rob.herring@calxeda.com> Subject: Re: [PATCH v5, part4 12/41] mm/ARC: prepare for removing num_physpages and simplify mem_init() Date: Wed, 29 May 2013 21:05:43 +0800 [thread overview] Message-ID: <51A5FD27.5080903@gmail.com> (raw) In-Reply-To: <51A5BF3A.2070108@synopsys.com> On Wed 29 May 2013 04:41:30 PM CST, Vineet Gupta wrote: > Hi Jiang, > > On 05/08/2013 09:21 PM, Jiang Liu wrote: >> Prepare for removing num_physpages and simplify mem_init(). >> >> Signed-off-by: Jiang Liu <jiang.liu@huawei.com> >> Cc: Vineet Gupta <vgupta@synopsys.com> >> Cc: James Hogan <james.hogan@imgtec.com> >> Cc: Rob Herring <rob.herring@calxeda.com> >> Cc: linux-kernel@vger.kernel.org >> --- >> arch/arc/mm/init.c | 36 +++--------------------------------- >> 1 file changed, 3 insertions(+), 33 deletions(-) >> >> diff --git a/arch/arc/mm/init.c b/arch/arc/mm/init.c >> index 78d8c31..8ba6562 100644 >> --- a/arch/arc/mm/init.c >> +++ b/arch/arc/mm/init.c >> @@ -74,7 +74,7 @@ void __init setup_arch_memory(void) >> /* Last usable page of low mem (no HIGHMEM yet for ARC port) */ >> max_low_pfn = max_pfn = PFN_DOWN(end_mem); >> >> - max_mapnr = num_physpages = max_low_pfn - min_low_pfn; >> + max_mapnr = max_low_pfn - min_low_pfn; >> >> /*------------- reserve kernel image -----------------------*/ >> memblock_reserve(CONFIG_LINUX_LINK_BASE, >> @@ -84,7 +84,7 @@ void __init setup_arch_memory(void) >> >> /*-------------- node setup --------------------------------*/ >> memset(zones_size, 0, sizeof(zones_size)); >> - zones_size[ZONE_NORMAL] = num_physpages; >> + zones_size[ZONE_NORMAL] = max_low_pfn - min_low_pfn; >> >> /* >> * We can't use the helper free_area_init(zones[]) because it uses >> @@ -106,39 +106,9 @@ void __init setup_arch_memory(void) >> */ >> void __init mem_init(void) >> { >> - int codesize, datasize, initsize, reserved_pages, free_pages; >> - int tmp; >> - >> high_memory = (void *)(CONFIG_LINUX_LINK_BASE + arc_mem_sz); >> - >> free_all_bootmem(); >> - > > What baseline is this code against, since mainline looks like following: > > high_memory = (void *)(CONFIG_LINUX_LINK_BASE + arc_mem_sz); > > totalram_pages = free_all_bootmem(); > > So I would handve expected the following > > - totalram_pages = free_all_bootmem(); > + free_all_bootmem(); > > Aha, you missed out CCing all maintainers on "[PATCH v7, part3 14/16]" or rather > "[PATCH v8, part3 13/14]" - and it is difficult to dig this out from all the > patches that fly by on linux-arch. > > Same goes for "[PATCH v8, part3 01/14]" and "[PATCH v8, part3 02/14]" Hi Vineet, This patchset is based on Andrew's mmotm tree, there are some differences between mmotm and the upstream kernel, sorry for the inconvenience. Once I sent those common patches to all related maintainers, but the CC list is too long and also caused other troubles. Next time I will send all patches to linux-arch maillist. > >> - /* count all reserved pages [kernel code/data/mem_map..] */ >> - reserved_pages = 0; >> - for (tmp = 0; tmp < max_mapnr; tmp++) >> - if (PageReserved(mem_map + tmp)) >> - reserved_pages++; >> - >> - /* XXX: nr_free_pages() is equivalent */ >> - free_pages = max_mapnr - reserved_pages; >> - >> - /* >> - * For the purpose of display below, split the "reserve mem" >> - * kernel code/data is already shown explicitly, >> - * Show any other reservations (mem_map[ ] et al) >> - */ >> - reserved_pages -= (((unsigned int)_end - CONFIG_LINUX_LINK_BASE) >> >> - PAGE_SHIFT); >> - >> - codesize = _etext - _text; >> - datasize = _end - _etext; >> - initsize = __init_end - __init_begin; >> - >> - pr_info("Memory Available: %dM / %ldM (%dK code, %dK data, %dK init, %dK reserv)\n", >> - PAGES_TO_MB(free_pages), >> - TO_MB(arc_mem_sz), >> - TO_KB(codesize), TO_KB(datasize), TO_KB(initsize), >> - PAGES_TO_KB(reserved_pages)); >> + mem_init_print_info(NULL); >> } >> >> /* >> > > The Changes look OK though. I managed to build your github tree (mem_init_v5 > branch). And it seems to work ok. > > Acked-by: Vineet Gupta <vgupta@synopsys.com> # for arch/arc Thanks for review and tests! Regards! Gerry > > Thx > -Vineet
WARNING: multiple messages have this Message-ID (diff)
From: Liu Jiang <liuj97@gmail.com> To: Vineet Gupta <vineet.gupta1@synopsys.com> Cc: Andrew Morton <akpm@linux-foundation.org>, Jiang Liu <jiang.liu@huawei.com>, David Rientjes <rientjes@google.com>, Wen Congyang <wency@cn.fujitsu.com>, Mel Gorman <mgorman@suse.de>, Minchan Kim <minchan@kernel.org>, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>, Michal Hocko <mhocko@suse.cz>, James Bottomley <james.bottomley@hansenpartnership.com>, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>, David Howells <dhowells@redhat.com>, Mark Salter <msalter@redhat.com>, Jianguo Wu <wujianguo@huawei.com>, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, James Hogan <james.hogan@imgtec.com>, Rob Herring <rob.herring@calxeda.com> Subject: Re: [PATCH v5, part4 12/41] mm/ARC: prepare for removing num_physpages and simplify mem_init() Date: Wed, 29 May 2013 21:05:43 +0800 [thread overview] Message-ID: <51A5FD27.5080903@gmail.com> (raw) In-Reply-To: <51A5BF3A.2070108@synopsys.com> On Wed 29 May 2013 04:41:30 PM CST, Vineet Gupta wrote: > Hi Jiang, > > On 05/08/2013 09:21 PM, Jiang Liu wrote: >> Prepare for removing num_physpages and simplify mem_init(). >> >> Signed-off-by: Jiang Liu <jiang.liu@huawei.com> >> Cc: Vineet Gupta <vgupta@synopsys.com> >> Cc: James Hogan <james.hogan@imgtec.com> >> Cc: Rob Herring <rob.herring@calxeda.com> >> Cc: linux-kernel@vger.kernel.org >> --- >> arch/arc/mm/init.c | 36 +++--------------------------------- >> 1 file changed, 3 insertions(+), 33 deletions(-) >> >> diff --git a/arch/arc/mm/init.c b/arch/arc/mm/init.c >> index 78d8c31..8ba6562 100644 >> --- a/arch/arc/mm/init.c >> +++ b/arch/arc/mm/init.c >> @@ -74,7 +74,7 @@ void __init setup_arch_memory(void) >> /* Last usable page of low mem (no HIGHMEM yet for ARC port) */ >> max_low_pfn = max_pfn = PFN_DOWN(end_mem); >> >> - max_mapnr = num_physpages = max_low_pfn - min_low_pfn; >> + max_mapnr = max_low_pfn - min_low_pfn; >> >> /*------------- reserve kernel image -----------------------*/ >> memblock_reserve(CONFIG_LINUX_LINK_BASE, >> @@ -84,7 +84,7 @@ void __init setup_arch_memory(void) >> >> /*-------------- node setup --------------------------------*/ >> memset(zones_size, 0, sizeof(zones_size)); >> - zones_size[ZONE_NORMAL] = num_physpages; >> + zones_size[ZONE_NORMAL] = max_low_pfn - min_low_pfn; >> >> /* >> * We can't use the helper free_area_init(zones[]) because it uses >> @@ -106,39 +106,9 @@ void __init setup_arch_memory(void) >> */ >> void __init mem_init(void) >> { >> - int codesize, datasize, initsize, reserved_pages, free_pages; >> - int tmp; >> - >> high_memory = (void *)(CONFIG_LINUX_LINK_BASE + arc_mem_sz); >> - >> free_all_bootmem(); >> - > > What baseline is this code against, since mainline looks like following: > > high_memory = (void *)(CONFIG_LINUX_LINK_BASE + arc_mem_sz); > > totalram_pages = free_all_bootmem(); > > So I would handve expected the following > > - totalram_pages = free_all_bootmem(); > + free_all_bootmem(); > > Aha, you missed out CCing all maintainers on "[PATCH v7, part3 14/16]" or rather > "[PATCH v8, part3 13/14]" - and it is difficult to dig this out from all the > patches that fly by on linux-arch. > > Same goes for "[PATCH v8, part3 01/14]" and "[PATCH v8, part3 02/14]" Hi Vineet, This patchset is based on Andrew's mmotm tree, there are some differences between mmotm and the upstream kernel, sorry for the inconvenience. Once I sent those common patches to all related maintainers, but the CC list is too long and also caused other troubles. Next time I will send all patches to linux-arch maillist. > >> - /* count all reserved pages [kernel code/data/mem_map..] */ >> - reserved_pages = 0; >> - for (tmp = 0; tmp < max_mapnr; tmp++) >> - if (PageReserved(mem_map + tmp)) >> - reserved_pages++; >> - >> - /* XXX: nr_free_pages() is equivalent */ >> - free_pages = max_mapnr - reserved_pages; >> - >> - /* >> - * For the purpose of display below, split the "reserve mem" >> - * kernel code/data is already shown explicitly, >> - * Show any other reservations (mem_map[ ] et al) >> - */ >> - reserved_pages -= (((unsigned int)_end - CONFIG_LINUX_LINK_BASE) >> >> - PAGE_SHIFT); >> - >> - codesize = _etext - _text; >> - datasize = _end - _etext; >> - initsize = __init_end - __init_begin; >> - >> - pr_info("Memory Available: %dM / %ldM (%dK code, %dK data, %dK init, %dK reserv)\n", >> - PAGES_TO_MB(free_pages), >> - TO_MB(arc_mem_sz), >> - TO_KB(codesize), TO_KB(datasize), TO_KB(initsize), >> - PAGES_TO_KB(reserved_pages)); >> + mem_init_print_info(NULL); >> } >> >> /* >> > > The Changes look OK though. I managed to build your github tree (mem_init_v5 > branch). And it seems to work ok. > > Acked-by: Vineet Gupta <vgupta@synopsys.com> # for arch/arc Thanks for review and tests! Regards! Gerry > > Thx > -Vineet -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-05-29 13:05 UTC|newest] Thread overview: 119+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-05-08 15:50 [PATCH v5, part4 00/41] Simplify mem_init() implementations and kill num_physpages Jiang Liu 2013-05-08 15:50 ` Jiang Liu 2013-05-08 15:50 ` [PATCH v5, part4 01/41] vmlinux.lds: add comments for global variables and clean up useless declarations Jiang Liu 2013-05-08 15:50 ` Jiang Liu 2013-05-08 15:50 ` [PATCH v5, part4 02/41] avr32: normalize global variables exported by vmlinux.lds Jiang Liu 2013-05-08 15:50 ` Jiang Liu 2013-05-08 15:51 ` [PATCH v5, part4 03/41] c6x: " Jiang Liu 2013-05-08 15:51 ` Jiang Liu 2013-05-08 15:51 ` [PATCH v5, part4 04/41] h8300: " Jiang Liu 2013-05-08 15:51 ` Jiang Liu 2013-05-08 15:51 ` [PATCH v5, part4 05/41] score: " Jiang Liu 2013-05-08 15:51 ` Jiang Liu 2013-05-08 15:51 ` [PATCH v5, part4 06/41] tile: " Jiang Liu 2013-05-08 15:51 ` Jiang Liu 2013-05-08 15:51 ` [PATCH v5, part4 07/41] UML: " Jiang Liu 2013-05-08 15:51 ` Jiang Liu 2013-05-08 15:51 ` [PATCH v5, part4 08/41] mm: introduce helper function mem_init_print_info() to simplify mem_init() Jiang Liu 2013-05-08 15:51 ` Jiang Liu 2013-05-08 15:51 ` [PATCH v5, part4 09/41] mm: use totalram_pages instead of num_physpages at runtime Jiang Liu 2013-05-08 15:51 ` Jiang Liu 2013-05-08 15:51 ` [PATCH v5, part4 10/41] mm/hotplug: prepare for removing num_physpages Jiang Liu 2013-05-08 15:51 ` Jiang Liu 2013-05-08 15:51 ` [PATCH v5, part4 11/41] mm/alpha: prepare for removing num_physpages and simplify mem_init() Jiang Liu 2013-05-08 15:51 ` Jiang Liu 2013-05-08 15:51 ` [PATCH v5, part4 12/41] mm/ARC: " Jiang Liu 2013-05-08 15:51 ` Jiang Liu 2013-05-29 8:41 ` Vineet Gupta 2013-05-29 8:41 ` Vineet Gupta 2013-05-29 8:41 ` Vineet Gupta 2013-05-29 13:05 ` Liu Jiang [this message] 2013-05-29 13:05 ` Liu Jiang 2013-05-08 15:51 ` [PATCH v5, part4 13/41] mm/ARM: " Jiang Liu 2013-05-08 15:51 ` Jiang Liu 2013-05-08 15:51 ` Jiang Liu 2013-05-08 15:51 ` [PATCH v5, part4 14/41] mm/ARM64: " Jiang Liu 2013-05-08 15:51 ` Jiang Liu 2013-05-08 15:51 ` Jiang Liu 2013-05-08 15:51 ` [PATCH v5, part4 15/41] mm/AVR32: " Jiang Liu 2013-05-08 15:51 ` Jiang Liu 2013-05-08 15:51 ` [PATCH v5, part4 16/41] mm/blackfin: " Jiang Liu 2013-05-08 15:51 ` Jiang Liu 2013-05-25 13:25 ` Sonic Zhang 2013-05-25 13:25 ` Sonic Zhang 2013-05-26 13:55 ` Liu Jiang 2013-05-26 13:55 ` Liu Jiang 2013-05-08 15:51 ` [PATCH v5, part4 17/41] mm/c6x: " Jiang Liu 2013-05-08 15:51 ` Jiang Liu 2013-05-08 15:51 ` [PATCH v5, part4 18/41] mm/cris: " Jiang Liu 2013-05-08 15:51 ` Jiang Liu 2013-05-08 15:51 ` [PATCH v5, part4 19/41] mm/frv: " Jiang Liu 2013-05-08 15:51 ` Jiang Liu 2013-05-08 15:51 ` [PATCH v5, part4 20/41] mm/h8300: " Jiang Liu 2013-05-08 15:51 ` Jiang Liu 2013-05-08 16:26 ` Sergei Shtylyov 2013-05-08 16:26 ` Sergei Shtylyov 2013-05-08 19:29 ` Sergei Shtylyov 2013-05-08 19:29 ` Sergei Shtylyov 2013-05-08 23:35 ` Cody P Schafer 2013-05-08 23:35 ` Cody P Schafer 2013-05-12 15:17 ` Liu Jiang 2013-05-12 15:17 ` Liu Jiang 2013-05-08 15:51 ` [PATCH v5, part4 21/41] mm/hexagon: " Jiang Liu 2013-05-08 15:51 ` Jiang Liu 2013-05-08 15:51 ` [PATCH v5, part4 22/41] mm/IA64: " Jiang Liu 2013-05-08 15:51 ` Jiang Liu 2013-05-08 15:51 ` Jiang Liu 2013-05-08 15:51 ` [PATCH v5, part4 23/41] mm/m32r: " Jiang Liu 2013-05-08 15:51 ` Jiang Liu 2013-05-08 15:51 ` [PATCH v5, part4 24/41] mm/m68k: " Jiang Liu 2013-05-08 15:51 ` Jiang Liu 2013-05-08 15:51 ` Jiang Liu 2013-05-08 15:51 ` Jiang Liu 2013-05-08 15:51 ` [PATCH v5, part4 25/41] mm/metag: " Jiang Liu 2013-05-08 15:51 ` Jiang Liu 2013-05-08 15:51 ` [PATCH v5, part4 26/41] mm/microblaze: " Jiang Liu 2013-05-08 15:51 ` Jiang Liu 2013-05-08 15:51 ` [PATCH v5, part4 27/41] mm/MIPS: " Jiang Liu 2013-05-08 15:51 ` Jiang Liu 2013-05-08 15:51 ` [PATCH v5, part4 28/41] mm/mn10300: " Jiang Liu 2013-05-08 15:51 ` Jiang Liu 2013-05-08 15:51 ` [PATCH v5, part4 29/41] mm/openrisc: " Jiang Liu 2013-05-08 15:51 ` Jiang Liu 2013-05-08 15:51 ` Jiang Liu 2013-05-08 15:51 ` [PATCH v5, part4 30/41] mm/PARISC: " Jiang Liu 2013-05-08 15:51 ` Jiang Liu 2013-05-08 15:51 ` [PATCH v5, part4 31/41] mm/ppc: " Jiang Liu 2013-05-08 15:51 ` Jiang Liu 2013-05-08 15:51 ` Jiang Liu 2013-05-15 0:32 ` Benjamin Herrenschmidt 2013-05-15 0:32 ` Benjamin Herrenschmidt 2013-05-15 0:32 ` Benjamin Herrenschmidt 2013-05-15 15:49 ` Liu Jiang 2013-05-15 15:49 ` Liu Jiang 2013-05-15 15:49 ` Liu Jiang 2013-05-08 15:51 ` [PATCH v5, part4 32/41] mm/s390: " Jiang Liu 2013-05-08 15:51 ` Jiang Liu 2013-05-08 15:51 ` [PATCH v5, part4 33/41] mm/score: " Jiang Liu 2013-05-08 15:51 ` Jiang Liu 2013-05-08 15:51 ` [PATCH v5, part4 34/41] mm/SH: " Jiang Liu 2013-05-08 15:51 ` Jiang Liu 2013-05-08 15:51 ` Jiang Liu 2013-05-08 15:51 ` [PATCH v5, part4 35/41] mm/SPARC: " Jiang Liu 2013-05-08 15:51 ` Jiang Liu 2013-05-08 15:51 ` Jiang Liu 2013-05-08 19:02 ` Sam Ravnborg 2013-05-08 19:02 ` Sam Ravnborg 2013-05-08 19:02 ` Sam Ravnborg 2013-05-08 15:51 ` [PATCH v5, part4 36/41] mm/tile: " Jiang Liu 2013-05-08 15:51 ` Jiang Liu 2013-05-08 15:51 ` [PATCH v5, part4 37/41] mm/um: " Jiang Liu 2013-05-08 15:51 ` Jiang Liu 2013-05-08 15:51 ` [PATCH v5, part4 38/41] mm/unicore32: " Jiang Liu 2013-05-08 15:51 ` Jiang Liu 2013-05-08 15:51 ` [PATCH v5, part4 39/41] mm/x86: " Jiang Liu 2013-05-08 15:51 ` Jiang Liu 2013-05-08 15:51 ` [PATCH v5, part4 40/41] mm/xtensa: " Jiang Liu 2013-05-08 15:51 ` Jiang Liu 2013-05-08 15:51 ` [PATCH v5, part4 41/41] mm: kill global variable num_physpages Jiang Liu 2013-05-08 15:51 ` Jiang Liu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=51A5FD27.5080903@gmail.com \ --to=liuj97@gmail.com \ --cc=akpm@linux-foundation.org \ --cc=dhowells@redhat.com \ --cc=james.bottomley@hansenpartnership.com \ --cc=james.hogan@imgtec.com \ --cc=jiang.liu@huawei.com \ --cc=kamezawa.hiroyu@jp.fujitsu.com \ --cc=linux-arch@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mgorman@suse.de \ --cc=mhocko@suse.cz \ --cc=minchan@kernel.org \ --cc=msalter@redhat.com \ --cc=rientjes@google.com \ --cc=rob.herring@calxeda.com \ --cc=sergei.shtylyov@cogentembedded.com \ --cc=vineet.gupta1@synopsys.com \ --cc=wency@cn.fujitsu.com \ --cc=wujianguo@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.