All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: <wensong@linux-vs.org>, <ja@ssi.bg>, <horms@verge.net.au>
Cc: <pablo@netfilter.org>, <lvs-devel@vger.kernel.org>,
	<netdev@vger.kernel.org>
Subject: [PATCH] ip_vs_sh: fix build
Date: Wed, 29 May 2013 13:33:51 +0100	[thread overview]
Message-ID: <51A611CF02000078000D99A6@nat28.tlf.novell.com> (raw)

kfree_rcu() requires offsetof(..., rcu_head) < 4096, which can get
violated with a sufficiently high CONFIG_IP_VS_SH_TAB_BITS.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

---
 net/netfilter/ipvs/ip_vs_sh.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- 3.10-rc3/net/netfilter/ipvs/ip_vs_sh.c
+++ 3.10-rc3-ip_vs_sh-build/net/netfilter/ipvs/ip_vs_sh.c
@@ -67,8 +67,8 @@ struct ip_vs_sh_bucket {
 #define IP_VS_SH_TAB_MASK               (IP_VS_SH_TAB_SIZE - 1)
 
 struct ip_vs_sh_state {
-	struct ip_vs_sh_bucket		buckets[IP_VS_SH_TAB_SIZE];
 	struct rcu_head			rcu_head;
+	struct ip_vs_sh_bucket		buckets[IP_VS_SH_TAB_SIZE];
 };
 
 /*




WARNING: multiple messages have this Message-ID (diff)
From: "Jan Beulich" <JBeulich@suse.com>
To: wensong@linux-vs.org, ja@ssi.bg, horms@verge.net.au
Cc: pablo@netfilter.org, lvs-devel@vger.kernel.org, netdev@vger.kernel.org
Subject: [PATCH] ip_vs_sh: fix build
Date: Wed, 29 May 2013 13:33:51 +0100	[thread overview]
Message-ID: <51A611CF02000078000D99A6@nat28.tlf.novell.com> (raw)

kfree_rcu() requires offsetof(..., rcu_head) < 4096, which can get
violated with a sufficiently high CONFIG_IP_VS_SH_TAB_BITS.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

---
 net/netfilter/ipvs/ip_vs_sh.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- 3.10-rc3/net/netfilter/ipvs/ip_vs_sh.c
+++ 3.10-rc3-ip_vs_sh-build/net/netfilter/ipvs/ip_vs_sh.c
@@ -67,8 +67,8 @@ struct ip_vs_sh_bucket {
 #define IP_VS_SH_TAB_MASK               (IP_VS_SH_TAB_SIZE - 1)
 
 struct ip_vs_sh_state {
-	struct ip_vs_sh_bucket		buckets[IP_VS_SH_TAB_SIZE];
 	struct rcu_head			rcu_head;
+	struct ip_vs_sh_bucket		buckets[IP_VS_SH_TAB_SIZE];
 };
 
 /*




             reply	other threads:[~2013-05-29 12:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-29 12:33 Jan Beulich [this message]
2013-05-29 12:33 ` [PATCH] ip_vs_sh: fix build Jan Beulich
2013-05-29 14:59 ` Simon Horman
2013-05-29 15:51   ` Pablo Neira Ayuso
2013-05-29 19:31 ` Julian Anastasov
2013-05-30  5:48   ` Jan Beulich
2013-05-30  5:48     ` Jan Beulich
2013-05-30  6:42     ` Julian Anastasov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51A611CF02000078000D99A6@nat28.tlf.novell.com \
    --to=jbeulich@suse.com \
    --cc=horms@verge.net.au \
    --cc=ja@ssi.bg \
    --cc=lvs-devel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=wensong@linux-vs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.