All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chen Gang <gang.chen@asianux.com>
To: David Laight <David.Laight@ACULAB.COM>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
	edumazet@google.com, Pravin Shelar <pshelar@nicira.com>,
	mgorman@suse.de, David Miller <davem@davemloft.net>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, netdev <netdev@vger.kernel.org>,
	Ben Hutchings <bhutchings@solarflare.com>
Subject: Re: [PATCH v2] include/linux/skbuff.h: using '(u16) ~0U' instead of '~0U'
Date: Wed, 05 Jun 2013 08:44:14 +0800	[thread overview]
Message-ID: <51AE89DE.60106@asianux.com> (raw)
In-Reply-To: <AE90C24D6B3A694183C094C60CF0A2F6026B7263@saturn3.aculab.com>

On 06/03/2013 08:47 PM, David Laight wrote:
>>> +#define SKB_HEADER_UNSET_16	((unsigned short) ~0U)
>>> > > +
>> > 
>> > The _16 part isn't really correct, the type could be changed
>> > and then it would be wrong.
>> > 
>> > I think I might have used SKB_HEADER_OFFSET.
> I meant SKB_HEADER_UNSET_OFFSET or SKB_HEADER_OFFSET_UNSET
> 

It sound good, I choose the 2nd: 'SKB_HEADER_OFFSET_UNSET', for it may
be a 'noun', not a 'sentence'.

I will send patch v3 (also use '__u16' instead of 'unsigned short')


Thanks.
-- 
Chen Gang

Asianux Corporation

  reply	other threads:[~2013-06-05  3:28 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-30  6:03 [PATCH] include/linux/skbuff.h: using '0xffff' instead of '~0U' Chen Gang
2013-05-30  9:55 ` Chen Gang
2013-05-30 15:30 ` Ben Hutchings
2013-06-03  8:52   ` Chen Gang
2013-05-31 21:05 ` Andy Shevchenko
2013-06-03  9:23   ` Chen Gang
2013-06-03 10:14     ` Andy Shevchenko
2013-06-03 10:51       ` Chen Gang
2013-06-03 11:24         ` [PATCH v2] include/linux/skbuff.h: using '(u16) ~0U' " Chen Gang
2013-06-03 11:34           ` Andy Shevchenko
2013-06-03 11:46             ` Chen Gang
2013-06-03 12:26           ` David Laight
2013-06-03 12:26             ` David Laight
2013-06-03 12:47             ` David Laight
2013-06-03 12:47               ` David Laight
2013-06-05  0:44               ` Chen Gang [this message]
2013-06-05  0:54                 ` [PATCH v3] include/linux/skbuff.h: using '(__u16) " Chen Gang
2013-06-05  8:36                   ` David Miller
2013-06-05 11:15                     ` Chen Gang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51AE89DE.60106@asianux.com \
    --to=gang.chen@asianux.com \
    --cc=David.Laight@ACULAB.COM \
    --cc=akpm@linux-foundation.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=bhutchings@solarflare.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=netdev@vger.kernel.org \
    --cc=pshelar@nicira.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.