From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Chen Gang <gang.chen@asianux.com>
Cc: edumazet@google.com, Pravin Shelar <pshelar@nicira.com>,
mgorman@suse.de, David Miller <davem@davemloft.net>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] include/linux/skbuff.h: using '0xffff' instead of '~0U'
Date: Sat, 1 Jun 2013 00:05:07 +0300 [thread overview]
Message-ID: <CAHp75VfWvXkaoYQ_40idSsLYUA=YqaswnV2y-hODHjt7JMHQvQ@mail.gmail.com> (raw)
In-Reply-To: <51A6EBC5.7040601@asianux.com>
On Thu, May 30, 2013 at 9:03 AM, Chen Gang <gang.chen@asianux.com> wrote:
>
> Both 'transport_header' and 'mac_header' are u16, which are never equal
> to '~0U'.
>
> So need use '0xffff' instead of '~0U'.
Why not "(u16)~0" ?
Or even better "!= USHORT_MAX"?
Or mac_header + 1 == 0, though it less clear.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2013-05-31 21:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 6:03 [PATCH] include/linux/skbuff.h: using '0xffff' instead of '~0U' Chen Gang
2013-05-30 9:55 ` Chen Gang
2013-05-30 15:30 ` Ben Hutchings
2013-06-03 8:52 ` Chen Gang
2013-05-31 21:05 ` Andy Shevchenko [this message]
2013-06-03 9:23 ` Chen Gang
2013-06-03 10:14 ` Andy Shevchenko
2013-06-03 10:51 ` Chen Gang
2013-06-03 11:24 ` [PATCH v2] include/linux/skbuff.h: using '(u16) ~0U' " Chen Gang
2013-06-03 11:34 ` Andy Shevchenko
2013-06-03 11:46 ` Chen Gang
2013-06-03 12:26 ` David Laight
2013-06-03 12:26 ` David Laight
2013-06-03 12:47 ` David Laight
2013-06-03 12:47 ` David Laight
2013-06-05 0:44 ` Chen Gang
2013-06-05 0:54 ` [PATCH v3] include/linux/skbuff.h: using '(__u16) " Chen Gang
2013-06-05 8:36 ` David Miller
2013-06-05 11:15 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VfWvXkaoYQ_40idSsLYUA=YqaswnV2y-hODHjt7JMHQvQ@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gang.chen@asianux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.