Re: [PATCH 01/15] sparc,leon: Convert to use devm_ioremap_resource

From: Tushar Behera <tushar.behera@linaro.org>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-kernel@vger.kernel.org, thierry.reding@gmail.com,
	patches@linaro.org, sparclinux@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 01/15] sparc,leon: Convert to use devm_ioremap_resource
Date: Tue, 11 Jun 2013 08:37:23 +0530	[thread overview]
Message-ID: <51B6946B.4050803@linaro.org> (raw)
In-Reply-To: <CAK9yfHyndkfDV6K4brkk06BHQAW=v-gpDw5w+dRqGrKhQ0yuFA@mail.gmail.com>

On 06/10/2013 05:33 PM, Sachin Kamat wrote:
> On 10 June 2013 17:04, Tushar Behera <tushar.behera@linaro.org> wrote:
>> Commit 75096579c3ac ("lib: devres: Introduce devm_ioremap_resource()")
>> introduced devm_ioremap_resource() and deprecated the use of
>> devm_request_and_ioremap().
>>
>> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
>> CC: sparclinux@vger.kernel.org
>> CC: "David S. Miller" <davem@davemloft.net>
>> ---
>> * Not compile tested.
>>  arch/sparc/kernel/leon_pci_grpci1.c |    6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/sparc/kernel/leon_pci_grpci1.c b/arch/sparc/kernel/leon_pci_grpci1.c
>> index 7739a54..23497f4 100644
>> --- a/arch/sparc/kernel/leon_pci_grpci1.c
>> +++ b/arch/sparc/kernel/leon_pci_grpci1.c
>> @@ -536,10 +536,10 @@ static int grpci1_of_probe(struct platform_device *ofdev)
>>
>>         /* find device register base address */
>>         res = platform_get_resource(ofdev, IORESOURCE_MEM, 0);
>> -       regs = devm_request_and_ioremap(&ofdev->dev, res);
>> -       if (!regs) {
>> +       regs = devm_ioremap_resource(&ofdev->dev, res);
>> +       if (IS_ERR(regs)) {
>>                 dev_err(&ofdev->dev, "io-regs mapping failed\n");
> 
> You may remove the above error message as devm_ioremap_resource prints
> its own error messages.
> 

Ok. I will remove the error message. I will do the same for other
instances too.

Thanks.

-- 
Tushar Behera