All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: Removing pdma for SSDK5440
@ 2013-06-11  8:02 ` Kukjin Kim
  0 siblings, 0 replies; 6+ messages in thread
From: Kukjin Kim @ 2013-06-11  8:02 UTC (permalink / raw)
  To: linux-arm-kernel, linux-samsung-soc; +Cc: 'Giridhar Maruthy'

From: Giridhar Maruthy <giridhar.m@samsung.com>

Since the pdma works only in secure mode, accessing the same
in hypervisor mode gives an abort. As we are not using pdma
anywhere (including spi), removing the same.

Signed-off-by: Giridhar Maruthy <giridhar.m@samsung.com>
Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
---
 arch/arm/boot/dts/exynos5440.dtsi |   24 ------------------------
 1 file changed, 24 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5440.dtsi b/arch/arm/boot/dts/exynos5440.dtsi
index 871ebad..b08449e 100644
--- a/arch/arm/boot/dts/exynos5440.dtsi
+++ b/arch/arm/boot/dts/exynos5440.dtsi
@@ -105,8 +105,6 @@
 		compatible = "samsung,exynos4210-spi";
 		reg = <0xD0000 0x1000>;
 		interrupts = <0 4 0>;
-		tx-dma-channel = <&pdma0 5>; /* preliminary */
-		rx-dma-channel = <&pdma0 4>; /* preliminary */
 		#address-cells = <1>;
 		#size-cells = <0>;
 		clocks = <&clock 21>, <&clock 16>;
@@ -184,28 +182,6 @@
 		compatible = "arm,amba-bus";
 		interrupt-parent = <&gic>;
 		ranges;
-
-		pdma0: pdma@00121000 {
-			compatible = "arm,pl330", "arm,primecell";
-			reg = <0x121000 0x1000>;
-			interrupts = <0 46 0>;
-			clocks = <&clock 8>;
-			clock-names = "apb_pclk";
-			#dma-cells = <1>;
-			#dma-channels = <8>;
-			#dma-requests = <32>;
-		};
-
-		pdma1: pdma@00120000 {
-			compatible = "arm,pl330", "arm,primecell";
-			reg = <0x120000 0x1000>;
-			interrupts = <0 47 0>;
-			clocks = <&clock 8>;
-			clock-names = "apb_pclk";
-			#dma-cells = <1>;
-			#dma-channels = <8>;
-			#dma-requests = <32>;
-		};
 	};
 
 	rtc {
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] ARM: dts: Removing pdma for SSDK5440
@ 2013-06-11  8:02 ` Kukjin Kim
  0 siblings, 0 replies; 6+ messages in thread
From: Kukjin Kim @ 2013-06-11  8:02 UTC (permalink / raw)
  To: linux-arm-kernel

From: Giridhar Maruthy <giridhar.m@samsung.com>

Since the pdma works only in secure mode, accessing the same
in hypervisor mode gives an abort. As we are not using pdma
anywhere (including spi), removing the same.

Signed-off-by: Giridhar Maruthy <giridhar.m@samsung.com>
Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
---
 arch/arm/boot/dts/exynos5440.dtsi |   24 ------------------------
 1 file changed, 24 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5440.dtsi b/arch/arm/boot/dts/exynos5440.dtsi
index 871ebad..b08449e 100644
--- a/arch/arm/boot/dts/exynos5440.dtsi
+++ b/arch/arm/boot/dts/exynos5440.dtsi
@@ -105,8 +105,6 @@
 		compatible = "samsung,exynos4210-spi";
 		reg = <0xD0000 0x1000>;
 		interrupts = <0 4 0>;
-		tx-dma-channel = <&pdma0 5>; /* preliminary */
-		rx-dma-channel = <&pdma0 4>; /* preliminary */
 		#address-cells = <1>;
 		#size-cells = <0>;
 		clocks = <&clock 21>, <&clock 16>;
@@ -184,28 +182,6 @@
 		compatible = "arm,amba-bus";
 		interrupt-parent = <&gic>;
 		ranges;
-
-		pdma0: pdma at 00121000 {
-			compatible = "arm,pl330", "arm,primecell";
-			reg = <0x121000 0x1000>;
-			interrupts = <0 46 0>;
-			clocks = <&clock 8>;
-			clock-names = "apb_pclk";
-			#dma-cells = <1>;
-			#dma-channels = <8>;
-			#dma-requests = <32>;
-		};
-
-		pdma1: pdma at 00120000 {
-			compatible = "arm,pl330", "arm,primecell";
-			reg = <0x120000 0x1000>;
-			interrupts = <0 47 0>;
-			clocks = <&clock 8>;
-			clock-names = "apb_pclk";
-			#dma-cells = <1>;
-			#dma-channels = <8>;
-			#dma-requests = <32>;
-		};
 	};
 
 	rtc {
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: Removing pdma for SSDK5440
  2013-06-11  8:02 ` Kukjin Kim
@ 2013-06-11  8:49   ` Sylwester Nawrocki
  -1 siblings, 0 replies; 6+ messages in thread
From: Sylwester Nawrocki @ 2013-06-11  8:49 UTC (permalink / raw)
  To: Kukjin Kim
  Cc: linux-arm-kernel, linux-samsung-soc, 'Giridhar Maruthy'

On 06/11/2013 10:02 AM, Kukjin Kim wrote:
> From: Giridhar Maruthy <giridhar.m@samsung.com>
> 
> Since the pdma works only in secure mode, accessing the same
> in hypervisor mode gives an abort. As we are not using pdma
> anywhere (including spi), removing the same.
> 
> Signed-off-by: Giridhar Maruthy <giridhar.m@samsung.com>
> Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>

I was wondering, wouldn't it be sufficient to add status = "disabled";
in those pdma nodes, to avoid re-adding them in future ?
As for the DMA properties in the spi device nodes, they should indeed
be removed, as generic DMA bindings would be used instead.

Regards,
Sylwester
> ---
>  arch/arm/boot/dts/exynos5440.dtsi |   24 ------------------------
>  1 file changed, 24 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos5440.dtsi b/arch/arm/boot/dts/exynos5440.dtsi
> index 871ebad..b08449e 100644
> --- a/arch/arm/boot/dts/exynos5440.dtsi
> +++ b/arch/arm/boot/dts/exynos5440.dtsi
> @@ -105,8 +105,6 @@
>  		compatible = "samsung,exynos4210-spi";Hmm, is there really no way to use PDMA in non-secure mode at all ?
>  		reg = <0xD0000 0x1000>;
>  		interrupts = <0 4 0>;
> -		tx-dma-channel = <&pdma0 5>; /* preliminary */
> -		rx-dma-channel = <&pdma0 4>; /* preliminary */
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  		clocks = <&clock 21>, <&clock 16>;
> @@ -184,28 +182,6 @@
>  		compatible = "arm,amba-bus";
>  		interrupt-parent = <&gic>;
>  		ranges;
> -
> -		pdma0: pdma@00121000 {
> -			compatible = "arm,pl330", "arm,primecell";
> -			reg = <0x121000 0x1000>;
> -			interrupts = <0 46 0>;
> -			clocks = <&clock 8>;
> -			clock-names = "apb_pclk";
> -			#dma-cells = <1>;
> -			#dma-channels = <8>;
> -			#dma-requests = <32>;
> -		};
> -
> -		pdma1: pdma@00120000 {
> -			compatible = "arm,pl330", "arm,primecell";
> -			reg = <0x120000 0x1000>;
> -			interrupts = <0 47 0>;
> -			clocks = <&clock 8>;
> -			clock-names = "apb_pclk";
> -			#dma-cells = <1>;
> -			#dma-channels = <8>;
> -			#dma-requests = <32>;
> -		};
>  	};

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] ARM: dts: Removing pdma for SSDK5440
@ 2013-06-11  8:49   ` Sylwester Nawrocki
  0 siblings, 0 replies; 6+ messages in thread
From: Sylwester Nawrocki @ 2013-06-11  8:49 UTC (permalink / raw)
  To: linux-arm-kernel

On 06/11/2013 10:02 AM, Kukjin Kim wrote:
> From: Giridhar Maruthy <giridhar.m@samsung.com>
> 
> Since the pdma works only in secure mode, accessing the same
> in hypervisor mode gives an abort. As we are not using pdma
> anywhere (including spi), removing the same.
> 
> Signed-off-by: Giridhar Maruthy <giridhar.m@samsung.com>
> Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>

I was wondering, wouldn't it be sufficient to add status = "disabled";
in those pdma nodes, to avoid re-adding them in future ?
As for the DMA properties in the spi device nodes, they should indeed
be removed, as generic DMA bindings would be used instead.

Regards,
Sylwester
> ---
>  arch/arm/boot/dts/exynos5440.dtsi |   24 ------------------------
>  1 file changed, 24 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos5440.dtsi b/arch/arm/boot/dts/exynos5440.dtsi
> index 871ebad..b08449e 100644
> --- a/arch/arm/boot/dts/exynos5440.dtsi
> +++ b/arch/arm/boot/dts/exynos5440.dtsi
> @@ -105,8 +105,6 @@
>  		compatible = "samsung,exynos4210-spi";Hmm, is there really no way to use PDMA in non-secure mode at all ?
>  		reg = <0xD0000 0x1000>;
>  		interrupts = <0 4 0>;
> -		tx-dma-channel = <&pdma0 5>; /* preliminary */
> -		rx-dma-channel = <&pdma0 4>; /* preliminary */
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  		clocks = <&clock 21>, <&clock 16>;
> @@ -184,28 +182,6 @@
>  		compatible = "arm,amba-bus";
>  		interrupt-parent = <&gic>;
>  		ranges;
> -
> -		pdma0: pdma at 00121000 {
> -			compatible = "arm,pl330", "arm,primecell";
> -			reg = <0x121000 0x1000>;
> -			interrupts = <0 46 0>;
> -			clocks = <&clock 8>;
> -			clock-names = "apb_pclk";
> -			#dma-cells = <1>;
> -			#dma-channels = <8>;
> -			#dma-requests = <32>;
> -		};
> -
> -		pdma1: pdma at 00120000 {
> -			compatible = "arm,pl330", "arm,primecell";
> -			reg = <0x120000 0x1000>;
> -			interrupts = <0 47 0>;
> -			clocks = <&clock 8>;
> -			clock-names = "apb_pclk";
> -			#dma-cells = <1>;
> -			#dma-channels = <8>;
> -			#dma-requests = <32>;
> -		};
>  	};

^ permalink raw reply	[flat|nested] 6+ messages in thread
* RE: [PATCH] ARM: dts: Removing pdma for SSDK5440
  2013-06-11  8:49   ` Sylwester Nawrocki
@ 2013-06-11 10:18     ` Kukjin Kim
  -1 siblings, 0 replies; 6+ messages in thread
From: Kukjin Kim @ 2013-06-11 10:18 UTC (permalink / raw)
  To: 'Sylwester Nawrocki'
  Cc: linux-arm-kernel, linux-samsung-soc, 'Giridhar Maruthy'

Sylwester Nawrocki wrote:
> 
Hi Sylwester,

> On 06/11/2013 10:02 AM, Kukjin Kim wrote:
> > From: Giridhar Maruthy <giridhar.m@samsung.com>
> >
> > Since the pdma works only in secure mode, accessing the same
> > in hypervisor mode gives an abort. As we are not using pdma
> > anywhere (including spi), removing the same.
> >
> > Signed-off-by: Giridhar Maruthy <giridhar.m@samsung.com>
> > Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> 
> I was wondering, wouldn't it be sufficient to add status = "disabled";
> in those pdma nodes, to avoid re-adding them in future ?

Yeah, could be. But the pdma will not be used on exynos5440 in future and if
some guy use it in non-secure mode, it will cause problem, so I want to
remove that.

> As for the DMA properties in the spi device nodes, they should indeed
> be removed, as generic DMA bindings would be used instead.
> 
Yes, agreed. So I'd prefer to remove that :-)

Thanks,
Kukjin

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] ARM: dts: Removing pdma for SSDK5440
@ 2013-06-11 10:18     ` Kukjin Kim
  0 siblings, 0 replies; 6+ messages in thread
From: Kukjin Kim @ 2013-06-11 10:18 UTC (permalink / raw)
  To: linux-arm-kernel

Sylwester Nawrocki wrote:
> 
Hi Sylwester,

> On 06/11/2013 10:02 AM, Kukjin Kim wrote:
> > From: Giridhar Maruthy <giridhar.m@samsung.com>
> >
> > Since the pdma works only in secure mode, accessing the same
> > in hypervisor mode gives an abort. As we are not using pdma
> > anywhere (including spi), removing the same.
> >
> > Signed-off-by: Giridhar Maruthy <giridhar.m@samsung.com>
> > Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> 
> I was wondering, wouldn't it be sufficient to add status = "disabled";
> in those pdma nodes, to avoid re-adding them in future ?

Yeah, could be. But the pdma will not be used on exynos5440 in future and if
some guy use it in non-secure mode, it will cause problem, so I want to
remove that.

> As for the DMA properties in the spi device nodes, they should indeed
> be removed, as generic DMA bindings would be used instead.
> 
Yes, agreed. So I'd prefer to remove that :-)

Thanks,
Kukjin

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-06-11 10:18 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-11  8:02 [PATCH] ARM: dts: Removing pdma for SSDK5440 Kukjin Kim
2013-06-11  8:02 ` Kukjin Kim
2013-06-11  8:49 ` Sylwester Nawrocki
2013-06-11  8:49   ` Sylwester Nawrocki
2013-06-11 10:18   ` Kukjin Kim
2013-06-11 10:18     ` Kukjin Kim

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.