From: konrad wilk <konrad.wilk@oracle.com>
To: "Roger Pau Monné" <roger.pau@citrix.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>,
Keir Fraser <keir@xen.org>, Jan Beulich <JBeulich@suse.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH] xen: fix initialization of wallclock time for PVHVM on migration
Date: Tue, 11 Jun 2013 09:15:52 -0400 [thread overview]
Message-ID: <51B72308.60908@oracle.com> (raw)
In-Reply-To: <51B71576.1080009@citrix.com>
On 6/11/2013 8:17 AM, Roger Pau Monné wrote:
> On 11/06/13 13:59, Jan Beulich wrote:
>>>>> On 11.06.13 at 12:46, Roger Pau Monne <roger.pau@citrix.com> wrote:
>>> The initial values of the wallclock time in the shared info page are
>>> set for PVHVM guests when the hypercall page is initialized, since the
>>> hypercall page is not reinitialized on resume, the hypervisor
>>> wallclock time is not properly set on resume.
>>>
>>> Fix it by forcing an update of the wallclock values when the shared
>>> info page is mapped.
>> NACK - this is a guest side bug. After migration, a guest _has_ to
>> re-init the hypercall page, as it may have got migrated between
>> a VMX and an SVM machine, and the hypercall instructions are
>> different between them.
> AFAICS Linux doesn't seem to re-init the hypercall page, see
> xen_arch_hvm_post_suspend at arch/x86/xen/suspend.c, but maybe I'm
> missing something.
You are right. It does not re-init. It is the first time I heard that it
has to re-init too.
In the past some steps were taken towards re-initing the shared page -
that (on PVHVM) flat out died during migration (32-bit). Never figured
out why and Olaf didn't have the time to dig in this.
(git commit 9d02b43dee0d7fb18dfb13a00915550b1a3daa9f).
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2013-06-11 13:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-11 10:46 [PATCH] xen: fix initialization of wallclock time for PVHVM on migration Roger Pau Monne
2013-06-11 11:59 ` Jan Beulich
2013-06-11 12:01 ` George Dunlap
2013-06-11 12:12 ` Jan Beulich
2013-06-11 13:59 ` Ian Campbell
2013-06-11 14:04 ` Jan Beulich
2013-06-12 13:36 ` Egger, Christoph
2013-06-11 12:17 ` Roger Pau Monné
2013-06-11 13:15 ` konrad wilk [this message]
2013-06-11 14:02 ` Jan Beulich
2013-06-11 13:38 ` Roger Pau Monné
2013-06-11 14:16 ` Jan Beulich
2013-06-11 14:41 ` Konrad Rzeszutek Wilk
2013-06-11 15:05 ` Keir Fraser
2013-06-11 15:45 ` Keir Fraser
2013-06-11 15:59 ` Roger Pau Monné
2013-06-11 16:12 ` Keir Fraser
2013-06-11 16:14 ` Roger Pau Monné
2013-06-11 15:59 ` Jan Beulich
2013-06-12 13:50 ` Konrad Rzeszutek Wilk
2013-06-12 13:55 ` Roger Pau Monné
2013-06-11 15:50 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B72308.60908@oracle.com \
--to=konrad.wilk@oracle.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.