From: Florian Vaussard <florian.vaussard@epfl.ch> To: Javier Martinez Canillas <javier.martinez@collabora.co.uk> Cc: Benoit Cousson <b-cousson@ti.com>, Tony Lindgren <tony@atomide.com>, Stephen Warren <swarren@wwwdotorg.org>, Anil Kumar <anilk4.v@gmail.com>, linux-omap@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 3/3] ARM: dts: OMAP3: Use MTD constants for OMAP3 boards Date: Tue, 11 Jun 2013 19:30:22 +0200 [thread overview] Message-ID: <51B75EAE.6070405@epfl.ch> (raw) In-Reply-To: <51B74267.1000700@collabora.co.uk> Hello Javier, On 06/11/2013 05:29 PM, Javier Martinez Canillas wrote: > On 06/11/2013 04:48 PM, Florian Vaussard wrote: >> Use the MTD constants for NAND and OneNAND nodes used in OMAP3 >> DTS. >> >> Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch> >> --- >> arch/arm/boot/dts/omap3-devkit8000.dts | 10 +++++----- >> arch/arm/boot/dts/omap3-igep0020.dts | 10 +++++----- >> arch/arm/boot/dts/omap3-igep0030.dts | 10 +++++----- >> arch/arm/boot/dts/omap3430-sdp.dts | 28 ++++++++++++++-------------- >> 4 files changed, 29 insertions(+), 29 deletions(-) >> >> diff --git a/arch/arm/boot/dts/omap3-devkit8000.dts b/arch/arm/boot/dts/omap3-devkit8000.dts >> index 5be71b1..08699cb 100644 >> --- a/arch/arm/boot/dts/omap3-devkit8000.dts >> +++ b/arch/arm/boot/dts/omap3-devkit8000.dts >> @@ -143,27 +143,27 @@ >> >> x-loader@0 { >> label = "X-Loader"; >> - reg = <0 0x80000>; >> + reg = <(0 * SZ_128K) (4 * SZ_128K)>; >> }; >> >> bootloaders@80000 { >> label = "U-Boot"; >> - reg = <0x80000 0x1e0000>; >> + reg = <(4 * SZ_128K) (15 * SZ_128K)>; >> }; >> >> bootloaders_env@260000 { >> label = "U-Boot Env"; >> - reg = <0x260000 0x20000>; >> + reg = <(19 * SZ_128K) (1 * SZ_128K)>; >> }; >> >> kernel@280000 { >> label = "Kernel"; >> - reg = <0x280000 0x400000>; >> + reg = <(20 * SZ_128K) (32 * SZ_128K)>; >> }; >> >> filesystem@680000 { >> label = "File System"; >> - reg = <0x680000 0xf980000>; >> + reg = <(52 * SZ_128K) MTDPART_SIZ_FULL>; >> }; >> }; >> }; >> diff --git a/arch/arm/boot/dts/omap3-igep0020.dts b/arch/arm/boot/dts/omap3-igep0020.dts >> index e8c4828..3476b3c 100644 >> --- a/arch/arm/boot/dts/omap3-igep0020.dts >> +++ b/arch/arm/boot/dts/omap3-igep0020.dts >> @@ -97,23 +97,23 @@ >> >> partition@0 { >> label = "SPL"; >> - reg = <0 0x100000>; >> + reg = <(0 * SZ_256K) (4 * SZ_256K)>; >> }; >> partition@0x80000 { >> label = "U-Boot"; >> - reg = <0x100000 0x180000>; >> + reg = <(4 * SZ_256K) (6 * SZ_256K)>; >> }; >> partition@0x1c0000 { >> label = "Environment"; >> - reg = <0x280000 0x100000>; >> + reg = <(10 * SZ_256K) (4 * SZ_256K)>; >> }; >> partition@0x280000 { >> label = "Kernel"; >> - reg = <0x380000 0x300000>; >> + reg = <(14 * SZ_256K) (12 * SZ_256K)>; >> }; >> partition@0x780000 { >> label = "Filesystem"; >> - reg = <0x680000 0x1f980000>; >> + reg = <(26 * SZ_256K) MTDPART_SIZ_FULL>; >> }; >> }; >> >> diff --git a/arch/arm/boot/dts/omap3-igep0030.dts b/arch/arm/boot/dts/omap3-igep0030.dts >> index 644d053..e4f078c 100644 >> --- a/arch/arm/boot/dts/omap3-igep0030.dts >> +++ b/arch/arm/boot/dts/omap3-igep0030.dts >> @@ -72,23 +72,23 @@ >> >> partition@0 { >> label = "SPL"; >> - reg = <0 0x100000>; >> + reg = <(0 * SZ_256K) (4 * SZ_256K)>; >> }; >> partition@0x80000 { >> label = "U-Boot"; >> - reg = <0x100000 0x180000>; >> + reg = <(4 * SZ_256K) (6 * SZ_256K)>; >> }; >> partition@0x1c0000 { >> label = "Environment"; >> - reg = <0x280000 0x100000>; >> + reg = <(10 * SZ_256K) (4 * SZ_256K)>; >> }; >> partition@0x280000 { >> label = "Kernel"; >> - reg = <0x380000 0x300000>; >> + reg = <(14 * SZ_256K) (12 * SZ_256K)>; >> }; >> partition@0x780000 { >> label = "Filesystem"; >> - reg = <0x680000 0x1f980000>; >> + reg = <(26 * SZ_256K) MTDPART_SIZ_FULL>; >> }; >> }; >> }; > > Hi Florian, > > I don't have access to my IGEP board so I can test it right now but the patch > looks good to me. > > In fact I wanted to use MTDPART_SIZ_FULL when added the NAND nodes since not all > IGEP boards have 512MB flash but I didn't know that a value of 0 meant that. > I had the same problem, and found that 0 was correctly parsed and later expanded to the correct value when probing the NAND. > So thanks a lot for doing this! > > Acked-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> > Thank you. Florian
WARNING: multiple messages have this Message-ID (diff)
From: florian.vaussard@epfl.ch (Florian Vaussard) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 3/3] ARM: dts: OMAP3: Use MTD constants for OMAP3 boards Date: Tue, 11 Jun 2013 19:30:22 +0200 [thread overview] Message-ID: <51B75EAE.6070405@epfl.ch> (raw) In-Reply-To: <51B74267.1000700@collabora.co.uk> Hello Javier, On 06/11/2013 05:29 PM, Javier Martinez Canillas wrote: > On 06/11/2013 04:48 PM, Florian Vaussard wrote: >> Use the MTD constants for NAND and OneNAND nodes used in OMAP3 >> DTS. >> >> Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch> >> --- >> arch/arm/boot/dts/omap3-devkit8000.dts | 10 +++++----- >> arch/arm/boot/dts/omap3-igep0020.dts | 10 +++++----- >> arch/arm/boot/dts/omap3-igep0030.dts | 10 +++++----- >> arch/arm/boot/dts/omap3430-sdp.dts | 28 ++++++++++++++-------------- >> 4 files changed, 29 insertions(+), 29 deletions(-) >> >> diff --git a/arch/arm/boot/dts/omap3-devkit8000.dts b/arch/arm/boot/dts/omap3-devkit8000.dts >> index 5be71b1..08699cb 100644 >> --- a/arch/arm/boot/dts/omap3-devkit8000.dts >> +++ b/arch/arm/boot/dts/omap3-devkit8000.dts >> @@ -143,27 +143,27 @@ >> >> x-loader at 0 { >> label = "X-Loader"; >> - reg = <0 0x80000>; >> + reg = <(0 * SZ_128K) (4 * SZ_128K)>; >> }; >> >> bootloaders at 80000 { >> label = "U-Boot"; >> - reg = <0x80000 0x1e0000>; >> + reg = <(4 * SZ_128K) (15 * SZ_128K)>; >> }; >> >> bootloaders_env at 260000 { >> label = "U-Boot Env"; >> - reg = <0x260000 0x20000>; >> + reg = <(19 * SZ_128K) (1 * SZ_128K)>; >> }; >> >> kernel at 280000 { >> label = "Kernel"; >> - reg = <0x280000 0x400000>; >> + reg = <(20 * SZ_128K) (32 * SZ_128K)>; >> }; >> >> filesystem at 680000 { >> label = "File System"; >> - reg = <0x680000 0xf980000>; >> + reg = <(52 * SZ_128K) MTDPART_SIZ_FULL>; >> }; >> }; >> }; >> diff --git a/arch/arm/boot/dts/omap3-igep0020.dts b/arch/arm/boot/dts/omap3-igep0020.dts >> index e8c4828..3476b3c 100644 >> --- a/arch/arm/boot/dts/omap3-igep0020.dts >> +++ b/arch/arm/boot/dts/omap3-igep0020.dts >> @@ -97,23 +97,23 @@ >> >> partition at 0 { >> label = "SPL"; >> - reg = <0 0x100000>; >> + reg = <(0 * SZ_256K) (4 * SZ_256K)>; >> }; >> partition at 0x80000 { >> label = "U-Boot"; >> - reg = <0x100000 0x180000>; >> + reg = <(4 * SZ_256K) (6 * SZ_256K)>; >> }; >> partition at 0x1c0000 { >> label = "Environment"; >> - reg = <0x280000 0x100000>; >> + reg = <(10 * SZ_256K) (4 * SZ_256K)>; >> }; >> partition at 0x280000 { >> label = "Kernel"; >> - reg = <0x380000 0x300000>; >> + reg = <(14 * SZ_256K) (12 * SZ_256K)>; >> }; >> partition at 0x780000 { >> label = "Filesystem"; >> - reg = <0x680000 0x1f980000>; >> + reg = <(26 * SZ_256K) MTDPART_SIZ_FULL>; >> }; >> }; >> >> diff --git a/arch/arm/boot/dts/omap3-igep0030.dts b/arch/arm/boot/dts/omap3-igep0030.dts >> index 644d053..e4f078c 100644 >> --- a/arch/arm/boot/dts/omap3-igep0030.dts >> +++ b/arch/arm/boot/dts/omap3-igep0030.dts >> @@ -72,23 +72,23 @@ >> >> partition at 0 { >> label = "SPL"; >> - reg = <0 0x100000>; >> + reg = <(0 * SZ_256K) (4 * SZ_256K)>; >> }; >> partition at 0x80000 { >> label = "U-Boot"; >> - reg = <0x100000 0x180000>; >> + reg = <(4 * SZ_256K) (6 * SZ_256K)>; >> }; >> partition at 0x1c0000 { >> label = "Environment"; >> - reg = <0x280000 0x100000>; >> + reg = <(10 * SZ_256K) (4 * SZ_256K)>; >> }; >> partition at 0x280000 { >> label = "Kernel"; >> - reg = <0x380000 0x300000>; >> + reg = <(14 * SZ_256K) (12 * SZ_256K)>; >> }; >> partition at 0x780000 { >> label = "Filesystem"; >> - reg = <0x680000 0x1f980000>; >> + reg = <(26 * SZ_256K) MTDPART_SIZ_FULL>; >> }; >> }; >> }; > > Hi Florian, > > I don't have access to my IGEP board so I can test it right now but the patch > looks good to me. > > In fact I wanted to use MTDPART_SIZ_FULL when added the NAND nodes since not all > IGEP boards have 512MB flash but I didn't know that a value of 0 meant that. > I had the same problem, and found that 0 was correctly parsed and later expanded to the correct value when probing the NAND. > So thanks a lot for doing this! > > Acked-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> > Thank you. Florian
next prev parent reply other threads:[~2013-06-11 17:30 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-06-11 14:48 [PATCH 0/3] ARM: dts: OMAP3: Use constants with MTD devices Florian Vaussard 2013-06-11 14:48 ` Florian Vaussard 2013-06-11 14:48 ` [PATCH 1/3] ARM: dts: Add headers with constants for MTD partitions Florian Vaussard 2013-06-11 14:48 ` Florian Vaussard 2013-06-11 16:24 ` Stephen Warren 2013-06-11 16:24 ` Stephen Warren 2013-06-11 17:28 ` Florian Vaussard 2013-06-11 17:28 ` Florian Vaussard 2013-06-12 13:05 ` Grant Likely 2013-06-12 13:05 ` Grant Likely 2013-06-19 9:19 ` Florian Vaussard 2013-06-19 9:19 ` Florian Vaussard 2013-06-11 14:48 ` [PATCH 2/3] ARM: dts: Add omap3-overo NAND flash memory binding Florian Vaussard 2013-06-11 14:48 ` Florian Vaussard 2013-06-11 14:48 ` [PATCH 3/3] ARM: dts: OMAP3: Use MTD constants for OMAP3 boards Florian Vaussard 2013-06-11 14:48 ` Florian Vaussard 2013-06-11 15:29 ` Javier Martinez Canillas 2013-06-11 15:29 ` Javier Martinez Canillas 2013-06-11 17:30 ` Florian Vaussard [this message] 2013-06-11 17:30 ` Florian Vaussard 2013-06-12 13:11 ` Grant Likely 2013-06-12 13:11 ` Grant Likely 2013-06-11 16:27 ` Stephen Warren 2013-06-11 16:27 ` Stephen Warren 2013-06-11 17:31 ` Florian Vaussard 2013-06-11 17:31 ` Florian Vaussard
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=51B75EAE.6070405@epfl.ch \ --to=florian.vaussard@epfl.ch \ --cc=anilk4.v@gmail.com \ --cc=b-cousson@ti.com \ --cc=devicetree-discuss@lists.ozlabs.org \ --cc=javier.martinez@collabora.co.uk \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-omap@vger.kernel.org \ --cc=swarren@wwwdotorg.org \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.