All of lore.kernel.org
 help / color / mirror / Atom feed
From: Timur Tabi <timur@tabi.org>
To: Oded Gabbay <ogabbay@advaoptical.com>,
	benh@kernel.crashing.org, paulus@samba.org, leoli@freescale.com,
	galak@kernel.crashing.org, B38951@freescale.com,
	Dongsheng.Wang@freescale.com, bigeasy@linutronix.de,
	stef.van.os@prodrive.nl, davem@davemloft.net
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org
Subject: Re: [PATCH] MDIO: FSL_PQ_MDIO: Fix bug on incorrect offset of tbipa register
Date: Wed, 12 Jun 2013 08:04:11 -0500	[thread overview]
Message-ID: <51B871CB.1090808@tabi.org> (raw)
In-Reply-To: <1371041258-15298-1-git-send-email-ogabbay@advaoptical.com>

Oded Gabbay wrote:
> Note: This patch may break MDIO functionallity of some old Freescale's SoC
> until Freescale will fix their device tree files. Basically, every device tree
> which contains an mdio device that is compatible to "fsl,gianfar-tbi" should be
> examined.

I haven't had a chance to review the patch in detail, but I can tell you 
that breaking compatibility with older device trees is unacceptable.  You 
need to add some code, even if it's an ugly hack, to support those trees.

-- 
Timur Tabi

WARNING: multiple messages have this Message-ID (diff)
From: Timur Tabi <timur@tabi.org>
To: Oded Gabbay <ogabbay@advaoptical.com>,
	benh@kernel.crashing.org, paulus@samba.org, leoli@freescale.com,
	galak@kernel.crashing.org, B38951@freescale.com,
	Dongsheng.Wang@freescale.com, bigeasy@linutronix.de,
	stef.van.os@prodrive.nl, davem@davemloft.net
Cc: netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MDIO: FSL_PQ_MDIO: Fix bug on incorrect offset of tbipa register
Date: Wed, 12 Jun 2013 08:04:11 -0500	[thread overview]
Message-ID: <51B871CB.1090808@tabi.org> (raw)
In-Reply-To: <1371041258-15298-1-git-send-email-ogabbay@advaoptical.com>

Oded Gabbay wrote:
> Note: This patch may break MDIO functionallity of some old Freescale's SoC
> until Freescale will fix their device tree files. Basically, every device tree
> which contains an mdio device that is compatible to "fsl,gianfar-tbi" should be
> examined.

I haven't had a chance to review the patch in detail, but I can tell you 
that breaking compatibility with older device trees is unacceptable.  You 
need to add some code, even if it's an ugly hack, to support those trees.

-- 
Timur Tabi

  reply	other threads:[~2013-06-12 13:04 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-12 12:47 [PATCH] MDIO: FSL_PQ_MDIO: Fix bug on incorrect offset of tbipa register Oded Gabbay
2013-06-12 12:47 ` Oded Gabbay
2013-06-12 13:04 ` Timur Tabi [this message]
2013-06-12 13:04   ` Timur Tabi
2013-06-12 13:09   ` Oded Gabbay
2013-06-12 13:09     ` Oded Gabbay
2013-06-12 15:08 ` Sebastian Andrzej Siewior
2013-06-12 15:08   ` Sebastian Andrzej Siewior
2013-06-12 18:31   ` Scott Wood
2013-06-12 18:31     ` Scott Wood
2013-06-13  6:44     ` Oded Gabbay
2013-06-13  6:44       ` Oded Gabbay
2013-06-15 22:57     ` Timur Tabi
2013-06-15 22:57       ` Timur Tabi
2015-10-09 15:15 ` [PATCH 1/2] net/fsl_pq_mdio: check TBI address for consistency with mapped range Gerlando Falauto
2015-10-09 15:15   ` [PATCH 2/2] net/fsl_pq_mdio: fix computed address for the TBI register Gerlando Falauto
2015-10-09 17:39   ` [PATCH 1/2] net/fsl_pq_mdio: check TBI address for consistency with mapped range kbuild test robot
2015-10-11 12:41   ` Timur Tabi
2015-10-12  7:18 ` [PATCH v2 " Gerlando Falauto
2015-10-12  7:18   ` Gerlando Falauto
2015-10-12  7:18   ` [PATCH v2 2/2] net/fsl_pq_mdio: fix computed address for the TBI register Gerlando Falauto
2015-10-12  7:18     ` Gerlando Falauto
2015-10-13 11:30     ` David Miller
2015-10-13 11:30   ` [PATCH v2 1/2] net/fsl_pq_mdio: check TBI address for consistency with mapped range David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51B871CB.1090808@tabi.org \
    --to=timur@tabi.org \
    --cc=B38951@freescale.com \
    --cc=Dongsheng.Wang@freescale.com \
    --cc=benh@kernel.crashing.org \
    --cc=bigeasy@linutronix.de \
    --cc=davem@davemloft.net \
    --cc=galak@kernel.crashing.org \
    --cc=leoli@freescale.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=netdev@vger.kernel.org \
    --cc=ogabbay@advaoptical.com \
    --cc=paulus@samba.org \
    --cc=stef.van.os@prodrive.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.