* [PATCH net-next] net: sh_eth: fix incorrect RX length error if R8A7740
@ 2013-06-12 1:33 ` Shimoda, Yoshihiro
0 siblings, 0 replies; 14+ messages in thread
From: Shimoda, Yoshihiro @ 2013-06-12 1:33 UTC (permalink / raw)
To: netdev; +Cc: SH-Linux, Sergei Shtylyov
This patch fixes an issue that the driver increments the "RX length error"
on every buffer in sh_eth_rx() if the R8A7740.
This patch also adds a description about the Receive Frame Status bits.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
This patch is based on the latest net-next.git.
drivers/net/ethernet/renesas/sh_eth.c | 15 +++++++++++----
1 files changed, 11 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
index 43d8490..ab2f9c2 100644
--- a/drivers/net/ethernet/renesas/sh_eth.c
+++ b/drivers/net/ethernet/renesas/sh_eth.c
@@ -1260,16 +1260,23 @@ static int sh_eth_rx(struct net_device *ndev, u32 intr_status)
desc_status = edmac_to_cpu(mdp, rxdesc->status);
pkt_len = rxdesc->frame_length;
-#if defined(CONFIG_ARCH_R8A7740)
- desc_status >>= 16;
-#endif
-
if (--boguscnt < 0)
break;
if (!(desc_status & RDFEND))
ndev->stats.rx_length_errors++;
+#if defined(CONFIG_ARCH_R8A7740)
+ /*
+ * In case of almost GETHER/ETHERs, the Receive Frame State
+ * (RFS) bits in the Receive Descriptor 0 are from bit 9 to
+ * bit 0. However, in case of the R8A7740's GETHER, the RFS
+ * bits are from bit 25 to bit 16. So, the driver needs right
+ * shifting by 16.
+ */
+ desc_status >>= 16;
+#endif
+
if (desc_status & (RD_RFS1 | RD_RFS2 | RD_RFS3 | RD_RFS4 |
RD_RFS5 | RD_RFS6 | RD_RFS10)) {
ndev->stats.rx_errors++;
--
1.7.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH net-next] net: sh_eth: fix incorrect RX length error if R8A7740
@ 2013-06-12 1:33 ` Shimoda, Yoshihiro
0 siblings, 0 replies; 14+ messages in thread
From: Shimoda, Yoshihiro @ 2013-06-12 1:33 UTC (permalink / raw)
To: netdev; +Cc: SH-Linux, Sergei Shtylyov
This patch fixes an issue that the driver increments the "RX length error"
on every buffer in sh_eth_rx() if the R8A7740.
This patch also adds a description about the Receive Frame Status bits.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
This patch is based on the latest net-next.git.
drivers/net/ethernet/renesas/sh_eth.c | 15 +++++++++++----
1 files changed, 11 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
index 43d8490..ab2f9c2 100644
--- a/drivers/net/ethernet/renesas/sh_eth.c
+++ b/drivers/net/ethernet/renesas/sh_eth.c
@@ -1260,16 +1260,23 @@ static int sh_eth_rx(struct net_device *ndev, u32 intr_status)
desc_status = edmac_to_cpu(mdp, rxdesc->status);
pkt_len = rxdesc->frame_length;
-#if defined(CONFIG_ARCH_R8A7740)
- desc_status >>= 16;
-#endif
-
if (--boguscnt < 0)
break;
if (!(desc_status & RDFEND))
ndev->stats.rx_length_errors++;
+#if defined(CONFIG_ARCH_R8A7740)
+ /*
+ * In case of almost GETHER/ETHERs, the Receive Frame State
+ * (RFS) bits in the Receive Descriptor 0 are from bit 9 to
+ * bit 0. However, in case of the R8A7740's GETHER, the RFS
+ * bits are from bit 25 to bit 16. So, the driver needs right
+ * shifting by 16.
+ */
+ desc_status >>= 16;
+#endif
+
if (desc_status & (RD_RFS1 | RD_RFS2 | RD_RFS3 | RD_RFS4 |
RD_RFS5 | RD_RFS6 | RD_RFS10)) {
ndev->stats.rx_errors++;
--
1.7.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH net-next] net: sh_eth: fix incorrect RX length error if R8A7740
2013-06-12 1:33 ` Shimoda, Yoshihiro
@ 2013-06-12 14:15 ` Sergei Shtylyov
-1 siblings, 0 replies; 14+ messages in thread
From: Sergei Shtylyov @ 2013-06-12 14:15 UTC (permalink / raw)
To: Shimoda, Yoshihiro; +Cc: netdev, SH-Linux
Hello.
On 12-06-2013 5:33, Shimoda, Yoshihiro wrote:
> This patch fixes an issue that the driver increments the "RX length error"
> on every buffer in sh_eth_rx() if the R8A7740.
> This patch also adds a description about the Receive Frame Status bits.
Thank you.
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
> This patch is based on the latest net-next.git.
Since this is a fix, it should have been done against 'net.git'.
WBR, Sergei
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net-next] net: sh_eth: fix incorrect RX length error if R8A7740
@ 2013-06-12 14:15 ` Sergei Shtylyov
0 siblings, 0 replies; 14+ messages in thread
From: Sergei Shtylyov @ 2013-06-12 14:15 UTC (permalink / raw)
To: Shimoda, Yoshihiro; +Cc: netdev, SH-Linux
Hello.
On 12-06-2013 5:33, Shimoda, Yoshihiro wrote:
> This patch fixes an issue that the driver increments the "RX length error"
> on every buffer in sh_eth_rx() if the R8A7740.
> This patch also adds a description about the Receive Frame Status bits.
Thank you.
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
> This patch is based on the latest net-next.git.
Since this is a fix, it should have been done against 'net.git'.
WBR, Sergei
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net-next] net: sh_eth: fix incorrect RX length error if R8A7740
2013-06-12 14:15 ` Sergei Shtylyov
@ 2013-06-12 19:13 ` Sergei Shtylyov
-1 siblings, 0 replies; 14+ messages in thread
From: Sergei Shtylyov @ 2013-06-12 19:13 UTC (permalink / raw)
To: Shimoda, Yoshihiro, David Miller; +Cc: netdev, SH-Linux
Hello.
On 06/12/2013 06:15 PM, Sergei Shtylyov wrote:
>> This patch fixes an issue that the driver increments the "RX length
>> error"
>> on every buffer in sh_eth_rx() if the R8A7740.
>> This patch also adds a description about the Receive Frame Status bits.
> Thank you.
>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>> ---
>> This patch is based on the latest net-next.git.
> Since this is a fix, it should have been done against 'net.git'.
David, this patch applies to the recent net.git repo with offset.
Could you merge it there and also queue for stable?
WBR, Sergei
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net-next] net: sh_eth: fix incorrect RX length error if R8A7740
@ 2013-06-12 19:13 ` Sergei Shtylyov
0 siblings, 0 replies; 14+ messages in thread
From: Sergei Shtylyov @ 2013-06-12 19:13 UTC (permalink / raw)
To: Shimoda, Yoshihiro, David Miller; +Cc: netdev, SH-Linux
Hello.
On 06/12/2013 06:15 PM, Sergei Shtylyov wrote:
>> This patch fixes an issue that the driver increments the "RX length
>> error"
>> on every buffer in sh_eth_rx() if the R8A7740.
>> This patch also adds a description about the Receive Frame Status bits.
> Thank you.
>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>> ---
>> This patch is based on the latest net-next.git.
> Since this is a fix, it should have been done against 'net.git'.
David, this patch applies to the recent net.git repo with offset.
Could you merge it there and also queue for stable?
WBR, Sergei
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net-next] net: sh_eth: fix incorrect RX length error if R8A7740
2013-06-12 1:33 ` Shimoda, Yoshihiro
@ 2013-06-12 19:25 ` Sergei Shtylyov
-1 siblings, 0 replies; 14+ messages in thread
From: Sergei Shtylyov @ 2013-06-12 19:25 UTC (permalink / raw)
To: Shimoda, Yoshihiro; +Cc: netdev, SH-Linux
On 06/12/2013 05:33 AM, Shimoda, Yoshihiro wrote:
> This patch fixes an issue that the driver increments the "RX length error"
> on every buffer in sh_eth_rx() if the R8A7740.
> This patch also adds a description about the Receive Frame Status bits.
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
> This patch is based on the latest net-next.git.
> drivers/net/ethernet/renesas/sh_eth.c | 15 +++++++++++----
> 1 files changed, 11 insertions(+), 4 deletions(-)
> diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
> index 43d8490..ab2f9c2 100644
> --- a/drivers/net/ethernet/renesas/sh_eth.c
> +++ b/drivers/net/ethernet/renesas/sh_eth.c
> @@ -1260,16 +1260,23 @@ static int sh_eth_rx(struct net_device *ndev, u32 intr_status)
> desc_status = edmac_to_cpu(mdp, rxdesc->status);
> pkt_len = rxdesc->frame_length;
>
> -#if defined(CONFIG_ARCH_R8A7740)
> - desc_status >>= 16;
> -#endif
> -
> if (--boguscnt < 0)
> break;
>
> if (!(desc_status & RDFEND))
> ndev->stats.rx_length_errors++;
>
> +#if defined(CONFIG_ARCH_R8A7740)
> + /*
> + * In case of almost GETHER/ETHERs, the Receive Frame State
Erm, minor nit: it seems you forgot "all" after "almost". Hence it's
probably worth resubmitting...
> + * (RFS) bits in the Receive Descriptor 0 are from bit 9 to
> + * bit 0. However, in case of the R8A7740's GETHER, the RFS
> + * bits are from bit 25 to bit 16. So, the driver needs right
> + * shifting by 16.
> + */
> + desc_status >>= 16;
> +#endif
> +
WBR, Sergei
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net-next] net: sh_eth: fix incorrect RX length error if R8A7740
@ 2013-06-12 19:25 ` Sergei Shtylyov
0 siblings, 0 replies; 14+ messages in thread
From: Sergei Shtylyov @ 2013-06-12 19:25 UTC (permalink / raw)
To: Shimoda, Yoshihiro; +Cc: netdev, SH-Linux
On 06/12/2013 05:33 AM, Shimoda, Yoshihiro wrote:
> This patch fixes an issue that the driver increments the "RX length error"
> on every buffer in sh_eth_rx() if the R8A7740.
> This patch also adds a description about the Receive Frame Status bits.
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
> This patch is based on the latest net-next.git.
> drivers/net/ethernet/renesas/sh_eth.c | 15 +++++++++++----
> 1 files changed, 11 insertions(+), 4 deletions(-)
> diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
> index 43d8490..ab2f9c2 100644
> --- a/drivers/net/ethernet/renesas/sh_eth.c
> +++ b/drivers/net/ethernet/renesas/sh_eth.c
> @@ -1260,16 +1260,23 @@ static int sh_eth_rx(struct net_device *ndev, u32 intr_status)
> desc_status = edmac_to_cpu(mdp, rxdesc->status);
> pkt_len = rxdesc->frame_length;
>
> -#if defined(CONFIG_ARCH_R8A7740)
> - desc_status >>= 16;
> -#endif
> -
> if (--boguscnt < 0)
> break;
>
> if (!(desc_status & RDFEND))
> ndev->stats.rx_length_errors++;
>
> +#if defined(CONFIG_ARCH_R8A7740)
> + /*
> + * In case of almost GETHER/ETHERs, the Receive Frame State
Erm, minor nit: it seems you forgot "all" after "almost". Hence it's
probably worth resubmitting...
> + * (RFS) bits in the Receive Descriptor 0 are from bit 9 to
> + * bit 0. However, in case of the R8A7740's GETHER, the RFS
> + * bits are from bit 25 to bit 16. So, the driver needs right
> + * shifting by 16.
> + */
> + desc_status >>= 16;
> +#endif
> +
WBR, Sergei
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net-next] net: sh_eth: fix incorrect RX length error if R8A7740
2013-06-12 19:13 ` Sergei Shtylyov
@ 2013-06-12 19:55 ` David Miller
-1 siblings, 0 replies; 14+ messages in thread
From: David Miller @ 2013-06-12 19:55 UTC (permalink / raw)
To: sergei.shtylyov; +Cc: yoshihiro.shimoda.uh, netdev, linux-sh
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Wed, 12 Jun 2013 23:13:14 +0400
> Hello.
>
> On 06/12/2013 06:15 PM, Sergei Shtylyov wrote:
>
>>> This patch fixes an issue that the driver increments the "RX length
>>> error"
>>> on every buffer in sh_eth_rx() if the R8A7740.
>>> This patch also adds a description about the Receive Frame Status
>>> bits.
>
>> Thank you.
>
>>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>>> ---
>>> This patch is based on the latest net-next.git.
>
>> Since this is a fix, it should have been done against 'net.git'.
>
> David, this patch applies to the recent net.git repo with offset.
> Could you merge it there and also queue for stable?
Repost it so that I can apply it cleanly.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net-next] net: sh_eth: fix incorrect RX length error if R8A7740
@ 2013-06-12 19:55 ` David Miller
0 siblings, 0 replies; 14+ messages in thread
From: David Miller @ 2013-06-12 19:55 UTC (permalink / raw)
To: sergei.shtylyov; +Cc: yoshihiro.shimoda.uh, netdev, linux-sh
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Wed, 12 Jun 2013 23:13:14 +0400
> Hello.
>
> On 06/12/2013 06:15 PM, Sergei Shtylyov wrote:
>
>>> This patch fixes an issue that the driver increments the "RX length
>>> error"
>>> on every buffer in sh_eth_rx() if the R8A7740.
>>> This patch also adds a description about the Receive Frame Status
>>> bits.
>
>> Thank you.
>
>>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>>> ---
>>> This patch is based on the latest net-next.git.
>
>> Since this is a fix, it should have been done against 'net.git'.
>
> David, this patch applies to the recent net.git repo with offset.
> Could you merge it there and also queue for stable?
Repost it so that I can apply it cleanly.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net-next] net: sh_eth: fix incorrect RX length error if R8A7740
2013-06-12 19:55 ` David Miller
@ 2013-06-12 20:03 ` Sergei Shtylyov
-1 siblings, 0 replies; 14+ messages in thread
From: Sergei Shtylyov @ 2013-06-12 20:03 UTC (permalink / raw)
To: David Miller; +Cc: yoshihiro.shimoda.uh, netdev, linux-sh
On 06/12/2013 11:55 PM, David Miller wrote:
>>>> This patch fixes an issue that the driver increments the "RX length
>>>> error"
>>>> on every buffer in sh_eth_rx() if the R8A7740.
>>>> This patch also adds a description about the Receive Frame Status
>>>> bits.
>>> Thank you.
>>>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>>>> ---
>>>> This patch is based on the latest net-next.git.
>>> Since this is a fix, it should have been done against 'net.git'.
>> David, this patch applies to the recent net.git repo with offset.
>> Could you merge it there and also queue for stable?
> Repost it so that I can apply it cleanly.
OK, I'll first wait for Shimoda-san's repost as it needs a little
comment fix anyway.
WBR, Sergei
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net-next] net: sh_eth: fix incorrect RX length error if R8A7740
@ 2013-06-12 20:03 ` Sergei Shtylyov
0 siblings, 0 replies; 14+ messages in thread
From: Sergei Shtylyov @ 2013-06-12 20:03 UTC (permalink / raw)
To: David Miller; +Cc: yoshihiro.shimoda.uh, netdev, linux-sh
On 06/12/2013 11:55 PM, David Miller wrote:
>>>> This patch fixes an issue that the driver increments the "RX length
>>>> error"
>>>> on every buffer in sh_eth_rx() if the R8A7740.
>>>> This patch also adds a description about the Receive Frame Status
>>>> bits.
>>> Thank you.
>>>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>>>> ---
>>>> This patch is based on the latest net-next.git.
>>> Since this is a fix, it should have been done against 'net.git'.
>> David, this patch applies to the recent net.git repo with offset.
>> Could you merge it there and also queue for stable?
> Repost it so that I can apply it cleanly.
OK, I'll first wait for Shimoda-san's repost as it needs a little
comment fix anyway.
WBR, Sergei
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net-next] net: sh_eth: fix incorrect RX length error if R8A7740
2013-06-12 19:25 ` Sergei Shtylyov
@ 2013-06-13 0:57 ` Shimoda, Yoshihiro
-1 siblings, 0 replies; 14+ messages in thread
From: Shimoda, Yoshihiro @ 2013-06-13 0:57 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: netdev, SH-Linux
Hi,
(2013/06/13 4:25), Sergei Shtylyov wrote:
> On 06/12/2013 05:33 AM, Shimoda, Yoshihiro wrote:
< snip >
>> +#if defined(CONFIG_ARCH_R8A7740)
>> + /*
>> + * In case of almost GETHER/ETHERs, the Receive Frame State
>
> Erm, minor nit: it seems you forgot "all" after "almost". Hence it's probably worth resubmitting...
>
Thank you for the point. I will fix it and resubmit a patch for "net.git".
Best regards,
Yoshihiro Shimoda
>> + * (RFS) bits in the Receive Descriptor 0 are from bit 9 to
>> + * bit 0. However, in case of the R8A7740's GETHER, the RFS
>> + * bits are from bit 25 to bit 16. So, the driver needs right
>> + * shifting by 16.
>> + */
>> + desc_status >>= 16;
>> +#endif
>> +
>
> WBR, Sergei
>
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net-next] net: sh_eth: fix incorrect RX length error if R8A7740
@ 2013-06-13 0:57 ` Shimoda, Yoshihiro
0 siblings, 0 replies; 14+ messages in thread
From: Shimoda, Yoshihiro @ 2013-06-13 0:57 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: netdev, SH-Linux
Hi,
(2013/06/13 4:25), Sergei Shtylyov wrote:
> On 06/12/2013 05:33 AM, Shimoda, Yoshihiro wrote:
< snip >
>> +#if defined(CONFIG_ARCH_R8A7740)
>> + /*
>> + * In case of almost GETHER/ETHERs, the Receive Frame State
>
> Erm, minor nit: it seems you forgot "all" after "almost". Hence it's probably worth resubmitting...
>
Thank you for the point. I will fix it and resubmit a patch for "net.git".
Best regards,
Yoshihiro Shimoda
>> + * (RFS) bits in the Receive Descriptor 0 are from bit 9 to
>> + * bit 0. However, in case of the R8A7740's GETHER, the RFS
>> + * bits are from bit 25 to bit 16. So, the driver needs right
>> + * shifting by 16.
>> + */
>> + desc_status >>= 16;
>> +#endif
>> +
>
> WBR, Sergei
>
>
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2013-06-13 0:57 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-12 1:33 [PATCH net-next] net: sh_eth: fix incorrect RX length error if R8A7740 Shimoda, Yoshihiro
2013-06-12 1:33 ` Shimoda, Yoshihiro
2013-06-12 14:15 ` Sergei Shtylyov
2013-06-12 14:15 ` Sergei Shtylyov
2013-06-12 19:13 ` Sergei Shtylyov
2013-06-12 19:13 ` Sergei Shtylyov
2013-06-12 19:55 ` David Miller
2013-06-12 19:55 ` David Miller
2013-06-12 20:03 ` Sergei Shtylyov
2013-06-12 20:03 ` Sergei Shtylyov
2013-06-12 19:25 ` Sergei Shtylyov
2013-06-12 19:25 ` Sergei Shtylyov
2013-06-13 0:57 ` Shimoda, Yoshihiro
2013-06-13 0:57 ` Shimoda, Yoshihiro
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.