All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sekhar Nori <nsekhar@ti.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: <rjw@sisk.pl>, <linaro-kernel@lists.linaro.org>,
	<patches@linaro.org>, <cpufreq@vger.kernel.org>,
	<linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<robin.randhawa@arm.com>, <Steve.Bannister@arm.com>,
	<Liviu.Dudau@arm.com>, <charles.garcia-tobin@arm.com>,
	<arvind.chauhan@arm.com>, <dave.martin@arm.com>
Subject: Re: [PATCH 03/13] cpufreq: davinci: call CPUFREQ_POSTCHANGE notfier in error cases
Date: Wed, 19 Jun 2013 14:28:27 +0530	[thread overview]
Message-ID: <51C172B3.5030806@ti.com> (raw)
In-Reply-To: <6e65891cd3e33c5db94563a387832ae648ef0d8c.1371630975.git.viresh.kumar@linaro.org>

On 6/19/2013 2:22 PM, Viresh Kumar wrote:
> PRECHANGE and POSTCHANGE notifiers must be called in groups, i.e either both
> should be called or both shouldn't be.
> 
> In case we have started PRECHANGE notifier and found an error, we must call
> POSTCHANGE notifier with freqs.new = freqs.old to guarantee that sequence of
> calling notifiers is complete.
> 
> Davinci driver was taking care of it but frequency isn't restored to freqs.old.
> 
> This patch fixes it.
> 
> Cc: Sekhar Nori <nsekhar@ti.com>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

Looks good to me.

Acked-by: Sekhar Nori <nsekhar@ti.com>

Thanks,
Sekhar

WARNING: multiple messages have this Message-ID (diff)
From: Sekhar Nori <nsekhar@ti.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: rjw@sisk.pl, linaro-kernel@lists.linaro.org, patches@linaro.org,
	cpufreq@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org, robin.randhawa@arm.com,
	Steve.Bannister@arm.com, Liviu.Dudau@arm.com,
	charles.garcia-tobin@arm.com, arvind.chauhan@arm.com,
	dave.martin@arm.com
Subject: Re: [PATCH 03/13] cpufreq: davinci: call CPUFREQ_POSTCHANGE notfier in error cases
Date: Wed, 19 Jun 2013 14:28:27 +0530	[thread overview]
Message-ID: <51C172B3.5030806@ti.com> (raw)
In-Reply-To: <6e65891cd3e33c5db94563a387832ae648ef0d8c.1371630975.git.viresh.kumar@linaro.org>

On 6/19/2013 2:22 PM, Viresh Kumar wrote:
> PRECHANGE and POSTCHANGE notifiers must be called in groups, i.e either both
> should be called or both shouldn't be.
> 
> In case we have started PRECHANGE notifier and found an error, we must call
> POSTCHANGE notifier with freqs.new = freqs.old to guarantee that sequence of
> calling notifiers is complete.
> 
> Davinci driver was taking care of it but frequency isn't restored to freqs.old.
> 
> This patch fixes it.
> 
> Cc: Sekhar Nori <nsekhar@ti.com>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

Looks good to me.

Acked-by: Sekhar Nori <nsekhar@ti.com>

Thanks,
Sekhar

  reply	other threads:[~2013-06-19  8:58 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-19  8:52 [PATCH 00/13] CPUFreq: Fix {PRE|POST}CHANGE notification sequence Viresh Kumar
2013-06-19  8:52 ` [PATCH 01/13] cpufreq: acpi: call CPUFREQ_POSTCHANGE notfier in error cases Viresh Kumar
2013-06-19  8:52 ` [PATCH 02/13] cpufreq: arm-big-little: " Viresh Kumar
2013-06-19  8:52 ` [PATCH 03/13] cpufreq: davinci: " Viresh Kumar
2013-06-19  8:58   ` Sekhar Nori [this message]
2013-06-19  8:58     ` Sekhar Nori
2013-06-19  8:52 ` [PATCH 04/13] cpufreq: dbx500: " Viresh Kumar
2013-06-19 19:42   ` Linus Walleij
2013-06-19  8:52 ` [PATCH 05/13] cpufreq: e_powersave: " Viresh Kumar
2013-06-19 12:22   ` Simon Horman
2013-06-19 14:54     ` Viresh Kumar
2013-06-19 15:08       ` Dave Jones
2013-06-19  8:53 ` [PATCH 06/13] cpufreq: exynos: " Viresh Kumar
2013-06-19  8:53 ` [PATCH 07/13] cpufreq: imx6q: " Viresh Kumar
2013-06-20  2:52   ` Shawn Guo
2013-06-20  2:52     ` Shawn Guo
2013-06-19  8:53 ` [PATCH 08/13] cpufreq: omap: " Viresh Kumar
2013-06-19 14:44   ` Santosh Shilimkar
2013-06-19 14:44     ` Santosh Shilimkar
2013-06-19  8:53 ` [PATCH 09/13] cpufreq: pcc: " Viresh Kumar
2013-06-19  8:53 ` [PATCH 10/13] cpufreq: powernow-k8: " Viresh Kumar
2013-06-19  8:53 ` [PATCH 11/13] cpufreq: s3c64xx: " Viresh Kumar
2013-06-19  8:53 ` [PATCH 12/13] cpufreq: tegra: " Viresh Kumar
2013-06-19 17:11   ` Stephen Warren
2013-06-19  8:53 ` [PATCH 13/13] cpufreq: make sure frequency transitions are serialized Viresh Kumar
2013-06-24 11:43   ` Rafael J. Wysocki
2013-06-24 13:08     ` Viresh Kumar
2013-06-24 13:23       ` Rafael J. Wysocki
2013-06-24 13:16         ` Viresh Kumar
2013-06-24 13:33           ` Rafael J. Wysocki
2013-06-24 13:31             ` Viresh Kumar
2013-06-26 21:57               ` Rafael J. Wysocki
2013-06-27  4:56                 ` Viresh Kumar
2013-06-27 12:15                   ` Rafael J. Wysocki
2013-06-24 11:58 ` [PATCH 00/13] CPUFreq: Fix {PRE|POST}CHANGE notification sequence Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51C172B3.5030806@ti.com \
    --to=nsekhar@ti.com \
    --cc=Liviu.Dudau@arm.com \
    --cc=Steve.Bannister@arm.com \
    --cc=arvind.chauhan@arm.com \
    --cc=charles.garcia-tobin@arm.com \
    --cc=cpufreq@vger.kernel.org \
    --cc=dave.martin@arm.com \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=patches@linaro.org \
    --cc=rjw@sisk.pl \
    --cc=robin.randhawa@arm.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.