* [PATCH] arch: arm64: include: asm: add pci.h to pass compiling
@ 2013-06-26 3:26 ` Chen Gang
0 siblings, 0 replies; 14+ messages in thread
From: Chen Gang @ 2013-06-26 3:26 UTC (permalink / raw)
To: Catalin Marinas, Will Deacon; +Cc: linux-arm-kernel, linux-kernel
Need add pci.h for compiling, the related error (with allmodconfig):
drivers/media/usb/b2c2/flexcop-usb.c: In function ‘flexcop_usb_transfer_exit’:
drivers/media/usb/b2c2/flexcop-usb.c:393:3: error: implicit declaration of function ‘pci_free_consistent’ [-Werror=implicit-function-declaration]
drivers/media/usb/b2c2/flexcop-usb.c: In function ‘flexcop_usb_transfer_init’:
drivers/media/usb/b2c2/flexcop-usb.c:410:2: error: implicit declaration of function ‘pci_alloc_consistent’ [-Werror=implicit-function-declaration]
drivers/media/usb/b2c2/flexcop-usb.c:410:21: warning: assignment makes pointer from integer without a cast [enabled by default]
cc1: some warnings being treated as errors
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
arch/arm64/include/asm/pci.h | 11 +++++++++++
1 files changed, 11 insertions(+), 0 deletions(-)
create mode 100644 arch/arm64/include/asm/pci.h
diff --git a/arch/arm64/include/asm/pci.h b/arch/arm64/include/asm/pci.h
new file mode 100644
index 0000000..2ed467f
--- /dev/null
+++ b/arch/arm64/include/asm/pci.h
@@ -0,0 +1,11 @@
+#ifndef ASMARM64_PCI_H
+#define ASMARM64_PCI_H
+
+#ifdef __KERNEL__
+
+#include <asm-generic/pci-dma-compat.h>
+#include <asm-generic/pci.h>
+
+#endif /* __KERNEL__ */
+
+#endif
--
1.7.7.6
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH] arch: arm64: include: asm: add pci.h to pass compiling
@ 2013-06-26 3:26 ` Chen Gang
0 siblings, 0 replies; 14+ messages in thread
From: Chen Gang @ 2013-06-26 3:26 UTC (permalink / raw)
To: linux-arm-kernel
Need add pci.h for compiling, the related error (with allmodconfig):
drivers/media/usb/b2c2/flexcop-usb.c: In function ?flexcop_usb_transfer_exit?:
drivers/media/usb/b2c2/flexcop-usb.c:393:3: error: implicit declaration of function ?pci_free_consistent? [-Werror=implicit-function-declaration]
drivers/media/usb/b2c2/flexcop-usb.c: In function ?flexcop_usb_transfer_init?:
drivers/media/usb/b2c2/flexcop-usb.c:410:2: error: implicit declaration of function ?pci_alloc_consistent? [-Werror=implicit-function-declaration]
drivers/media/usb/b2c2/flexcop-usb.c:410:21: warning: assignment makes pointer from integer without a cast [enabled by default]
cc1: some warnings being treated as errors
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
arch/arm64/include/asm/pci.h | 11 +++++++++++
1 files changed, 11 insertions(+), 0 deletions(-)
create mode 100644 arch/arm64/include/asm/pci.h
diff --git a/arch/arm64/include/asm/pci.h b/arch/arm64/include/asm/pci.h
new file mode 100644
index 0000000..2ed467f
--- /dev/null
+++ b/arch/arm64/include/asm/pci.h
@@ -0,0 +1,11 @@
+#ifndef ASMARM64_PCI_H
+#define ASMARM64_PCI_H
+
+#ifdef __KERNEL__
+
+#include <asm-generic/pci-dma-compat.h>
+#include <asm-generic/pci.h>
+
+#endif /* __KERNEL__ */
+
+#endif
--
1.7.7.6
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH] arch: arm64: include: asm: add pci.h to pass compiling
2013-06-26 3:26 ` Chen Gang
@ 2013-06-26 14:07 ` Catalin Marinas
-1 siblings, 0 replies; 14+ messages in thread
From: Catalin Marinas @ 2013-06-26 14:07 UTC (permalink / raw)
To: Chen Gang; +Cc: Will Deacon, linux-arm-kernel, linux-kernel, Arnd Bergmann
On Wed, Jun 26, 2013 at 04:26:41AM +0100, Chen Gang wrote:
> Need add pci.h for compiling, the related error (with allmodconfig):
>
> drivers/media/usb/b2c2/flexcop-usb.c: In function ‘flexcop_usb_transfer_exit’:
> drivers/media/usb/b2c2/flexcop-usb.c:393:3: error: implicit declaration of function ‘pci_free_consistent’ [-Werror=implicit-function-declaration]
> drivers/media/usb/b2c2/flexcop-usb.c: In function ‘flexcop_usb_transfer_init’:
> drivers/media/usb/b2c2/flexcop-usb.c:410:2: error: implicit declaration of function ‘pci_alloc_consistent’ [-Werror=implicit-function-declaration]
> drivers/media/usb/b2c2/flexcop-usb.c:410:21: warning: assignment makes pointer from integer without a cast [enabled by default]
> cc1: some warnings being treated as errors
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
> arch/arm64/include/asm/pci.h | 11 +++++++++++
> 1 files changed, 11 insertions(+), 0 deletions(-)
> create mode 100644 arch/arm64/include/asm/pci.h
>
> diff --git a/arch/arm64/include/asm/pci.h b/arch/arm64/include/asm/pci.h
> new file mode 100644
> index 0000000..2ed467f
> --- /dev/null
> +++ b/arch/arm64/include/asm/pci.h
> @@ -0,0 +1,11 @@
> +#ifndef ASMARM64_PCI_H
> +#define ASMARM64_PCI_H
> +
> +#ifdef __KERNEL__
> +
> +#include <asm-generic/pci-dma-compat.h>
> +#include <asm-generic/pci.h>
> +
> +#endif /* __KERNEL__ */
> +
> +#endif
I wonder whether it makes sense to include pci-dma-compat.h in
asm-generic/pci.h, I don't see why one would want the generic pci.h but
not the generic pci-dma-compat.h (cc'ing Arnd).
--
Catalin
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] arch: arm64: include: asm: add pci.h to pass compiling
@ 2013-06-26 14:07 ` Catalin Marinas
0 siblings, 0 replies; 14+ messages in thread
From: Catalin Marinas @ 2013-06-26 14:07 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jun 26, 2013 at 04:26:41AM +0100, Chen Gang wrote:
> Need add pci.h for compiling, the related error (with allmodconfig):
>
> drivers/media/usb/b2c2/flexcop-usb.c: In function ?flexcop_usb_transfer_exit?:
> drivers/media/usb/b2c2/flexcop-usb.c:393:3: error: implicit declaration of function ?pci_free_consistent? [-Werror=implicit-function-declaration]
> drivers/media/usb/b2c2/flexcop-usb.c: In function ?flexcop_usb_transfer_init?:
> drivers/media/usb/b2c2/flexcop-usb.c:410:2: error: implicit declaration of function ?pci_alloc_consistent? [-Werror=implicit-function-declaration]
> drivers/media/usb/b2c2/flexcop-usb.c:410:21: warning: assignment makes pointer from integer without a cast [enabled by default]
> cc1: some warnings being treated as errors
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
> arch/arm64/include/asm/pci.h | 11 +++++++++++
> 1 files changed, 11 insertions(+), 0 deletions(-)
> create mode 100644 arch/arm64/include/asm/pci.h
>
> diff --git a/arch/arm64/include/asm/pci.h b/arch/arm64/include/asm/pci.h
> new file mode 100644
> index 0000000..2ed467f
> --- /dev/null
> +++ b/arch/arm64/include/asm/pci.h
> @@ -0,0 +1,11 @@
> +#ifndef ASMARM64_PCI_H
> +#define ASMARM64_PCI_H
> +
> +#ifdef __KERNEL__
> +
> +#include <asm-generic/pci-dma-compat.h>
> +#include <asm-generic/pci.h>
> +
> +#endif /* __KERNEL__ */
> +
> +#endif
I wonder whether it makes sense to include pci-dma-compat.h in
asm-generic/pci.h, I don't see why one would want the generic pci.h but
not the generic pci-dma-compat.h (cc'ing Arnd).
--
Catalin
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] arch: arm64: include: asm: add pci.h to pass compiling
2013-06-26 14:07 ` Catalin Marinas
@ 2013-06-27 0:30 ` Chen Gang
-1 siblings, 0 replies; 14+ messages in thread
From: Chen Gang @ 2013-06-27 0:30 UTC (permalink / raw)
To: Catalin Marinas
Cc: Will Deacon, linux-arm-kernel, linux-kernel, Arnd Bergmann
On 06/26/2013 10:07 PM, Catalin Marinas wrote:
> On Wed, Jun 26, 2013 at 04:26:41AM +0100, Chen Gang wrote:
>> > Need add pci.h for compiling, the related error (with allmodconfig):
>> >
>> > drivers/media/usb/b2c2/flexcop-usb.c: In function ‘flexcop_usb_transfer_exit’:
>> > drivers/media/usb/b2c2/flexcop-usb.c:393:3: error: implicit declaration of function ‘pci_free_consistent’ [-Werror=implicit-function-declaration]
>> > drivers/media/usb/b2c2/flexcop-usb.c: In function ‘flexcop_usb_transfer_init’:
>> > drivers/media/usb/b2c2/flexcop-usb.c:410:2: error: implicit declaration of function ‘pci_alloc_consistent’ [-Werror=implicit-function-declaration]
>> > drivers/media/usb/b2c2/flexcop-usb.c:410:21: warning: assignment makes pointer from integer without a cast [enabled by default]
>> > cc1: some warnings being treated as errors
>> >
>> > Signed-off-by: Chen Gang <gang.chen@asianux.com>
>> > ---
>> > arch/arm64/include/asm/pci.h | 11 +++++++++++
>> > 1 files changed, 11 insertions(+), 0 deletions(-)
>> > create mode 100644 arch/arm64/include/asm/pci.h
>> >
>> > diff --git a/arch/arm64/include/asm/pci.h b/arch/arm64/include/asm/pci.h
>> > new file mode 100644
>> > index 0000000..2ed467f
>> > --- /dev/null
>> > +++ b/arch/arm64/include/asm/pci.h
>> > @@ -0,0 +1,11 @@
>> > +#ifndef ASMARM64_PCI_H
>> > +#define ASMARM64_PCI_H
>> > +
>> > +#ifdef __KERNEL__
>> > +
>> > +#include <asm-generic/pci-dma-compat.h>
>> > +#include <asm-generic/pci.h>
>> > +
>> > +#endif /* __KERNEL__ */
>> > +
>> > +#endif
> I wonder whether it makes sense to include pci-dma-compat.h in
> asm-generic/pci.h, I don't see why one would want the generic pci.h but
> not the generic pci-dma-compat.h (cc'ing Arnd).
I think, it will let architecture guys easier to add their own
pci-dma-compat.h (although they still need generic pci_dma_compat.h, and
generic pci.h, too).
e.g. one architecture want include generic pci-dma-compat.h firstly,
then define its own features in its own pci-dma-compat.h.
Thanks.
--
Chen Gang
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] arch: arm64: include: asm: add pci.h to pass compiling
@ 2013-06-27 0:30 ` Chen Gang
0 siblings, 0 replies; 14+ messages in thread
From: Chen Gang @ 2013-06-27 0:30 UTC (permalink / raw)
To: linux-arm-kernel
On 06/26/2013 10:07 PM, Catalin Marinas wrote:
> On Wed, Jun 26, 2013 at 04:26:41AM +0100, Chen Gang wrote:
>> > Need add pci.h for compiling, the related error (with allmodconfig):
>> >
>> > drivers/media/usb/b2c2/flexcop-usb.c: In function ?flexcop_usb_transfer_exit?:
>> > drivers/media/usb/b2c2/flexcop-usb.c:393:3: error: implicit declaration of function ?pci_free_consistent? [-Werror=implicit-function-declaration]
>> > drivers/media/usb/b2c2/flexcop-usb.c: In function ?flexcop_usb_transfer_init?:
>> > drivers/media/usb/b2c2/flexcop-usb.c:410:2: error: implicit declaration of function ?pci_alloc_consistent? [-Werror=implicit-function-declaration]
>> > drivers/media/usb/b2c2/flexcop-usb.c:410:21: warning: assignment makes pointer from integer without a cast [enabled by default]
>> > cc1: some warnings being treated as errors
>> >
>> > Signed-off-by: Chen Gang <gang.chen@asianux.com>
>> > ---
>> > arch/arm64/include/asm/pci.h | 11 +++++++++++
>> > 1 files changed, 11 insertions(+), 0 deletions(-)
>> > create mode 100644 arch/arm64/include/asm/pci.h
>> >
>> > diff --git a/arch/arm64/include/asm/pci.h b/arch/arm64/include/asm/pci.h
>> > new file mode 100644
>> > index 0000000..2ed467f
>> > --- /dev/null
>> > +++ b/arch/arm64/include/asm/pci.h
>> > @@ -0,0 +1,11 @@
>> > +#ifndef ASMARM64_PCI_H
>> > +#define ASMARM64_PCI_H
>> > +
>> > +#ifdef __KERNEL__
>> > +
>> > +#include <asm-generic/pci-dma-compat.h>
>> > +#include <asm-generic/pci.h>
>> > +
>> > +#endif /* __KERNEL__ */
>> > +
>> > +#endif
> I wonder whether it makes sense to include pci-dma-compat.h in
> asm-generic/pci.h, I don't see why one would want the generic pci.h but
> not the generic pci-dma-compat.h (cc'ing Arnd).
I think, it will let architecture guys easier to add their own
pci-dma-compat.h (although they still need generic pci_dma_compat.h, and
generic pci.h, too).
e.g. one architecture want include generic pci-dma-compat.h firstly,
then define its own features in its own pci-dma-compat.h.
Thanks.
--
Chen Gang
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] arch: arm64: include: asm: add pci.h to pass compiling
2013-06-27 0:30 ` Chen Gang
@ 2013-06-27 2:05 ` Chen Gang
-1 siblings, 0 replies; 14+ messages in thread
From: Chen Gang @ 2013-06-27 2:05 UTC (permalink / raw)
To: Catalin Marinas
Cc: Will Deacon, linux-arm-kernel, linux-kernel, Arnd Bergmann
On 06/27/2013 08:30 AM, Chen Gang wrote:
> On 06/26/2013 10:07 PM, Catalin Marinas wrote:
>> On Wed, Jun 26, 2013 at 04:26:41AM +0100, Chen Gang wrote:
>>>> Need add pci.h for compiling, the related error (with allmodconfig):
>>>>
>>>> drivers/media/usb/b2c2/flexcop-usb.c: In function ‘flexcop_usb_transfer_exit’:
>>>> drivers/media/usb/b2c2/flexcop-usb.c:393:3: error: implicit declaration of function ‘pci_free_consistent’ [-Werror=implicit-function-declaration]
>>>> drivers/media/usb/b2c2/flexcop-usb.c: In function ‘flexcop_usb_transfer_init’:
>>>> drivers/media/usb/b2c2/flexcop-usb.c:410:2: error: implicit declaration of function ‘pci_alloc_consistent’ [-Werror=implicit-function-declaration]
>>>> drivers/media/usb/b2c2/flexcop-usb.c:410:21: warning: assignment makes pointer from integer without a cast [enabled by default]
>>>> cc1: some warnings being treated as errors
>>>>
>>>> Signed-off-by: Chen Gang <gang.chen@asianux.com>
>>>> ---
>>>> arch/arm64/include/asm/pci.h | 11 +++++++++++
>>>> 1 files changed, 11 insertions(+), 0 deletions(-)
>>>> create mode 100644 arch/arm64/include/asm/pci.h
>>>>
>>>> diff --git a/arch/arm64/include/asm/pci.h b/arch/arm64/include/asm/pci.h
>>>> new file mode 100644
>>>> index 0000000..2ed467f
>>>> --- /dev/null
>>>> +++ b/arch/arm64/include/asm/pci.h
>>>> @@ -0,0 +1,11 @@
>>>> +#ifndef ASMARM64_PCI_H
>>>> +#define ASMARM64_PCI_H
>>>> +
>>>> +#ifdef __KERNEL__
>>>> +
>>>> +#include <asm-generic/pci-dma-compat.h>
>>>> +#include <asm-generic/pci.h>
>>>> +
>>>> +#endif /* __KERNEL__ */
>>>> +
>>>> +#endif
>> I wonder whether it makes sense to include pci-dma-compat.h in
>> asm-generic/pci.h, I don't see why one would want the generic pci.h but
>> not the generic pci-dma-compat.h (cc'ing Arnd).
>
For m32r, it needs generic pci.h but not the generic pci-dma-compat.h.
I am just compiling it with allmodconfig to see whether it will can
cause issue too, if so I will send the patch for asm-generic. :-)
And, sorry for the original reply below is incorrect.
> I think, it will let architecture guys easier to add their own
> pci-dma-compat.h (although they still need generic pci_dma_compat.h, and
> generic pci.h, too).
>
> e.g. one architecture want include generic pci-dma-compat.h firstly,
> then define its own features in its own pci-dma-compat.h.
>
> Thanks.
>
--
Chen Gang
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] arch: arm64: include: asm: add pci.h to pass compiling
@ 2013-06-27 2:05 ` Chen Gang
0 siblings, 0 replies; 14+ messages in thread
From: Chen Gang @ 2013-06-27 2:05 UTC (permalink / raw)
To: linux-arm-kernel
On 06/27/2013 08:30 AM, Chen Gang wrote:
> On 06/26/2013 10:07 PM, Catalin Marinas wrote:
>> On Wed, Jun 26, 2013 at 04:26:41AM +0100, Chen Gang wrote:
>>>> Need add pci.h for compiling, the related error (with allmodconfig):
>>>>
>>>> drivers/media/usb/b2c2/flexcop-usb.c: In function ?flexcop_usb_transfer_exit?:
>>>> drivers/media/usb/b2c2/flexcop-usb.c:393:3: error: implicit declaration of function ?pci_free_consistent? [-Werror=implicit-function-declaration]
>>>> drivers/media/usb/b2c2/flexcop-usb.c: In function ?flexcop_usb_transfer_init?:
>>>> drivers/media/usb/b2c2/flexcop-usb.c:410:2: error: implicit declaration of function ?pci_alloc_consistent? [-Werror=implicit-function-declaration]
>>>> drivers/media/usb/b2c2/flexcop-usb.c:410:21: warning: assignment makes pointer from integer without a cast [enabled by default]
>>>> cc1: some warnings being treated as errors
>>>>
>>>> Signed-off-by: Chen Gang <gang.chen@asianux.com>
>>>> ---
>>>> arch/arm64/include/asm/pci.h | 11 +++++++++++
>>>> 1 files changed, 11 insertions(+), 0 deletions(-)
>>>> create mode 100644 arch/arm64/include/asm/pci.h
>>>>
>>>> diff --git a/arch/arm64/include/asm/pci.h b/arch/arm64/include/asm/pci.h
>>>> new file mode 100644
>>>> index 0000000..2ed467f
>>>> --- /dev/null
>>>> +++ b/arch/arm64/include/asm/pci.h
>>>> @@ -0,0 +1,11 @@
>>>> +#ifndef ASMARM64_PCI_H
>>>> +#define ASMARM64_PCI_H
>>>> +
>>>> +#ifdef __KERNEL__
>>>> +
>>>> +#include <asm-generic/pci-dma-compat.h>
>>>> +#include <asm-generic/pci.h>
>>>> +
>>>> +#endif /* __KERNEL__ */
>>>> +
>>>> +#endif
>> I wonder whether it makes sense to include pci-dma-compat.h in
>> asm-generic/pci.h, I don't see why one would want the generic pci.h but
>> not the generic pci-dma-compat.h (cc'ing Arnd).
>
For m32r, it needs generic pci.h but not the generic pci-dma-compat.h.
I am just compiling it with allmodconfig to see whether it will can
cause issue too, if so I will send the patch for asm-generic. :-)
And, sorry for the original reply below is incorrect.
> I think, it will let architecture guys easier to add their own
> pci-dma-compat.h (although they still need generic pci_dma_compat.h, and
> generic pci.h, too).
>
> e.g. one architecture want include generic pci-dma-compat.h firstly,
> then define its own features in its own pci-dma-compat.h.
>
> Thanks.
>
--
Chen Gang
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] arch: arm64: include: asm: add pci.h to pass compiling
2013-06-27 2:05 ` Chen Gang
@ 2013-06-27 3:47 ` Chen Gang
-1 siblings, 0 replies; 14+ messages in thread
From: Chen Gang @ 2013-06-27 3:47 UTC (permalink / raw)
To: Catalin Marinas
Cc: Will Deacon, linux-arm-kernel, linux-kernel, Arnd Bergmann
On 06/27/2013 10:05 AM, Chen Gang wrote:
> On 06/27/2013 08:30 AM, Chen Gang wrote:
>> On 06/26/2013 10:07 PM, Catalin Marinas wrote:
>>> On Wed, Jun 26, 2013 at 04:26:41AM +0100, Chen Gang wrote:
>>>>> Need add pci.h for compiling, the related error (with allmodconfig):
>>>>>
>>>>> drivers/media/usb/b2c2/flexcop-usb.c: In function ‘flexcop_usb_transfer_exit’:
>>>>> drivers/media/usb/b2c2/flexcop-usb.c:393:3: error: implicit declaration of function ‘pci_free_consistent’ [-Werror=implicit-function-declaration]
>>>>> drivers/media/usb/b2c2/flexcop-usb.c: In function ‘flexcop_usb_transfer_init’:
>>>>> drivers/media/usb/b2c2/flexcop-usb.c:410:2: error: implicit declaration of function ‘pci_alloc_consistent’ [-Werror=implicit-function-declaration]
>>>>> drivers/media/usb/b2c2/flexcop-usb.c:410:21: warning: assignment makes pointer from integer without a cast [enabled by default]
>>>>> cc1: some warnings being treated as errors
>>>>>
>>>>> Signed-off-by: Chen Gang <gang.chen@asianux.com>
>>>>> ---
>>>>> arch/arm64/include/asm/pci.h | 11 +++++++++++
>>>>> 1 files changed, 11 insertions(+), 0 deletions(-)
>>>>> create mode 100644 arch/arm64/include/asm/pci.h
>>>>>
>>>>> diff --git a/arch/arm64/include/asm/pci.h b/arch/arm64/include/asm/pci.h
>>>>> new file mode 100644
>>>>> index 0000000..2ed467f
>>>>> --- /dev/null
>>>>> +++ b/arch/arm64/include/asm/pci.h
>>>>> @@ -0,0 +1,11 @@
>>>>> +#ifndef ASMARM64_PCI_H
>>>>> +#define ASMARM64_PCI_H
>>>>> +
>>>>> +#ifdef __KERNEL__
>>>>> +
>>>>> +#include <asm-generic/pci-dma-compat.h>
>>>>> +#include <asm-generic/pci.h>
>>>>> +
>>>>> +#endif /* __KERNEL__ */
>>>>> +
>>>>> +#endif
>>> I wonder whether it makes sense to include pci-dma-compat.h in
>>> asm-generic/pci.h, I don't see why one would want the generic pci.h but
>>> not the generic pci-dma-compat.h (cc'ing Arnd).
>>
>
For m32r, it also face the same issue. So I need send related patch to
asm-generic instead of arm64.
> For m32r, it needs generic pci.h but not the generic pci-dma-compat.h.
>
> I am just compiling it with allmodconfig to see whether it will can
> cause issue too, if so I will send the patch for asm-generic. :-)
>
> And, sorry for the original reply below is incorrect.
>
>> I think, it will let architecture guys easier to add their own
>> pci-dma-compat.h (although they still need generic pci_dma_compat.h, and
>> generic pci.h, too).
>>
>> e.g. one architecture want include generic pci-dma-compat.h firstly,
>> then define its own features in its own pci-dma-compat.h.
>>
>> Thanks.
>>
>
>
--
Chen Gang
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] arch: arm64: include: asm: add pci.h to pass compiling
@ 2013-06-27 3:47 ` Chen Gang
0 siblings, 0 replies; 14+ messages in thread
From: Chen Gang @ 2013-06-27 3:47 UTC (permalink / raw)
To: linux-arm-kernel
On 06/27/2013 10:05 AM, Chen Gang wrote:
> On 06/27/2013 08:30 AM, Chen Gang wrote:
>> On 06/26/2013 10:07 PM, Catalin Marinas wrote:
>>> On Wed, Jun 26, 2013 at 04:26:41AM +0100, Chen Gang wrote:
>>>>> Need add pci.h for compiling, the related error (with allmodconfig):
>>>>>
>>>>> drivers/media/usb/b2c2/flexcop-usb.c: In function ?flexcop_usb_transfer_exit?:
>>>>> drivers/media/usb/b2c2/flexcop-usb.c:393:3: error: implicit declaration of function ?pci_free_consistent? [-Werror=implicit-function-declaration]
>>>>> drivers/media/usb/b2c2/flexcop-usb.c: In function ?flexcop_usb_transfer_init?:
>>>>> drivers/media/usb/b2c2/flexcop-usb.c:410:2: error: implicit declaration of function ?pci_alloc_consistent? [-Werror=implicit-function-declaration]
>>>>> drivers/media/usb/b2c2/flexcop-usb.c:410:21: warning: assignment makes pointer from integer without a cast [enabled by default]
>>>>> cc1: some warnings being treated as errors
>>>>>
>>>>> Signed-off-by: Chen Gang <gang.chen@asianux.com>
>>>>> ---
>>>>> arch/arm64/include/asm/pci.h | 11 +++++++++++
>>>>> 1 files changed, 11 insertions(+), 0 deletions(-)
>>>>> create mode 100644 arch/arm64/include/asm/pci.h
>>>>>
>>>>> diff --git a/arch/arm64/include/asm/pci.h b/arch/arm64/include/asm/pci.h
>>>>> new file mode 100644
>>>>> index 0000000..2ed467f
>>>>> --- /dev/null
>>>>> +++ b/arch/arm64/include/asm/pci.h
>>>>> @@ -0,0 +1,11 @@
>>>>> +#ifndef ASMARM64_PCI_H
>>>>> +#define ASMARM64_PCI_H
>>>>> +
>>>>> +#ifdef __KERNEL__
>>>>> +
>>>>> +#include <asm-generic/pci-dma-compat.h>
>>>>> +#include <asm-generic/pci.h>
>>>>> +
>>>>> +#endif /* __KERNEL__ */
>>>>> +
>>>>> +#endif
>>> I wonder whether it makes sense to include pci-dma-compat.h in
>>> asm-generic/pci.h, I don't see why one would want the generic pci.h but
>>> not the generic pci-dma-compat.h (cc'ing Arnd).
>>
>
For m32r, it also face the same issue. So I need send related patch to
asm-generic instead of arm64.
> For m32r, it needs generic pci.h but not the generic pci-dma-compat.h.
>
> I am just compiling it with allmodconfig to see whether it will can
> cause issue too, if so I will send the patch for asm-generic. :-)
>
> And, sorry for the original reply below is incorrect.
>
>> I think, it will let architecture guys easier to add their own
>> pci-dma-compat.h (although they still need generic pci_dma_compat.h, and
>> generic pci.h, too).
>>
>> e.g. one architecture want include generic pci-dma-compat.h firstly,
>> then define its own features in its own pci-dma-compat.h.
>>
>> Thanks.
>>
>
>
--
Chen Gang
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] arch: arm64: include: asm: add pci.h to pass compiling
2013-06-27 0:30 ` Chen Gang
@ 2013-06-27 8:43 ` Arnd Bergmann
-1 siblings, 0 replies; 14+ messages in thread
From: Arnd Bergmann @ 2013-06-27 8:43 UTC (permalink / raw)
To: Chen Gang; +Cc: Catalin Marinas, Will Deacon, linux-arm-kernel, linux-kernel
On Thursday 27 June 2013 08:30:40 Chen Gang wrote:
> On 06/26/2013 10:07 PM, Catalin Marinas wrote:
> > On Wed, Jun 26, 2013 at 04:26:41AM +0100, Chen Gang wrote:
> > I wonder whether it makes sense to include pci-dma-compat.h in
> > asm-generic/pci.h, I don't see why one would want the generic pci.h but
> > not the generic pci-dma-compat.h (cc'ing Arnd).
>
> I think, it will let architecture guys easier to add their own
> pci-dma-compat.h (although they still need generic pci_dma_compat.h, and
> generic pci.h, too).
>
> e.g. one architecture want include generic pci-dma-compat.h firstly,
> then define its own features in its own pci-dma-compat.h.
I think there is no excuse for still keeping the asm-generic/pci-dma-compat.h
header around any more.
All architectures use the same implementation and have done so for years.
We should just convert the remaining users to use the dma_mapping.h
interfaces directly.
Arnd
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] arch: arm64: include: asm: add pci.h to pass compiling
@ 2013-06-27 8:43 ` Arnd Bergmann
0 siblings, 0 replies; 14+ messages in thread
From: Arnd Bergmann @ 2013-06-27 8:43 UTC (permalink / raw)
To: linux-arm-kernel
On Thursday 27 June 2013 08:30:40 Chen Gang wrote:
> On 06/26/2013 10:07 PM, Catalin Marinas wrote:
> > On Wed, Jun 26, 2013 at 04:26:41AM +0100, Chen Gang wrote:
> > I wonder whether it makes sense to include pci-dma-compat.h in
> > asm-generic/pci.h, I don't see why one would want the generic pci.h but
> > not the generic pci-dma-compat.h (cc'ing Arnd).
>
> I think, it will let architecture guys easier to add their own
> pci-dma-compat.h (although they still need generic pci_dma_compat.h, and
> generic pci.h, too).
>
> e.g. one architecture want include generic pci-dma-compat.h firstly,
> then define its own features in its own pci-dma-compat.h.
I think there is no excuse for still keeping the asm-generic/pci-dma-compat.h
header around any more.
All architectures use the same implementation and have done so for years.
We should just convert the remaining users to use the dma_mapping.h
interfaces directly.
Arnd
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] arch: arm64: include: asm: add pci.h to pass compiling
2013-06-27 8:43 ` Arnd Bergmann
@ 2013-06-27 10:20 ` Chen Gang
-1 siblings, 0 replies; 14+ messages in thread
From: Chen Gang @ 2013-06-27 10:20 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Catalin Marinas, Will Deacon, linux-arm-kernel, linux-kernel
On 06/27/2013 04:43 PM, Arnd Bergmann wrote:
> On Thursday 27 June 2013 08:30:40 Chen Gang wrote:
>> > On 06/26/2013 10:07 PM, Catalin Marinas wrote:
>>> > > On Wed, Jun 26, 2013 at 04:26:41AM +0100, Chen Gang wrote:
>>> > > I wonder whether it makes sense to include pci-dma-compat.h in
>>> > > asm-generic/pci.h, I don't see why one would want the generic pci.h but
>>> > > not the generic pci-dma-compat.h (cc'ing Arnd).
>> >
>> > I think, it will let architecture guys easier to add their own
>> > pci-dma-compat.h (although they still need generic pci_dma_compat.h, and
>> > generic pci.h, too).
>> >
>> > e.g. one architecture want include generic pci-dma-compat.h firstly,
>> > then define its own features in its own pci-dma-compat.h.
> I think there is no excuse for still keeping the asm-generic/pci-dma-compat.h
> header around any more.
>
> All architectures use the same implementation and have done so for years.
> We should just convert the remaining users to use the dma_mapping.h
> interfaces directly.
in "asm-generic/pci-dma-compat.h", it include "linux/dma-mapping.h" firstly.
So can we say it also has additional features (at least for compatible
old things) which "dma-mapping.h" not have ?
Thanks.
--
Chen Gang
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] arch: arm64: include: asm: add pci.h to pass compiling
@ 2013-06-27 10:20 ` Chen Gang
0 siblings, 0 replies; 14+ messages in thread
From: Chen Gang @ 2013-06-27 10:20 UTC (permalink / raw)
To: linux-arm-kernel
On 06/27/2013 04:43 PM, Arnd Bergmann wrote:
> On Thursday 27 June 2013 08:30:40 Chen Gang wrote:
>> > On 06/26/2013 10:07 PM, Catalin Marinas wrote:
>>> > > On Wed, Jun 26, 2013 at 04:26:41AM +0100, Chen Gang wrote:
>>> > > I wonder whether it makes sense to include pci-dma-compat.h in
>>> > > asm-generic/pci.h, I don't see why one would want the generic pci.h but
>>> > > not the generic pci-dma-compat.h (cc'ing Arnd).
>> >
>> > I think, it will let architecture guys easier to add their own
>> > pci-dma-compat.h (although they still need generic pci_dma_compat.h, and
>> > generic pci.h, too).
>> >
>> > e.g. one architecture want include generic pci-dma-compat.h firstly,
>> > then define its own features in its own pci-dma-compat.h.
> I think there is no excuse for still keeping the asm-generic/pci-dma-compat.h
> header around any more.
>
> All architectures use the same implementation and have done so for years.
> We should just convert the remaining users to use the dma_mapping.h
> interfaces directly.
in "asm-generic/pci-dma-compat.h", it include "linux/dma-mapping.h" firstly.
So can we say it also has additional features (at least for compatible
old things) which "dma-mapping.h" not have ?
Thanks.
--
Chen Gang
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2013-06-27 10:21 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-26 3:26 [PATCH] arch: arm64: include: asm: add pci.h to pass compiling Chen Gang
2013-06-26 3:26 ` Chen Gang
2013-06-26 14:07 ` Catalin Marinas
2013-06-26 14:07 ` Catalin Marinas
2013-06-27 0:30 ` Chen Gang
2013-06-27 0:30 ` Chen Gang
2013-06-27 2:05 ` Chen Gang
2013-06-27 2:05 ` Chen Gang
2013-06-27 3:47 ` Chen Gang
2013-06-27 3:47 ` Chen Gang
2013-06-27 8:43 ` Arnd Bergmann
2013-06-27 8:43 ` Arnd Bergmann
2013-06-27 10:20 ` Chen Gang
2013-06-27 10:20 ` Chen Gang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.