From: Daniel Borkmann <dborkman@redhat.com> To: Joe Perches <joe@perches.com> Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-sctp@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v3 1/2] lib: vsprintf: add IPv4/v6 generic %p[Ii]S[pfs] format specifier Date: Fri, 28 Jun 2013 17:53:39 +0200 [thread overview] Message-ID: <51CDB183.1070209@redhat.com> (raw) In-Reply-To: <1372434289.29380.6.camel@joe-AO722> On 06/28/2013 05:44 PM, Joe Perches wrote: > On Fri, 2013-06-28 at 14:05 +0200, Daniel Borkmann wrote: >> In order to avoid making code that deals with printing both, IPv4 and >> IPv6 addresses, unnecessary complicated as for example ... > > Thanks Daniel, seems sensible. Just trivial comments... Ok, thanks. > [] > >> diff --git a/lib/vsprintf.c b/lib/vsprintf.c > [] > > Should any other include other than net/addrconf be needed? I'm not sure I understand this question. >> +char *ip6_addr_string_sa(char *buf, char *end, const struct sockaddr_in6 *sa, >> + struct printf_spec spec, const char *fmt) >> +{ > [] >> + char fmt6[2] = { fmt[0], '6'}; > > This looks odd to me. why not use a bool compressed > flag and identify this before the isalpha loop and not > have fmt6 at all? Well, we have a bool called 'have_c' that identifies if 'c' was specified. To have the same behaviour as with %pI6, this is used to create a temporary fmt that we then can pass to ip6_string(). If you look at ip6_addr_string(), it's done the same way, and by that, we stay compatible in behaviour. >> + u8 off = 0; >> + >> + fmt++; >> + while (isalpha(*++fmt)) { >> + switch (*fmt) { >> + case 'p': >> + have_p = true; >> + break; >> + case 'f': >> + have_f = true; >> + break; >> + case 's': >> + have_s = true; >> + break; >> + case 'c': >> + have_c = true; >> + break; >> + } >> + } > >
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Borkmann <dborkman@redhat.com> To: Joe Perches <joe@perches.com> Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-sctp@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v3 1/2] lib: vsprintf: add IPv4/v6 generic %p[Ii]S[pfs] format specifier Date: Fri, 28 Jun 2013 15:53:39 +0000 [thread overview] Message-ID: <51CDB183.1070209@redhat.com> (raw) In-Reply-To: <1372434289.29380.6.camel@joe-AO722> On 06/28/2013 05:44 PM, Joe Perches wrote: > On Fri, 2013-06-28 at 14:05 +0200, Daniel Borkmann wrote: >> In order to avoid making code that deals with printing both, IPv4 and >> IPv6 addresses, unnecessary complicated as for example ... > > Thanks Daniel, seems sensible. Just trivial comments... Ok, thanks. > [] > >> diff --git a/lib/vsprintf.c b/lib/vsprintf.c > [] > > Should any other include other than net/addrconf be needed? I'm not sure I understand this question. >> +char *ip6_addr_string_sa(char *buf, char *end, const struct sockaddr_in6 *sa, >> + struct printf_spec spec, const char *fmt) >> +{ > [] >> + char fmt6[2] = { fmt[0], '6'}; > > This looks odd to me. why not use a bool compressed > flag and identify this before the isalpha loop and not > have fmt6 at all? Well, we have a bool called 'have_c' that identifies if 'c' was specified. To have the same behaviour as with %pI6, this is used to create a temporary fmt that we then can pass to ip6_string(). If you look at ip6_addr_string(), it's done the same way, and by that, we stay compatible in behaviour. >> + u8 off = 0; >> + >> + fmt++; >> + while (isalpha(*++fmt)) { >> + switch (*fmt) { >> + case 'p': >> + have_p = true; >> + break; >> + case 'f': >> + have_f = true; >> + break; >> + case 's': >> + have_s = true; >> + break; >> + case 'c': >> + have_c = true; >> + break; >> + } >> + } > >
next prev parent reply other threads:[~2013-06-28 15:53 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-06-28 12:05 [PATCH net-next v3 0/2] Rework SCTP debugging framework Daniel Borkmann 2013-06-28 12:05 ` Daniel Borkmann 2013-06-28 12:05 ` [PATCH net-next v3 1/2] lib: vsprintf: add IPv4/v6 generic %p[Ii]S[pfs] format specifier Daniel Borkmann 2013-06-28 12:05 ` Daniel Borkmann 2013-06-28 15:44 ` Joe Perches 2013-06-28 15:44 ` Joe Perches 2013-06-28 15:53 ` Daniel Borkmann [this message] 2013-06-28 15:53 ` Daniel Borkmann 2013-06-28 16:04 ` Joe Perches 2013-06-28 16:04 ` Joe Perches 2013-06-28 16:13 ` Daniel Borkmann 2013-06-28 16:13 ` Daniel Borkmann 2013-06-28 16:06 ` Daniel Borkmann 2013-06-28 16:06 ` Daniel Borkmann 2013-06-28 16:30 ` Joe Perches 2013-06-28 16:30 ` Joe Perches 2013-06-28 12:05 ` [PATCH net-next v3 2/2] net: sctp: rework debugging framework to use pr_debug and friends Daniel Borkmann 2013-06-28 12:05 ` Daniel Borkmann
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=51CDB183.1070209@redhat.com \ --to=dborkman@redhat.com \ --cc=davem@davemloft.net \ --cc=joe@perches.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-sctp@vger.kernel.org \ --cc=netdev@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.