All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] regulator: max77693: Fix trivial typo
@ 2013-06-29  3:37 Axel Lin
  2013-06-30 23:51 ` jonghwa3.lee
  2013-07-01 10:15 ` Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2013-06-29  3:37 UTC (permalink / raw)
  To: Mark Brown; +Cc: Jonghwa Lee, Myungjoo Ham, Liam Girdwood, linux-kernel

Fix trivial typo in the equation to check upper bound of current setting.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/regulator/max77693.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/max77693.c b/drivers/regulator/max77693.c
index 674ece7..d45a4dd 100644
--- a/drivers/regulator/max77693.c
+++ b/drivers/regulator/max77693.c
@@ -97,7 +97,7 @@ static int max77693_chg_set_current_limit(struct regulator_dev *rdev,
 	while (chg_min_uA + CHGIN_ILIM_STEP_20mA * sel < min_uA)
 		sel++;
 
-	if (chg_min_uA * CHGIN_ILIM_STEP_20mA * sel > max_uA)
+	if (chg_min_uA + CHGIN_ILIM_STEP_20mA * sel > max_uA)
 		return -EINVAL;
 
 	/* the first four codes for charger current are all 60mA */
-- 
1.8.1.2




^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] regulator: max77693: Fix trivial typo
  2013-06-29  3:37 [PATCH] regulator: max77693: Fix trivial typo Axel Lin
@ 2013-06-30 23:51 ` jonghwa3.lee
  2013-07-01 10:15 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: jonghwa3.lee @ 2013-06-30 23:51 UTC (permalink / raw)
  To: Axel Lin; +Cc: Mark Brown, Myungjoo Ham, Liam Girdwood, linux-kernel

On 2013년 06월 29일 12:37, Axel Lin wrote:

> Fix trivial typo in the equation to check upper bound of current setting.
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
>  drivers/regulator/max77693.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/regulator/max77693.c b/drivers/regulator/max77693.c
> index 674ece7..d45a4dd 100644
> --- a/drivers/regulator/max77693.c
> +++ b/drivers/regulator/max77693.c
> @@ -97,7 +97,7 @@ static int max77693_chg_set_current_limit(struct regulator_dev *rdev,
>  	while (chg_min_uA + CHGIN_ILIM_STEP_20mA * sel < min_uA)
>  		sel++;
>  
> -	if (chg_min_uA * CHGIN_ILIM_STEP_20mA * sel > max_uA)
> +	if (chg_min_uA + CHGIN_ILIM_STEP_20mA * sel > max_uA)
>  		return -EINVAL;
>  
>  	/* the first four codes for charger current are all 60mA */


Acked-by: Jonghwa Lee <jonghwa3.lee@samsung.com>


Thanks,
Jonghwa


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] regulator: max77693: Fix trivial typo
  2013-06-29  3:37 [PATCH] regulator: max77693: Fix trivial typo Axel Lin
  2013-06-30 23:51 ` jonghwa3.lee
@ 2013-07-01 10:15 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2013-07-01 10:15 UTC (permalink / raw)
  To: Axel Lin; +Cc: Jonghwa Lee, Myungjoo Ham, Liam Girdwood, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 152 bytes --]

On Sat, Jun 29, 2013 at 11:37:29AM +0800, Axel Lin wrote:
> Fix trivial typo in the equation to check upper bound of current setting.

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-07-01 10:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-29  3:37 [PATCH] regulator: max77693: Fix trivial typo Axel Lin
2013-06-30 23:51 ` jonghwa3.lee
2013-07-01 10:15 ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.