* Crash during reboot due to 7628774 "mmc: core: Handle card shutdown from mmc_bus"
@ 2013-07-01 20:32 Stephen Warren
2013-07-02 10:40 ` Ulf Hansson
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Warren @ 2013-07-01 20:32 UTC (permalink / raw)
To: Chris Ball, Ulf Hansson; +Cc: linux-mmc, linux-next
It looks like commit 7628774 "mmc: core: Handle card shutdown from
mmc_bus" causes a crash during "reboot" at least on Tegra platforms. The
issue appears to be in:
> static void mmc_bus_shutdown(struct device *dev)
> {
> struct mmc_driver *drv = to_mmc_driver(dev->driver);
> struct mmc_card *card = mmc_dev_to_card(dev);
> struct mmc_host *host = card->host;
> int ret;
>
> drv->shutdown(card);
Since drv == NULL.
Is this expected (and hence there's a missing guard on that function
call), or is the root-cause some other issue?
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Crash during reboot due to 7628774 "mmc: core: Handle card shutdown from mmc_bus"
2013-07-01 20:32 Crash during reboot due to 7628774 "mmc: core: Handle card shutdown from mmc_bus" Stephen Warren
@ 2013-07-02 10:40 ` Ulf Hansson
0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2013-07-02 10:40 UTC (permalink / raw)
To: Stephen Warren; +Cc: Chris Ball, linux-mmc, linux-next
On 1 July 2013 22:32, Stephen Warren <swarren@wwwdotorg.org> wrote:
> It looks like commit 7628774 "mmc: core: Handle card shutdown from
> mmc_bus" causes a crash during "reboot" at least on Tegra platforms. The
> issue appears to be in:
>
>> static void mmc_bus_shutdown(struct device *dev)
>> {
>> struct mmc_driver *drv = to_mmc_driver(dev->driver);
>> struct mmc_card *card = mmc_dev_to_card(dev);
>> struct mmc_host *host = card->host;
>> int ret;
>>
>> drv->shutdown(card);
>
> Since drv == NULL.
>
> Is this expected (and hence there's a missing guard on that function
> call), or is the root-cause some other issue?
Hi Stephen,
It is expected that drv is NULL, and obviously needs to be a check for
it before calling it, my bad!
A fixup patch is on it's way asap.
Kind regards
Ulf Hansson
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-07-02 10:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-01 20:32 Crash during reboot due to 7628774 "mmc: core: Handle card shutdown from mmc_bus" Stephen Warren
2013-07-02 10:40 ` Ulf Hansson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.