* Re: [infiniband:for-next 769/772] drivers/net/ethernet/mellanox/mlx5/core/cmd.c:894:7-14: WARNING opportunity for memdup_user
[not found] <20130708094047.GC2985@localhost>
@ 2013-07-08 9:58 ` Or Gerlitz
[not found] ` <51DA8D32.2090504-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Or Gerlitz @ 2013-07-08 9:58 UTC (permalink / raw)
To: Fengguang Wu, Roland Dreier
Cc: Eli Cohen, kbuild-all-JC7UmRfGjtg, Jack Morgenstein,
linux-rdma (linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org)
On 08/07/2013 12:40, Fengguang Wu wrote:
> Hi Eli,
>
> FYI, there are coccinelle warnings in
>
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband.git for-next
> head: 1af1abad19f6a40d8822cb7a35736e9e102fade6
> commit: 809d3a921f9047bf575488f410ed12b365fe5cd7 [769/772] mlx5: Add driver for Mellanox Connect-IB adapters
>
>>> drivers/net/ethernet/mellanox/mlx5/core/cmd.c:894:7-14: WARNING opportunity for memdup_user
> --
>>> drivers/infiniband/hw/mlx5/mr.c:445:2-3: Unneeded semicolon
>>> drivers/infiniband/hw/mlx5/mr.c:167:2-3: Unneeded semicolon
> --
>>> drivers/net/ethernet/mellanox/mlx5/core/cmd.c:98:11-19: WARNING opportunity for simple_open, see also structure on line 938
>>> drivers/net/ethernet/mellanox/mlx5/core/cmd.c:98:11-19: WARNING opportunity for simple_open, see also structure on line 718
>>> drivers/net/ethernet/mellanox/mlx5/core/cmd.c:98:11-19: WARNING opportunity for simple_open, see also structure on line 1006
> --
>>> drivers/net/ethernet/mellanox/mlx5/core/debugfs.c:145:11-19: WARNING opportunity for simple_open, see also structure on line 470
>>> drivers/net/ethernet/mellanox/mlx5/core/debugfs.c:145:11-19: WARNING opportunity for simple_open, see also structure on line 203
> --
>>> drivers/infiniband/hw/mlx5/mr.c:52:11-20: WARNING opportunity for simple_open, see also structure on line 289
>>> drivers/infiniband/hw/mlx5/mr.c:52:11-20: WARNING opportunity for simple_open, see also structure on line 227
> Please consider folding the attached diff with suitable fixups :-)
Hi Roland,
Eli is still OOO, I have reviewed the four patches and they are OK,
please roll into the initial version
Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [infiniband:for-next 769/772] drivers/net/ethernet/mellanox/mlx5/core/cmd.c:894:7-14: WARNING opportunity for memdup_user
[not found] ` <51DA8D32.2090504-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
@ 2013-07-08 10:58 ` Fengguang Wu
2013-07-08 12:06 ` Or Gerlitz
0 siblings, 1 reply; 3+ messages in thread
From: Fengguang Wu @ 2013-07-08 10:58 UTC (permalink / raw)
To: Or Gerlitz
Cc: Roland Dreier, Eli Cohen, kbuild-all-JC7UmRfGjtg,
Jack Morgenstein,
linux-rdma (linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org)
On Mon, Jul 08, 2013 at 12:58:10PM +0300, Or Gerlitz wrote:
> On 08/07/2013 12:40, Fengguang Wu wrote:
> >Hi Eli,
> >
> >FYI, there are coccinelle warnings in
> >
> >tree: git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband.git for-next
> >head: 1af1abad19f6a40d8822cb7a35736e9e102fade6
> >commit: 809d3a921f9047bf575488f410ed12b365fe5cd7 [769/772] mlx5: Add driver for Mellanox Connect-IB adapters
> >
> >>>drivers/net/ethernet/mellanox/mlx5/core/cmd.c:894:7-14: WARNING opportunity for memdup_user
> >--
> >>>drivers/infiniband/hw/mlx5/mr.c:445:2-3: Unneeded semicolon
> >>>drivers/infiniband/hw/mlx5/mr.c:167:2-3: Unneeded semicolon
> >--
> >>>drivers/net/ethernet/mellanox/mlx5/core/cmd.c:98:11-19: WARNING opportunity for simple_open, see also structure on line 938
> >>>drivers/net/ethernet/mellanox/mlx5/core/cmd.c:98:11-19: WARNING opportunity for simple_open, see also structure on line 718
> >>>drivers/net/ethernet/mellanox/mlx5/core/cmd.c:98:11-19: WARNING opportunity for simple_open, see also structure on line 1006
> >--
> >>>drivers/net/ethernet/mellanox/mlx5/core/debugfs.c:145:11-19: WARNING opportunity for simple_open, see also structure on line 470
> >>>drivers/net/ethernet/mellanox/mlx5/core/debugfs.c:145:11-19: WARNING opportunity for simple_open, see also structure on line 203
> >--
> >>>drivers/infiniband/hw/mlx5/mr.c:52:11-20: WARNING opportunity for simple_open, see also structure on line 289
> >>>drivers/infiniband/hw/mlx5/mr.c:52:11-20: WARNING opportunity for simple_open, see also structure on line 227
> >Please consider folding the attached diff with suitable fixups :-)
>
> Hi Roland,
>
> Eli is still OOO, I have reviewed the four patches and they are OK,
> please roll into the initial version
Roland, you may need to replace some " " with "\t" in the patches.
Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [infiniband:for-next 769/772] drivers/net/ethernet/mellanox/mlx5/core/cmd.c:894:7-14: WARNING opportunity for memdup_user
2013-07-08 10:58 ` Fengguang Wu
@ 2013-07-08 12:06 ` Or Gerlitz
0 siblings, 0 replies; 3+ messages in thread
From: Or Gerlitz @ 2013-07-08 12:06 UTC (permalink / raw)
To: Fengguang Wu, Roland Dreier
Cc: Eli Cohen, kbuild-all-JC7UmRfGjtg, Jack Morgenstein,
linux-rdma (linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org),
Moshe Lazer
On 08/07/2013 13:58, Fengguang Wu wrote:
> Roland, you may need to replace some " " with "\t" in the patches.
> Thanks, Fengguang
Roland, I have prepared these patches properly and will send them to
you, they can be just squashed into the initial commit
or come as add on patches.
Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-07-08 12:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20130708094047.GC2985@localhost>
2013-07-08 9:58 ` [infiniband:for-next 769/772] drivers/net/ethernet/mellanox/mlx5/core/cmd.c:894:7-14: WARNING opportunity for memdup_user Or Gerlitz
[not found] ` <51DA8D32.2090504-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2013-07-08 10:58 ` Fengguang Wu
2013-07-08 12:06 ` Or Gerlitz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.