* [PATCH 0/1] udev: add runtime dependency on blkid
@ 2013-07-08 7:10 jackie.huang
2013-07-08 7:10 ` [PATCH 1/1] " jackie.huang
0 siblings, 1 reply; 5+ messages in thread
From: jackie.huang @ 2013-07-08 7:10 UTC (permalink / raw)
To: openembedded-core
From: Jackie Huang <jackie.huang@windriver.com>
The following changes since commit 3e1dbabbf33a2e461abc92ff10cd970fe604ee38:
sysstat: backport a patch to fix a parallel building error (2013-07-02 07:58:10 -0700)
are available in the git repository at:
git://git.pokylinux.org/poky-contrib jhuang0/r_bbappend_udev_0708_1
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=jhuang0/r_bbappend_udev_0708_1
Jackie Huang (1):
udev: add runtime dependency on blkid
meta/recipes-core/udev/udev_182.bb | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
--
1.7.4.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/1] udev: add runtime dependency on blkid
2013-07-08 7:10 [PATCH 0/1] udev: add runtime dependency on blkid jackie.huang
@ 2013-07-08 7:10 ` jackie.huang
2013-07-08 19:35 ` Saul Wold
0 siblings, 1 reply; 5+ messages in thread
From: jackie.huang @ 2013-07-08 7:10 UTC (permalink / raw)
To: openembedded-core
From: Jackie Huang <jackie.huang@windriver.com>
udev requires blkid, but this wasn't explicit. Note that the
dependency is on util-linux specifically, the one from e2fsprogs
won't work.
Signed-off-by: Andy Ross <andy.ross@windriver.com>
Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
---
meta/recipes-core/udev/udev_182.bb | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/meta/recipes-core/udev/udev_182.bb b/meta/recipes-core/udev/udev_182.bb
index d66292e..114a557 100644
--- a/meta/recipes-core/udev/udev_182.bb
+++ b/meta/recipes-core/udev/udev_182.bb
@@ -5,5 +5,9 @@ PR = "r7"
# module-init-tools from kmod_git will provide libkmod runtime
DEPENDS += "module-init-tools"
+# Needs blkid from this particular package. The one in e2fsprogs is
+# old and incompatible.
+RDEPENDS_${PN} += "util-linux-blkid"
+
SRC_URI[md5sum] = "1b964456177fbf48023dfee7db3a708d"
SRC_URI[sha256sum] = "7857ed19fafd8f3ca8de410194e8c7336e9eb8a20626ea8a4ba6449b017faba4"
--
1.7.4.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] udev: add runtime dependency on blkid
2013-07-08 7:10 ` [PATCH 1/1] " jackie.huang
@ 2013-07-08 19:35 ` Saul Wold
2013-07-08 19:47 ` Andy Ross
0 siblings, 1 reply; 5+ messages in thread
From: Saul Wold @ 2013-07-08 19:35 UTC (permalink / raw)
To: jackie.huang; +Cc: openembedded-core
On 07/08/2013 12:10 AM, jackie.huang@windriver.com wrote:
> From: Jackie Huang <jackie.huang@windriver.com>
>
> udev requires blkid, but this wasn't explicit. Note that the
> dependency is on util-linux specifically, the one from e2fsprogs
> won't work.
>
Doesn't udev use an internal builtin-blkid? Or is the configure finding
that we have util-linux and using it instead of the built-in?
If it's a configure test, then it might need to be a DEPENDS, not RDEPENDS.
Sau!
> Signed-off-by: Andy Ross <andy.ross@windriver.com>
> Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
> ---
> meta/recipes-core/udev/udev_182.bb | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/meta/recipes-core/udev/udev_182.bb b/meta/recipes-core/udev/udev_182.bb
> index d66292e..114a557 100644
> --- a/meta/recipes-core/udev/udev_182.bb
> +++ b/meta/recipes-core/udev/udev_182.bb
> @@ -5,5 +5,9 @@ PR = "r7"
> # module-init-tools from kmod_git will provide libkmod runtime
> DEPENDS += "module-init-tools"
>
> +# Needs blkid from this particular package. The one in e2fsprogs is
> +# old and incompatible.
> +RDEPENDS_${PN} += "util-linux-blkid"
> +
> SRC_URI[md5sum] = "1b964456177fbf48023dfee7db3a708d"
> SRC_URI[sha256sum] = "7857ed19fafd8f3ca8de410194e8c7336e9eb8a20626ea8a4ba6449b017faba4"
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] udev: add runtime dependency on blkid
2013-07-08 19:35 ` Saul Wold
@ 2013-07-08 19:47 ` Andy Ross
2013-07-09 2:06 ` jhuang0
0 siblings, 1 reply; 5+ messages in thread
From: Andy Ross @ 2013-07-08 19:47 UTC (permalink / raw)
To: Saul Wold; +Cc: openembedded-core
On 07/08/2013 12:35 PM, Saul Wold wrote:
> On 07/08/2013 12:10 AM, jackie.huang@windriver.com wrote:
>> From: Jackie Huang <jackie.huang@windriver.com>
>>
>> udev requires blkid, but this wasn't explicit. Note that the
>> dependency is on util-linux specifically, the one from e2fsprogs
>> won't work.
>>
> Doesn't udev use an internal builtin-blkid? Or is the configure finding
> that we have util-linux and using it instead of the built-in?
I think (I'm really stale here) I wrote that patch against a udev
version prior to the addition of the builtin. And in any case didn't
I see that blkid got yanked from the e2fsprogs package at some point
anyway? Pretty sure this is not needed in upstream oe-core. Not sure
if it ever was.
Andy
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] udev: add runtime dependency on blkid
2013-07-08 19:47 ` Andy Ross
@ 2013-07-09 2:06 ` jhuang0
0 siblings, 0 replies; 5+ messages in thread
From: jhuang0 @ 2013-07-09 2:06 UTC (permalink / raw)
To: Andy Ross; +Cc: openembedded-core
On 7/9/2013 3:47 AM, Andy Ross wrote:
> On 07/08/2013 12:35 PM, Saul Wold wrote:
>> On 07/08/2013 12:10 AM, jackie.huang@windriver.com wrote:
>>> From: Jackie Huang <jackie.huang@windriver.com>
>>>
>>> udev requires blkid, but this wasn't explicit. Note that the
>>> dependency is on util-linux specifically, the one from e2fsprogs
>>> won't work.
>>>
>> Doesn't udev use an internal builtin-blkid? Or is the configure finding
>> that we have util-linux and using it instead of the built-in?
>
> I think (I'm really stale here) I wrote that patch against a udev
> version prior to the addition of the builtin. And in any case didn't
> I see that blkid got yanked from the e2fsprogs package at some point
> anyway? Pretty sure this is not needed in upstream oe-core. Not sure
Thanks for clarifying this, I think it it not needed in our layer's
bbappend file as well since we had sync up with upstream oe-core, I will
check that and clean up the bbappend.
Thanks,
Jackie
> if it ever was.
>
> Andy
>
>
--
Jackie Huang
WIND RIVER | China Development Center
MSN:jackielily@hotmail.com
Tel: +86 8477 8594
Mobile: +86 138 1027 4745
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-07-09 2:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-08 7:10 [PATCH 0/1] udev: add runtime dependency on blkid jackie.huang
2013-07-08 7:10 ` [PATCH 1/1] " jackie.huang
2013-07-08 19:35 ` Saul Wold
2013-07-08 19:47 ` Andy Ross
2013-07-09 2:06 ` jhuang0
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.