All of lore.kernel.org
 help / color / mirror / Atom feed
From: George Dunlap <george.dunlap@eu.citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Ian Campbell <Ian.Campbell@citrix.com>,
	Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] tools/xl: Add 'xen_version' to `xl info`
Date: Thu, 11 Jul 2013 10:21:24 +0100	[thread overview]
Message-ID: <51DE7914.7070403@eu.citrix.com> (raw)
In-Reply-To: <51DE7674.8010508@citrix.com>

On 11/07/13 10:10, Andrew Cooper wrote:
> On 11/07/13 10:02, George Dunlap wrote:
>> On Wed, Jul 10, 2013 at 5:46 PM, Andrew Cooper
>> <andrew.cooper3@citrix.com> wrote:
>>> Getting the full Xen version in an easily scriptable way is awkward,
>>> especially if trying to piece together from xen_{major,minor,extra}.
>>>
>>> This reflects $(XEN_FULLVERSION) in the build system (but under a more
>>> sensible name, as $(XEN_VERSION) is just the major number).
>>>
>>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> I can see the point, but it seems a bit redundant to have the version
>> info printed twice.
>>
>> This makes me wonder if it might make sense to have options to print
>> just individual items; e.g.:
>>
>> xl info --xen_version
>>
>> or perhaps
>>
>> xi info --format="%{xen_version}"
>>
>> or something.
>>
>> -George
> Ah - that was part 2 which I am working on in my copious free time.
>
> At the moment, xl info takes no parameters, or an -h or -n.
>
> I was thinking it could be modifed to optionally take a positional
> paramater, such as
>
> xl info xen_version
>
> Even with this however, my original point still stands.  Getting the
> version number is awkward.

Is there actually a reason to print it separately at all?  Why not 
replace the individual lines with the unified line?

  -George

  reply	other threads:[~2013-07-11  9:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-10 16:46 [PATCH] tools/xl: Add 'xen_version' to `xl info` Andrew Cooper
2013-07-10 17:07 ` Matt Wilson
2013-07-12 16:40   ` [PATCH] tools/xl: Add 'xen_version' to `xl info` [and 3 more messages] Ian Jackson
2013-07-11  9:02 ` [PATCH] tools/xl: Add 'xen_version' to `xl info` George Dunlap
2013-07-11  9:10   ` Andrew Cooper
2013-07-11  9:21     ` George Dunlap [this message]
2013-07-11  9:34       ` Andrew Cooper
2013-07-11 17:49       ` Matt Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51DE7914.7070403@eu.citrix.com \
    --to=george.dunlap@eu.citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.