All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chad Versace <chad.versace@linux.intel.com>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: Intel GFX <intel-gfx@lists.freedesktop.org>,
	Bryan Bell <bryan.j.bell@intel.com>
Subject: Re: [PATCH] [v2] drm/i915: Expose LLC size to user space
Date: Fri, 12 Jul 2013 10:38:01 -0700	[thread overview]
Message-ID: <51E03EF9.2000809@linux.intel.com> (raw)
In-Reply-To: <1373568732-3061-1-git-send-email-ben@bwidawsk.net>

On 07/11/2013 11:52 AM, Ben Widawsky wrote:
> The algorithm/information was originally written by Chad, though I
> changed the control flow, and I think his original code had a couple of
> bugs, though I didn't look very hard before rewriting. That could have
> also been different interpretations of the spec.
>
> I've tested this on two platforms, and it seems to perform how I want.
>
> With this patch is a small tool for igt to query the size. This can be
> used as a reference for DRI clients wishing to query the information.
>
> v2: Update name of the SDM location (Bryan)
> Dissent: Use a new param instead of reusing HAS_LLC param (Chris, Chad)
> Fix unicode multiply symbol (Ben)
>
> CC: Chad Versace <chad.versace@linux.intel.com>
> CC: Bryan Bell <bryan.j.bell@intel.com>
> Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
> ---
>   drivers/gpu/drm/i915/i915_dma.c |  3 +++
>   drivers/gpu/drm/i915/i915_drv.h |  2 ++
>   drivers/gpu/drm/i915/i915_gem.c | 55 +++++++++++++++++++++++++++++++++++++++++
>   include/uapi/drm/i915_drm.h     |  1 +
>   4 files changed, 61 insertions(+)

As long as this is tested and returns the same as L3 in /proc/cpuinfo, this patch is
Reviewed-by: Chad Versace <chad.versace@linux.intel.com>

      parent reply	other threads:[~2013-07-12 17:38 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-10  2:58 [PATCH] drm/i915: Expose LLC size to user space Ben Widawsky
2013-07-10  2:58 ` [PATCH] intel_get_llc_size: Small tool to query LLC size Ben Widawsky
2013-07-10  6:34   ` Daniel Vetter
2013-07-10 16:58     ` Ben Widawsky
2013-07-10 17:15       ` Daniel Vetter
2013-07-10 17:24         ` Ben Widawsky
2013-07-10 17:45           ` Daniel Vetter
2013-07-10  8:59 ` [PATCH] drm/i915: Expose LLC size to user space Chris Wilson
2013-07-10 16:40   ` Ben Widawsky
2013-07-10 17:11     ` Ben Widawsky
2013-07-10 17:40     ` Chris Wilson
2013-07-10 17:46       ` Ben Widawsky
2013-07-10 18:00         ` Chris Wilson
2013-07-10 18:44           ` Ben Widawsky
2013-07-10 17:00 ` Bell, Bryan J
2013-07-11  0:16 ` Chad Versace
2013-07-11  5:06   ` Ben Widawsky
2013-07-11 18:52 ` [PATCH] [v2] " Ben Widawsky
2013-07-11 18:53   ` [PATCH 1/2] intel_get_llc_size: Small tool to query LLC size Ben Widawsky
2013-07-11 18:53     ` [PATCH 2/2] tests: Basic tools tester Ben Widawsky
2013-07-12 17:39     ` [PATCH 1/2] intel_get_llc_size: Small tool to query LLC size Chad Versace
2013-07-12 17:49       ` Ben Widawsky
2013-07-11 20:46   ` [PATCH] [v2] drm/i915: Expose LLC size to user space Chris Wilson
2013-07-12 17:38   ` Chad Versace [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51E03EF9.2000809@linux.intel.com \
    --to=chad.versace@linux.intel.com \
    --cc=ben@bwidawsk.net \
    --cc=bryan.j.bell@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.