* [PATCH] f2fs: add the missing delection of orphan inode entry in write_orphan_inodes()
@ 2013-07-19 8:18 Gu Zheng
2013-07-22 12:51 ` [f2fs-dev] " Jaegeuk Kim
0 siblings, 1 reply; 5+ messages in thread
From: Gu Zheng @ 2013-07-19 8:18 UTC (permalink / raw)
To: Kim; +Cc: f2fs, linux-kernel
After writing orphan inode entry in jornal block, we need to delete each
entry from the orphan entry list, and release them.
Signed-off-by: Gu Zheng <guz.fnst@cn.fujitsu.com>
---
fs/f2fs/checkpoint.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
index 66a6b85..290db04 100644
--- a/fs/f2fs/checkpoint.c
+++ b/fs/f2fs/checkpoint.c
@@ -337,6 +337,10 @@ static void write_orphan_inodes(struct f2fs_sb_info *sbi, block_t start_blk)
memset(orphan_blk, 0, sizeof(*orphan_blk));
page_exist:
orphan_blk->ino[nentries++] = cpu_to_le32(orphan->ino);
+
+ list_del(&orphan->list);
+ kmem_cache_free(orphan_entry_slab, orphan);
+ sbi->n_orphans--;
}
if (!page)
goto end;
--
1.7.7
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] f2fs: add the missing delection of orphan inode entry in write_orphan_inodes()
2013-07-19 8:18 [PATCH] f2fs: add the missing delection of orphan inode entry in write_orphan_inodes() Gu Zheng
@ 2013-07-22 12:51 ` Jaegeuk Kim
0 siblings, 0 replies; 5+ messages in thread
From: Jaegeuk Kim @ 2013-07-22 12:51 UTC (permalink / raw)
To: Gu Zheng; +Cc: f2fs, linux-kernel
Hi,
2013-07-19 (금), 16:18 +0800, Gu Zheng:
> After writing orphan inode entry in jornal block, we need to delete each
> entry from the orphan entry list, and release them.
>
>
> Signed-off-by: Gu Zheng <guz.fnst@cn.fujitsu.com>
> ---
> fs/f2fs/checkpoint.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
> index 66a6b85..290db04 100644
> --- a/fs/f2fs/checkpoint.c
> +++ b/fs/f2fs/checkpoint.c
> @@ -337,6 +337,10 @@ static void write_orphan_inodes(struct f2fs_sb_info *sbi, block_t start_blk)
> memset(orphan_blk, 0, sizeof(*orphan_blk));
> page_exist:
> orphan_blk->ino[nentries++] = cpu_to_le32(orphan->ino);
> +
> + list_del(&orphan->list);
> + kmem_cache_free(orphan_entry_slab, orphan);
> + sbi->n_orphans--;
NAK.
We should not release them here.
Only f2fs_evict_inode can do it.
> }
> if (!page)
> goto end;
--
Jaegeuk Kim
Samsung
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: add the missing delection of orphan inode entry in write_orphan_inodes()
@ 2013-07-22 12:51 ` Jaegeuk Kim
0 siblings, 0 replies; 5+ messages in thread
From: Jaegeuk Kim @ 2013-07-22 12:51 UTC (permalink / raw)
To: Gu Zheng; +Cc: linux-kernel, f2fs
Hi,
2013-07-19 (금), 16:18 +0800, Gu Zheng:
> After writing orphan inode entry in jornal block, we need to delete each
> entry from the orphan entry list, and release them.
>
>
> Signed-off-by: Gu Zheng <guz.fnst@cn.fujitsu.com>
> ---
> fs/f2fs/checkpoint.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
> index 66a6b85..290db04 100644
> --- a/fs/f2fs/checkpoint.c
> +++ b/fs/f2fs/checkpoint.c
> @@ -337,6 +337,10 @@ static void write_orphan_inodes(struct f2fs_sb_info *sbi, block_t start_blk)
> memset(orphan_blk, 0, sizeof(*orphan_blk));
> page_exist:
> orphan_blk->ino[nentries++] = cpu_to_le32(orphan->ino);
> +
> + list_del(&orphan->list);
> + kmem_cache_free(orphan_entry_slab, orphan);
> + sbi->n_orphans--;
NAK.
We should not release them here.
Only f2fs_evict_inode can do it.
> }
> if (!page)
> goto end;
--
Jaegeuk Kim
Samsung
------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] f2fs: add the missing delection of orphan inode entry in write_orphan_inodes()
2013-07-22 12:51 ` [f2fs-dev] " Jaegeuk Kim
@ 2013-07-23 1:24 ` Gu Zheng
-1 siblings, 0 replies; 5+ messages in thread
From: Gu Zheng @ 2013-07-23 1:24 UTC (permalink / raw)
To: jaegeuk.kim; +Cc: f2fs, linux-kernel
On 07/22/2013 08:51 PM, Jaegeuk Kim wrote:
> Hi,
>
> 2013-07-19 (금), 16:18 +0800, Gu Zheng:
>> After writing orphan inode entry in jornal block, we need to delete each
>> entry from the orphan entry list, and release them.
>>
>>
>> Signed-off-by: Gu Zheng <guz.fnst@cn.fujitsu.com>
>> ---
>> fs/f2fs/checkpoint.c | 4 ++++
>> 1 files changed, 4 insertions(+), 0 deletions(-)
>>
>> diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
>> index 66a6b85..290db04 100644
>> --- a/fs/f2fs/checkpoint.c
>> +++ b/fs/f2fs/checkpoint.c
>> @@ -337,6 +337,10 @@ static void write_orphan_inodes(struct f2fs_sb_info *sbi, block_t start_blk)
>> memset(orphan_blk, 0, sizeof(*orphan_blk));
>> page_exist:
>> orphan_blk->ino[nentries++] = cpu_to_le32(orphan->ino);
>> +
>> + list_del(&orphan->list);
>> + kmem_cache_free(orphan_entry_slab, orphan);
>> + sbi->n_orphans--;
>
> NAK.
> We should not release them here.
> Only f2fs_evict_inode can do it.
Yeah, f2fs_evict_inode can do this job safely, sorry for my mistake,
please ignore this patch.:)
Regards,
Gu
>
>> }
>> if (!page)
>> goto end;
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: add the missing delection of orphan inode entry in write_orphan_inodes()
@ 2013-07-23 1:24 ` Gu Zheng
0 siblings, 0 replies; 5+ messages in thread
From: Gu Zheng @ 2013-07-23 1:24 UTC (permalink / raw)
To: jaegeuk.kim; +Cc: linux-kernel, f2fs
On 07/22/2013 08:51 PM, Jaegeuk Kim wrote:
> Hi,
>
> 2013-07-19 (금), 16:18 +0800, Gu Zheng:
>> After writing orphan inode entry in jornal block, we need to delete each
>> entry from the orphan entry list, and release them.
>>
>>
>> Signed-off-by: Gu Zheng <guz.fnst@cn.fujitsu.com>
>> ---
>> fs/f2fs/checkpoint.c | 4 ++++
>> 1 files changed, 4 insertions(+), 0 deletions(-)
>>
>> diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
>> index 66a6b85..290db04 100644
>> --- a/fs/f2fs/checkpoint.c
>> +++ b/fs/f2fs/checkpoint.c
>> @@ -337,6 +337,10 @@ static void write_orphan_inodes(struct f2fs_sb_info *sbi, block_t start_blk)
>> memset(orphan_blk, 0, sizeof(*orphan_blk));
>> page_exist:
>> orphan_blk->ino[nentries++] = cpu_to_le32(orphan->ino);
>> +
>> + list_del(&orphan->list);
>> + kmem_cache_free(orphan_entry_slab, orphan);
>> + sbi->n_orphans--;
>
> NAK.
> We should not release them here.
> Only f2fs_evict_inode can do it.
Yeah, f2fs_evict_inode can do this job safely, sorry for my mistake,
please ignore this patch.:)
Regards,
Gu
>
>> }
>> if (!page)
>> goto end;
>
------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-07-23 1:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-19 8:18 [PATCH] f2fs: add the missing delection of orphan inode entry in write_orphan_inodes() Gu Zheng
2013-07-22 12:51 ` Jaegeuk Kim
2013-07-22 12:51 ` [f2fs-dev] " Jaegeuk Kim
2013-07-23 1:24 ` Gu Zheng
2013-07-23 1:24 ` [f2fs-dev] " Gu Zheng
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.