* [PATCH] Make BCMA_HOST_SOC depend on BCM47XX
@ 2013-07-23 2:31 John W. Linville
2013-07-23 7:26 ` Hauke Mehrtens
0 siblings, 1 reply; 5+ messages in thread
From: John W. Linville @ 2013-07-23 2:31 UTC (permalink / raw)
To: linux-wireless; +Cc: Rafał Miłecki, John W. Linville
From: "John W. Linville" <linville@tuxdriver.com>
Otherwise, 'make allyesconfig' generates this:
CC [M] drivers/net/ethernet/broadcom/bgmac.o
drivers/net/ethernet/broadcom/bgmac.c:19:27: fatal error:
bcm47xx_nvram.h: No such file or directory
compilation terminated.
make[4]: *** [drivers/net/ethernet/broadcom/bgmac.o] Error 1
make[3]: *** [drivers/net/ethernet/broadcom] Error 2
make[2]: *** [drivers/net/ethernet] Error 2
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2
Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
drivers/bcma/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig
index 7c081b3..a2bdab1 100644
--- a/drivers/bcma/Kconfig
+++ b/drivers/bcma/Kconfig
@@ -36,7 +36,7 @@ config BCMA_DRIVER_PCI_HOSTMODE
config BCMA_HOST_SOC
bool "Support for BCMA in a SoC"
- depends on BCMA
+ depends on BCMA && BCM47XX
help
Host interface for a Broadcom AIX bus directly mapped into
the memory. This only works with the Broadcom SoCs from the
--
1.8.1.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Make BCMA_HOST_SOC depend on BCM47XX
2013-07-23 2:31 [PATCH] Make BCMA_HOST_SOC depend on BCM47XX John W. Linville
@ 2013-07-23 7:26 ` Hauke Mehrtens
2013-07-23 7:50 ` Rafał Miłecki
0 siblings, 1 reply; 5+ messages in thread
From: Hauke Mehrtens @ 2013-07-23 7:26 UTC (permalink / raw)
To: John W. Linville; +Cc: linux-wireless, Rafał Miłecki
On 07/23/2013 04:31 AM, John W. Linville wrote:
> From: "John W. Linville" <linville@tuxdriver.com>
>
> Otherwise, 'make allyesconfig' generates this:
>
> CC [M] drivers/net/ethernet/broadcom/bgmac.o
> drivers/net/ethernet/broadcom/bgmac.c:19:27: fatal error:
> bcm47xx_nvram.h: No such file or directory
> compilation terminated.
> make[4]: *** [drivers/net/ethernet/broadcom/bgmac.o] Error 1
> make[3]: *** [drivers/net/ethernet/broadcom] Error 2
> make[2]: *** [drivers/net/ethernet] Error 2
> make[1]: *** [drivers/net] Error 2
> make: *** [drivers] Error 2
>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
> ---
> drivers/bcma/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig
> index 7c081b3..a2bdab1 100644
> --- a/drivers/bcma/Kconfig
> +++ b/drivers/bcma/Kconfig
> @@ -36,7 +36,7 @@ config BCMA_DRIVER_PCI_HOSTMODE
>
> config BCMA_HOST_SOC
> bool "Support for BCMA in a SoC"
> - depends on BCMA
> + depends on BCMA && BCM47XX
> help
> Host interface for a Broadcom AIX bus directly mapped into
> the memory. This only works with the Broadcom SoCs from the
>
I think bgmac should depend on BCM47XX.
Hauke
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Make BCMA_HOST_SOC depend on BCM47XX
2013-07-23 7:26 ` Hauke Mehrtens
@ 2013-07-23 7:50 ` Rafał Miłecki
2013-07-23 11:06 ` Florian Fainelli
0 siblings, 1 reply; 5+ messages in thread
From: Rafał Miłecki @ 2013-07-23 7:50 UTC (permalink / raw)
To: Hauke Mehrtens; +Cc: John W. Linville, linux-wireless
2013/7/23 Hauke Mehrtens <hauke@hauke-m.de>:
> On 07/23/2013 04:31 AM, John W. Linville wrote:
>> From: "John W. Linville" <linville@tuxdriver.com>
>>
>> Otherwise, 'make allyesconfig' generates this:
>>
>> CC [M] drivers/net/ethernet/broadcom/bgmac.o
>> drivers/net/ethernet/broadcom/bgmac.c:19:27: fatal error:
>> bcm47xx_nvram.h: No such file or directory
>> compilation terminated.
>> make[4]: *** [drivers/net/ethernet/broadcom/bgmac.o] Error 1
>> make[3]: *** [drivers/net/ethernet/broadcom] Error 2
>> make[2]: *** [drivers/net/ethernet] Error 2
>> make[1]: *** [drivers/net] Error 2
>> make: *** [drivers] Error 2
>>
>> Signed-off-by: John W. Linville <linville@tuxdriver.com>
>> ---
>> drivers/bcma/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig
>> index 7c081b3..a2bdab1 100644
>> --- a/drivers/bcma/Kconfig
>> +++ b/drivers/bcma/Kconfig
>> @@ -36,7 +36,7 @@ config BCMA_DRIVER_PCI_HOSTMODE
>>
>> config BCMA_HOST_SOC
>> bool "Support for BCMA in a SoC"
>> - depends on BCMA
>> + depends on BCMA && BCM47XX
>> help
>> Host interface for a Broadcom AIX bus directly mapped into
>> the memory. This only works with the Broadcom SoCs from the
>>
> I think bgmac should depend on BCM47XX.
Yeah, I'm wondering about that.
It's bgmac that calls BCM47XX specific functions (nvram).
On the other hand it doesn't make much sense to use BCMA_HOST_SOC on
anything else than BCM47XX, does it?
--
Rafał
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Make BCMA_HOST_SOC depend on BCM47XX
2013-07-23 7:50 ` Rafał Miłecki
@ 2013-07-23 11:06 ` Florian Fainelli
2013-07-23 21:36 ` Hauke Mehrtens
0 siblings, 1 reply; 5+ messages in thread
From: Florian Fainelli @ 2013-07-23 11:06 UTC (permalink / raw)
To: Rafał Miłecki; +Cc: Hauke Mehrtens, John W. Linville, linux-wireless
2013/7/23 Rafał Miłecki <zajec5@gmail.com>:
> 2013/7/23 Hauke Mehrtens <hauke@hauke-m.de>:
>> On 07/23/2013 04:31 AM, John W. Linville wrote:
>>> From: "John W. Linville" <linville@tuxdriver.com>
>>>
>>> Otherwise, 'make allyesconfig' generates this:
>>>
>>> CC [M] drivers/net/ethernet/broadcom/bgmac.o
>>> drivers/net/ethernet/broadcom/bgmac.c:19:27: fatal error:
>>> bcm47xx_nvram.h: No such file or directory
>>> compilation terminated.
>>> make[4]: *** [drivers/net/ethernet/broadcom/bgmac.o] Error 1
>>> make[3]: *** [drivers/net/ethernet/broadcom] Error 2
>>> make[2]: *** [drivers/net/ethernet] Error 2
>>> make[1]: *** [drivers/net] Error 2
>>> make: *** [drivers] Error 2
>>>
>>> Signed-off-by: John W. Linville <linville@tuxdriver.com>
>>> ---
>>> drivers/bcma/Kconfig | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig
>>> index 7c081b3..a2bdab1 100644
>>> --- a/drivers/bcma/Kconfig
>>> +++ b/drivers/bcma/Kconfig
>>> @@ -36,7 +36,7 @@ config BCMA_DRIVER_PCI_HOSTMODE
>>>
>>> config BCMA_HOST_SOC
>>> bool "Support for BCMA in a SoC"
>>> - depends on BCMA
>>> + depends on BCMA && BCM47XX
>>> help
>>> Host interface for a Broadcom AIX bus directly mapped into
>>> the memory. This only works with the Broadcom SoCs from the
>>>
>> I think bgmac should depend on BCM47XX.
>
> Yeah, I'm wondering about that.
>
> It's bgmac that calls BCM47XX specific functions (nvram).
And this is bad, make that a platform_data callback or something like
that such that there is no build-time dependency on nvram functions.
>
> On the other hand it doesn't make much sense to use BCMA_HOST_SOC on
> anything else than BCM47XX, does it?
Hauke has been working on BCM53XX which is an ARM-based BCM47XX-like
SoC, but that just means depends on (BCM47XX || ARCH_BCM53XX) then.
--
Florian
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Make BCMA_HOST_SOC depend on BCM47XX
2013-07-23 11:06 ` Florian Fainelli
@ 2013-07-23 21:36 ` Hauke Mehrtens
0 siblings, 0 replies; 5+ messages in thread
From: Hauke Mehrtens @ 2013-07-23 21:36 UTC (permalink / raw)
To: Florian Fainelli
Cc: Rafał Miłecki, John W. Linville, linux-wireless
On 07/23/2013 01:06 PM, Florian Fainelli wrote:
> 2013/7/23 Rafał Miłecki <zajec5@gmail.com>:
>> 2013/7/23 Hauke Mehrtens <hauke@hauke-m.de>:
>>> On 07/23/2013 04:31 AM, John W. Linville wrote:
>>>> From: "John W. Linville" <linville@tuxdriver.com>
>>>>
>>>> Otherwise, 'make allyesconfig' generates this:
>>>>
>>>> CC [M] drivers/net/ethernet/broadcom/bgmac.o
>>>> drivers/net/ethernet/broadcom/bgmac.c:19:27: fatal error:
>>>> bcm47xx_nvram.h: No such file or directory
>>>> compilation terminated.
>>>> make[4]: *** [drivers/net/ethernet/broadcom/bgmac.o] Error 1
>>>> make[3]: *** [drivers/net/ethernet/broadcom] Error 2
>>>> make[2]: *** [drivers/net/ethernet] Error 2
>>>> make[1]: *** [drivers/net] Error 2
>>>> make: *** [drivers] Error 2
>>>>
>>>> Signed-off-by: John W. Linville <linville@tuxdriver.com>
>>>> ---
>>>> drivers/bcma/Kconfig | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig
>>>> index 7c081b3..a2bdab1 100644
>>>> --- a/drivers/bcma/Kconfig
>>>> +++ b/drivers/bcma/Kconfig
>>>> @@ -36,7 +36,7 @@ config BCMA_DRIVER_PCI_HOSTMODE
>>>>
>>>> config BCMA_HOST_SOC
>>>> bool "Support for BCMA in a SoC"
>>>> - depends on BCMA
>>>> + depends on BCMA && BCM47XX
>>>> help
>>>> Host interface for a Broadcom AIX bus directly mapped into
>>>> the memory. This only works with the Broadcom SoCs from the
>>>>
>>> I think bgmac should depend on BCM47XX.
>>
>> Yeah, I'm wondering about that.
>>
>> It's bgmac that calls BCM47XX specific functions (nvram).
>
> And this is bad, make that a platform_data callback or something like
> that such that there is no build-time dependency on nvram functions.
Ok, I will try that. I still have no idea how to handle the nvram stuff
properly with DT on arm. My current plan is to do this stuff properly
for arm and try to use most of the improvements also for mips.
>> On the other hand it doesn't make much sense to use BCMA_HOST_SOC on
>> anything else than BCM47XX, does it?
>
> Hauke has been working on BCM53XX which is an ARM-based BCM47XX-like
> SoC, but that just means depends on (BCM47XX || ARCH_BCM53XX) then.
Yes preparing for adding arm support was the intention of this patch
series, it was some code which should not harm the mips part or any other.
Hauke
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-07-23 21:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-23 2:31 [PATCH] Make BCMA_HOST_SOC depend on BCM47XX John W. Linville
2013-07-23 7:26 ` Hauke Mehrtens
2013-07-23 7:50 ` Rafał Miłecki
2013-07-23 11:06 ` Florian Fainelli
2013-07-23 21:36 ` Hauke Mehrtens
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.