alsa-lib 1.0.27 incorrect definition of __kernel_off_t?

alsa-lib 1.0.27 incorrect definition of __kernel_off_t?

[Kevin Groeneveld]

I tried doing a cross compile of alsa-lib 1.0.27.2 today and ended up with
the following error:

error: conflicting types for 'off_t'

Commit 9b5beef1 adds the following line to local.h:

#define __kernel_off_t        off_t

Not only is __kernel_off_t already defined elsewhere in my header files,
the above line tries to define __kernel_off_t (which I think should be 32
bit on my platform) to off_t which is 64 bit.

I just deleted the line and everything seems to be working so far.


Kevin

Re: alsa-lib 1.0.27 incorrect definition of __kernel_off_t?

[Jaroslav Kysela]

Date 22.7.2013 23:22, Kevin Groeneveld wrote:
> I tried doing a cross compile of alsa-lib 1.0.27.2 today and ended up with
> the following error:
> 
> error: conflicting types for 'off_t'
> 
> Commit 9b5beef1 adds the following line to local.h:
> 
> #define __kernel_off_t        off_t
> 
> Not only is __kernel_off_t already defined elsewhere in my header files,
> the above line tries to define __kernel_off_t (which I think should be 32
> bit on my platform) to off_t which is 64 bit.
> 
> I just deleted the line and everything seems to be working so far.

I tried to fix this issue using <linux/types.h>. Please, check:

http://git.alsa-project.org/?p=alsa-lib.git;a=commitdiff;h=b3b53a1bec47aaa2baef724cc9e79adadd603caf

					Jaroslav


-- 
Jaroslav Kysela <perex@perex.cz>
Linux Kernel Sound Maintainer
ALSA Project; Red Hat, Inc.

Re: alsa-lib 1.0.27 incorrect definition of __kernel_off_t?

[Kevin Groeneveld]

On Tue, Jul 23, 2013 at 8:55 AM, Jaroslav Kysela <perex@perex.cz> wrote:

> I tried to fix this issue using <linux/types.h>. Please, check:
>
>
> http://git.alsa-project.org/?p=alsa-lib.git;a=commitdiff;h=b3b53a1bec47aaa2baef724cc9e79adadd603caf
>
>
Yes, that patch fixes the compile error I was getting.  Thanks for looking
into this.

You don't actually need to include <linux/types.h> in local.h.  local.h
includes asound.h which already includes <linux/types.h>.  This is how I
just got away with deleting the #define __kernel_off_t line.


Kevin