All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: "Anthony Liguori" <aliguori@us.ibm.com>,
	seabios@seabios.org, qemu-devel@nongnu.org,
	"Aurelien Jarno" <aurelien@aurel32.net>,
	"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [SeaBIOS] [PATCH v2 3/4] i386: generate pc guest info
Date: Wed, 24 Jul 2013 16:42:08 +0200	[thread overview]
Message-ID: <51EFE7C0.5060202@redhat.com> (raw)
In-Reply-To: <20130708195259.GA19775@redhat.com>

  Hi,

>> This does not satisfy the "should use QOM properties" requirement that
>> we discussed in the RFC thread.
> 
> I don't know which part of the RFC thread still applied and
> which doesn't: at that point you were rejecting the whole
> approach.
> 
> I found a mail where you said:
> 	I'd be a lot happier if we were passing more information to this routine
> 	and not hard coding it.  For instance, the PCI interrupt assignments,
> 	the APIC ids, the number of available CPUs, etc.
> 
> So this is exactly what this code does.
> What, exactly, would you like to see instead?
> Create a guest info QOM object, and encode all information used by ACPI
> generation as properties of this object?

Don't touch device code for this.

>>> -void pvpanic_init(ISABus *bus)
>>> +void pvpanic_init(ISABus *bus, PcGuestInfo *guest_info)
>>>  {
>>>      ISADevice *dev;
>>> -    FWCfgState *fw_cfg = fw_cfg_find();
>>> +    FWCfgState *fw_cfg = guest_info->fw_cfg;
>>>      if (!fw_cfg) {
>>>          return;
>>>      }
>>>      dev = isa_create_simple (bus, TYPE_ISA_PVPANIC_DEVICE);
>>> -    pvpanic_fw_cfg(dev, fw_cfg);
>>> +    pvpanic_guest_info(dev, guest_info);
>>>  }

To pick this one as example:  Instead of patching pvpanic code to stuff
config info into GuestInfo you should (1) search the device object tree
for a pvpanic device and (b) if present read the ioport property to
figure the base address.

/me suggests to check out qmp_qom_get() in qmp.c.  Some qom aequivalent
for qdev_find_recursive would be handy, dunno whenever such a thing
exists already, Andreas?

I'd tend to accept GuestInfo as temporary thing for stuff which can't be
figured using qom properties today.  Anthony might disagree though.

cheers,
  Gerd

  reply	other threads:[~2013-07-24 14:42 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-08 18:30 [Qemu-devel] [PATCH v2 0/4] qemu: generate acpi tables for the guest Michael S. Tsirkin
2013-07-08 18:30 ` [Qemu-devel] [PATCH v2 1/4] loader: support for unmapped ROM blobs Michael S. Tsirkin
2013-07-08 18:30 ` [Qemu-devel] [PATCH v2 2/4] loader: allow adding ROMs in done callbacks Michael S. Tsirkin
2013-07-08 18:30 ` [Qemu-devel] [PATCH v2 3/4] i386: generate pc guest info Michael S. Tsirkin
2013-07-08 19:10   ` [Qemu-devel] [SeaBIOS] " Anthony Liguori
2013-07-08 19:52     ` Michael S. Tsirkin
2013-07-24 14:42       ` Gerd Hoffmann [this message]
2013-07-24 14:52         ` Andreas Färber
2013-07-24 15:04           ` Gerd Hoffmann
2013-07-24 15:09             ` Andreas Färber
2013-07-24 15:11               ` Paolo Bonzini
2013-07-24 16:17           ` Michael S. Tsirkin
2013-07-24 15:28         ` Michael S. Tsirkin
2013-07-11 20:25     ` [Qemu-devel] " Michael S. Tsirkin
2013-07-08 18:30 ` [Qemu-devel] [PATCH v2 4/4] i386: ACPI table generation code from seabios Michael S. Tsirkin
2013-07-08 19:16   ` [Qemu-devel] [SeaBIOS] " Anthony Liguori
2013-07-08 19:57     ` Michael S. Tsirkin
2013-07-09  7:53 ` [Qemu-devel] [PATCH v2 0/4] qemu: generate acpi tables for the guest Laszlo Ersek
2013-07-09  7:57   ` Michael S. Tsirkin
2013-07-09  8:04     ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51EFE7C0.5060202@redhat.com \
    --to=kraxel@redhat.com \
    --cc=afaerber@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=aurelien@aurel32.net \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=seabios@seabios.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.