Re: [Qemu-devel] [SeaBIOS] [PATCH v2 3/4] i386: generate pc guest info

From: "Andreas Färber" <afaerber@suse.de>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	seabios@seabios.org, qemu-devel@nongnu.org,
	Paolo Bonzini <pbonzini@redhat.com>,
	Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [SeaBIOS] [PATCH v2 3/4] i386: generate pc guest info
Date: Wed, 24 Jul 2013 17:09:03 +0200	[thread overview]
Message-ID: <51EFEE0F.1090605@suse.de> (raw)
In-Reply-To: <51EFECE9.3090308@redhat.com>

Hi,

Am 24.07.2013 17:04, schrieb Gerd Hoffmann:
>>> /me suggests to check out qmp_qom_get() in qmp.c.  Some qom aequivalent
>>> for qdev_find_recursive would be handy, dunno whenever such a thing
>>> exists already, Andreas?
>>
>> Not sure what's needed here? object_resolve_path() and
>> object_foreach_child() come to mind...
> 
> object_resolve_path should do to (a) figure whenever we are i440fx or
> q35 and (b) get the pcihost device (then read enable_s3 etc properties).
> 
> For pvpanic (and maybe others) it might be handy to have "find me the
> device of type TYPE_ISA_PVPANIC_DEVICE, anywhere in the tree"
> functionality, so the same code works no matter where the isa bridge
> happens to live.  Or "find me all pci bridges in the system".

I think Paolo used object_resolve_path_type("", TYPE_...) for that
somewhere in audio code.

> Is object_foreach_child recursive?  Then it might do the job ...

No, recursion would need to be implemented in the callback - my recent
recursive QOM realization series had an example of a deep search for
devices.

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg