From: Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org> To: Santosh Shilimkar <santosh.shilimkar-l0cyMroinI0@public.gmane.org> Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> Subject: Re: [PATCH 1/2] i2c: davinci: remove useless mach/hardware include Date: Thu, 25 Jul 2013 15:10:19 +0530 [thread overview] Message-ID: <51F0F283.5080900@ti.com> (raw) In-Reply-To: <1374712099-32095-2-git-send-email-santosh.shilimkar-l0cyMroinI0@public.gmane.org> On Thursday 25 July 2013 05:58 AM, Santosh Shilimkar wrote: > This driver no longer uses definitions from mach/hardware.h. > On the other hand, including this header breaks this driver > on non-davinci platforms which don't have such a header. > > Fix it. > > Cc: Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org> > Cc: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> > > Signed-off-by: Santosh Shilimkar <santosh.shilimkar-l0cyMroinI0@public.gmane.org> Acked-by: Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org> One minor nit: > --- > drivers/i2c/busses/i2c-davinci.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-davinci.c > index fa55605..ddaa2a3 100644 > --- a/drivers/i2c/busses/i2c-davinci.c > +++ b/drivers/i2c/busses/i2c-davinci.c > @@ -41,7 +41,6 @@ > #include <linux/of_i2c.h> > #include <linux/of_device.h> > You can now remove this empty line too. Thanks, Sekhar > -#include <mach/hardware.h> > #include <linux/platform_data/i2c-davinci.h> > > /* ----- global defines ----------------------------------------------- */ >
WARNING: multiple messages have this Message-ID (diff)
From: nsekhar@ti.com (Sekhar Nori) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/2] i2c: davinci: remove useless mach/hardware include Date: Thu, 25 Jul 2013 15:10:19 +0530 [thread overview] Message-ID: <51F0F283.5080900@ti.com> (raw) In-Reply-To: <1374712099-32095-2-git-send-email-santosh.shilimkar@ti.com> On Thursday 25 July 2013 05:58 AM, Santosh Shilimkar wrote: > This driver no longer uses definitions from mach/hardware.h. > On the other hand, including this header breaks this driver > on non-davinci platforms which don't have such a header. > > Fix it. > > Cc: Sekhar Nori <nsekhar@ti.com> > Cc: Wolfram Sang <wsa@the-dreams.de> > > Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com> Acked-by: Sekhar Nori <nsekhar@ti.com> One minor nit: > --- > drivers/i2c/busses/i2c-davinci.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-davinci.c > index fa55605..ddaa2a3 100644 > --- a/drivers/i2c/busses/i2c-davinci.c > +++ b/drivers/i2c/busses/i2c-davinci.c > @@ -41,7 +41,6 @@ > #include <linux/of_i2c.h> > #include <linux/of_device.h> > You can now remove this empty line too. Thanks, Sekhar > -#include <mach/hardware.h> > #include <linux/platform_data/i2c-davinci.h> > > /* ----- global defines ----------------------------------------------- */ >
next prev parent reply other threads:[~2013-07-25 9:40 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-07-25 0:28 [PATCH 0/2] i2c: davinci: Couple of patches to make i2c usable on Keystone SOCs Santosh Shilimkar 2013-07-25 0:28 ` Santosh Shilimkar [not found] ` <1374712099-32095-1-git-send-email-santosh.shilimkar-l0cyMroinI0@public.gmane.org> 2013-07-25 0:28 ` [PATCH 1/2] i2c: davinci: remove useless mach/hardware include Santosh Shilimkar 2013-07-25 0:28 ` Santosh Shilimkar [not found] ` <1374712099-32095-2-git-send-email-santosh.shilimkar-l0cyMroinI0@public.gmane.org> 2013-07-25 9:40 ` Sekhar Nori [this message] 2013-07-25 9:40 ` Sekhar Nori 2013-07-25 20:59 ` Santosh Shilimkar 2013-07-25 20:59 ` Santosh Shilimkar [not found] ` <51F191AD.9020108-l0cyMroinI0@public.gmane.org> 2013-08-15 12:31 ` Wolfram Sang 2013-08-15 12:31 ` Wolfram Sang 2013-08-09 20:09 ` [PATCH 0/2] i2c: davinci: Couple of patches to make i2c usable on Keystone SOCs Santosh Shilimkar 2013-08-09 20:09 ` Santosh Shilimkar [not found] ` <52054C7E.70108-l0cyMroinI0@public.gmane.org> 2013-08-11 9:53 ` Wolfram Sang 2013-08-11 9:53 ` Wolfram Sang [not found] ` <20130811095337.GA3796-z923LK4zBo2bacvFa/9K2g@public.gmane.org> 2013-08-12 0:26 ` Shilimkar, Santosh 2013-08-12 0:26 ` Shilimkar, Santosh 2013-07-25 0:28 ` [PATCH 2/2] i2c: davinci: Allow i2c driver available for keystone platforms Santosh Shilimkar 2013-07-25 0:28 ` Santosh Shilimkar [not found] ` <1374712099-32095-3-git-send-email-santosh.shilimkar-l0cyMroinI0@public.gmane.org> 2013-08-15 12:31 ` Wolfram Sang 2013-08-15 12:31 ` Wolfram Sang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=51F0F283.5080900@ti.com \ --to=nsekhar-l0cymroini0@public.gmane.org \ --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=santosh.shilimkar-l0cyMroinI0@public.gmane.org \ --cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.