[PATCH 1/4] [media] em28xx: fix assignment of the eeprom data.

[PATCH 1/4] [media] em28xx: fix assignment of the eeprom data.

[Alban Browaeys]

Set the config structure pointer to the eeprom data pointer (data,
here eedata dereferenced) not the pointer to the pointer to
the eeprom data (eedata itself).

Signed-off-by: Alban Browaeys <prahal@yahoo.com>
---
 drivers/media/usb/em28xx/em28xx-i2c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/usb/em28xx/em28xx-i2c.c b/drivers/media/usb/em28xx/em28xx-i2c.c
index 4851cc2..c4ff973 100644
--- a/drivers/media/usb/em28xx/em28xx-i2c.c
+++ b/drivers/media/usb/em28xx/em28xx-i2c.c
@@ -726,7 +726,7 @@ static int em28xx_i2c_eeprom(struct em28xx *dev, unsigned bus,
 
 	*eedata = data;
 	*eedata_len = len;
-	dev_config = (void *)eedata;
+	dev_config = (void *)*eedata;
 
 	switch (le16_to_cpu(dev_config->chip_conf) >> 4 & 0x3) {
 	case 0:
-- 
1.8.3.2

Re: [PATCH 1/4] [media] em28xx: fix assignment of the eeprom data.

[Frank Schäfer]

Am 17.07.2013 00:57, schrieb Alban Browaeys:
> Set the config structure pointer to the eeprom data pointer (data,
> here eedata dereferenced) not the pointer to the pointer to
> the eeprom data (eedata itself).
>
> Signed-off-by: Alban Browaeys <prahal@yahoo.com>
> ---
>  drivers/media/usb/em28xx/em28xx-i2c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/usb/em28xx/em28xx-i2c.c b/drivers/media/usb/em28xx/em28xx-i2c.c
> index 4851cc2..c4ff973 100644
> --- a/drivers/media/usb/em28xx/em28xx-i2c.c
> +++ b/drivers/media/usb/em28xx/em28xx-i2c.c
> @@ -726,7 +726,7 @@ static int em28xx_i2c_eeprom(struct em28xx *dev, unsigned bus,
>  
>  	*eedata = data;
>  	*eedata_len = len;
> -	dev_config = (void *)eedata;
> +	dev_config = (void *)*eedata;
>  
>  	switch (le16_to_cpu(dev_config->chip_conf) >> 4 & 0x3) {
>  	case 0:
Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com>

Thanks,
Frank

Re: [PATCH 1/4] [media] em28xx: fix assignment of the eeprom data.

[Antti Palosaari]

On 07/18/2013 06:13 PM, Frank Schäfer wrote:
> Am 17.07.2013 00:57, schrieb Alban Browaeys:
>> Set the config structure pointer to the eeprom data pointer (data,
>> here eedata dereferenced) not the pointer to the pointer to
>> the eeprom data (eedata itself).
>>
>> Signed-off-by: Alban Browaeys <prahal@yahoo.com>
>> ---
>>   drivers/media/usb/em28xx/em28xx-i2c.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/usb/em28xx/em28xx-i2c.c b/drivers/media/usb/em28xx/em28xx-i2c.c
>> index 4851cc2..c4ff973 100644
>> --- a/drivers/media/usb/em28xx/em28xx-i2c.c
>> +++ b/drivers/media/usb/em28xx/em28xx-i2c.c
>> @@ -726,7 +726,7 @@ static int em28xx_i2c_eeprom(struct em28xx *dev, unsigned bus,
>>
>>   	*eedata = data;
>>   	*eedata_len = len;
>> -	dev_config = (void *)eedata;
>> +	dev_config = (void *)*eedata;
>>
>>   	switch (le16_to_cpu(dev_config->chip_conf) >> 4 & 0x3) {
>>   	case 0:
> Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com>

Does that SOB mean you will pick that patch via you tree, or was it only 
a mistake?

I have thought few times what should I reply to patches which are for 
modules I am maintaining and I will pick up and pull-request via own 
tree. Usually I just reply "patch applied" but maybe Signed-off-by is 
used for same.

regards
Antti

-- 
http://palosaari.fi/

Re: [PATCH 1/4] [media] em28xx: fix assignment of the eeprom data.

[Frank Schäfer]

Am 18.07.2013 17:51, schrieb Antti Palosaari:
> On 07/18/2013 06:13 PM, Frank Schäfer wrote:
>> Am 17.07.2013 00:57, schrieb Alban Browaeys:
>>> Set the config structure pointer to the eeprom data pointer (data,
>>> here eedata dereferenced) not the pointer to the pointer to
>>> the eeprom data (eedata itself).
>>>
>>> Signed-off-by: Alban Browaeys <prahal@yahoo.com>
>>> ---
>>>   drivers/media/usb/em28xx/em28xx-i2c.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/media/usb/em28xx/em28xx-i2c.c
>>> b/drivers/media/usb/em28xx/em28xx-i2c.c
>>> index 4851cc2..c4ff973 100644
>>> --- a/drivers/media/usb/em28xx/em28xx-i2c.c
>>> +++ b/drivers/media/usb/em28xx/em28xx-i2c.c
>>> @@ -726,7 +726,7 @@ static int em28xx_i2c_eeprom(struct em28xx *dev,
>>> unsigned bus,
>>>
>>>       *eedata = data;
>>>       *eedata_len = len;
>>> -    dev_config = (void *)eedata;
>>> +    dev_config = (void *)*eedata;
>>>
>>>       switch (le16_to_cpu(dev_config->chip_conf) >> 4 & 0x3) {
>>>       case 0:
>> Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com>
>
> Does that SOB mean you will pick that patch via you tree, or was it
> only a mistake?

No, I don't have a public tree.
Following the official rules (SubmittingPatches) strictly, it should
indeed have been Acked-by instead, sorry.

>
> I have thought few times what should I reply to patches which are for
> modules I am maintaining and I will pick up and pull-request via own
> tree. Usually I just reply "patch applied" but maybe Signed-off-by is
> used for same.

The problem is, that although there are rules, things like this are
handled slightly differently from project to project. (Coding style is
the other example ;) )
I'm always trying to adapt myself to the habits of a project, but
sometimes I make a mistake (especially when switching between multiple
projects).

Regards,
Frank

>
> regards
> Antti
>

Re: [PATCH 1/4] [media] em28xx: fix assignment of the eeprom data.

[Hans Verkuil]

Ouch. I'll take this for 3.11 and CC linux-stable for 3.10.

I'm amazed that this hasn't been discovered earlier.

Thanks!

	Hans

On 07/17/2013 12:57 AM, Alban Browaeys wrote:
> Set the config structure pointer to the eeprom data pointer (data,
> here eedata dereferenced) not the pointer to the pointer to
> the eeprom data (eedata itself).
> 
> Signed-off-by: Alban Browaeys <prahal@yahoo.com>
> ---
>  drivers/media/usb/em28xx/em28xx-i2c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/usb/em28xx/em28xx-i2c.c b/drivers/media/usb/em28xx/em28xx-i2c.c
> index 4851cc2..c4ff973 100644
> --- a/drivers/media/usb/em28xx/em28xx-i2c.c
> +++ b/drivers/media/usb/em28xx/em28xx-i2c.c
> @@ -726,7 +726,7 @@ static int em28xx_i2c_eeprom(struct em28xx *dev, unsigned bus,
>  
>  	*eedata = data;
>  	*eedata_len = len;
> -	dev_config = (void *)eedata;
> +	dev_config = (void *)*eedata;
>  
>  	switch (le16_to_cpu(dev_config->chip_conf) >> 4 & 0x3) {
>  	case 0:
>