From: Laxman Dewangan <ldewangan@nvidia.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: "grant.likely@linaro.org" <grant.likely@linaro.org>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
"rob@landley.net" <rob@landley.net>,
"sameo@linux.intel.com" <sameo@linux.intel.com>,
"lee.jones@linaro.org" <lee.jones@linaro.org>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"gg@slimlogic.co.uk" <gg@slimlogic.co.uk>,
"kishon@ti.com" <kishon@ti.com>,
Stephen Warren <swarren@nvidia.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH 1/2] pinctrl: pinconf_generic: add utility functions for add map/configs
Date: Sat, 27 Jul 2013 15:44:48 +0530 [thread overview]
Message-ID: <51F39D98.1090008@nvidia.com> (raw)
In-Reply-To: <51F2B384.9050706@wwwdotorg.org>
On Friday 26 July 2013 11:06 PM, Stephen Warren wrote:
> On 07/26/2013 04:15 AM, Laxman Dewangan wrote:
>> Some of pincontrol driver needs the utility function to create map
>> list. The utility function needed for adding mux, configs etc.
> Which other drivers already contain this code? Are you planning on
> converting them over to use these new functions? The code looks
> familiar, so I assume it's just cut/paste from Tegra with some renames,
> so I didn't read it through in detail.
Yes, these functions are taken from the pinctrl-tegra driver. Other
drivers which have similar implementation are nomadik, tegra, abx500,
tz1090, tz1090-pdc.
So All can use these utility function to avoid duplication and reduce
code size.
Yes, I have plan to use this in Tegra atleast but once this patch get
accepted.
>
>> drivers/pinctrl/pinconf-generic.c | 105 +++++++++++++++++++++++++++++++
>> include/linux/pinctrl/pinconf-generic.h | 52 +++++++++++++++
> I don't think those are the correct files for this code. Presumably
> there's no reason at all why a pinctrl driver that doesn't require
> CONFIG_GENERIC_PINCONF can't use these basic utility functions. Perhaps
> add a new pinctrl-utils file?
I thought generic implementation of parsing of dt is pinctrl-generic
file and as these newly added APIs are require for the parsing the DT
node, I added here.
I can move this to pinctrl-util.c/h also.
next prev parent reply other threads:[~2013-07-27 10:03 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-26 10:15 [PATCH 0/2] pinctrl: palmas: add pincontrol driver Laxman Dewangan
2013-07-26 10:15 ` Laxman Dewangan
2013-07-26 10:15 ` [PATCH 1/2] pinctrl: pinconf_generic: add utility functions for add map/configs Laxman Dewangan
2013-07-26 10:15 ` Laxman Dewangan
2013-07-26 17:36 ` Stephen Warren
2013-07-27 10:14 ` Laxman Dewangan [this message]
2013-07-27 10:14 ` Laxman Dewangan
2013-07-29 16:38 ` Stephen Warren
2013-07-29 16:38 ` Stephen Warren
2013-08-07 18:27 ` Linus Walleij
2013-08-07 18:27 ` Linus Walleij
2013-08-08 7:23 ` Laxman Dewangan
2013-08-08 7:23 ` Laxman Dewangan
2013-07-26 10:15 ` [PATCH 2/2] pinctrl: palmas: add pincontrol driver Laxman Dewangan
2013-07-26 10:15 ` Laxman Dewangan
2013-07-26 16:41 ` Mark Brown
2013-07-27 10:23 ` Laxman Dewangan
2013-07-27 10:23 ` Laxman Dewangan
2013-07-28 12:20 ` Mark Brown
2013-07-28 12:20 ` Mark Brown
2013-07-26 19:09 ` Stephen Warren
2013-07-27 12:11 ` Laxman Dewangan
2013-07-27 12:11 ` Laxman Dewangan
2013-07-29 16:45 ` Stephen Warren
2013-07-29 16:45 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F39D98.1090008@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=devicetree@vger.kernel.org \
--cc=gg@slimlogic.co.uk \
--cc=grant.likely@linaro.org \
--cc=kishon@ti.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=sameo@linux.intel.com \
--cc=swarren@nvidia.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.