All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Don Slutz <dslutz@verizon.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH for-1.6] memory: add tracepoints for MMIO reads/writes
Date: Mon, 05 Aug 2013 18:20:58 +0200	[thread overview]
Message-ID: <51FFD0EA.6040606@redhat.com> (raw)
In-Reply-To: <51FFC24C.6010300@terremark.com>

On 08/05/2013 05:18 PM, Don Slutz wrote:
>> diff --git a/trace-events b/trace-events
>> index 002df83..3e0dd74 100644
>> --- a/trace-events
>> +++ b/trace-events
>> @@ -1165,6 +1165,10 @@ kvm_vm_ioctl(int type, void *arg) "type %d, arg
>> %p"
>>   kvm_vcpu_ioctl(int cpu_index, int type, void *arg) "cpu_index %d,
>> type %d, arg %p"
>>   kvm_run_exit(int cpu_index, uint32_t reason) "cpu_index %d, reason %d"
>> +# memory.c
>> +memory_region_ops_read(void *mr, uint64_t addr, uint64_t value,
>> unsigned size) "mr %p addr %#"PRIx64" value %#"PRIx64" size %d"
>> +memory_region_ops_write(void *mr, uint64_t addr, uint64_t value,
>> unsigned size) "mr %p addr %#"PRIx64" value %#"PRIx64" size %d"
>> +
> Sorry about the late mail.  Did you mean to have the stderr trace text
> to be the same?

Yes, the name of the tracepoint should come before the text.

See scripts/tracetool/backend/stderr.py for the generator source code.

Paolo

      reply	other threads:[~2013-08-05 16:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-28 12:35 [Qemu-devel] [PATCH for-1.6] memory: add tracepoints for MMIO reads/writes Paolo Bonzini
2013-07-28 12:45 ` Andreas Färber
2013-07-28 12:55   ` Paolo Bonzini
2013-07-28 12:58     ` Andreas Färber
2013-07-28 14:34 ` Peter Maydell
2013-07-28 15:02   ` Andreas Färber
2013-08-05 15:18 ` Don Slutz
2013-08-05 16:20   ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51FFD0EA.6040606@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=dslutz@verizon.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.